Re: Boot failure with ext2 and initrds

2006-11-16 Thread Mingming Cao
On Wed, 2006-11-15 at 23:22 -0800, Andrew Morton wrote: On Wed, 15 Nov 2006 22:55:43 -0800 Mingming Cao [EMAIL PROTECTED] wrote: Hmm, maxblocks, in bitmap_search_next_usable_block(), is the end block number of the range to search, not the lengh of the range. maxblocks get passed

Re: [PATCH 1/6] ext2 balloc: fix _with_rsv freeze

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 17:40 +, Hugh Dickins wrote: After several days of testing ext2 with reservations, it got caught inside ext2_try_to_allocate_with_rsv: alloc_new_reservation repeatedly succeeding on the window [12cff,12d0e], ext2_try_to_allocate repeatedly failing to find the free

Re: [PATCH 3/6] ext2 balloc: fix off-by-one against rsv_end

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 17:41 +, Hugh Dickins wrote: rsv_end is the last block within the reservation, so alloc_new_reservation should accept start_block == rsv_end as success. Signed-off-by: Hugh Dickins [EMAIL PROTECTED] --- Thanks, Acked. This is not a problem for now, as the

Re: [PATCH 4/6] ext2 balloc: fix off-by-one against grp_goal

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 17:42 +, Hugh Dickins wrote: grp_goal 0 is a genuine goal (unlike -1), so ext2_try_to_allocate_with_rsv should treat it as such. Signed-off-by: Hugh Dickins [EMAIL PROTECTED] Acked. Thanks, Mingming --- fs/ext2/balloc.c |4 ++-- 1 file changed, 2

Re: [PATCH 6/6] ext2 balloc: use io_error label

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 17:44 +, Hugh Dickins wrote: ext2_new_blocks has a nice io_error label for setting -EIO, so goto that in the one place that doesn't already use it. Signed-off-by: Hugh Dickins [EMAIL PROTECTED] --- Acked, Mingming fs/ext2/balloc.c |7 +++ 1 file

Re: [PATCH 5/6] ext2 balloc: say rb_entry not list_entry

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 17:43 +, Hugh Dickins wrote: The reservations tree is an rb_tree not a list, so it's less confusing to use rb_entry() than list_entry() - though they're both just container_of(). Signed-off-by: Hugh Dickins [EMAIL PROTECTED] --- Acked. Thanks, Mingming

Re: Boot failure with ext2 and initrds

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 14:33 -0800, Andrew Morton wrote: On Tue, 28 Nov 2006 13:04:53 -0800 Mingming Cao [EMAIL PROTECTED] wrote: Thanks, I have acked most of them, and will port them to ext3/4 soon. You've acked #2 and #3. #4, #5 and #6 remain un-commented-upon and #1 is unclear

Re: a question about ext4_fsblk_t

2006-11-28 Thread Mingming Cao
On Sun, 2006-10-22 at 16:50 +0800, guomingyang wrote: I also find many places where the block number type is not changed in namei.c and dir.c. Why? They are all file logical blocks, ext4_fsblk_t is for on disk blocks. Takashi Sato has a patch to define all file logical blocks as

Re: [PATCH 1/6] ext2 balloc: fix _with_rsv freeze

2006-11-28 Thread Mingming Cao
On Tue, 2006-11-28 at 20:07 +, Hugh Dickins wrote: On Tue, 28 Nov 2006, Mingming Cao wrote: On Tue, 2006-11-28 at 17:40 +, Hugh Dickins wrote: After several days of testing ext2 with reservations, it got caught inside ext2_try_to_allocate_with_rsv: alloc_new_reservation repeatedly

[PATCH 1/12] ext3 balloc: reset windowsz when full

2006-11-28 Thread Mingming Cao
-by: Mingming Cao [EMAIL PROTECTED] --- --- linux-2.6.19-rc5-cmm/fs/ext3/balloc.c |1 + 1 file changed, 1 insertion(+) diff -puN fs/ext3/balloc.c~ext3_reset_windowsz_in_full_fs fs/ext3/balloc.c --- linux-2.6.19-rc5/fs/ext3/balloc.c~ext3_reset_windowsz_in_full_fs 2006-11-28 19:36:41.0

[PATCH 12/12] ext3 balloc: fix _with_rsv freeze

2006-11-28 Thread Mingming Cao
for ext3 or ext4? No, because they have an additional extN_test_allocatable test which rescues them from the error. -- Sync up a reservation fix from ext2 in ext4 Signed-off-by: Mingming Cao [EMAIL PROTECTED] --- linux-2.6.19-rc5-cmm/fs/ext4/balloc.c

[PATCH 2/12] ext3 balloc: fix off-by-one against grp_goal

2006-11-28 Thread Mingming Cao
it as such. -- Sync up with ext2 reservation fix in ext3 Signed-off-by: Mingming Cao [EMAIL PROTECTED] --- --- linux-2.6.19-rc5-cmm/fs/ext3/balloc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN fs/ext3/balloc.c~ext3-balloc-fix-off-by-one-against-grp_goal fs/ext3/balloc.c

Re: [RFC][Patch 1/1] Persistent preallocation in ext4

2006-12-12 Thread Mingming Cao
On Tue, 2006-12-12 at 11:53 +0530, Amit K. Arora wrote: Hi Mingming, Hi Amit, On Mon, Dec 11, 2006 at 05:28:15PM -0800, Mingming Cao wrote: On Wed, 2006-12-06 at 11:28 +0530, Amit K. Arora wrote: @@ -1142,13 +1155,22 @@ /* try to insert block into found extent and return

Re: [RFC][Patch 1/2] Persistent preallocation in ext4

2006-12-27 Thread Mingming Cao
On Fri, 2006-12-15 at 18:05 +0530, Amit K. Arora wrote: This is the first patch in the set of two. It implements the ioctl which will be used for persistent preallocation. It is a respun of the previous patch which was posted earlier, and includes following changes: * Takes care of review

Re: [RFC][Patch 1/2] Persistent preallocation in ext4

2007-01-02 Thread Mingming Cao
On Tue, 2007-01-02 at 16:34 +0530, Amit K. Arora wrote: Hi Mingming, And, Looking at other places calling ext4_*_get_blocks() in the kernel, it seems not all of them protected by i_mutex lock. I think it probably okay to not holding i_mutex during calling ext4_ext4_get_blocks(). We are

Re: [PATCH 1/1] Extent overlap bugfix in ext4

2007-01-02 Thread Mingming Cao
On Tue, 2007-01-02 at 14:39 +0530, Amit K. Arora wrote: This problem was first sighted while stress testing (using modified fsx-linux stress test) persistent preallocation patches that I posted earlier. Though I am not able to reproduce this bug (extent overlap) without the persistent

Re: [PATCH 1/1] Extent overlap bugfix in ext4

2007-01-04 Thread Mingming Cao
Alex Tomas wrote: Mingming Cao (MC) writes: MC But the bug Amit pointed here is unrelated to the code convert MC uninitialized blocks to initialized ones. Rather, it's related to do MC multiple block allocation across on a window with parts already have MC blocks allocated. Without

Re: [RFC] [patch 0/3] i_version update for ext4

2007-01-24 Thread Mingming Cao
Cordenner jean noel wrote: Andreas Dilger a écrit : On Jan 23, 2007 18:23 +0100, Cordenner jean noel wrote: I've updated what was previously the change attribute patch for ext4 initially posted by Alexandre Ratchov. The previous patch was introducing a change_attribute field, now it uses

Re: where is the ext4 git tree ?

2007-01-26 Thread Mingming Cao
coly wrote: Hi friends: I can not find the ext4 git tree (on kernel.org) which Te mentioned on the talk. Can anybody give me a point ? I am new to ext4. That was the plan discussed a few weeks ago. Ted is travelling (I think??so he may not get a chance to work on it or annonce it yet.

Re: Testing ext4 persistent preallocation patches for 64 bit features

2007-02-07 Thread Mingming Cao
On Wed, 2007-02-07 at 13:18 +0530, Amit K. Arora wrote: I plan to test the persistent preallocation patches on a huge sparse device, to know if 32 bit physical block numbers (upto 48bit) behave as expected. Thanks! I have following questions for this and will appreciate suggestions here:

Re: qla2xxx BUG: workqueue leaked lock or atomic

2007-03-07 Thread Mingming Cao
On Wed, 2007-03-07 at 11:45 -0800, Andrew Morton wrote: On Wed, 7 Mar 2007 18:09:55 +0100 Andre Noll [EMAIL PROTECTED] wrote: On 20:39, Andrew Morton wrote: On Wed, 28 Feb 2007 16:37:22 +0100 Andre Noll [EMAIL PROTECTED] wrote: On 16:18, Andre Noll wrote: With 2.6.21-rc2

Re: Ext4 devel interlock meeting minutes (March 14, 2007)

2007-03-14 Thread Mingming Cao
On Wed, 2007-03-14 at 15:49 -0700, Avantika Mathur wrote: Ext4 Developer Interlock Call: 03/14/2007 Meeting Minutes Attendees: Mingming Cao, Eric Sandeen, Ted Ts'o, Dave Kleikamp, Suparna Bhattacharya, Takashi Sato, Avantika Mathur Minutes can be accessed at: http://ext4.wiki.kernel.org

Re: cleaned up ext4 patch series

2007-03-19 Thread Mingming Cao
On Mon, 2007-03-19 at 10:48 -0500, Dave Kleikamp wrote: Ted, I have rebased the ext4 patchset on 2.6.21-rc4 and cleaned up some bad whitespace and sparse warnings. The patches are here: http://www.kernel.org/pub/linux/kernel/people/shaggy/ext4/ext4-2007-03-19.tar.bz2 Untarred here:

64bit inode number and dynamic inode table for ext4

2007-03-22 Thread Mingming Cao
On Wed, 2007-03-21 at 19:53 -0700, Avantika Mathur wrote: Ext4 Developer Interlock Call: 03/21/2007 Meeting Minutes ... 64 bit Inode and Dynamic Inode Table Discussion: - Though this feature has been discussed for many years; there does not seem to be high demand currently for 64 bit inode

Re: [PATCH] Add i_version_hi for 64-bit version

2007-04-02 Thread Mingming Cao
On Sun, 2007-03-18 at 15:43 +0530, Kalpak Shah wrote: Hi, This patch adds a 32-bit i_version_hi field to ext4_inode, which can be used for 64-bit inode versions. This field will store the higher 32 bits of the version, while Jean Noel's patch has added support to store the lower 32-bits

Re: Ext4 benchmarks

2007-04-04 Thread Mingming Cao
On Wed, 2007-04-04 at 13:21 -0600, Andreas Dilger wrote: On Apr 04, 2007 19:06 +0200, Cordenner jean noel wrote: here is the first results of the round: http://www.bullopensource.org/ext4/20070404/ Jean Noel, thank you for the test results. It is always nice to see that ext4 is doing

ext4 patch queue update

2007-04-04 Thread Mingming Cao
Ted, I Just rebased the ext4 patch queue to 2.6.21-rc5, # Added Reserve high 32 bit for 64 bit inode version i_version_hi.patch # Add mount option to turn off extents ext4_noextent_mount_opt.patch # Add mount option to turn off delayed allocation ext4_nodelalloc_mount_opt.patch And move

Re: Missing JBD2_FEATURE_INCOMPAT_64BIT in ext4

2007-04-19 Thread Mingming Cao
On Sun, 2007-04-15 at 10:16 -0600, Andreas Dilger wrote: Just a quick note before I forget. I thought there was a call in ext4 to set JBD2_FEATURE_INCOMPAT_64BIT at mount time if the filesystem has more than 2^32 blocks? Question about the online resize case. If the fs is increased to more

Re: 2.6.21-ext4-1

2007-05-07 Thread Mingming Cao
On Mon, 2007-04-30 at 11:14 -0400, Theodore Ts'o wrote: I've respun the ext4 development patchset, with Amit's updated fallocate patches. I've added Dave's patch to add ia64 support to the fallocate system call, but *not* the XFS fallocate support patches. (Probably better for them to live

Re: [PATCH 4/5] ext4: fallocate support in ext4

2007-05-07 Thread Mingming Cao
On Mon, 2007-05-07 at 13:58 -0700, Andrew Morton wrote: On Mon, 7 May 2007 05:37:54 -0600 Andreas Dilger [EMAIL PROTECTED] wrote: + block = offset blkbits; + max_blocks = (EXT4_BLOCK_ALIGN(len + offset, blkbits) blkbits) +- block; +

Re: [PATCH 4/5] ext4: fallocate support in ext4

2007-05-07 Thread Mingming Cao
On Mon, 2007-05-07 at 16:31 -0700, Andrew Morton wrote: On Mon, 7 May 2007 19:14:42 -0400 Theodore Tso [EMAIL PROTECTED] wrote: On Mon, May 07, 2007 at 03:38:56PM -0700, Andrew Morton wrote: Actually, this is a non-issue. The reason that it is handled for extent-only is that

Re: [PATCH 4/5] ext4: fallocate support in ext4

2007-05-07 Thread Mingming Cao
On Mon, 2007-05-07 at 17:15 -0700, Andrew Morton wrote: On Mon, 07 May 2007 17:00:24 -0700 Mingming Cao [EMAIL PROTECTED] wrote: + while (ret = 0 ret max_blocks) { + block = block + ret; + max_blocks = max_blocks - ret; + ret

Re: [PATCH 4/5] ext4: fallocate support in ext4

2007-05-08 Thread Mingming Cao
On Mon, 2007-05-07 at 21:43 -0400, Theodore Tso wrote: On Mon, May 07, 2007 at 05:41:39PM -0700, Mingming Cao wrote: We could check the total number of fs free blocks account before preallocation happens, if there isn't enough space left, there is no need to bother preallocating

Re: 2.6.21-ext4-1

2007-05-08 Thread Mingming Cao
On Tue, 2007-05-08 at 12:50 +1000, David Chinner wrote: On Mon, May 07, 2007 at 01:56:23PM -0700, Mingming Cao wrote: In any case, it would be useful to add a new set of testsuites for the new fallocate() syscall and fsstress in LTP testsuites to automatically the preallocation code in ext4

Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc

2007-05-09 Thread Mingming Cao
On Wed, 2007-05-09 at 21:31 +0530, Amit K. Arora wrote: I have the updated patches ready which take care of Andrew's comments. Will run some tests and post them soon. But, before submitting these patches, I think it will be better to finalize on certain things which might be worth some

Re: Ext4 devel interlock meeting minutes (May 7, 2007)

2007-05-09 Thread Mingming Cao
On Wed, 2007-05-09 at 10:37 -0700, Andreas Dilger wrote: On May 09, 2007 10:02 -0700, Avantika Mathur wrote: Metablock Groups: - Mingming mentioned that in the metablock group feature, the inode metadata is not moved with the rest of the metadata. Ted will check this, as he thought

Re: [RFC] [patch 2/2] i_version update - ext4 part

2007-05-14 Thread Mingming Cao
On Mon, 2007-05-14 at 14:31 -0600, Andreas Dilger wrote: On May 14, 2007 14:21 -0600, Andreas Dilger wrote: On May 14, 2007 13:05 +0200, Cordenner jean noel wrote: @@ -331,12 +331,13 @@ } osd2; /* OS dependent 2 */ __le16 i_extra_isize; __le16

[PATCH] enable extents mount option by default in ext4

2007-05-15 Thread Mingming Cao
Turn on extents feature by default in ext4 filesystem. User could use -o noextents to turn it off. Signed-Off-By: Mingming Cao [EMAIL PROTECTED] Index: linux-2.6.21.1/fs/ext4/super.c === --- linux-2.6.21.1.orig/fs/ext4/super.c 2007

[PATCH] Remove unnecessery exported ext4 symbols

2007-05-15 Thread Mingming Cao
These symbols are used in ext4 only. Acked-By: Ales Tomas [EMAIL PROTECTED] Signed-Off-By: Mingming Cao [EMAIL PROTECTED] Index: linux-2.6.21.1/fs/ext4/extents.c === --- linux-2.6.21.1.orig/fs/ext4/extents.c 2007-05-15 11:52

Re: [PATCH 0/5][TAKE3] fallocate system call

2007-05-15 Thread Mingming Cao
On Wed, 2007-05-16 at 01:07 +0530, Amit K. Arora wrote: ToDos: - 1 Implementation on other architectures (other than i386, x86_64, ppc64 and s390(x)). David Chinner has already posted a patch for ia64. Here is the 2.6.22-rc1 version of David's patch: add fallocate() on ia64 From: David

Re: [PATCH 1/1] [RFC] 64-bit inode version

2007-05-15 Thread Mingming Cao
. Renamed the ext3 functions to ext4_xxx_xxx(). Compile tested. Can you Ack the changes. Appreciate if you can let me know it passes your tests. Signed-Off-By: Mingming Cao [EMAIL PROTECTED] Index: linux-2.6.22-rc1/fs/ext4/inode.c

Re: [PATCH 0/6][TAKE4] fallocate system call

2007-05-20 Thread Mingming Cao
On Fri, 2007-05-18 at 23:44 -0700, Andrew Morton wrote: On Thu, 17 May 2007 19:41:15 +0530 Amit K. Arora [EMAIL PROTECTED] wrote: fallocate() is a new system call being proposed here which will allow applications to preallocate space to any file(s) in a file system. I merged the first

Re: files mapped funny? (related to online defragmentation)

2007-05-21 Thread Mingming Cao
On Mon, 2007-05-21 at 06:49 -0700, Eric wrote: Hi, I'm getting strange results when I map out the blocks used in files larger than a several thousand KB. I never seem to get any more than 1024 contiguous data blocks in a row. Here's a portion of the output of my script when I run it on a

Re: [patch 2/2] i_version update - ext4 part

2007-05-29 Thread Mingming Cao
On Fri, 2007-05-25 at 18:25 +0200, Jean noel Cordenner wrote: The patch is on top of the ext4 tree: http://repo.or.cz/w/ext4-patch-queue.git In this part, the i_version counter is stored into 2 32bit fields of the ext4_inode structure osd1.linux1.l_i_version and i_version_hi. I included

Re: ext2_discard_prealloc() called on each iput?

2007-05-29 Thread Mingming Cao
On Mon, 2007-05-28 at 18:04 +0200, Jan Kara wrote: On Wed 23-05-07 08:37:43, Theodore Tso wrote: On Tue, May 22, 2007 at 06:11:27PM +0200, Jan Kara wrote: while fixing some problems with preallocation in UDF, I had a look how ext2 solves similar problems. I found out that

Re: [patch 2/2] i_version update - ext4 part

2007-05-30 Thread Mingming Cao
On Tue, 2007-05-29 at 16:58 -0600, Andreas Dilger wrote: On May 29, 2007 12:44 -0700, Mingming Cao wrote: I am a little bit confused about the two patches. It appears in the ext4_expand_inode_extra_isize patch by Kalpak, there a new 64 bit i_fs_version field is added to ext4 inode

Re: [PATCH][RFC] JBD2: Use DebugFS for jbd2 debug config option.

2007-06-11 Thread Mingming Cao
On Fri, 2007-06-08 at 22:57 -0500, Jose R. Santos wrote: On Fri, 8 Jun 2007 01:08:12 -0600 Andreas Dilger [EMAIL PROTECTED] wrote: On Jun 07, 2007 23:45 -0500, Jose R. Santos wrote: The jbd2-debug file used to be located in /proc/sys/fs/jbd2-debug, but create_proc_entry() does not do

ext4 patch queue updated

2007-06-13 Thread Mingming Cao
Just updated the ext4 patch queue http://repo.or.cz/w/ext4-patch-queue Changes: Added these three patches from Jose Santos: ext4_set_jbd2_64bit_feature.patch jbd2_config_jbd2_debug_fix.patch jbd2_move_jbd2_debug_to_debugfs.patch Reordered the series, move jbd-stats-through-procfs and

Re: [PATCH] ext4:fix invariant checking in ext4_rebalance_reservation

2007-06-18 Thread Mingming Cao
On Sat, 2007-06-16 at 12:02 +0400, Dmitriy Monakhov wrote: Variable free was declarated as __u64 so conidition (free 0) always false, even if free was overflowed during substraction. Agreed. Can you add your Signed-off to this patch? I can add mine after yours. Thanks, Mingming ---

Re: delayed allocatiou result in Oops

2007-06-18 Thread Mingming Cao
On Sat, 2007-06-16 at 12:14 +0400, Dmitriy Monakhov wrote: On 16:16 Птн 15 Июн , Mingming Cao wrote: I hit almost the same issue today also, but with different error #, and one more kernel oops, when run fsstress on x86_64. EXT4-fs: writeback error = -2 EXT4-fs: writeback error

Re: delayed allocatiou result in Oops

2007-06-19 Thread Mingming Cao
On Tue, 2007-06-19 at 11:11 +0400, Alex Tomas wrote: Mingming Cao wrote: From the comments it says the page-private is set to 1 to letting commit_write know that it needs block reservation, but I don't see the page-private value being checked in ext4_wb_commit_write(). Instead

Re: delayed allocatiou result in Oops

2007-06-20 Thread Mingming Cao
On Wed, 2007-06-20 at 12:15 +0400, Alex Tomas wrote: Mingming Cao wrote: Hmm, PageMappedToDisk is probably not sufficient enough for pagesize! =blocksize. Is that the reason we need page-private to pass the request? PageMappedToDisk isn't enough in that case, definitely. bh is the way

ext4 patch queue rebased to linux2.6.22-rc5

2007-06-20 Thread Mingming Cao
http://repo.or.cz/w/ext4-patch-queue.git diff --git a/series b/series index d68345c..766f3eb 100644 (file) --- a/series +++ b/series @@ -1,4 +1,4 @@ -# Rebased the patches to 2.6.22-rc4 +# Rebased the patches to 2.6.22-rc5 # Add mount option to turn off extents

Re: [PATCH 0/6][TAKE5] fallocate system call

2007-06-28 Thread Mingming Cao
On Thu, 2007-06-28 at 02:55 -0700, Andrew Morton wrote: Please drop the non-ext4 patches from the ext4 tree and send incremental patches against the (non-ext4) fallocate patches in -mm. The ext4 fallocate() patches are dependent on the core fallocate() patches, so ext4 patch-queue and git

Re: fallocate support for bitmap-based files

2007-06-30 Thread Mingming Cao
On Fri, 2007-06-29 at 13:01 -0700, Andrew Morton wrote: Guys, Mike and Sreenivasa at google are looking into implementing fallocate() on ext2. Of course, any such implementation could and should also be portable to ext3 and ext4 bitmapped files. I believe that Sreenivasa will mainly be

Re: fallocate support for bitmap-based files

2007-06-30 Thread Mingming Cao
On Sat, 2007-06-30 at 01:14 -0400, Andreas Dilger wrote: On Jun 29, 2007 18:26 -0400, Mike Waychison wrote: Andreas Dilger wrote: I don't think ext2 is safe for 8TB filesystems anyways, so this isn't a huge loss. This is reference to the idea of overloading the high-bit and not

Ext4 patches for 2.6.22-rc6

2007-07-01 Thread Mingming Cao
On Fri, 2007-06-29 at 13:57 -0700, Andrew Morton wrote: On Fri, 29 Jun 2007 11:50:04 -0400 Mingming Caoc [EMAIL PROTECTED] wrote: I think the ext4 patch queue is in good shape now. Which ext4 patches are you intending to merge into 2.6.23? Please send all those out to lkml for review?

[EXT4 set 1][PATCH 1/2] Add noextents mount option

2007-07-01 Thread Mingming Cao
Add a mount option to turn off extents. Signed-off-by: Mingming Cao [EMAIL PROTECTED] --- Index: linux-2.6.22-rc4/fs/ext4/super.c === --- linux-2.6.22-rc4.orig/fs/ext4/super.c 2007-06-11 17:02:18.0 -0700 +++ linux

[EXT4 set 1][PATCH 2/2] Enable extents by default for ext4dev

2007-07-01 Thread Mingming Cao
Turn on extents feature by default in ext4 filesystem. User could use -o noextents to turn it off. Signed-off-by: Mingming Cao [EMAIL PROTECTED] Index: linux-2.6.22-rc4/fs/ext4/super.c === --- linux-2.6.22-rc4.orig/fs/ext4/super.c

[EXT4 set 2][PATCH 1/5] cleanups: Propagate some i_flags to disk

2007-07-01 Thread Mingming Cao
Propagate flags such as S_APPEND, S_IMMUTABLE, etc. from i_flags into ext4-specific i_flags. Hence, when someone sets these flags via a different interface than ioctl, they are stored correctly. Signed-off-by: Jan Kara [EMAIL PROTECTED] Signed-off-by: Mingming Cao [EMAIL PROTECTED] Index: linux

[EXT4 set 2][PATCH 2/5] cleanups: Add extent sanity checks

2007-07-01 Thread Mingming Cao
with the patch all headers are checked. the code should become more resistant to on-disk corruptions. needless BUG_ON() have been removed. please, review for inclusion. Signed-off-by: Alex Tomas [EMAIL PROTECTED] Signed-off-by: Mingming Cao [EMAIL PROTECTED] Index: linux-2.6.22-rc4/fs/ext4

[EXT4 set 2][PATCH 3/5] cleanups: set_jbd2_64bit_feature for 16TB ext4 fs

2007-07-01 Thread Mingming Cao
Set the journals JBD2_FEATURE_INCOMPAT_64BIT on devices with more than 32bit block sizes during mount time. This ensure proper record lenth when writing to the journal. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] Signed-off-by: Andreas Dilger [EMAIL PROTECTED] Signed-off-by: Mingming Cao

[EXT4 set 2][PATCH 4/5] cleanups: Rename CONFIG_JBD_DEBUG to CONFIG_JBD2_DEBUG

2007-07-01 Thread Mingming Cao
When the JBD code was forked to create the new JBD2 code base, the references to CONFIG_JBD_DEBUG where never changed to CONFIG_JBD2_DEBUG. This patch fixes that. Signed-off-by: Jose R. Santos [EMAIL PROTECTED] --- Index: linux-2.6.22-rc4/fs/jbd2/journal.c

[EXT4 set 4][PATCH 2/5] i_version: Add hi 32 bit inode version on ext4 on-disk inode

2007-07-01 Thread Mingming Cao
This patch adds a 32-bit i_version_hi field to ext4_inode, which can be used for 64-bit inode versions. This field will store the higher 32 bits of the version, while Jean Noel's patch has added support to store the lower 32-bits in osd1.linux1.l_i_version. Signed-off-by: Mingming Cao [EMAIL

[EXT4 set 4][PATCH 3/5] i_version:ext4 inode version read/store

2007-07-01 Thread Mingming Cao
This patch adds 64-bit inode version support to ext4. The lower 32 bits are stored in the osd1.linux1.l_i_version field while the high 32 bits are stored in the i_version_hi field newly created in the ext4_inode. Signed-off-by: Kalpak Shah [EMAIL PROTECTED] Signed-off-by: Mingming Cao [EMAIL

[EXT4 set 4][PATCH 4/5] i_version:ext4 inode version update

2007-07-01 Thread Mingming Cao
This patch is on top of i_version_update_vfs. The i_version field of the inode is set on inode creation and incremented when the inode is being modified. Signed-off-by: Jean Noel Cordenner [EMAIL PROTECTED] Signed-off-by: Mingming Cao [EMAIL PROTECTED] Index: linux-2.6.22-rc4/fs/ext4/ialloc.c

[EXT4 set 4][PATCH 5/5] i_version: noversion mount option to disable inode version updates

2007-07-01 Thread Mingming Cao
Add a noversion mount option to disable inode version updates. Signed-off-by: Andreas Dilger [EMAIL PROTECTED] Signed-off-by: Kalpak Shah [EMAIL PROTECTED] Index: linux-2.6.21/fs/ext4/super.c === ---

[EXT4 set 6][PATCH 1/1]Export jbd stats through procfs

2007-07-01 Thread Mingming Cao
[PATCH] jbd2 stats through procfs The patch below updates the jbd stats patch to 2.6.20/jbd2. The initial patch was posted by Alex Tomas in December 2005 (http://marc.info/?l=linux-ext4m=113538565128617w=2). It provides statistics via procfs such as transaction lifetime and size. [ This probably

[EXT4 set 7][PATCH 1/1]Remove 32000 subdirs limit.

2007-07-01 Thread Mingming Cao
From [EMAIL PROTECTED] Thu May 17 17:21:08 2007 Hi, I have rebased this patch to 2.6.22-rc1 so that it can be added to the ext4 patch queue. It has been tested by creating more than 65000 subdirs and then deleting them and checking the nlinks. The e2fsprogs part of this patch was sent earlier by

[EXT4 set 8][PATCH 1/1]Add journal checksums

2007-07-01 Thread Mingming Cao
Journal checksum feature has been added to detect corruption of journal. Signed-off-by: Andreas Dilger [EMAIL PROTECTED] Signed-off-by: Girish Shilamkar [EMAIL PROTECTED] Signed-off-by: Dave Kleikamp [EMAIL PROTECTED] diff -Nurp linux024/fs/ext4/super.c linux/fs/ext4/super.c ---

[EXT4 set 9][PATCH 1/5]Morecleanups:ext4-zero_user_page

2007-07-01 Thread Mingming Cao
Use zero_user_page() in ext4 where possible. Signed-off-by: Eric Sandeen [EMAIL PROTECTED] Index: linux-2.6.22-rc4-mm2/fs/ext4/inode.c === --- linux-2.6.22-rc4-mm2.orig/fs/ext4/inode.c +++ linux-2.6.22-rc4-mm2/fs/ext4/inode.c @@

[EXT4 set 9][PATCH 2/5]Morecleanups: use is_power_of_2 () in fill_super

2007-07-01 Thread Mingming Cao
Subject: is_power_of_2: ext4/super.c From: vignesh babu [EMAIL PROTECTED] Replace (n (n-1)) in the context of power of 2 checks with is_power_of_2() Signed-off-by: vignesh babu [EMAIL PROTECTED] Cc: linux-ext4@vger.kernel.org Signed-off-by: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Dave

[EXT4 set 9][PATCH 3/5]Morecleanups:ext4-remove-extra-is_rdonly-check

2007-07-01 Thread Mingming Cao
Subject: ext4: remove extra IS_RDONLY() check From: Dave Hansen [EMAIL PROTECTED] ext4_change_inode_journal_flag() is only called from one location: ext4_ioctl(EXT3_IOC_SETFLAGS). That ioctl case already has a IS_RDONLY() call in it so this one is superfluous. Signed-off-by: Dave Hansen [EMAIL

[EXT4 set 9][PATCH 5/5]Extent micro cleanups

2007-07-01 Thread Mingming Cao
From: Dmitry Monakhov [EMAIL PROTECTED] Subject: ext4: extent macros cleanup - Replace math equation to it's macro equivalent - make ext4_ext_grow_indepth() indexes/leaf correct Signed-off-by: Dmitry Monakhov [EMAIL PROTECTED] Acked-by: Alex Tomas [EMAIL PROTECTED] Signed-off-by: Dave Kleikamp

Re: [RFC] BIG_BG vs extended META_BG in ext4

2007-07-02 Thread Mingming Cao
On Mon, 2007-07-02 at 11:49 -0400, Theodore Tso wrote: On Sun, Jul 01, 2007 at 09:48:33AM -0500, Jose R. Santos wrote: Is your concern due to being unable to find contiguous block in the case that a bad disk area is in one of the bitmap blocks? One thing we can do is try to search for

Re: fallocate support for bitmap-based files

2007-07-02 Thread Mingming Cao
On Sat, 2007-06-30 at 13:29 -0400, Andreas Dilger wrote: On Jun 30, 2007 10:13 -0400, Mingming Cao wrote: Another approach we have been thinking is using a backing inode(per-inode-with-preallocation) to store the preallocated blocks. When user asked for preallocation on the base inode

Re: ext4-patch-queue rebased to 2.6.22

2007-07-09 Thread Mingming Cao
On Mon, 2007-07-09 at 13:37 -0400, Theodore Ts'o wrote: Per our discussion on the call, I've moved the fallocate patches back up to the front of the queue, and rebased the syscall numbers to 2.6.22. I updated the ext4 patch queue. It seem there is conflict to apply delayed allocation patch,

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-09 Thread Mingming Cao
On Fri, 2007-07-06 at 16:53 -0600, Andreas Dilger wrote: On Jul 06, 2007 09:51 -0400, J. Bruce Fields wrote: The use of a mount option means the change attribute could be inconsistent across mounts. If we really need this, wouldn't it make more sense for it to be a persistent feature of

Re: block groups with no inode tables

2007-07-10 Thread Mingming Cao
On Tue, 2007-07-10 at 12:40 -0500, Dave Kleikamp wrote: On Wed, 2007-07-11 at 01:30 +0800, coly li wrote: Hi, once we decide to do this, how about storing inode inside the directory ? Which directory? I think Coly is refering to the idea of store-inode-inside-in-directory-file. It's one

Re: [EXT4 set 2][PATCH 3/5] cleanups: set_jbd2_64bit_feature for 16TB ext4 fs

2007-07-10 Thread Mingming Cao
On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: On Sun, 01 Jul 2007 03:36:32 -0400 Mingming Cao [EMAIL PROTECTED] wrote: Set the journals JBD2_FEATURE_INCOMPAT_64BIT on devices with more than 32bit block sizes during mount time. This ensure proper record lenth when writing

Re: [EXT4 set 1][PATCH 2/2] Enable extents by default for ext4dev

2007-07-10 Thread Mingming Cao
On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: On Sun, 01 Jul 2007 03:36:01 -0400 Mingming Cao [EMAIL PROTECTED] wrote: Turn on extents feature by default in ext4 filesystem. User could use -o noextents to turn it off. Oh, there you go. Index: linux-2.6.22-rc4/fs/ext4

Re: [EXT4 set 3][PATCH 1/1] ext4 nanosecond timestamp

2007-07-10 Thread Mingming Cao
On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: On Sun, 01 Jul 2007 03:36:56 -0400 Mingming Cao [EMAIL PROTECTED] wrote: This patch is a spinoff of the old nanosecond patches. I don't know what the old nanosecond patches are. A link to a suitable changlog for those patches would

Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs

2007-07-10 Thread Mingming Cao
On Tue, 2007-07-10 at 21:42 -0700, Andrew Morton wrote: On Tue, 10 Jul 2007 23:21:49 -0400 Cédric Augonnet [EMAIL PROTECTED] wrote: 2007/7/10, Andrew Morton [EMAIL PROTECTED]: Hi all, + size = sizeof(struct transaction_stats_s); + s-stats = kmalloc(size, GFP_KERNEL);

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-10 Thread Mingming Cao
On Tue, 2007-07-10 at 21:22 -0700, Andrew Morton wrote: On Tue, 10 Jul 2007 20:19:16 -0400 Mingming Cao [EMAIL PROTECTED] wrote: On Tue, 2007-07-10 at 18:22 -0700, Andrew Morton wrote: On Tue, 10 Jul 2007 18:09:40 -0400 Mingming Cao [EMAIL PROTECTED] wrote: On Tue, 2007-07-10 at 16

Re: [EXT4 set 2][PATCH 5/5] cleanups: Export jbd2-debug via debugfs

2007-07-11 Thread Mingming Cao
On Wed, 2007-07-11 at 00:38 -0500, Jose R. Santos wrote: On Tue, 10 Jul 2007 16:30:25 -0700 Andrew Morton [EMAIL PROTECTED] wrote: On Sun, 01 Jul 2007 03:36:48 -0400 Mingming Cao [EMAIL PROTECTED] wrote: On Jun 07, 2007 23:45 -0500, Jose R. Santos wrote: The jbd2-debug file

Re: [EXT4 set 1][PATCH 2/2] Enable extents by default for ext4dev

2007-07-11 Thread Mingming Cao
On Tue, 2007-07-10 at 23:35 -0400, Dave Jones wrote: On Tue, Jul 10, 2007 at 05:35:13PM -0400, Mingming Cao wrote: Sorry about this. I was using version 0.04. The latest one I can find for now is 0.05(searching lkml), but it didn't catch this codling style bug either. I appreciate

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-11 Thread Mingming Cao
On Tue, 2007-07-10 at 22:17 -0700, Andrew Morton wrote: On Tue, 10 Jul 2007 22:09:08 -0400 Mingming Cao [EMAIL PROTECTED] wrote: David Chinneer pointed that we need to journal the version number updates together with the operations that causes the change of the inode version number

Re: [EXT4 set 9][PATCH 5/5]Extent micro cleanups

2007-07-11 Thread Mingming Cao
On Tue, 2007-07-10 at 23:20 -0700, Andrew Morton wrote: On Sun, 01 Jul 2007 03:38:59 -0400 Mingming Cao [EMAIL PROTECTED] wrote: From: Dmitry Monakhov [EMAIL PROTECTED] Subject: ext4: extent macros cleanup - Replace math equation to it's macro equivalent s/it's/its/;) Okay

[PATCH 1/1] ext4: JBD-JBD2 naming cleanups

2007-07-16 Thread Mingming Cao
/linux/jbd2.h 2007-06-11 16:35:25.0 -0700 @@ -57,7 +57,7 @@ * CONFIG_JBD2_DEBUG is on. */ #define JBD_EXPENSIVE_CHECKING JBD2? Some cleanups in ext4/JBD2 to follow the naming fules:change micros name from JBD_XXX to JBD2_XXX. Signed-off-by: Mingming Cao [EMAIL

Re: [EXT4 set 2][PATCH 2/5] cleanups: Add extent sanity checks

2007-07-16 Thread Mingming Cao
On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: On Sun, 01 Jul 2007 03:36:22 -0400 Mingming Cao [EMAIL PROTECTED] wrote: with the patch all headers are checked. the code should become more resistant to on-disk corruptions. needless BUG_ON() have been removed. please, review

Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs

2007-07-16 Thread Mingming Cao
On Tue, 2007-07-10 at 19:31 -0700, Andrew Morton wrote: On Sun, 01 Jul 2007 03:38:10 -0400 Mingming Cao [EMAIL PROTECTED] wrote: [PATCH] jbd2 stats through procfs The patch below updates the jbd stats patch to 2.6.20/jbd2. The initial patch was posted by Alex Tomas in December 2005

Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs

2007-07-16 Thread Mingming Cao
On Tue, 2007-07-10 at 21:42 -0700, Andrew Morton wrote: On Tue, 10 Jul 2007 23:21:49 -0400 Cédric Augonnet [EMAIL PROTECTED] wrote: 2007/7/10, Andrew Morton [EMAIL PROTECTED]: Hi all, + size = sizeof(struct transaction_stats_s); + s-stats = kmalloc(size, GFP_KERNEL);

Re: [EXT4 set 5][PATCH 1/1] expand inode i_extra_isize to support features in larger inode

2007-07-16 Thread Mingming Cao
isize patch. Fixing memory allocation issue with expand inode extra isize patch. - use GFP_NOFS instead of GFP_KERNEL flag for memory allocation - use kzalloc instead of kmalloc - fix memory leak in the success case, at the end of while loop. Signed-off-by: Mingming Cao [EMAIL PROTECTED] --- fs

Re: [EXT4 set 5][PATCH 1/1] expand inode i_extra_isize to support features in larger inode

2007-07-16 Thread Mingming Cao
On Mon, 2007-07-16 at 18:06 -0600, Andreas Dilger wrote: On Jul 16, 2007 16:52 -0700, Mingming Cao wrote: I am not sure why we need GFP_KERNEL flag here. I think we should use GFP_NOFS instead. The following patch use the GFP_NOFS flag, as well as fixing memory leak issue introduced

Re: [EXT4 set 3][PATCH 1/1] ext4 nanosecond timestamp

2007-07-16 Thread Mingming Cao
On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: On Sun, 01 Jul 2007 03:36:56 -0400 Mingming Cao [EMAIL PROTECTED] wrote: This patch is a spinoff of the old nanosecond patches. I don't know what the old nanosecond patches are. A link to a suitable changlog for those patches would

Re: [EXT4 set 3][PATCH 1/1] ext4 nanosecond timestamp

2007-07-17 Thread Mingming Cao
On Tue, 2007-07-17 at 15:29 +0530, Kalpak Shah wrote: On Mon, 2007-07-16 at 17:49 -0700, Mingming Cao wrote: On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: On Sun, 01 Jul 2007 03:36:56 -0400 Mingming Cao [EMAIL PROTECTED] wrote: +static inline __le32 ext4_encode_extra_time

Re: [BUG?] ext4_ext_put_in_cache uses __u32 to receive physical block number.

2007-07-27 Thread Mingming Cao
-by: Mingming Cao [EMAIL PROTECTED] Index: linux-2.6.22/fs/ext4/extents.c === --- linux-2.6.22.orig/fs/ext4/extents.c 2007-07-27 08:31:02.0 -0700 +++ linux-2.6.22/fs/ext4/extents.c 2007-07-27 08:31:48.0 -0700 @@ -1544,7

Re: [RFC] basic delayed allocation in VFS

2007-07-30 Thread Mingming Cao
On Sun, 2007-07-29 at 20:24 +0100, Christoph Hellwig wrote: On Sun, Jul 29, 2007 at 11:30:36AM -0600, Andreas Dilger wrote: Sigh, we HAVE a patch that was only adding delalloc to ext4, but it was rejected because that functionality should go into the VFS. Since the performance improvement

Re: [patch] i_version mount option

2007-08-03 Thread Mingming Cao
Jean noel Cordenner wrote: hi, This patch apply on the top of the ext4 git tree. It adds a mount option to enable i_version feature for ext4. I think we should fix overwrite case first. Per lkml discussion, if we fix the overwrite case by updating the counter in file_update_time() all the

Re: [EXT4 set 8][PATCH 1/1]Add journal checksums

2007-08-06 Thread Mingming Cao
On Wed, 2007-08-01 at 12:34 +0530, Girish Shilamkar wrote: On Wed, 2007-07-11 at 17:16 +0530, Girish Shilamkar wrote: I will make the changes and send an incremental patch. Hi, I have made the changes and attached the incremental patch as per the review. Thanks, I merged your

  1   2   3   >