Re: 'sameas:device' broken, fix included

2014-06-25 Thread Thomas Neumann
On Tuesday 24 June 2014 16:48:06 Thomas Lange wrote: It would be nice it you could separate the whitespace diffs from all other patches. ??? I already did that. patch1_indentation is just the re-indentation to match the file's general style. It looks a bit intimidating, but it's really just

Re: 'sameas:device' broken, fix included

2014-06-25 Thread Thomas Neumann
On Wednesday 25 June 2014 12:12:15 Thomas Lange wrote: However there's an underlying problem by treating 'disk#' and hda/sda/xvda differently. patch3 addresses that issue. Mmm, I did a diff on the code block after sameas:(\S+) and sameas:disk(\d+). Except for the clone vs. dclone call, it's

'sameas:device' broken, fix included

2014-06-24 Thread Thomas Neumann
Hello The bug: sameas:disk1 works, sameas:sda does not Proposed patches and sample config attached to mail. Output for sameas:disk1 # cat /var/lib/fai/config/disk_config/SAMEAS_DISK1 disk_config disk1 disklabel:msdos align-at:4k primary - 1G-50% - -