Re: [RFC] Quota reentrancy locking

2001-06-27 Thread Andrew Morton
Jan Kara wrote: Hello, after some discussion with Andrew Morton I decided to write a few rules about what quota expects from filesystem and what filesystem should expect from quota. Does anybody have any comment? Honza

Re: [PATCH][RFC] inode-u.nfs_i allocated separately

2001-06-27 Thread Linus Torvalds
If we're going to do this for a major filesystem, then I'd really just rather see this being done generically during 2.5.x, making u be a pointer only, and having the generic iput() just always free the dang thing. Linus - To unsubscribe from this list: send the line

Re: [PATCH][RFC] inode-u.nfs_i allocated separately

2001-06-27 Thread Linus Torvalds
On Wed, 27 Jun 2001, Ben LaHaise wrote: On Wed, 27 Jun 2001, Linus Torvalds wrote: If we're going to do this for a major filesystem, then I'd really just rather see this being done generically during 2.5.x, making u be a pointer only, and having the generic iput() just always free the

Re: [PATCH][RFC] inode-u.nfs_i allocated separately

2001-06-27 Thread Alexander Viro
On Wed, 27 Jun 2001, Ben LaHaise wrote: Are you certain that adding yet another level of pointer indirection here is a good idea? The whole cache miss and indirection issue is exactly why almost all systems in the world make use of a VNODE style interface. Ben, mind looking into

Re: [PATCH][RFC] inode-u.nfs_i allocated separately

2001-06-27 Thread Alexander Viro
On Wed, 27 Jun 2001, Linus Torvalds wrote: and then when ext2 calls down to the generic VFS layer it just passes ext2_inode-inode down, and when it gets a struct inode * it uses inode_to_ext2() to convert it to an ext2 inode pointer. This is what the struct list_head thing

Re: [PATCH][RFC] inode-u.nfs_i allocated separately

2001-06-27 Thread Linus Torvalds
On Wed, 27 Jun 2001, Alexander Viro wrote: We get inode initilization (generic parts) spread all over the place and sooner or later it's going to bite us, for one thing. I don't really think so. The struct inode has become less and less important as far as the VFS layer is concerned, and

Re: [PATCH][RFC] inode-u.nfs_i allocated separately

2001-06-27 Thread Anton Altaparmakov
At 22:43 27/06/2001, Alexander Viro wrote: On Wed, 27 Jun 2001, Linus Torvalds wrote: and then when ext2 calls down to the generic VFS layer it just passes ext2_inode-inode down, and when it gets a struct inode * it uses inode_to_ext2() to convert it to an ext2 inode pointer.

Re: [PATCH][RFC] inode-u.nfs_i allocated separately

2001-06-27 Thread Daniel Phillips
On Wednesday 27 June 2001 23:22, Linus Torvalds wrote: we could _easily_ have the setup struct ext2_inode { struct inode inode; /* Generic fields */ specific-ext2 struct; /* specific fields */ }; and then when ext2 calls down to the generic

Re: [PATCH][RFC] inode-u.nfs_i allocated separately

2001-06-27 Thread Alexander Viro
On Thu, 28 Jun 2001, Daniel Phillips wrote: Advantages: no extra memory use, no indirection, no memory allocation overhead. An advantage you overlooked: clean up fs.h so it doesn't have to include every filesystem in the known universe. All of this also applies to struct

Re: [PATCH][RFC] inode-u.nfs_i allocated separately

2001-06-27 Thread Alexander Viro
On Wed, 27 Jun 2001, Linus Torvalds wrote: On Wed, 27 Jun 2001, Alexander Viro wrote: We get inode initilization (generic parts) spread all over the place and sooner or later it's going to bite us, for one thing. I don't really think so. The struct inode has become less and less

Re: [RFC] Quota reentrancy locking

2001-06-27 Thread Jan Kara
Hello, Planned state = Required locks: Nothing substantial changes. Just BKL might be substituted by some quota- specific spinlock. Blocking: No change - any quota call can schedule. Reentrancy: DQUOT_INITIALIZE(), DQUOT_TRANSFER() require any IO

Re: [RFC] Quota reentrancy locking

2001-06-27 Thread Andrew Morton
Jan Kara wrote: Quota file can grow only if you write quota for some user (group) for the first time. I think that after adding ~23 quota structures quotafile should grow (you can do this for example by creating files owned by users who never appeared on the system). But note that quota

Re: [PATCH][RFC] inode-u.nfs_i allocated separately

2001-06-27 Thread Alexander Viro
On Thu, 28 Jun 2001, Andrew Morton wrote: So the rule should be: if your private inode info is larger than ext2's, you should allocate it separately. Wrong. There is /proc. There is devfs or its equivalents. There are pipes and sockets. bloated inodes are OK since ext2 is all that matters