Re: TAKE 963965 - Add lockdep support for XFS

2007-05-03 Thread David Chinner
On Wed, May 02, 2007 at 12:51:05PM +0100, Christoph Hellwig wrote: On Fri, Apr 27, 2007 at 06:50:45PM +1000, Lachlan McIlroy wrote: Add lockdep support for XFS I don't think this is entirely correct, and it misses some of the most interesting cases. Yeah, we decided it was better to get

Re: [RFC] add FIEMAP ioctl to efficiently map file allocation

2007-05-03 Thread Andreas Dilger
On May 02, 2007 20:57 +1000, David Chinner wrote: On Wed, May 02, 2007 at 10:36:12AM +0100, Anton Altaparmakov wrote: HSM_READ is definitely _NOT_ required because all it means is if the file is OFFLINE, bring it ONLINE and then return the extent map. You've got the definition of

Re: [RFC] add FIEMAP ioctl to efficiently map file allocation

2007-05-03 Thread Anton Altaparmakov
On 3 May 2007, at 08:49, Andreas Dilger wrote: On May 02, 2007 20:57 +1000, David Chinner wrote: On Wed, May 02, 2007 at 10:36:12AM +0100, Anton Altaparmakov wrote: HSM_READ is definitely _NOT_ required because all it means is if the file is OFFLINE, bring it ONLINE and then return the

Re: [PATCH] Implement renaming for debugfs

2007-05-03 Thread Jan Kara
On Tue 01-05-07 20:26:27, Greg KH wrote: On Mon, Apr 30, 2007 at 07:55:36PM +0200, Jan Kara wrote: Hello, attached patch implements renaming for debugfs. I was asked for this feature by WLAN guys and I guess it makes sence (they have some debug info in the directory identified by

[PATCH 3/5] [NET]: Add __dev_getfirstbyhwtype

2007-05-03 Thread David Howells
Add __dev_getfirstbyhwtype for callers that don't want a reference but some data from the device and thus need to take the rtnl anyway. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Signed-off-by: David Howells [EMAIL PROTECTED] --- include/linux/netdevice.h |1 + net/core/dev.c

[PATCH 2/5] [AFS]: Fix memory leak in SRXAFSCB_GetCapabilities

2007-05-03 Thread David Howells
The interface array is not freed on exit. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/afs/cmservice.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/afs/cmservice.c b/fs/afs/cmservice.c index

[PATCH 4/5] [AFS]: Replace rtnetlink client by direct dev_base walking

2007-05-03 Thread David Howells
Replace the large and complicated rtnetlink client by two simple functions for getting the MAC address for the first ethernet device and building a list of IPv4 addresses. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/afs/Makefile

Re: [PATCH] AFS: Fix use of __exit functions from __init path

2007-05-03 Thread David Miller
From: David Howells [EMAIL PROTECTED] Date: Tue, 01 May 2007 19:17:06 +0100 Fix use of __exit functions from __init path. Signed-off-by: David Howells [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL

Re: [PATCH 1/5] [NETLINK]: Fix use after free in netlink_recvmsg

2007-05-03 Thread David Miller
From: David Howells [EMAIL PROTECTED] Date: Thu, 03 May 2007 10:53:15 +0100 When the user passes in MSG_TRUNC the skb is used after getting freed. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Signed-off-by: David Howells [EMAIL PROTECTED] Ugh, good catch, applied :-) - To unsubscribe

Re: [PATCH 2/5] [AFS]: Fix memory leak in SRXAFSCB_GetCapabilities

2007-05-03 Thread David Miller
From: David Howells [EMAIL PROTECTED] Date: Thu, 03 May 2007 10:53:20 +0100 The interface array is not freed on exit. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Signed-off-by: David Howells [EMAIL PROTECTED] Applied, thanks. - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 4/5] [AFS]: Replace rtnetlink client by direct dev_base walking

2007-05-03 Thread David Miller
From: David Howells [EMAIL PROTECTED] Date: Thu, 03 May 2007 10:53:31 +0100 Replace the large and complicated rtnetlink client by two simple functions for getting the MAC address for the first ethernet device and building a list of IPv4 addresses. Signed-off-by: Patrick McHardy [EMAIL

Re: [PATCH 5/5] AFS: Adjust the new netdevice scanning code

2007-05-03 Thread David Miller
From: David Howells [EMAIL PROTECTED] Date: Thu, 03 May 2007 10:53:36 +0100 Adjust the new netdevice scanning code provided by Patrick McHardy: (1) Restore the function banner comments that were dropped. (2) Rather than using an array size of 6 in some places and an array size of

Re: [PATCH 1/5] [NETLINK]: Fix use after free in netlink_recvmsg

2007-05-03 Thread Marcel Holtmann
Hi Dave, When the user passes in MSG_TRUNC the skb is used after getting freed. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Signed-off-by: David Howells [EMAIL PROTECTED] Ugh, good catch, applied :-) it seems this could be easily exploited and is at least a local DoS. It should

Re: [PATCH 1/5] [NETLINK]: Fix use after free in netlink_recvmsg

2007-05-03 Thread Patrick McHardy
Marcel Holtmann wrote: it seems this could be easily exploited and is at least a local DoS. It should be a candidate for the -stable kernel. The bug got introduced in 2.6.21-git, so -stable is not affected. - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of

Re: [PATCH 1/5] [NETLINK]: Fix use after free in netlink_recvmsg

2007-05-03 Thread David Miller
From: Marcel Holtmann [EMAIL PROTECTED] Date: Thu, 03 May 2007 14:27:16 +0200 Hi Dave, When the user passes in MSG_TRUNC the skb is used after getting freed. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Signed-off-by: David Howells [EMAIL PROTECTED] Ugh, good catch,

Re: [PATCH] Implement renaming for debugfs

2007-05-03 Thread Greg KH
On Thu, May 03, 2007 at 11:54:52AM +0200, Jan Kara wrote: On Tue 01-05-07 20:26:27, Greg KH wrote: On Mon, Apr 30, 2007 at 07:55:36PM +0200, Jan Kara wrote: Hello, attached patch implements renaming for debugfs. I was asked for this feature by WLAN guys and I guess it makes

Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc

2007-05-03 Thread Andrew Morton
On Thu, 26 Apr 2007 23:33:32 +0530 Amit K. Arora [EMAIL PROTECTED] wrote: This patch implements the fallocate() system call and adds support for i386, x86_64 and powerpc. ... +asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len) Please add a comment over this

Re: [PATCH 3/5] ext4: Extent overlap bugfix

2007-05-03 Thread Andrew Morton
On Thu, 26 Apr 2007 23:41:01 +0530 Amit K. Arora [EMAIL PROTECTED] wrote: +unsigned int ext4_ext_check_overlap(struct inode *inode, + struct ext4_extent *newext, + struct ext4_ext_path *path) +{ + unsigned long b1,

Re: [PATCH 4/5] ext4: fallocate support in ext4

2007-05-03 Thread Andrew Morton
On Thu, 26 Apr 2007 23:43:32 +0530 Amit K. Arora [EMAIL PROTECTED] wrote: This patch has the ext4 implemtation of fallocate system call. ... + /* ext4_can_extents_be_merged should have checked that either + * both extents are uninitialized, or both aren't. Thus we

Re: [PATCH 5/5] ext4: write support for preallocated blocks/extents

2007-05-03 Thread Andrew Morton
On Thu, 26 Apr 2007 23:46:23 +0530 Amit K. Arora [EMAIL PROTECTED] wrote: This patch adds write support for preallocated (using fallocate system call) blocks/extents. The preallocated extents in ext4 are marked uninitialized, hence they need special handling especially while writing to them.

Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc

2007-05-03 Thread Andrew Morton
On Thu, 3 May 2007 21:29:55 -0700 Andrew Morton [EMAIL PROTECTED] wrote: + ret = -EFBIG; + if (offset + len inode-i_sb-s_maxbytes) + goto out_fput; This code does handle offset+len going negative, but only by accident, I suspect. But it doesn't handle offset+len wrapping

Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc

2007-05-03 Thread Paul Mackerras
Andrew Morton writes: On Thu, 26 Apr 2007 23:33:32 +0530 Amit K. Arora [EMAIL PROTECTED] wrote: This patch implements the fallocate() system call and adds support for i386, x86_64 and powerpc. ... +asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len)