Re: [PATCH 0/4] autofs4 - implement a miscelaneous device for ioctl control

2008-02-25 Thread Andrew Morton
We have four patches, all with the same title - please avoid doing this. I could invent titles for them (as I often have to do), but I think it would be best if you were to do so. That way, we avoid confusion and people who later google for the patch's title to understand the patch's background

Re: [PATCH 0/4] autofs4 - implement a miscelaneous device for ioctl control

2008-02-25 Thread Ian Kent
On Mon, 2008-02-25 at 00:17 -0800, Andrew Morton wrote: We have four patches, all with the same title - please avoid doing this. I could invent titles for them (as I often have to do), but I think it would be best if you were to do so. That way, we avoid confusion and people who later

[PATCH] uverbs: kill last remaining modular get_empty_filp user

2008-02-25 Thread Christoph Hellwig
uvers should be using the proper alloc_file helper instead of an open-coded get_empty_filp. In fact this was the last modular user so we can kill the export aswell and force people to use the proper interface. Also remove the useless setting of .owner and the fops_get because all this is not

Re: [PATCH 00/37] Permit filesystem local caching

2008-02-25 Thread David Howells
Daniel Phillips [EMAIL PROTECTED] wrote: This factor of four (even worse on XFS, not quite as bad on Ext3) is worth ruminating upon. Is all of the difference explained by avoiding seeks on the server, which has the files in memory? Here are some more stats for you to consider: (1) Copy

Re: [PATCH 00/37] Permit filesystem local caching

2008-02-25 Thread Daniel Phillips
On Monday 25 February 2008 15:19, David Howells wrote: So I guess there's a problem in cachefiles's efficiency - possibly due to the fact that it tries to be fully asynchronous. OK, not just my imagination, and it makes me feel better about the patch set because efficiency bugs are fixable

Re: [PATCH 00/37] Permit filesystem local caching

2008-02-25 Thread David Howells
Daniel Phillips [EMAIL PROTECTED] wrote: On Monday 25 February 2008 15:19, David Howells wrote: So I guess there's a problem in cachefiles's efficiency - possibly due to the fact that it tries to be fully asynchronous. OK, not just my imagination, and it makes me feel better about the

[PATCH 0/4] autofs4 - autofs needs a miscelaneous device for ioctls

2008-02-25 Thread Ian Kent
Hi Andrew, There is a problem with active restarts in autofs (that is to say restarting autofs when there are busy mounts). Currently autofs uses umount -l to clear active mounts at restart. While using lazy umount works for most cases, anything that needs to walk back up the mount tree to

[PATCH 1/4] autofs4 - check for invalid dentry in getpath

2008-02-25 Thread Ian Kent
Hi Andrew, Patch to catch invalid dentry when calculating it's path. Signed-off-by: Ian Kent [EMAIL PROTECTED] Ian --- diff -up linux-2.6.25-rc2-mm1/fs/autofs4/waitq.c.getpath-check-valid-dentry linux-2.6.25-rc2-mm1/fs/autofs4/waitq.c ---

[PATCH 4/4] autofs4 - add miscelaneous device for ioctls

2008-02-25 Thread Ian Kent
Hi Andrew, Patch to add miscellaneous device to autofs4 module for ioctls. Signed-off-by: Ian Kent [EMAIL PROTECTED] Ian --- diff -up linux-2.6.25-rc2-mm1/fs/autofs4/expire.c.device-node-ioctl linux-2.6.25-rc2-mm1/fs/autofs4/expire.c ---

Re: [PATCH 3/4] autofs4 - track uid and gid of last mount requestor - correction

2008-02-25 Thread Ian Kent
On Tue, 26 Feb 2008, Ian Kent wrote: + + /* Set mount requestor */ + if (ino) { + if (ino) { + ino-uid = wq-uid; + ino-gid = wq-gid; + } + } + As has been

Proposal for proper durable fsync() and fdatasync()

2008-02-25 Thread Jamie Lokier
Dear kernel, This is a proposal to add proper durable fsync() and fdatasync() to Linux. First the problem, then a proposed solution with benefits, so to speak. I need feedback on the details, before implementing anything. Or (hopefully) someone else thinks it's very important and does it

Re: Proposal for proper durable fsync() and fdatasync()

2008-02-25 Thread Andrew Morton
On Tue, 26 Feb 2008 07:26:50 + Jamie Lokier [EMAIL PROTECTED] wrote: (It would be nicer if sync_file_range() took a vector of ranges for better elevator scheduling, but let's ignore that :-) Two passes: Pass 1: shove each of the segments into the queue with

Re: Proposal for proper durable fsync() and fdatasync()

2008-02-25 Thread Jamie Lokier
Jeff Garzik wrote: Jamie Lokier wrote: By durable, I mean that fsync() should actually commit writes to physical stable storage, Yes, it should. Glad we agree :-) I was surprised that fsync() doesn't do this already. There was a lot of effort put into block I/O write barriers during