Re: [patch 01/26] mount options: add documentation

2008-02-08 Thread Roman Zippel
Hi, On Wed, 30 Jan 2008, Miklos Szeredi wrote: How does this deal with certain special cases: - chroot: how will mount/df only show the for chroot relevant mounts? That is a very good question. Andreas Gruenbacher had some patches for fixing behavior of /proc/mounts under a chroot, but

Re: [PATCH][RFC] fix reservation discarding in affs

2008-01-13 Thread Roman Zippel
Hi, On Thu, 10 Jan 2008, Christoph Hellwig wrote: Is there any chance you could either send me a affs image to run fsx on it or do it yourself? If you want you can use http://www.xs4all.nl/~zippel/affstools-0.1a.tar.gz to create one. bye, Roman - To unsubscribe from this list: send the line

Re: Read/write counts

2007-06-04 Thread Roman Zippel
Hi, On Mon, 4 Jun 2007, Theodore Tso wrote: Hmm, I'm not sure I would go that far. Per the POSIX specification, we support the optional BSD-style restartable system calls for signals which will avoid short reads; but this is only true if SA_RESTART is passed to sigaction(). Without

Re: [PATCH 1/17] cramfs: use read_mapping_page

2007-04-12 Thread Roman Zippel
Hi, On Thu, 12 Apr 2007, Christoph Hellwig wrote: On Wed, Apr 11, 2007 at 07:49:38PM -0700, Nate Diller wrote: read_mapping_page_async() is going away, so convert its only user to read_mapping_page(). This change has not been benchmarked, however, in order to get real parallelism this

[PATCH 3/5] hfs: remove debug code

2005-08-01 Thread Roman Zippel
Hi, This removes some old debug code, which is no longer needed. Signed-off-by: Roman Zippel [EMAIL PROTECTED] --- fs/hfs/bnode.c | 21 + fs/hfsplus/bnode.c | 21 + 2 files changed, 2 insertions(+), 40 deletions(-) Index: linux-2.6/fs/hfsplus

[PATCH 5/5] hfs: NLS support

2005-08-01 Thread Roman Zippel
Hi, This adds NLS support to HFS. Using the kernel options iocharset and codepage it's possible to map the disk encoding to a local mapping. If these options are not used, it falls back to the old direct mapping. Signed-off-by: Roman Zippel [EMAIL PROTECTED] --- fs/hfs/catalog.c | 35

Re: [PATCH 1/5] hfs: don't dirty unchanged inode

2005-08-01 Thread Roman Zippel
Hi, On Mon, 1 Aug 2005, Roman Zippel wrote: If inode size hasn't changed, don't do anything further in truncate, which also prevents a dirty inode, what might upset some readonly devices quite badly. Sorry, I forgot this: Signed-off-by: Roman Zippel [EMAIL PROTECTED] Andrew, the first

Re: share/private/slave a subtree - define vs enum

2005-07-10 Thread Roman Zippel
Hi, On Sun, 10 Jul 2005, Pekka Enberg wrote: The point of a review is to comment on things that _need_ fixing. Less experienced hackers take this a requirement for their drivers to be included. Hmm. So we disagree on that issue as well. I think the point of review is to improve code

Re: share/private/slave a subtree - define vs enum

2005-07-08 Thread Roman Zippel
Hi, On Fri, 8 Jul 2005, Pekka Enberg wrote: On Fri, 2005-07-08 at 21:11 +0200, Roman Zippel wrote: So it basically comes down to personal preference, if the original uses defines and it works fine, I don't really see a good enough reason to change it to enums, so please leave

[PATCH 1/7] hfs: free page buffers in releasepage

2005-03-18 Thread Roman Zippel
Call try_to_free_buffers() when a page can be released. This behaviour changed during 2.5 and wasn't fixed in hfs while porting it to 2.6. Also remove an unnecessary PageActive() check, only the node ref count is really relevant. Signed-off-by: Roman Zippel [EMAIL PROTECTED] --- hfs/inode.c

[PATCH 2/7] hfs: fix umask behaviour

2005-03-18 Thread Roman Zippel
This makes umask behaviour more consistent, so it's now also used for new files and the mount options behave like other umask users. (Problem reported by [EMAIL PROTECTED]) Signed-off-by: Roman Zippel [EMAIL PROTECTED] --- inode.c | 14 ++ super.c |6 +++--- 2 files changed

[PATCH 3/7] hfs: more bnode error checks

2005-03-18 Thread Roman Zippel
Check for errors during reading of bnode pages and report them. Also improve error checks in case bnode validity checks failed. Signed-off-by: Roman Zippel [EMAIL PROTECTED] --- hfs/bnode.c | 12 hfsplus/bnode.c | 12 2 files changed, 24 insertions(+) Index

[PATCH 4/7] hfs: fix sign problem in hfs_ext_keycmp

2005-03-18 Thread Roman Zippel
The key values are unsigned, so comparing them using the difference doesn't always work. (Problem reported by [EMAIL PROTECTED]) Signed-off-by: Roman Zippel [EMAIL PROTECTED] --- extent.c | 29 ++--- 1 files changed, 14 insertions(+), 15 deletions(-) Index: linux

[PATCH 5/7] hfs: use parse library for mount options

2005-03-18 Thread Roman Zippel
Make use of parser library to parse mount options. Signed-off-by: Roman Zippel [EMAIL PROTECTED] --- hfs/super.c | 166 -- hfsplus/options.c | 114 ++--- 2 files changed, 158 insertions(+), 122

[PATCH 6/7] hfs: add nls support

2005-03-18 Thread Roman Zippel
Add full nls support for HFS+. The default is still utf8, but that can be changed now via a mount option. Signed-off-by: Roman Zippel [EMAIL PROTECTED] --- Kconfig |1 hfsplus/catalog.c| 39 ++-- hfsplus/dir.c|8