On Sun, Oct 28, 2007 at 02:05:16PM -0400, Erez Zadok wrote:
Sure. I assume you mean an internal function to encapsulate the entire case
statement's code, one for each of the FIO* cases.
Yes.
-
To unsubscribe from this list: send the line unsubscribe linux-fsdevel in
the body of a message to
On Sun, Oct 28, 2007 at 07:57:47PM -0700, Daniel Phillips wrote:
On 10/28/07, Christoph Hellwig [EMAIL PROTECTED] wrote:
While you're at it, it's probably worth splitting this out into
a small helper function.
Why? Is the same pattern called from more than one place?
Becauase it's a lot
Nice, I always hated these double-indented switch statements.
+ case FIBMAP:
+ {
+ struct address_space *mapping = filp-f_mapping;
+ int res;
+ /* do we support this mess? */
+ if (!mapping-a_ops-bmap)
+ return
In message [EMAIL PROTECTED], Christoph Hellwig writes:
Nice, I always hated these double-indented switch statements.
+ case FIBMAP:
+ {
+ struct address_space *mapping = filp-f_mapping;
+ int res;
+ /* do we support this mess? */
+ if
On 10/28/07, Christoph Hellwig [EMAIL PROTECTED] wrote:
While you're at it, it's probably worth splitting this out into
a small helper function.
Why? Is the same pattern called from more than one place?
Regards,
Daniel
-
To unsubscribe from this list: send the line unsubscribe linux-fsdevel
