Re: [Patch 06/18] fs/logfs/compr.c

2007-06-04 Thread Jörn Engel
On Sun, 3 June 2007 23:58:43 +0200, Arnd Bergmann wrote: On Sunday 03 June 2007, Jörn Engel wrote: +#define COMPR_LEVEL 3 + +static DEFINE_MUTEX(compr_mutex); +static struct z_stream_s stream; Is there a particular reason to choose '3' as the only compression level? Should this

Re: [Patch 06/18] fs/logfs/compr.c

2007-06-04 Thread David Woodhouse
On Mon, 2007-06-04 at 10:54 +0200, Jörn Engel wrote: There is no particular reason. '3' should be a reasonable value for most people. If actual users want to change this value, I can make it a mount option as well. Right now I'm just lazy and doubt the merits. I think you probably made the

[Patch 06/18] fs/logfs/compr.c

2007-06-03 Thread Jörn Engel
--- /dev/null 2007-03-13 19:15:28.862769062 +0100 +++ linux-2.6.21logfs/fs/logfs/compr.c 2007-06-03 19:18:57.0 +0200 @@ -0,0 +1,95 @@ +/* + * fs/logfs/compr.c- compression routines + * + * As should be obvious for Linux kernel code, license is GPLv2 + * + * Copyright (c) 2005-2007

Re: [Patch 06/18] fs/logfs/compr.c

2007-06-03 Thread Arnd Bergmann
On Sunday 03 June 2007, Jörn Engel wrote: +#define COMPR_LEVEL 3 + +static DEFINE_MUTEX(compr_mutex); +static struct z_stream_s stream; Is there a particular reason to choose '3' as the only compression level? Should this perhaps be a per-superblock option instead? Also, I thought I saw