Re: [RFC][PATCH] ensure i_ino uniqueness in filesystems without permanent inode numbers (via idr)

2006-12-03 Thread Al Boldi
Brad Boyer wrote: To be honest, I think it looks bad for someone associated with redhat to be suggesting that life should be made more difficult for those who write proprietary software on Linux. The support from commercial software is a major reason for the success of the RHEL product line.

Re: [RFC][PATCH] ensure i_ino uniqueness in filesystems without permanent inode numbers (via idr)

2006-12-02 Thread Jeff Layton
Brad Boyer wrote: On Fri, Dec 01, 2006 at 12:21:36PM -0500, Jeff Layton wrote: Here's an updated (but untested) patch based on your suggestions. I also went ahead and made the exported symbols GPL-only since that seems like it would be appropriate here. Any further thoughts on it? This

Re: [RFC][PATCH] ensure i_ino uniqueness in filesystems without permanent inode numbers (via idr)

2006-12-02 Thread Brad Boyer
On Sat, Dec 02, 2006 at 09:56:27PM -0500, Jeff Layton wrote: My main reasoning for doing this was that the structures involved are per-superblock. There is virtually no reason that a filesystem would ever need to touch these structures in another filesystem. I don't think this is relevant to

Re: [RFC][PATCH] ensure i_ino uniqueness in filesystems without permanent inode numbers (via idr)

2006-12-01 Thread Jeff Layton
On Fri, Dec 01, 2006 at 08:52:27AM -0800, Randy Dunlap wrote: Thanks for having a look, Randy... s/idr_/iunique_/ Doh! Can you tell I cut and pasted this email from earlier ones? :-) - don't attempt to remove inodes with values 100 Please explain that one. (May be obvious to some, but

Re: [RFC][PATCH] ensure i_ino uniqueness in filesystems without permanent inode numbers (via idr)

2006-12-01 Thread Randy Dunlap
Jeff Layton wrote: On Fri, Dec 01, 2006 at 08:52:27AM -0800, Randy Dunlap wrote: Thanks for having a look, Randy... s/idr_/iunique_/ Doh! Can you tell I cut and pasted this email from earlier ones? :-) - don't attempt to remove inodes with values 100 Please explain that one. (May be

Re: [RFC][PATCH] ensure i_ino uniqueness in filesystems without permanent inode numbers (via idr hashing)

2006-12-01 Thread Jeff Layton
Thanks again, Randy. Here's an updated and tested patch and description. This one also makes sure that the root inode for the mount gets a unique i_ino value as well. Let me know what you think... --[snip]--- This patch is a proof of concept. It works, but I'd like to get

Re: [RFC][PATCH] ensure i_ino uniqueness in filesystems without permanent inode numbers (via idr)

2006-11-16 Thread Al Viro
On Wed, Nov 15, 2006 at 11:42:38AM -0500, Jeff Layton wrote: +{ + int rv; + + rv = idr_pre_get(inode-i_sb-s_inode_ids, GFP_KERNEL); + if (! rv) + return -ENOMEM; + + lock_super(inode-i_sb); [EMAIL PROTECTED] Please, use something saner. Use of lock_super()

Re: [RFC][PATCH] ensure i_ino uniqueness in filesystems without permanent inode numbers (via idr)

2006-11-16 Thread Jeff Layton
On Thu, 2006-11-16 at 14:06 +, Al Viro wrote: On Wed, Nov 15, 2006 at 11:42:38AM -0500, Jeff Layton wrote: +{ + int rv; + + rv = idr_pre_get(inode-i_sb-s_inode_ids, GFP_KERNEL); + if (! rv) + return -ENOMEM; + + lock_super(inode-i_sb); [EMAIL PROTECTED]