read_inode() extra argument ?

2000-12-19 Thread Steve Whitehouse
Hi, Can you tell me if there is a reason that the "opaque" argument of iget4() doesn't get passed to read_inode() ? If the answer is simply that nobody has sent a patch yet, then I've got a patch here which I'll forward to you. I wondered if this was perhaps something scheduled for change in 2.5

Re: read_inode() extra argument ?

2000-12-19 Thread Alexander Viro
On Tue, 19 Dec 2000, Steve Whitehouse wrote: Hi, Can you tell me if there is a reason that the "opaque" argument of iget4() doesn't get passed to read_inode() ? If the answer is simply that nobody has sent a patch yet, then I've got a patch here which I'll forward to you. I wondered if

Re: read_inode() extra argument ?

2000-12-19 Thread Steve Whitehouse
Hi, Thanks for your quick response. [patch and explanation snipped] The point being: allow filesystems to use whatever means they find convenient for filling the inode. All we really need from icache is an analog of iget() that would leave new struct inode locked, recognizable as new and

Re: read_inode() extra argument ?

2000-12-19 Thread Daniel Phillips
Alexander Viro wrote: In all fairness, -read_inode() should not be a method. Correct way to deal with that would be along the lines [...] + if (inode-i_state I_NEW) { + ext2_read_inode(inode); + unlock_new_inode(inode); +