Re: [patch 00/10] mount ownership and unprivileged mount syscall (v8)

2008-02-15 Thread Christoph Hellwig
On Thu, Feb 14, 2008 at 10:21:03PM -0800, Andrew Morton wrote: Linus has just merged all the VFS renaming patches, so the decks are clear for looking at this work. However David and Christoph are beavering away on the r-o-bind-mounts patches and I expect that there will be overlaps with

Re: [patch 00/10] mount ownership and unprivileged mount syscall (v8)

2008-02-15 Thread Andrew Morton
On Fri, 15 Feb 2008 04:01:20 -0500 Christoph Hellwig [EMAIL PROTECTED] wrote: On Thu, Feb 14, 2008 at 10:21:03PM -0800, Andrew Morton wrote: Linus has just merged all the VFS renaming patches, so the decks are clear for looking at this work. However David and Christoph are beavering

Re: [patch 00/10] mount ownership and unprivileged mount syscall (v8)

2008-02-15 Thread Christoph Hellwig
On Fri, Feb 15, 2008 at 01:09:51AM -0800, Andrew Morton wrote: However David and Christoph are beavering away on the r-o-bind-mounts patches and I expect that there will be overlaps with unprivileged mounts. Could we coordinate things a bit please? Decide who goes first, review

Re: i_version changes

2008-02-15 Thread Jean noel Cordenner
Peter Staubach a écrit : Few month ago, I ran a FFSB test on a 2.6.23 kernel enabling or not the i_version flag. http://bullopensource.org/ext4/20071116/ffsb-write.html This is good information. A couple of questions -- what is the -I 256 option used for the ext4 mkfs? This option force

Re: [RFC] ext3 freeze feature

2008-02-15 Thread Takashi Sato
Hi, Christoph Hellwig wrote: On Fri, Feb 08, 2008 at 08:26:57AM -0500, Andreas Dilger wrote: You may as well make the common ioctl the same as the XFS version, both by number and parameters, so that applications which already understand the XFS ioctl will work on other filesystems. Yes. In

Re: [RFC] ext3 freeze feature

2008-02-15 Thread Eric Sandeen
Takashi Sato wrote: Hi, Christoph Hellwig wrote: On Fri, Feb 08, 2008 at 08:26:57AM -0500, Andreas Dilger wrote: You may as well make the common ioctl the same as the XFS version, both by number and parameters, so that applications which already understand the XFS ioctl will work on other

Re: [linux-cifs-client] review 5, was Re: projected date for mount.cifs to support DFS junction points

2008-02-15 Thread Q (Igor Mammedov)
Sorry guys, but I have a lot of work for the last 3 weeks, so I couldn't spare much time for a hobby and react quickly. Here is what I've done the last weekend. Attached: fixed patch [5/5] (0001-DFS-patch-that-connects-inode-with-dfs-handling-ops.patch). fixed mixed case in struct member

Re: [linux-cifs-client] review 5, was Re: projected date for mount.cifs to support DFS junction points

2008-02-15 Thread Christoph Hellwig
On Fri, Feb 15, 2008 at 07:37:35PM +0300, Q (Igor Mammedov) wrote: Sorry guys, but I have a lot of work for the last 3 weeks, so I couldn't spare much time for a hobby and react quickly. No problem. I know this problem very well as almost all of my core kernel contributions are spare time as

Re: [linux-cifs-client] review 5, was Re: projected date for mount.cifs to support DFS junction points

2008-02-15 Thread Steve French
On 2/15/08, Christoph Hellwig [EMAIL PROTECTED] wrote: On Fri, Feb 15, 2008 at 07:37:35PM +0300, Q (Igor Mammedov) wrote: Here is what I've done the last weekend. Attached: fixed patch [5/5] (0001-DFS-patch-that-connects-inode-with-dfs-handling-ops.patch). Not merged yet. fixed

Re: [linux-cifs-client] review 5, was Re: projected date for mount.cifs to support DFS junction points

2008-02-15 Thread Christoph Hellwig
If you like these kind of consolidation patches here's another one: Index: linux-2.6/fs/cifs/inode.c === --- linux-2.6.orig/fs/cifs/inode.c 2008-02-15 22:46:08.0 +0100 +++ linux-2.6/fs/cifs/inode.c 2008-02-15

[patch 02/18] Use page_cache_xxx functions in mm/filemap.c

2008-02-15 Thread Christoph Lameter
Convert the uses of PAGE_CACHE_xxx. Reviewed-by: Dave Chinner [EMAIL PROTECTED] Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- mm/filemap.c | 91 +-- 1 file changed, 46 insertions(+), 45 deletions(-) Index: linux-2.6/mm/filemap.c

[patch 03/18] Use page_cache_xxx in mm/page-writeback.c

2008-02-15 Thread Christoph Lameter
Use page_cache_xxx in mm/page-writeback.c Reviewed-by: Dave Chinner [EMAIL PROTECTED] Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- mm/page-writeback.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: mm/mm/page-writeback.c

[patch 04/18] Use page_cache_xxx in mm/truncate.c

2008-02-15 Thread Christoph Lameter
Use page_cache_xxx in mm/truncate.c Reviewed-by: Dave Chinner [EMAIL PROTECTED] Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- mm/truncate.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) Index: linux-2.6.24-rc6-mm1/mm/truncate.c

[patch 05/18] Use page_cache_xxx in mm/rmap.c

2008-02-15 Thread Christoph Lameter
V2-V3: - vma_address(): Check for truncation if this is a file based page. return -EFAULT if truncation occurred. - page_referenced_file(): Only use mapping after we have made sure that the mapping is valid and the page is locked. Use page_cache_xxx in mm/rmap.c Reviewed-by: Dave

[patch 06/18] Use page_cache_xxx in mm/filemap_xip.c

2008-02-15 Thread Christoph Lameter
Use page_cache_xxx in mm/filemap_xip.c Reviewed-by: Dave Chinner [EMAIL PROTECTED] Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- mm/filemap_xip.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) Index: linux-2.6/mm/filemap_xip.c

[patch 08/18] Use page_cache_xxx in fs/libfs.c

2008-02-15 Thread Christoph Lameter
Use page_cache_xxx in fs/libfs.c Reviewed-by: Dave Chinner [EMAIL PROTECTED] Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- fs/libfs.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) Index: linux-2.6/fs/libfs.c

[patch 07/18] Use page_cache_xxx in mm/migrate.c

2008-02-15 Thread Christoph Lameter
V2-V3: - Only use mapping in remove_file_migration_ptes after it was checked for NULL. Use page_cache_xxx in mm/migrate.c Reviewed-by: Dave Chinner [EMAIL PROTECTED] Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- mm/migrate.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[patch 09/18] Use page_cache_xxx in fs/sync

2008-02-15 Thread Christoph Lameter
Use page_cache_xxx in fs/sync. Reviewed-by: Dave Chinner [EMAIL PROTECTED] Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- fs/sync.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: linux-2.6/fs/sync.c

[patch 10/18] Use page_cache_xxx in fs/buffer.c

2008-02-15 Thread Christoph Lameter
V2-V3: - alloc_page_buffers(): Add comment to explain use of page-mapping - Consistently determine mapping if there is a reference chain page-mapping-host to determine the inode. Use page_cache_xxx in fs/buffer.c. Reviewed-by: Dave Chinner [EMAIL PROTECTED] Signed-off-by: Christoph Lameter

[patch 11/18] Use page_cache_xxx in mm/mpage.c

2008-02-15 Thread Christoph Lameter
Use page_cache_xxx in mm/mpage.c Reviewed-by: Dave Chinner [EMAIL PROTECTED] Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- fs/mpage.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) Index: linux-2.6/fs/mpage.c

[patch 13/18] Use page_cache_xxx in fs/splice.c

2008-02-15 Thread Christoph Lameter
Use page_cache_xxx in fs/splice.c Reviewed-by: Dave Chinner [EMAIL PROTECTED] Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- fs/splice.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) Index: linux-2.6/fs/splice.c

[patch 14/18] Use page_cache_xxx in ext2

2008-02-15 Thread Christoph Lameter
Use page_cache_xxx functions in fs/ext2/* Reviewed-by: Dave Chinner [EMAIL PROTECTED] Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- fs/ext2/dir.c | 41 +++-- 1 file changed, 23 insertions(+), 18 deletions(-) Index: linux-2.6/fs/ext2/dir.c

[patch 12/18] Use page_cache_xxx in mm/fadvise.c

2008-02-15 Thread Christoph Lameter
Use page_cache_xxx in mm/fadvise.c Reviewed-by: Dave Chinner [EMAIL PROTECTED] Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- mm/fadvise.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: linux-2.6/mm/fadvise.c

[patch 15/18] Use page_cache_xxx in fs/ext3

2008-02-15 Thread Christoph Lameter
Use page_cache_xxx in fs/ext3 Reviewed-by: Dave Chinner [EMAIL PROTECTED] Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- fs/ext3/dir.c |3 ++- fs/ext3/inode.c | 39 --- 2 files changed, 22 insertions(+), 20 deletions(-) Index:

[patch 16/18] Use page_cache_xxx in fs/ext4

2008-02-15 Thread Christoph Lameter
Use page_cache_xxx in fs/ext4 Reviewed-by: Dave Chinner [EMAIL PROTECTED] Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- fs/ext4/dir.c |3 ++- fs/ext4/inode.c | 34 +- 2 files changed, 19 insertions(+), 18 deletions(-) Index:

[patch 18/18] Use page_cache_xxx for fs/xfs

2008-02-15 Thread Christoph Lameter
V2-V3: - xfs_page_trace: Determine mapping from inode - xfs_probe_page: Make mapping check easier to read Use page_cache_xxx for fs/xfs Reviewed-by: Dave Chinner [EMAIL PROTECTED] Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- fs/xfs/linux-2.6/xfs_aops.c | 58

[patch 17/18] Use page_cache_xxx in fs/reiserfs

2008-02-15 Thread Christoph Lameter
V2-V3: - reiserfs_commit_write(): Use common method to extract mapping from page-mapping-host chain Use page_cache_xxx in fs/reiserfs Reviewed-by: Dave Chinner [EMAIL PROTECTED] Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- fs/reiserfs/file.c|5 +++--

[patch 01/18] Define functions for page cache handling

2008-02-15 Thread Christoph Lameter
V2-V3: - Use mapping instead of a as the address space parameter We use the macros PAGE_CACHE_SIZE PAGE_CACHE_SHIFT PAGE_CACHE_MASK and PAGE_CACHE_ALIGN in various places in the kernel. Many times common operations like calculating the offset or the index are coded using shifts and adds. This

[patch 00/18] Page cache: Replace PAGE_CACHE_xx with inline functions V4

2008-02-15 Thread Christoph Lameter
This patchset cleans up page cache handling by replacing open coded shifts and adds with inline function calls. The ultimate goal is to replace all uses of PAGE_CACHE_xxx in the kernel through the use of these functions. All the functions take a mapping parameter. The mapping parameter is