In message [EMAIL PROTECTED], Miklos Szeredi writes:
From: Miklos Szeredi [EMAIL PROTECTED]
This series addresses the problem of showing mount options in
/proc/mounts.
[...]
The following filesystems still need fixing: CIFS, NFS, XFS, Unionfs,
Reiser4. For CIFS, NFS and XFS I
Also add minor fix: when parsing the mode option, mask with
S_IALLUGO instead of ~S_IFMT, which could leave unsed bits in the
mask.
umode_t is 16 bits, so it doesn't. The change is still good, of course.
We still use 16 bit types? Strange ;)
+ if (config.mode !=
On Thu, Jan 24, 2008 at 08:33:50PM +0100, Miklos Szeredi wrote:
From: Miklos Szeredi [EMAIL PROTECTED]
Add a .show_options super operation to capifs.
Use generic_show_options() and save the complete option string in
capifs_remount().
Signed-off-by: Miklos Szeredi [EMAIL PROTECTED]
On Jan 25, 2008 12:29 PM, Miklos Szeredi [EMAIL PROTECTED] wrote:
| + /* is this correct? */
| + if (sbi-s_anchor[2] != 0)
| + seq_printf(seq, ,anchor=%u, sbi-s_anchor[2]);
you know, I would prefer to use form UDF_SB_ANCHOR(sb)[2]
in sake of style unification but we
In the LSM ml, we are discussing about
how to know requested pathnames within LSM modules.
Currently, VFS helper functions don't pass struct vfsmount parameter.
Therefore, we cannot calculate requested pathnames within LSM modules
because LSM hooks can't know struct vfsmount parameter that
Where did you check for the existence of a -show_options method for
unionfs? Unionfs does implement -show_options and supports all of the
mount/remount options. See:
Hi,
Currently, ext3 doesn't have the freeze feature which suspends write
requests. So, we cannot get a backup which keeps the filesystem's
consistency with the storage device's features (snapshot, replication)
while it is mounted.
In many case, a commercial filesystems (e.g. VxFS) has the freeze
| + /* is this correct? */
| + if (sbi-s_anchor[2] != 0)
| + seq_printf(seq, ,anchor=%u, sbi-s_anchor[2]);
you know, I would prefer to use form UDF_SB_ANCHOR(sb)[2]
in sake of style unification but we should wait for Jan's
decision (i'm not the expert in this area ;)
I think
Miklos Szeredi wrote:
From: Miklos Szeredi [EMAIL PROTECTED]
Add posix, bsize=, namelen= options to /proc/mounts for nfs
filesystems.
Document several other options that are still missing.
NFS lists only some options in /proc/mounts on purpose: only the
essential options are
On Thu, 2008-01-24 at 20:34 +0100, Miklos Szeredi wrote:
plain text document attachment (nfs_opts.patch)
From: Miklos Szeredi [EMAIL PROTECTED]
Add posix, bsize=, namelen= options to /proc/mounts for nfs
filesystems.
Document several other options that are still missing.
From: Miklos Szeredi [EMAIL PROTECTED]
Add a .show_options super operation to usbfs.
Signed-off-by: Miklos Szeredi [EMAIL PROTECTED]
Looks good to me. Do you want to take this through your tree, as it is
dependant on other changes, or do you want me to take this through the
USB
Hi,
diff -uprN -X linux-2.6.24-rc8/Documentation/dontdiff
linux-2.6.24-rc8/include/linux/ext3_fs_sb.h
linux-2.6.24-rc8-freeze/include/linux/ext3_fs_sb.h
--- linux-2.6.24-rc8/include/linux/ext3_fs_sb.h 2008-01-16 13:22:48.0
+0900
+++
Hi,
I am also wondering whether we should have system call(s) for these:
On Jan 25, 2008 12:59 PM, Takashi Sato [EMAIL PROTECTED] wrote:
+ case EXT3_IOC_FREEZE: {
+ case EXT3_IOC_THAW: {
And just convert XFS to use them too?
I think it is reasonable to implement it as the
On 19:59 Fri 25 Jan , Takashi Sato wrote:
Hi,
Currently, ext3 doesn't have the freeze feature which suspends write
requests. So, we cannot get a backup which keeps the filesystem's
consistency with the storage device's features (snapshot, replication)
while it is mounted.
In many
On Friday 25 January 2008, Jan Kara wrote:
If ext3's DIO code only touches transactions in get_block, then it can
violate data=ordered rules. Basically the transaction that allocates
the blocks might commit before the DIO code gets around to writing them.
A crash in the wrong place
On Fri 25-01-08 16:56:13, Miklos Szeredi wrote:
Please use just 'int' for 'remount' option. We are slowly trying to
get rid of these strange things in UDF code so adding new ones isn't
desirable.
What's wrong with bool?
I'm not advocating mass replacements, but all new code _should_
Hi Adrian,
Please drop the previous version of the BFS patches I sent
to the trivial patches yesterday. I am now sending a new
version, where part #5 has been redone addressing the
comments I received.
Please note that the driver maintainer (I'm Cc:in him now)
has approved the changes in a
Clean up errors found by checkpatch.pl.
Before the patch:
$ ./scripts/checkpatch.pl --file fs/bfs/dir.c | grep total
total: 7 errors, 1 warnings, 370 lines checked
After the patch:
$ ./scripts/checkpatch.pl --file fs/bfs/dir.c | grep total
total: 0 errors, 1 warnings, 370 lines checked
No
Incidentally, some context for the AIX approach to the OOM problem: a
process may exclude itself from OOM vulnerability altogether. It
places
itself in early allocation mode, which means at the time it creates
virtual memory, it reserves enough backing store for the worst case.
The
On Sat, Jan 26, 2008 at 04:35:26PM +1100, David Chinner wrote:
On Fri, Jan 25, 2008 at 07:59:38PM +0900, Takashi Sato wrote:
The points of the implementation are followings.
- Add calls of the freeze function (freeze_bdev) and
the unfreeze function (thaw_bdev) in ext3_ioctl().
-
On Fri, Jan 25, 2008 at 07:59:38PM +0900, Takashi Sato wrote:
The points of the implementation are followings.
- Add calls of the freeze function (freeze_bdev) and
the unfreeze function (thaw_bdev) in ext3_ioctl().
- ext3_freeze_timeout() which calls the unfreeze function (thaw_bdev)
is
Chris Snook wrote:
Al Boldi wrote:
Greetings!
data=ordered mode has proven reliable over the years, and it does this
by ordering filedata flushes before metadata flushes. But this
sometimes causes contention in the order of a 10x slowdown for certain
apps, either due to the misuse of
Diego Calleja wrote:
El Thu, 24 Jan 2008 23:36:00 +0300, Al Boldi [EMAIL PROTECTED] escribió:
Greetings!
data=ordered mode has proven reliable over the years, and it does this
by ordering filedata flushes before metadata flushes. But this
sometimes causes contention in the order of a
On Fri, Jan 25, 2008 at 09:42:30PM +0900, Takashi Sato wrote:
I am also wondering whether we should have system call(s) for these:
On Jan 25, 2008 12:59 PM, Takashi Sato [EMAIL PROTECTED] wrote:
+ case EXT3_IOC_FREEZE: {
+ case EXT3_IOC_THAW: {
And just convert XFS to use
In message [EMAIL PROTECTED], Al Viro writes:
After grep for locking-related things:
* lock_parent(): who said that you won't get dentry moved
before managing to grab i_mutex on parent? While we are at it,
who said that you won't get dentry moved between fetching d_parent
and doing
CC: Mike Halcrow [EMAIL PROTECTED]
Signed-off-by: Erez Zadok [EMAIL PROTECTED]
---
fs/unionfs/rename.c | 16 +++-
1 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/fs/unionfs/rename.c b/fs/unionfs/rename.c
index 9306a2b..5ab13f9 100644
--- a/fs/unionfs/rename.c
+++
Signed-off-by: Erez Zadok [EMAIL PROTECTED]
---
fs/unionfs/copyup.c |3 +--
fs/unionfs/union.h |4 ++--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/unionfs/copyup.c b/fs/unionfs/copyup.c
index 8663224..9beac01 100644
--- a/fs/unionfs/copyup.c
+++
Cleanup code in -create, -symlink, and -mknod: refactor common code into
helper functions. Also, this allows writing to multiple branches again,
which was broken by an earlier patch.
Signed-off-by: Erez Zadok [EMAIL PROTECTED]
---
fs/unionfs/inode.c | 395
[EMAIL PROTECTED] wrote:
On Thu, 24 Jan 2008 23:36:00 +0300, Al Boldi said:
This RFC proposes to introduce a tunable which allows to disable fsync
and changes ordered into writeback writeout on a per-process basis like
this:
:
:
But if you want to give them enough rope to shoot themselves
This old code was to fix a bug which has long since been fixed in our
copyup_permission and unionfs_d_iput.
Signed-off-by: Erez Zadok [EMAIL PROTECTED]
---
fs/unionfs/copyup.c | 13 -
1 files changed, 0 insertions(+), 13 deletions(-)
diff --git a/fs/unionfs/copyup.c
The following is a series of patchsets related to Unionfs. This is the
fifth set of patchsets resulting from an lkml review of the entire unionfs
code base, in preparation for a merge into mainline. The most significant
changes here are a few locking related fixes, and a correction to broken
Clean up errors found by checkpatch.pl.
Before the patch:
$ ./scripts/checkpatch.pl --file fs/bfs/bfs.h | grep total
total: 2 errors, 0 warnings, 57 lines checked
After the patch:
$ ./scripts/checkpatch.pl --file fs/bfs/bfs.h | grep total
total: 0 errors, 0 warnings, 57 lines checked
No
Clean up errors found by checkpatch.pl.
Before the patch:
$ ./scripts/checkpatch.pl --file fs/bfs/file.c | grep total
total: 6 errors, 0 warnings, 191 lines checked
After the patch:
$ ./scripts/checkpatch.pl --file fs/bfs/file.c | grep total
total: 0 errors, 0 warnings, 191 lines checked
No
The dump_imap() routine is defined in bs/bfs/inode.c and used both in
the same file and in fs/bfs/dir.c. This patch adds an extern function
declaration to the private bfs.h header file.
The effect is that one warning issued by checkpatch.pl is gone.
Before the patch:
$ ./scripts/checkpatch.pl
On Thu, 24 Jan 2008, Andreas Dilger wrote:
On Jan 24, 2008 23:36 +0300, Al Boldi wrote:
data=ordered mode has proven reliable over the years, and it does this by
ordering filedata flushes before metadata flushes. But this sometimes
causes contention in the order of a 10x slowdown for certain
On Jan 24, 2008 23:36 +0300, Al Boldi wrote:
data=ordered mode has proven reliable over the years, and it does this by
ordering filedata flushes before metadata flushes. But this sometimes
causes contention in the order of a 10x slowdown for certain apps, either
due to the misuse of fsync
On Jan 24, 2008 17:25 -0700, Zan Lynx wrote:
Have y'all been following the /dev/mem_notify patches?
http://article.gmane.org/gmane.linux.kernel/628653
Having the notification be via poll() is a very restrictive processing
model. Having the notification be via a signal means that any kind of
On Fri, Jan 25, 2008 at 10:34:25AM -0600, Eric Sandeen wrote:
But it was this concern which is why ext3 never exported freeze
functionality to userspace, even though other commercial filesystems
do support this. It wasn't that it wasn't considered, but the concern
about whether or not it
Theodore Tso wrote:
The other approach would be to say, oh well, the freeze ioctl is
inherently dangerous, and root is allowed to himself in the foot, so
who cares. :-)
I tend to agree. Either you need your fs frozen, or not, and if you do,
be prepared for the consequences.
But it was this
From: Miklos Szeredi [EMAIL PROTECTED]
Add a .show_options super operation to isofs.
Use generic_show_options() and save the complete option string in
isofs_fill_super().
Signed-off-by: Miklos Szeredi [EMAIL PROTECTED]
---
Index: linux/fs/isofs/inode.c
On Fri, Jan 25, 2008 at 03:18:51PM +0300, Dmitri Monakhov wrote:
First of all Linux already have at least one open-source(dm-snap),
and several commercial snapshot solutions.
Yes, but it requires that the filesystem be stored under LVM. Unlike
what EVMS v1 allowed us to do, we can't currently
On Fri, 25 Jan 2008, Bryan Henderson wrote:
AIX basically did this with SIGDANGER (the signal is ignored by
default), except there wasn't the ability for the process to tell the
kernel at what level of memory pressure before it should start getting
notified, and there was no way for the
Clean up errors found by checkpatch.pl.
Before the patch:
$ ./scripts/checkpatch.pl --file include/linux/bfs_fs.h | grep total
total: 5 errors, 3 warnings, 80 lines checked
After the patch:
$ ./scripts/checkpatch.pl --file include/linux/bfs_fs.h | grep total
total: 0 errors, 0 warnings, 83
In the bfs_fill_super() routine, the sblock variable is declared
and assigned a value. However, this value is never used. This trivial
patch removes this useless variable.
This was compile-tested by building the bfs driver both as a module
and as a part of the kernel proper. Both build finished
[Miklos Szeredi - Fri, Jan 25, 2008 at 10:29:21AM +0100]
| | + /* is this correct? */
| | + if (sbi-s_anchor[2] != 0)
| | + seq_printf(seq, ,anchor=%u, sbi-s_anchor[2]);
|
| you know, I would prefer to use form UDF_SB_ANCHOR(sb)[2]
| in sake of style unification but we should wait
AIX basically did this with SIGDANGER (the signal is ignored by
default), except there wasn't the ability for the process to tell the
kernel at what level of memory pressure before it should start getting
notified, and there was no way for the kernel to tell how bad the
memory pressure
On Thu, 2008-01-24 at 20:33 +0100, Miklos Szeredi wrote:
plain text document attachment (ext4_opts.patch)
From: Miklos Szeredi [EMAIL PROTECTED]
Add stripe= option to /proc/mounts for ext4 filesystems.
Signed-off-by: Miklos Szeredi [EMAIL PROTECTED]
---
Index: linux/fs/ext4/super.c
From: Miklos Szeredi [EMAIL PROTECTED]
Add noreservation option to /proc/mounts for ext2 filesystems.
Signed-off-by: Miklos Szeredi [EMAIL PROTECTED]
---
Index: linux/fs/ext2/super.c
===
--- linux.orig/fs/ext2/super.c
From: Miklos Szeredi [EMAIL PROTECTED]
Add stripe= option to /proc/mounts for ext4 filesystems.
Signed-off-by: Miklos Szeredi [EMAIL PROTECTED]
---
Index: linux/fs/ext4/super.c
===
--- linux.orig/fs/ext4/super.c
On Mon 14-01-08 13:14:54, Chris Mason wrote:
On Mon, 14 Jan 2008 18:06:09 +0100
Jan Kara [EMAIL PROTECTED] wrote:
On Wed 02-01-08 12:42:19, Zach Brown wrote:
Erez Zadok wrote:
Setting: ltp-full-20071031, dio01 test on ext3 with Linus's
latest tree. Kernel w/ SMP, preemption, and
On Fri 25-01-08 16:50:15, Miklos Szeredi wrote:
| + /* is this correct? */
| + if (sbi-s_anchor[2] != 0)
| + seq_printf(seq, ,anchor=%u, sbi-s_anchor[2]);
you know, I would prefer to use form UDF_SB_ANCHOR(sb)[2]
in sake of style unification but we
| + /* is this correct? */
| + if (sbi-s_anchor[2] != 0)
| + seq_printf(seq, ,anchor=%u, sbi-s_anchor[2]);
you know, I would prefer to use form UDF_SB_ANCHOR(sb)[2]
in sake of style unification but we should wait for Jan's
decision (i'm not the
From: Miklos Szeredi [EMAIL PROTECTED]
Add a .show_options super operation to udf.
Signed-off-by: Miklos Szeredi [EMAIL PROTECTED]
---
Index: linux/fs/udf/super.c
===
--- linux.orig/fs/udf/super.c 2008-01-24
| + /* is this correct? */
| + if (sbi-s_anchor[2] != 0)
| + seq_printf(seq, ,anchor=%u, sbi-s_anchor[2]);
you know, I would prefer to use form UDF_SB_ANCHOR(sb)[2]
in sake of style unification but we should wait for Jan's
decision (i'm not the expert in this area ;)
I
Greetings!
data=ordered mode has proven reliable over the years, and it does this by
ordering filedata flushes before metadata flushes. But this sometimes
causes contention in the order of a 10x slowdown for certain apps, either
due to the misuse of fsync or due to inherent behaviour
[Miklos Szeredi - Fri, Jan 25, 2008 at 04:50:15PM +0100]
|| + /* is this correct? */
|| + if (sbi-s_anchor[2] != 0)
|| + seq_printf(seq, ,anchor=%u, sbi-s_anchor[2]);
|
|you know, I would prefer to use form UDF_SB_ANCHOR(sb)[2]
|in sake of style
On Fri 25-01-08 16:50:15, Miklos Szeredi wrote:
| + /* is this correct? */
| + if (sbi-s_anchor[2] != 0)
| + seq_printf(seq, ,anchor=%u, sbi-s_anchor[2]);
you know, I would prefer to use form UDF_SB_ANCHOR(sb)[2]
in sake of style unification but we
On Jan 25, 2008, at 4:39 AM, Miklos Szeredi wrote:
Miklos Szeredi wrote:
From: Miklos Szeredi [EMAIL PROTECTED]
Add posix, bsize=, namelen= options to /proc/mounts for nfs
filesystems.
Document several other options that are still missing.
NFS lists only some options in /proc/mounts on
On Jan 24, 2008 20:33 +0100, Miklos Szeredi wrote:
Add stripe= option to /proc/mounts for ext4 filesystems.
Signed-off-by: Miklos Szeredi [EMAIL PROTECTED]
Acked-by: Andreas Dilger [EMAIL PROTECTED]
Index: linux/fs/ext4/super.c
The checkpatch.pl reported several warnings about multiple variable
assignments in the BFS driver sources. This trivial patch fixes these
warnings by giving each assignment its own line.
No functional changes introduced.
This patch was compile-tested by building the BFS driver both
as a module
The checkpatch.pl reported the following warning:
$ ./scripts/checkpatch.pl --strict --file fs/bfs/inode.c
CHECK: Use #include linux/uaccess.h instead of asm/uaccess.h
+#include asm/uaccess.h
This patch fixes this warning.
No functional changes introduced.
This patch was compile-tested by
This patch cleans up errors found by checkpatch.pl.
Before the patch:
$ ./scripts/checkpatch.pl --file fs/bfs/inode.c | grep total
total: 11 errors, 0 warnings, 445 lines checked
After the patch:
$ ./scripts/checkpatch.pl --file fs/bfs/inode.c | grep total
total: 0 errors, 0 warnings, 446
62 matches
Mail list logo
