Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Trond Myklebust
On Thu, 2008-02-14 at 09:30 +0100, Miklos Szeredi wrote: And this is where we usually conclude, that a new userspace mount API is long overdue. So for starters, how about a new syscall for bind mounts: int mount_bind(const char *src, const char *dst, unsigned flags,

Re: i_version changes

2008-02-14 Thread Peter Staubach
Jean noel Cordenner wrote: hi, Peter Staubach a écrit : Is the perceived performance hit really going to be as large as suspected? We already update the time fields fairly often and we don't pay a huge penalty for those, or at least not a penalty that we aren't willing to pay. Has anyone

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Paul Menage
On Thu, Feb 14, 2008 at 12:30 AM, Miklos Szeredi [EMAIL PROTECTED] wrote: For recursive bind mounts, only the root of the tree being bound inherits the per-mount flags from the mount() arguments; sub-mounts inherit their per-mount flags from the source tree as usual. This is rather

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Paul Menage
[ cc: linux-fsdevel ] On Thu, Feb 14, 2008 at 7:22 AM, Paul Menage [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 10:02 PM, Christoph Hellwig [EMAIL PROTECTED] wrote: I think this concept is reasonable, but I don't think MS_BIND_FLAGS is a descriptive name for this flag.

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Trond Myklebust
On Thu, 2008-02-14 at 17:03 +0100, Miklos Szeredi wrote: And I'm not against doing it with the at* variants, as Trond suggested. If you're going to change the syscall, then you should ensure that it solves _all_ the problems that are known at this time. Ignoring the automounter issue is just

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Miklos Szeredi
Maybe instead of messing with masks, it's better to introduce a get_flags() or a more general mount_stat() operation, and let userspace deal with setting and clearing flags, just as we do for stat/chmod? So we'd have mount_stat(path, stat); mount_bind(from, to, flags);

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Miklos Szeredi
And I'm not against doing it with the at* variants, as Trond suggested. If you're going to change the syscall, then you should ensure that it solves _all_ the problems that are known at this time. Ignoring the automounter issue is just going to force us to redo the syscall in a couple of

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Paul Menage
On Thu, Feb 14, 2008 at 9:31 AM, Miklos Szeredi [EMAIL PROTECTED] wrote: I deliberately not used the MS_* flags, which is currently a messy mix of things with totally different meanings. Does this solve all the issues? We should add a size parameter either in the mount_params or as a

[PATCH] Add linux-fsdevel to VFS entry in MAINTAINERS

2008-02-14 Thread Paul Menage
Add linux-fsdevel to the VFS entry in MAINTAINERS Signed-off-by: Paul Menage [EMAIL PROTECTED] --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) Index: 2.6.24-mm1-bindflags/MAINTAINERS === ---

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Trond Myklebust
On Thu, 2008-02-14 at 18:39 +0100, Miklos Szeredi wrote: And I'm not against doing it with the at* variants, as Trond suggested. If you're going to change the syscall, then you should ensure that it solves _all_ the problems that are known at this time. Ignoring the automounter

jffs2 console printk storm

2008-02-14 Thread Erez Zadok
Hi David, This has been a problem I've seen for a while. I've generated a jffs2 image of an empty directory (I don't recall the version of the jffs2 utils I've used to generate it). I mount the jffs2 image something like this: # cp jffs2-empty.img /tmp/fs.0 # losetup /dev/loop0 /tmp/fs.0 #

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Miklos Szeredi
On Thu, Feb 14, 2008 at 9:31 AM, Miklos Szeredi [EMAIL PROTECTED] wrote: I deliberately not used the MS_* flags, which is currently a messy mix of things with totally different meanings. Does this solve all the issues? We should add a size parameter either in the mount_params or

- embed-a-struct-path-into-struct-nameidata-instead-of-nd-dentrymnt-cifs-fix.patch removed from -mm tree

2008-02-14 Thread akpm
The patch titled embed-a-struct-path-into-struct-nameidata-instead-of-nd-dentrymnt-cifs-fix has been removed from the -mm tree. Its filename was embed-a-struct-path-into-struct-nameidata-instead-of-nd-dentrymnt-cifs-fix.patch This patch was dropped because it was folded into

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Trond Myklebust
On Thu, 2008-02-14 at 23:18 +0100, Miklos Szeredi wrote: I understand perfectly that this is what you want to do. And I'm saying that the following code snippet should do exactly the same, without having to add a new syscall: char tmpbuf[64]; sprintf(tmpbuf, /proc/self/fd/%i,

[patch 06/10] Introduce path_put()

2008-02-14 Thread akpm
From: Jan Blunck [EMAIL PROTECTED] * Add path_put() functions for releasing a reference to the dentry and vfsmount of a struct path in the right order * Switch from path_release(nd) to path_put(nd-path) * Rename dput_path() to path_put_conditional() [EMAIL PROTECTED]: fix cifs]

Re: [patch 00/10] mount ownership and unprivileged mount syscall (v8)

2008-02-14 Thread Andrew Morton
On Tue, 05 Feb 2008 22:36:16 +0100 Miklos Szeredi [EMAIL PROTECTED] wrote: Just documentation updates, compared to the previous submission. Thanks to Serge for the relentless reviews :) Please consider for -mm, and then for 2.6.26. Linus has just merged all the VFS renaming patches, so the

- introduce-path_put.patch removed from -mm tree

2008-02-14 Thread akpm
The patch titled Introduce path_put() has been removed from the -mm tree. Its filename was introduce-path_put.patch This patch was dropped because it was merged into mainline or a subsystem tree The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/