Re: 2.4.2: opening deleted directories

2001-03-18 Thread Chuck Lever
g to the POSIX standard's description of relative pathname lookup and rmdir, i'd say that, if the cwd is a deleted directory, open("..") should also fail . i haven't checked whether this is true or not. but we do know that ".." is handled similarly in path_walk -- no d_lookup or

[PATCH 0/2] RFC: exporting per-superblock statistics to user space

2005-03-17 Thread Chuck Lever
We still have a need to provide iostat like statistics for NFS clients. Following are a couple of patches, against 2.6.11.3, which prototype an approach for providing this kind of data to user programs. I'd like some comment on the approach. 01-mountstats.patch adds a new file called

[PATCH 1/2] VFS: New /proc file /proc/self/mountstats

2005-03-17 Thread Chuck Lever
to use while other processes are unmounting file systems. Version: Mon, 14 Mar 2005 17:06:04 -0500 Signed-off-by: Chuck Lever [EMAIL PROTECTED] --- fs/namespace.c | 66 + fs/proc/base.c | 40 +++ include/linux

[PATCH 2/2] NFS: add I/O performance counters

2005-03-17 Thread Chuck Lever
Add an extensible per-superblock performance counter facility to the NFS client. This facility mimics the counters available for block devices and for networking. Expose these new counters via /proc/self/mountstats. Version: Mon, 14 Mar 2005 17:06:12 -0500 Signed-off-by: Chuck Lever

[PATCH 13/13] NFS: Integrate support for processing nfs4 mount options in fs/nfs/super.c

2007-05-21 Thread Chuck Lever
Finally, hook in the new mount option parsing logic. Signed-off-by: Chuck Lever [EMAIL PROTECTED] --- fs/nfs/super.c | 87 1 files changed, 19 insertions(+), 68 deletions(-) diff --git a/fs/nfs/super.c b/fs/nfs/super.c index e0acd08

[PATCH 06/13] NFS: Improve debugging output in NFS in-kernel mount client

2007-05-21 Thread Chuck Lever
Signed-off-by: Chuck Lever [EMAIL PROTECTED] --- fs/nfs/mount_clnt.c| 18 +- include/linux/nfs_fs.h |1 + 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/fs/nfs/mount_clnt.c b/fs/nfs/mount_clnt.c index f8584ad..81ea782 100644 --- a/fs/nfs/mount_clnt.c

[PATCH 09/13] NFS: Implement NFSv2/3 in-kernel mount option parsing

2007-05-21 Thread Chuck Lever
Signed-off-by: Chuck Lever [EMAIL PROTECTED] --- fs/nfs/super.c | 130 +++- 1 files changed, 82 insertions(+), 48 deletions(-) diff --git a/fs/nfs/super.c b/fs/nfs/super.c index a9f698b..7b7cacb 100644 --- a/fs/nfs/super.c +++ b/fs/nfs

[PATCH 01/13] NFS: Refactor IP address sanity checks in NFS client

2007-05-21 Thread Chuck Lever
Provide mechanism for adding IPv6 address support at some later point. Signed-off-by: Chuck Lever [EMAIL PROTECTED] Cc: Aurelien Charbon [EMAIL PROTECTED] --- fs/nfs/super.c | 39 --- 1 files changed, 28 insertions(+), 11 deletions(-) diff --git a/fs/nfs

[PATCH 08/13] NFS: Add functions to parse nfs mount options to fs/nfs/super.c

2007-05-21 Thread Chuck Lever
For NFSv2 and NFSv3 mount options. Signed-off-by: Chuck Lever [EMAIL PROTECTED] --- fs/nfs/super.c | 449 1 files changed, 449 insertions(+), 0 deletions(-) diff --git a/fs/nfs/super.c b/fs/nfs/super.c index 1974648..a9f698b 100644

[PATCH 10/13] NFS: Add functions to parse nfs4 mount options to fs/nfs/super.c

2007-05-21 Thread Chuck Lever
Add helpers required for parsing nfs4 mount options in the NFS client. Signed-off-by: Chuck Lever [EMAIL PROTECTED] --- fs/nfs/super.c | 290 1 files changed, 290 insertions(+), 0 deletions(-) diff --git a/fs/nfs/super.c b/fs/nfs

[PATCH 04/13] NFS: Remake nfsroot_mount as a permanent part of NFS client

2007-05-21 Thread Chuck Lever
In preparation for supporting NFSv2 and NFSv3 mount option handling in the kernel NFS client, convert mount_clnt.c to be a permanent part of the NFS client, instead of built only when CONFIG_ROOT_NFS is enabled. Signed-off-by: Chuck Lever [EMAIL PROTECTED] --- fs/nfs/Makefile|4

[PATCH 05/13] NFS: Clean up in-kernel NFS mount

2007-05-21 Thread Chuck Lever
Clean up white space and coding conventions. Signed-off-by: Chuck Lever [EMAIL PROTECTED] --- fs/nfs/mount_clnt.c | 132 --- 1 files changed, 63 insertions(+), 69 deletions(-) diff --git a/fs/nfs/mount_clnt.c b/fs/nfs/mount_clnt.c index 82a8536

[PATCH 03/13] SUNRPC: Rename rpcb_getport to be consistent with new rpcb_getport_sync name

2007-05-21 Thread Chuck Lever
Clean up, for consistency. Rename rpcb_getport as rpcb_getport_async, to match the naming scheme of rpcb_getport_sync. Signed-off-by: Chuck Lever [EMAIL PROTECTED] --- include/linux/sunrpc/clnt.h |2 +- net/sunrpc/rpcb_clnt.c | 37 +++-- net/sunrpc

[PATCH 07/13] NFS: New infrastructure for NFS client in-kernel mount option parsing

2007-05-21 Thread Chuck Lever
Add some data structures and definitions to support parsing NFS mount options in the kernel NFS client. Signed-off-by: Chuck Lever [EMAIL PROTECTED] --- fs/nfs/super.c | 79 1 files changed, 79 insertions(+), 0 deletions(-) diff --git

[PATCH 00/13] Support NFS mount option parsing in the kernel

2007-05-21 Thread Chuck Lever
This patch series introduces support for parsing NFS mount options in the kernel, similar to support that exists for many other Linux file systems such as ext3, autofs, fat, cifs, hfs, and ocfs2. I'd like to integrate this patch set into -mm to encourage wide review and perhaps get some

[PATCH 12/13] NFS: More nfs4 in-kernel mount option parsing infrastructure

2007-05-21 Thread Chuck Lever
Add function for switching between an nfs4_mount_data structure from user space (the current nfs4 mount mechanism) and generating an nfs4_mount_data structure from a text string containing nfs4 mount options. Signed-off-by: Chuck Lever [EMAIL PROTECTED] --- fs/nfs/super.c | 123

[PATCH 02/13] SUNRPC: Rename rpcb_getport_external routine

2007-05-21 Thread Chuck Lever
In preparation for handling NFS mount option parsing in the kernel, rename rpcb_getport_external as rpcb_get_port_sync, and make it available always (instead of only when CONFIG_ROOT_NFS is enabled). Signed-off-by: Chuck Lever [EMAIL PROTECTED] --- fs/nfs/nfsroot.c|2 +- include

[PATCH 11/13] NFS: Move nfs_copy_user_string

2007-05-21 Thread Chuck Lever
Next patch will add a new function that calls nfs_copy_user_string. Signed-off-by: Chuck Lever [EMAIL PROTECTED] --- fs/nfs/super.c | 42 +- 1 files changed, 21 insertions(+), 21 deletions(-) diff --git a/fs/nfs/super.c b/fs/nfs/super.c index 927c1c2

Re: [PATCH 08/13] NFS: Add functions to parse nfs mount options to fs/nfs/super.c

2007-05-29 Thread Chuck Lever
Karel Zak wrote: On Mon, May 21, 2007 at 12:09:54PM -0400, Chuck Lever wrote: For NFSv2 and NFSv3 mount options. Signed-off-by: Chuck Lever [EMAIL PROTECTED] +static int nfs_parse_options(char *raw, struct nfs_mount_args *mnt) +{ + char *p, *string; + + if (!raw

Re: [ANNOUNCE] Btrfs: a copy on write, snapshotting FS

2007-06-14 Thread Chuck Lever
Hi Chris- John Stoffel wrote: As a user of Netapps, having quotas (if only for reporting purposes) and some way to migrate non-used files to slower/cheaper storage would be great. Ie. being able to setup two pools, one being RAID6, the other being RAID1, where all currently accessed files are

Re: [ANNOUNCE] Btrfs: a copy on write, snapshotting FS

2007-06-15 Thread Chuck Lever
Chris Mason wrote: On Thu, Jun 14, 2007 at 02:20:26PM -0400, Chuck Lever wrote: NetApp happens to use the standard NDMP protocol for sending the flattened file system. NetApp uses it for synchronous replication, volume migration, and back up to nearline storage and tape. AFS used vol dump

Re: Adding subroot information to /proc/mounts, or obtaining that through other means

2007-06-20 Thread Chuck Lever
Al Viro wrote: On Wed, Jun 20, 2007 at 01:57:33PM -0700, H. Peter Anvin wrote: ... or, alternatively, add a subfield to the first field (which would entail escaping whatever separator we choose): /dev/md6 /export ext3 rw,data=ordered 0 0 /dev/md6:/users/foo /home/foo ext3 rw,data=ordered 0 0

Re: Adding subroot information to /proc/mounts, or obtaining that through other means

2007-06-20 Thread Chuck Lever
H. Peter Anvin wrote: Chuck Lever wrote: To support NFS client performance statistics, I recently added /proc/self/mountstats. That might be a place to add details about --move and --bind mounts without changing the format of /proc/mounts. I just looked at /proc/self/mountstats; it seems

Re: Adding subroot information to /proc/mounts, or obtaining that through other means

2007-06-20 Thread Chuck Lever
H. Peter Anvin wrote: Chuck Lever wrote: The advantage is that it doesn't have strong user space dependencies on its format like /proc/mounts does. If you have NFS mount points, you will see that it includes a great deal of additional information about each mount. OK, I see now: device

Re: request for patches: showing mount options

2007-07-27 Thread Chuck Lever
Miklos: Some mount options are never passed to the kernel, and thus can't appear in /proc/mounts. Examples include user, users, and _netdev for NFS. Miklos Szeredi wrote: [please consider pruning the CC list if discussing some aspect, which doesn't concern all] I've done an audit of all

Re: request for patches: showing mount options

2007-07-27 Thread Chuck Lever
Miklos Szeredi wrote: Some mount options are never passed to the kernel, and thus can't appear in /proc/mounts. Examples include user, users, and _netdev for NFS. These options control *who* may mount and *when* to mount. They are not a property of the mount itself and are not added to

Re: Correct behavior on O_DIRECT sparse file writes

2007-10-15 Thread Chuck Lever
Florian Weimer wrote: * Andrew Morton: I don't think it's a bug. Sure, O_DIRECT is synchronous, but that's because it is, err, direct. Not because it provides extra data-integrity guarantees. If you want those guarantees, use O_SYNC as well. This needs to be prominently documented. Right

Re: Beagle and logging inotify events

2007-11-14 Thread Chuck Lever
unsubscribe linux- fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html -- Chuck Lever chuck[dot]lever[at]oracle[dot]com - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL

Re: Beagle and logging inotify events

2007-11-14 Thread Chuck Lever
Jon Smirl wrote: On 11/14/07, Chuck Lever [EMAIL PROTECTED] wrote: On Nov 13, 2007, at 7:04 PM, Jon Smirl wrote: Is it feasible to do something like this in the linux file system architecture? Beagle beats on my disk for an hour when I reboot. Of course I don't like that and I shut Beagle off

Re: Beagle and logging inotify events

2007-11-14 Thread Chuck Lever
Jon Smirl wrote: On 11/14/07, Chuck Lever [EMAIL PROTECTED] wrote: Jon Smirl wrote: On 11/14/07, Chuck Lever [EMAIL PROTECTED] wrote: On Nov 13, 2007, at 7:04 PM, Jon Smirl wrote: Is it feasible to do something like this in the linux file system architecture? Beagle beats on my disk

Re: [patch] VFS: extend /proc/mounts

2008-01-17 Thread Chuck Lever
it or uses it. It can go away for all I care, as long as we retain some flexible mechanism for non-block-based file systems to report I/O stats. As far as I am aware, there are only two user utilities that understand and parse this data, and I maintain both. -- Chuck Lever chuck[dot]lever

Re: [PATCH 0/3] enhanced ESTALE error handling

2008-01-18 Thread Chuck Lever
that is no longer working? -- Chuck Lever chuck[dot]lever[at]oracle[dot]com - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] enhanced ESTALE error handling

2008-01-18 Thread Chuck Lever
On Jan 18, 2008, at 11:55 AM, Peter Staubach wrote: Chuck Lever wrote: Hi Peter- On Jan 18, 2008, at 10:35 AM, Peter Staubach wrote: Hi. Here is a patch set which modifies the system to enhance the ESTALE error handling for system calls which take pathnames as arguments. The VFS already

Re: [PATCH 0/3] enhanced ESTALE error handling

2008-01-18 Thread Chuck Lever
On Jan 18, 2008, at 12:30 PM, Peter Staubach wrote: Chuck Lever wrote: On Jan 18, 2008, at 11:55 AM, Peter Staubach wrote: Chuck Lever wrote: Hi Peter- On Jan 18, 2008, at 10:35 AM, Peter Staubach wrote: Hi. Here is a patch set which modifies the system to enhance the ESTALE error handling

Re: [patch 21/26] mount options: partially fix nfs

2008-01-24 Thread Chuck Lever
Hi Miklos- Miklos Szeredi wrote: From: Miklos Szeredi [EMAIL PROTECTED] Add posix, bsize=, namelen= options to /proc/mounts for nfs filesystems. Document several other options that are still missing. NFS lists only some options in /proc/mounts on purpose: only the essential options are

Re: [PATCH 24/27] NFS: Use local caching [try #2]

2008-01-24 Thread Chuck Lever
Some comments below. This patch really ought to be broken into more manageable atomic changes to make it easier to review, and to provide more fine-grained explanation and rationalization for each specific change via individual patch descriptions. David Howells wrote: The attached patch

Re: [patch 21/26] mount options: partially fix nfs

2008-01-25 Thread Chuck Lever
mount with the copied options, you should get the same mount. For NFS, umount also needs to read some of the options in order to determine how mountd is to connect to the server for the unmount. (That's why we have addr= in the first place). -- Chuck Lever chuck[dot]lever[at]oracle[dot]com

Re: [patch 21/26] mount options: partially fix nfs

2008-01-28 Thread Chuck Lever
)); + + /* +* Missing options: +* port= +* mountport= +* mountvers= +* mountproto= +* clientaddr= +* mounthost= +* mountaddr= +*/ } /* -- Chuck Lever chuck[dot]lever[at]oracle[dot]com - To unsubscribe from this list

Re: [PATCH 24/27] NFS: Use local caching [try #2]

2008-01-30 Thread Chuck Lever
Hi David- On Jan 29, 2008, at 10:25 PM, David Howells wrote: Chuck Lever [EMAIL PROTECTED] wrote: This patch really ought to be broken into more manageable atomic changes to make it easier to review, and to provide more fine-grained explanation and rationalization for each specific change via