Re: [PATCH 2/4] isl29020: ambient light sensor

2010-04-15 Thread Jonathan Cameron
On 04/15/10 07:20, Daniel Mack wrote: On Wed, Apr 14, 2010 at 11:35:54PM +0100, Alan Cox wrote: Would it be possible to make the existing driver for the ISL29003 support the ISL29020 as well? I dug the manuals out for these to take a look - the answer is they are quite different chips.

Re: [PATCH 3/4] liss331d1: accelerometer driver

2010-04-15 Thread Éric Piel
On 15/04/10 01:05, Neil Brown wrote: : The Openmoko Freerunner has as lis302D which is an SPI version of a very similar device, so making the one driver work on that was well would be nice if possible. Definitely! The lis302d can detect threshold crossings and taps as well as simple

Re: [PATCH 3/4] liss331d1: accelerometer driver

2010-04-15 Thread Jonathan Cameron
On 04/14/10 23:12, Éric Piel wrote: Op 14-04-10 14:52, Alan Cox schreef: From: Kalhan Trisal kalhan.tri...@intel.com The acceleremeter driver reads the x,y,z coordinate registers and provides the information to user through the input layer Conversion to input device, clean up and porting of

Re: isl29020: ALS driver as misc device

2010-04-15 Thread Jonathan Cameron
On 04/14/10 18:01, Greg KH wrote: On Wed, Apr 14, 2010 at 05:56:02PM +0100, Alan Cox wrote: And this adds the isl29020 as a misc device per discussions isl29020: ambient light sensor From: Kalhan Trisal kalhan.tri...@intel.com The LS driver will read the latest Lux measurement based upon

[PATCH 0/1] BH1770GLC / SFH7770 combined ambient light / proximity sensor

2010-04-15 Thread Samu Onkalo
This patch introduces driver for Rohm BH1770GLC and Osram SFH7770 combined ambient light and proximity sensor. Driver is divided to 3 parts. Core-part contains common functionality for both parts of the chips. ALS and PS specific functionalities are in separate files. ALS part is fully based on

[PATCH 1/1] misc: bh1770glc: Driver for bh1770glc combined als and ps sensor

2010-04-15 Thread Samu Onkalo
Driver for combined ambient light and proximity sensor. BH1770GLC and SW compatible SFH7770 sensors are supported. Signed-off-by: Samu Onkalo samu.p.onk...@nokia.com --- drivers/misc/Kconfig | 12 + drivers/misc/Makefile |3 + drivers/misc/bh1770glc.h | 169

[PATCH v3] OMAP2/3: I2C: Errata ID i207: Clear wrong RDR interrupt

2010-04-15 Thread Manjunatha GK
Under certain rare conditions, I2C_STAT[13].RDR bit may be set and the corresponding interrupt fire, even there is no data in the receive FIFO, or the I2C data transfer is still ongoing. These spurious RDR events must be ignored by the software. This patch handles and ignores RDR spurious

Re: isl29020: ALS driver as misc device

2010-04-15 Thread Alan Cox
lux- illuminance0_input (or I guess lux0_input would also work, I can change the iio abi to match this as well). It also occurs to me that we might want to associate the calibration with the particular channel? There's sure to be a dual ALS chip along at some point. Obviously the

Re: [lm-sensors] [PATCH 0/1] BH1770GLC / SFH7770 combined ambient light / proximity sensor

2010-04-15 Thread Jean Delvare
On Thu, 15 Apr 2010 13:34:07 +0300, Samu Onkalo wrote: This patch introduces driver for Rohm BH1770GLC and Osram SFH7770 combined ambient light and proximity sensor. I fail to see why this is being sent to the lm-sensors list. -- Jean Delvare -- To unsubscribe from this list: send the line

Re: [PATCH 0/1] BH1770GLC / SFH7770 combined ambient light / proximity sensor

2010-04-15 Thread Jonathan Cameron
Hi Samu, This patch introduces driver for Rohm BH1770GLC and Osram SFH7770 combined ambient light and proximity sensor. Driver is divided to 3 parts. Core-part contains common functionality for both parts of the chips. ALS and PS specific functionalities are in separate files. ALS part

Re: [lm-sensors] [PATCH 0/1] BH1770GLC / SFH7770 combined ambient light / proximity sensor

2010-04-15 Thread Alan Cox
On Thu, 15 Apr 2010 13:26:43 +0200 Jean Delvare kh...@linux-fr.org wrote: On Thu, 15 Apr 2010 13:34:07 +0300, Samu Onkalo wrote: This patch introduces driver for Rohm BH1770GLC and Osram SFH7770 combined ambient light and proximity sensor. I fail to see why this is being sent to the

Re: [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass

2010-04-15 Thread Alan Cox
Argument alignment Makes it take more space Spacing Mostly dropped Make chars static Not sure I see the point (compiler generates good code anyway) Remove prefixes from dev_level logging Good point. -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a

Re: [PATCH v3] OMAP2/3: I2C: Errata ID i207: Clear wrong RDR interrupt

2010-04-15 Thread Aaro Koskinen
Hi, Manjunatha GK wrote: Under certain rare conditions, I2C_STAT[13].RDR bit may be set and the corresponding interrupt fire, even there is no data in the receive FIFO, or the I2C data transfer is still ongoing. These spurious RDR events must be ignored by the software. This patch handles

Re: [PATCH 1/2] i2c: Multiplexed I2C bus core support.

2010-04-15 Thread Jean Delvare
Hi Michael, Sorry for the long delay. Here finally comes a review of your code. On Mon, 25 Jan 2010 13:13:48 +0100, Michael Lawnick wrote: Subject: [PATCH 1/2] i2c: Multiplexed I2C bus core support. Signed-off-by: Rodolfo Giometti giome...@linux.it Signed-off-by: Michael Lawnick

Re: your mail

2010-04-15 Thread Rafi Rubin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 +if (ts-tc.event_sended == false) { We set event_sended to false immediately before calling cy8ctmg110_send_event() so I do not see the point of this flag. On that note: $ git grep -n sended drivers/net/eth16i.c:1295: how

Re: your mail

2010-04-15 Thread Dmitry Torokhov
On Thu, Apr 15, 2010 at 07:41:22PM -0400, Rafi Rubin wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 + if (ts-tc.event_sended == false) { We set event_sended to false immediately before calling cy8ctmg110_send_event() so I do not see the point of this flag. On that note: $