Re: [PATCH 07/13] i2c: pnx: Use devm_*() functions

2013-12-17 Thread Roland Stigge
On 12/17/2013 07:55 AM, Jingoo Han wrote: Use devm_*() functions to make cleanup paths simpler. Signed-off-by: Jingoo Han jg1@samsung.com --- drivers/i2c/busses/i2c-pnx.c | 56 +- 1 file changed, 17 insertions(+), 39 deletions(-) diff

Re: [PATCH] dt: Update I2C trivial devices list

2013-12-17 Thread Stephen Warren
On 12/16/2013 05:12 PM, Ben Gamari wrote: diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt This is a list of trivial i2c devices that have simple device tree bindings, consisting only of a compatible field,

[PATCH] i2c: at91: document clock properties

2013-12-17 Thread Boris BREZILLON
Document the clock properties required by the at91 i2c bus driver. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com --- Documentation/devicetree/bindings/i2c/i2c-at91.txt |2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/i2c-at91.txt

Re: [PATCH] dt: Update I2C trivial devices list

2013-12-17 Thread Ben Gamari
Stephen Warren swar...@wwwdotorg.org writes: On 12/16/2013 05:12 PM, Ben Gamari wrote: diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt This is a list of trivial i2c devices that have simple device tree

Re: [lm-sensors] I2C support for AMD Hudson-1

2013-12-17 Thread Guenter Roeck
On Tue, Dec 17, 2013 at 07:32:26AM +0100, Christian Herzog wrote: Dear list, I'm currently beta testing a pretty cool embedded board for router applications etc. (http://www.pcengines.ch/apu.htm) that sports a Hudson-1 FCH which is pretty similar to the Hudson-2 your module supports but

Re: [lm-sensors] I2C support for AMD Hudson-1

2013-12-17 Thread Jean Delvare
On Tue, 17 Dec 2013 19:10:53 +0100, Wolfram Sang wrote: I'm currently beta testing a pretty cool embedded board for router applications etc. (http://www.pcengines.ch/apu.htm) that sports a Hudson-1 FCH which is pretty similar to the Hudson-2 your module supports but sufficiently

[RESEND PATCH v1 2/2] i2c: Add bus driver for for OSIF USB i2c device.

2013-12-17 Thread Andrew Lunn
OSIF, Open Source InterFace, is a USB based i2c bus master. The origional design was based on i2c-tiny-usb, but more modern versions of the firmware running on the MegaAVR microcontroller use a different protocol over the USB. This code is based on Barry Carter barry.car...@gmail.com driver.

[RESEND PATCH v1 1/2] i2c: i2c-tiny-usb: Remove RobotFuzz USB vendor:product ID

2013-12-17 Thread Andrew Lunn
The RobotFuzz device is not compatible with i2c-tiny-usb. Remove its entry from the USB table so that the new correct driver can be used. Signed-off-by: Andrew Lunn and...@lunn.ch CC: Emmanuel Deloget log...@free.fr CC: Barry Carter barry.car...@gmail.com --- drivers/i2c/busses/i2c-tiny-usb.c |

[PATCH 1/5] pinctrl: r7s72100: add riic groups

2013-12-17 Thread Wolfram Sang
From: Wolfram Sang w...@sang-engineering.com Tested RIIC2 on a genmai board. Other riic groups are untested but seem trivial enough to be added. Signed-off-by: Wolfram Sang w...@sang-engineering.com Acked-by: Magnus Damm d...@opensource.se --- Note: With the current PFC driver as posted by

[PATCH 0/5] arm: shmobile: r7s72100: add native i2c support

2013-12-17 Thread Wolfram Sang
Here is a series to support the I2C core of the r7s72100 natively. It has been tested with a genmai board where an eeprom is connected. The series can be found here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/riic It is based on the latest r7s72100 topic branch from

[PATCH 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-17 Thread Wolfram Sang
From: Wolfram Sang w...@sang-engineering.com Tested with RIIC2 on a genmai board. Others untested but hopefully trivial enough to be added. Signed-off-by: Wolfram Sang w...@sang-engineering.com Acked-by: Magnus Damm d...@opensource.se --- arch/arm/mach-shmobile/clock-r7s72100.c | 12

[PATCH 3/5] arm: shmobile: r7s72100: add nodes for i2c controllers to dtsi

2013-12-17 Thread Wolfram Sang
From: Wolfram Sang w...@sang-engineering.com I decided to put the pinmuxing into the dtsi file since there is only one pinmux posiibility which one probably wants to have when using the bus. Signed-off-by: Wolfram Sang w...@sang-engineering.com Acked-by: Magnus Damm d...@opensource.se ---

[PATCH 4/5] arm: shmobile: genmai: adapt dts to use native i2c driver

2013-12-17 Thread Wolfram Sang
From: Wolfram Sang w...@sang-engineering.com Switch from the gpio-driver to the shiny new native driver. Tested by accessing the eeprom on the genmai board. Signed-off-by: Wolfram Sang w...@sang-engineering.com Acked-by: Magnus Damm d...@opensource.se ---

[PATCH 5/5] i2c: riic: add driver

2013-12-17 Thread Wolfram Sang
From: Wolfram Sang w...@sang-engineering.com Tested with a r7s72100 genmai board acessing an eeprom. Signed-off-by: Wolfram Sang w...@sang-engineering.com --- Documentation/devicetree/bindings/i2c/i2c-riic.txt | 29 ++ drivers/i2c/busses/Kconfig | 10 +

Re: [PATCH 1/5] pinctrl: r7s72100: add riic groups

2013-12-17 Thread Wolfram Sang
On Tue, Dec 17, 2013 at 10:44:34PM +0100, Wolfram Sang wrote: From: Wolfram Sang w...@sang-engineering.com Tested RIIC2 on a genmai board. Other riic groups are untested but seem trivial enough to be added. Signed-off-by: Wolfram Sang w...@sang-engineering.com Acked-by: Magnus Damm

Re: [PATCH 1/5] pinctrl: r7s72100: add riic groups

2013-12-17 Thread Laurent Pinchart
Hi Wolfram, Thank you for the patch. On Tuesday 17 December 2013 22:44:34 Wolfram Sang wrote: From: Wolfram Sang w...@sang-engineering.com Tested RIIC2 on a genmai board. Other riic groups are untested but seem trivial enough to be added. Signed-off-by: Wolfram Sang

Re: [PATCH 3/5] arm: shmobile: r7s72100: add nodes for i2c controllers to dtsi

2013-12-17 Thread Laurent Pinchart
Hi Wolfram, Thank you for the patch. On Tuesday 17 December 2013 22:44:36 Wolfram Sang wrote: From: Wolfram Sang w...@sang-engineering.com I decided to put the pinmuxing into the dtsi file since there is only one pinmux posiibility which one probably wants to have when using the bus.

Re: [PATCH 4/5] arm: shmobile: genmai: adapt dts to use native i2c driver

2013-12-17 Thread Laurent Pinchart
Hi Wolfram, Thank you for the patch. On Tuesday 17 December 2013 22:44:37 Wolfram Sang wrote: From: Wolfram Sang w...@sang-engineering.com Switch from the gpio-driver to the shiny new native driver. Tested by accessing the eeprom on the genmai board. Signed-off-by: Wolfram Sang

Re: [PATCH 3/5] arm: shmobile: r7s72100: add nodes for i2c controllers to dtsi

2013-12-17 Thread Wolfram Sang
Hi, On Tue, Dec 17, 2013 at 10:55:31PM +0100, Laurent Pinchart wrote: Hi Wolfram, Thank you for the patch. On Tuesday 17 December 2013 22:44:36 Wolfram Sang wrote: From: Wolfram Sang w...@sang-engineering.com I decided to put the pinmuxing into the dtsi file since there is only

Re: [PATCH 3/5] arm: shmobile: r7s72100: add nodes for i2c controllers to dtsi

2013-12-17 Thread Laurent Pinchart
Hi Wolfram, On Tuesday 17 December 2013 23:13:09 Wolfram Sang wrote: On Tue, Dec 17, 2013 at 10:55:31PM +0100, Laurent Pinchart wrote: On Tuesday 17 December 2013 22:44:36 Wolfram Sang wrote: From: Wolfram Sang w...@sang-engineering.com I decided to put the pinmuxing into the dtsi

[PATCH] i2c: fix a potential kmemleak of adapter device

2013-12-17 Thread Gu Zheng
When running with the latest kernel, we get the following kmemleak message: unreferenced object 0x8800c2a36100 (size 256): comm modprobe, pid 629, jiffies 4294676002 (age 1531.115s) hex dump (first 32 bytes): 00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00 .N.. ff ff

Re: [PATCH 04/13] i2c: isch: Use devm_request_region()

2013-12-17 Thread Jingoo Han
On Tuesday, December 17, 2013 4:53 PM, Jean Delvare wrote: On Tue, 17 Dec 2013 15:51:28 +0900, Jingoo Han wrote: Use devm_request_region() to make cleanup paths simpler. You need to include linux/ioport.h for this function. According to the i2c tree, linux/ioport.h is already included. :-)

[PATCH V2 04/13] i2c: isch: Use devm_request_region()

2013-12-17 Thread Jingoo Han
Use devm_request_region() to make cleanup paths simpler. Signed-off-by: Jingoo Han jg1@samsung.com --- Changes since V1: - Remove unnecessary 'res' variable from smbus_sch_remove(). drivers/i2c/busses/i2c-isch.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 01/13] i2c: bcm2835: Use devm_request_irq()

2013-12-17 Thread Stephen Warren
On 12/16/2013 11:46 PM, Jingoo Han wrote: Use devm_request_irq() to make cleanup paths simpler. This may not be safe. The interrupt used by the I2C controllers on the BCM2835 chip is shared between two controllers. In theory, you could run into a condition where you're remove()ing the driver for

Re: [PATCH 01/13] i2c: bcm2835: Use devm_request_irq()

2013-12-17 Thread Jingoo Han
On Wednesday, December 18, 2013 11:21 AM, Stephen Warren wrote: On 12/16/2013 11:46 PM, Jingoo Han wrote: Use devm_request_irq() to make cleanup paths simpler. This may not be safe. The interrupt used by the I2C controllers on the BCM2835 chip is shared between two controllers. In theory,

Re: [PATCH V2 04/13] i2c: isch: Use devm_request_region()

2013-12-17 Thread Jean Delvare
On Wed, 18 Dec 2013 10:48:07 +0900, Jingoo Han wrote: Use devm_request_region() to make cleanup paths simpler. Signed-off-by: Jingoo Han jg1@samsung.com --- Changes since V1: - Remove unnecessary 'res' variable from smbus_sch_remove(). drivers/i2c/busses/i2c-isch.c |7 ++-