Re: [PATCH v3 1/4] i2c: mux-pinctrl: Rework to honor disabled child nodes

2015-03-19 Thread Wolfram Sang
Possible. But this change just makes i2c-mux-pinctrl honor status property at all. There is no functional change except it now allows you to disable any of the sub-busses. Actually, this is the feature I like. However, I wonder if we shouldn't have that in the core, say in

Re: [PATCH 2/2] i2c: driver for the Conexant Digicolor I2C controller

2015-03-19 Thread Baruch Siach
Hi Wolfram, On Wed, Mar 18, 2015 at 10:07:30PM +0100, Wolfram Sang wrote: On Mon, Feb 16, 2015 at 03:20:04PM +0200, Baruch Siach wrote: This commit adds a driver for the I2C master controller on the CX92755 SoC. The CX92755 is one SoC in the Conexant Digicolor series. This driver should

Re: [PATCH] eeprom: at24: Add support for large EEPROMs connected to SMBus adapters

2015-03-19 Thread Wolfram Sang
I don't call that multi-master, though, so I guess we may have a bit of a terminology problem. This is definately not a multi-master issue, I agree. It is just another issue I saw when thinking about your patch thoroughly again. I'll see what I can come up with, but I am not sure if I'll

[PATCH v2 2/2] i2c: driver for the Conexant Digicolor I2C controller

2015-03-19 Thread Baruch Siach
Signed-off-by: Baruch Siach bar...@tkos.co.il --- v2: * Address the comment of Wolfram Sang: - Advertise the I2C_FUNC_NOSTART capability - Rebase on v4.0-rc1 --- drivers/i2c/busses/Kconfig | 9 + drivers/i2c/busses/Makefile| 1 + drivers/i2c/busses/i2c-digicolor.c |

[PATCH v2 1/2] i2c: dt binding documentation for the Digicolor I2C controller

2015-03-19 Thread Baruch Siach
The CX92755 is an SoC in the Conexant Digicolor series. This devicetree binding document describes the I2C controller on the CX92755 SoC, that is also shared by some other SoCs in the Digicolor series. Signed-off-by: Baruch Siach bar...@tkos.co.il --- v2: no change ---

[PATCH v3 2/2] i2c: driver for the Conexant Digicolor I2C controller

2015-03-19 Thread Baruch Siach
Signed-off-by: Baruch Siach bar...@tkos.co.il --- v3: * Fix checkpatch.pl errors v2: * Address the comment of Wolfram Sang: - Advertise the I2C_FUNC_NOSTART capability - Rebase on v4.0-rc1 --- drivers/i2c/busses/Kconfig | 9 + drivers/i2c/busses/Makefile| 1 +

[PATCH v3 1/2] i2c: dt binding documentation for the Digicolor I2C controller

2015-03-19 Thread Baruch Siach
The CX92755 is an SoC in the Conexant Digicolor series. This devicetree binding document describes the I2C controller on the CX92755 SoC, that is also shared by some other SoCs in the Digicolor series. Signed-off-by: Baruch Siach bar...@tkos.co.il --- v3: No change v2: No change ---

Re: [PATCH v2 2/2] i2c: driver for the Conexant Digicolor I2C controller

2015-03-19 Thread Wolfram Sang
On Thu, Mar 19, 2015 at 11:54:18AM +0200, Baruch Siach wrote: Signed-off-by: Baruch Siach bar...@tkos.co.il --- v2: * Address the comment of Wolfram Sang: - Advertise the I2C_FUNC_NOSTART capability - Rebase on v4.0-rc1 Please fix: Applying: i2c: driver for the Conexant

Re: [PATCH v3 1/4] i2c: mux-pinctrl: Rework to honor disabled child nodes

2015-03-19 Thread Wolfram Sang
I am still not too eager working on it but if you insist, I can see what I can do as long as Stephen sticks with testing it on Tegra. ;) Please decide if you want to work on it. Remember, I am not short of patches to deal with. Maybe sounds more harsh than it was meant. I just want to

Re: [PATCH v2 2/2] i2c: driver for the Conexant Digicolor I2C controller

2015-03-19 Thread Baruch Siach
Hi Wolfram, On Thu, Mar 19, 2015 at 12:00:02PM +0100, Wolfram Sang wrote: On Thu, Mar 19, 2015 at 11:54:18AM +0200, Baruch Siach wrote: Signed-off-by: Baruch Siach bar...@tkos.co.il --- v2: * Address the comment of Wolfram Sang: - Advertise the I2C_FUNC_NOSTART capability

Re: [PATCH] eeprom: at24: Add support for large EEPROMs connected to SMBus adapters

2015-03-19 Thread Guenter Roeck
On 03/19/2015 01:16 AM, Wolfram Sang wrote: I don't call that multi-master, though, so I guess we may have a bit of a terminology problem. This is definately not a multi-master issue, I agree. It is just another issue I saw when thinking about your patch thoroughly again. I'll see what I

Re: [PATCH] eeprom: at24: Add support for large EEPROMs connected to SMBus adapters

2015-03-19 Thread Guenter Roeck
On Thu, Mar 19, 2015 at 09:16:21AM +0100, Wolfram Sang wrote: I don't call that multi-master, though, so I guess we may have a bit of a terminology problem. This is definately not a multi-master issue, I agree. It is just another issue I saw when thinking about your patch thoroughly

Re: [PATCH v3 1/4] i2c: mux-pinctrl: Rework to honor disabled child nodes

2015-03-19 Thread Sebastian Hesselbarth
On 19.03.2015 17:02, Wolfram Sang wrote: Perhaps better would be to have a mux-specific function to iterate over a mux's child nodes and instantiate buses for those. That function would check whether each bus node was disabled or not. That'd isolate the special case into the place where it was

Re: [PATCH 1/3] i2c: slave: rework the slave API

2015-03-19 Thread Uwe Kleine-König
Hello Wolfram, On Thu, Mar 12, 2015 at 01:42:01PM +0100, Wolfram Sang wrote: From: Wolfram Sang wsa+rene...@sang-engineering.com After more discussion, brave users, and additional datasheet evaluation, some API updates for the new I2C slave framework became imminent. The slave events now

Re: [PATCH] eeprom: at24: Add support for large EEPROMs connected to SMBus adapters

2015-03-19 Thread Wolfram Sang
Turns out this is really easy to reproduce. One process reads the eeprom over and over again, another runs i2cdump in a loop, and voila ... lots of corruptions. Scary, especially considering how wide-spread this kind of i2c access is in the kernel. A coccinelle script should at least be able

Re: [PATCH v3 1/4] i2c: mux-pinctrl: Rework to honor disabled child nodes

2015-03-19 Thread Wolfram Sang
-/* Only register child devices if the adapter has a node pointer set */ -if (!adap-dev.of_node) +/* Only register childs if adapter has a node pointer with enabled status */ +if (!adap-dev.of_node || !of_device_is_available(adap-dev.of_node)) return; That

Re: [PATCH v3 2/2] i2c: driver for the Conexant Digicolor I2C controller

2015-03-19 Thread Wolfram Sang
On Thu, Mar 19, 2015 at 01:16:47PM +0200, Baruch Siach wrote: Signed-off-by: Baruch Siach bar...@tkos.co.il I fixed two remaining 'check' issues with spaces around operators. Applied to for-next, thanks! signature.asc Description: Digital signature

Re: [PATCH v3 1/2] i2c: dt binding documentation for the Digicolor I2C controller

2015-03-19 Thread Wolfram Sang
On Thu, Mar 19, 2015 at 01:16:46PM +0200, Baruch Siach wrote: The CX92755 is an SoC in the Conexant Digicolor series. This devicetree binding document describes the I2C controller on the CX92755 SoC, that is also shared by some other SoCs in the Digicolor series. Signed-off-by: Baruch

Re: [PATCH v3 1/4] i2c: mux-pinctrl: Rework to honor disabled child nodes

2015-03-19 Thread Stephen Warren
On 03/19/2015 04:09 AM, Wolfram Sang wrote: Possible. But this change just makes i2c-mux-pinctrl honor status property at all. There is no functional change except it now allows you to disable any of the sub-busses. Actually, this is the feature I like. However, I wonder if we shouldn't have

Re: [PATCH v3 1/4] i2c: mux-pinctrl: Rework to honor disabled child nodes

2015-03-19 Thread Stephen Warren
On 03/19/2015 10:02 AM, Wolfram Sang wrote: - /* Only register child devices if the adapter has a node pointer set */ - if (!adap-dev.of_node) + /* Only register childs if adapter has a node pointer with enabled status */ + if (!adap-dev.of_node ||