Re: [PATCH 00/12] lis3 accelerator feature update

2010-10-24 Thread Éric Piel
Op 22-10-10 13:57, Samu Onkalo schreef: Changes are tested only with I2C interface using 8bit sensor since I don't have other possibilities. Some features are not enabled by default since I can't test them with all possible configurations. Platform data contains field which controls new

Re: [PATCH 01/12] hwmon: lis3: pm_runtime support

2010-10-24 Thread Éric Piel
Op 22-10-10 13:57, Samu Onkalo schreef: Add pm_runtime support to lis3 core driver. Add pm_runtime support to lis3 i2c driver. spi and hp_accel drivers are not yet supported. Old always on functionality remains for those. For sysfs there is 5 second delay before turning off the chip to avoid

Re: [PATCH 04/12] hwmon: lis3: Update coordinates at polled device open

2010-10-24 Thread Éric Piel
Op 22-10-10 13:57, Samu Onkalo schreef: Call input device poll function at device open to refresh coordinates immediately. This is needed for the case where poll interval is set to zero and coordinate updates happens purely under interrupt control. Signed-off-by: Samu

Re: [PATCH 03/12] hwmon: lis3: Cleanup interrupt handling

2010-10-24 Thread Éric Piel
Op 22-10-10 13:57, Samu Onkalo schreef: Irqcfg moved to chip data instead of platform data. This simplifies access in interrupt handler little bit. Input device open and close functions set status for interrupt threaded handler once. Unnecessary check for interrupt source removed since it is

Re: [PATCH 06/12] hwmon: lis3: restore axis enabled bits

2010-10-24 Thread Éric Piel
Op 22-10-10 13:57, Samu Onkalo schreef: All axis enable bits are set to 0 at module remove. Restore reset default value at init. Signed-off-by: Samu Onkalosamu.p.onk...@nokia.com Acked-by: Eric Piel eric.p...@tremplin-utc.net --- drivers/hwmon/lis3lv02d_i2c.c |2 +-

Re: [PATCH 07/12] hwmon: lis3: New parameters to platform data

2010-10-24 Thread Éric Piel
Op 22-10-10 13:57, Samu Onkalo schreef: Added default output data rate setting to platform data. If default rate is 0, reset default value is used. Added control for duration via platform data. Added possibility to configure interrupts to trig on both rising and falling edge. The lis3 WU unit

Re: [PATCH 08/12] hwmon: lis3: Adjust fuzziness for 8 bit device

2010-10-24 Thread Éric Piel
Op 22-10-10 13:57, Samu Onkalo schreef: Default fuziness is set smaller for 8 device. In 12 bit device LSB is quite close to 1 mg (mg = 1 / 1000 of earth gravity). In 8bit device LSB is about 18 mg. Set fuziness to 1 for 8 bit device. Signed-off-by: Samu Onkalosamu.p.onk...@nokia.com Acked-by:

Re: [PATCH 09/12] hwmon: lis3: use block read to access data registers

2010-10-24 Thread Éric Piel
Op 22-10-10 13:57, Samu Onkalo schreef: Add optional blockread function to interface driver. If available the chip driver uses it for data register access. For 12 bit device it reads 6 bytes to get 3*16bit data. For 8 bit device it reads out 5 bytes since every second byte is dummy. This

Re: [PATCH 10/12] hwmon: lis3: Enhance lis3 selftest with IRQ line test

2010-10-24 Thread Éric Piel
Op 22-10-10 13:57, Samu Onkalo schreef: Configure chip to data ready mode in selftest and count received interrupts to see that interrupt line(s) are working. Signed-off-by: Samu Onkalosamu.p.onk...@nokia.com Acked-by: Eric Piel eric.p...@tremplin-utc.net --- drivers/hwmon/lis3lv02d.c |

Re: [PATCHv2] hwmon: lis3: Short explanations of platform data fields

2010-10-24 Thread Éric Piel
Op 23-10-10 15:39, Samu Onkalo schreef: Short documentation at kernel doc format. Signed-off-by: Samu Onkalosamu.p.onk...@nokia.com Acked-by: Eric Piel eric.p...@tremplin-utc.net --- include/linux/lis3lv02d.h | 46 + 1 files changed, 46

Re: [PATCH 12/12] hwmon: lis3: Release resources is case of failure

2010-10-24 Thread Éric Piel
Op 22-10-10 13:57, Samu Onkalo schreef: If lis3lv02d_init_device fails, HW resources were not released properly. In case of failure call release_resources if available. Signed-off-by: Samu Onkalosamu.p.onk...@nokia.com Acked-by: Eric Piel eric.p...@tremplin-utc.net ---

Re: [PATCH 02/12] hwmon: lis3: regulator control

2010-10-24 Thread Éric Piel
Op 22-10-10 13:57, Samu Onkalo schreef: Based on pm_runtime control, turn lis3 regulators on and off. Perform context save and restore on transitions. Feature is optional and must be enabled in platform data. Signed-off-by: Samu Onkalosamu.p.onk...@nokia.com I have very little knowledge about

Re: [PATCH 05/12] hwmon: lis3: Power on corrections

2010-10-24 Thread Éric Piel
Op 22-10-10 13:57, Samu Onkalo schreef: Sometimes lis3 chip seems to fail to setup factory tuning at boot up. This probably happens if there is some odd power ramp down ramp up sequence for example in device restart. Set boot bit in control2 register to trig boot sequence manually and wait until

Re: [PATCH 00/12] lis3 accelerator feature update

2010-10-22 Thread Éric Piel
Op 22-10-10 22:08, Guenter Roeck schreef: On Fri, 2010-10-22 at 07:57 -0400, Samu Onkalo wrote: Changes are tested only with I2C interface using 8bit sensor since I don't have other possibilities. Some features are not enabled by default since I can't test them with all possible

Re: [PATCH 3/4] liss331d1: accelerometer driver

2010-04-15 Thread Éric Piel
On 15/04/10 01:05, Neil Brown wrote: : The Openmoko Freerunner has as lis302D which is an SPI version of a very similar device, so making the one driver work on that was well would be nice if possible. Definitely! The lis302d can detect threshold crossings and taps as well as simple

Re: [PATCH 3/4] liss331d1: accelerometer driver

2010-04-14 Thread Éric Piel
Op 14-04-10 14:52, Alan Cox schreef: From: Kalhan Trisal kalhan.tri...@intel.com The acceleremeter driver reads the x,y,z coordinate registers and provides the information to user through the input layer Conversion to input device, clean up and porting of retry fixes needed for AAVA done