Attached patch removes the obsolete means to specify the value mask from i2cset.
It also streamlines and improves parameter validation.
--
Index: tools/i2cset.c
===
--- tools/i2cset.c (revision 5911)
+++ tools/i2cset.c
Hi Jean,
On Sat, Jan 29, 2011 at 11:43:54AM -0500, Jean Delvare wrote:
[ ...]
Other than that, it looks alright, feel free to commit (I've just added
you to the list of committers - same credentials as lm-sensors
repository.)
Thanks, and done.
Next, I think we can remove the old method
This patch adds support to write block data to i2cset.
I tried to limit the changes as much as possible. Detecting new write modes
is a bit tricky since the command supports an undocumented parameter (mask)
after the mode. So I decided to handle block data first and bypass the rest
of the
Add support to write SMBus and I2C block data to i2cset.
Rev 2: Included review feedback
--
Index: tools/i2cset.8
===
--- tools/i2cset.8 (revision 5909)
+++ tools/i2cset.8 (working copy)
@@ -12,6 +12,7 @@
.I chip-address
Guenter Roeck guenter.roeck@... writes:
EREMOTEIO is not a valid error return code for I2C drivers. Replace with error
codes per Documentation/i2c/fault-codes.
Signed-off-by: Guenter Roeck guenter.roeck@...
---
ping ... any interest ?
--
To unsubscribe from this list: send the line
This patch adds support for the Diolan U2C-12 USB-I2C adapter.
It also updates MAINTAINERS to list the author as maintainer.
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
v4 changes:
- Moved buffer to beginning of device data structure to improve cache alignment
- Increased maximum
On Tue, Jan 25, 2011 at 11:21:06AM -0500, Guenter Roeck wrote:
Hi,
I need the capability to write a SMBus block command with i2ctools.
Not an issue writing it myself. Question is if to expand i2cset to include
that capability, or to write a new command (i2csetblock ?) to do it.
Thoughts
On Tue, Jan 25, 2011 at 11:49:22AM -0500, Jean Delvare wrote:
Hi Guenter,
On Tue, 25 Jan 2011 08:21:06 -0800, Guenter Roeck wrote:
I need the capability to write a SMBus block command with i2ctools.
Not an issue writing it myself. Question is if to expand i2cset to include
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
v3:
- Round frequency configuration down (instead of rounding to closest value)
- Simplify diolan_usb_transfer() a bit
- Introduce diolan_write_cmd() to check if a write is needed and execute it if
so.
- diolan_fw_version
EREMOTEIO is not a valid error return code for I2C drivers. Replace with error
codes per Documentation/i2c/fault-codes.
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
drivers/i2c/algos/i2c-algo-bit.c| 14 +++---
drivers/i2c/algos/i2c-algo-pca.c|2 +-
drivers
v2 changes:
- Moved receive and transmit buffers to allocated driver memory
- diolan_usb_transfer() no longer requires buffer and length arguments
- Pass struct i2c_diolan_u2c * instead of struct i2c_adapter * to many of
the internal usb access functions.
- Introduced diolan_usb_cmd(),
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
MAINTAINERS |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 1af022e..12b0be3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2089,6 +2089,12 @@ F: Documentation/serial
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
drivers/i2c/busses/Kconfig | 10 +
drivers/i2c/busses/Makefile |1 +
drivers/i2c/busses/i2c-diolan-u2c.c | 529 +++
3 files changed, 540 insertions(+), 0 deletions(-)
create mode
On Wed, 2011-01-19 at 15:56 -0500, Ben Dooks wrote:
On Wed, Jan 19, 2011 at 01:26:38PM -0800, Guenter Roeck wrote:
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
meaningful commit messages please.
In general I agree, only if the headline says everything what else do
you want me
On Wed, 2011-01-19 at 16:14 -0500, Ben Dooks wrote:
On Wed, Jan 19, 2011 at 01:26:37PM -0800, Guenter Roeck wrote:
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
drivers/i2c/busses/Kconfig | 10 +
drivers/i2c/busses/Makefile |1 +
drivers/i2c/busses
On Wed, 2011-01-19 at 16:14 -0500, Ben Dooks wrote:
On Wed, Jan 19, 2011 at 01:26:37PM -0800, Guenter Roeck wrote:
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
[ ... ]
+/* Structure to hold all of our device specific stuff */
+struct i2c_diolan_u2c {
+ struct usb_device
On Tue, Dec 07, 2010 at 09:30:27AM -0500, Maciej W. Rozycki wrote:
On Mon, 6 Dec 2010, Guenter Roeck wrote:
A quick look through sb1250 vs. sb1480 code shows that the 1480 uses
different
interrupt numbers. The patch assigns the sb1250 interrupt numbers, so unless
I am missing something
On Mon, Dec 06, 2010 at 01:38:14AM -0500, Matt Turner wrote:
From: Maciej W. Rozycki ma...@linux-mips.org
This is a rewrite of large parts of the driver mainly so that it uses
SMBus interrupts to offload the CPU from busy-waiting on status inputs.
As a part of the overhaul of the init and
On Mon, Dec 06, 2010 at 01:38:14AM -0500, Matt Turner wrote:
From: Maciej W. Rozycki ma...@linux-mips.org
This is a rewrite of large parts of the driver mainly so that it uses
SMBus interrupts to offload the CPU from busy-waiting on status inputs.
As a part of the overhaul of the init and
On Mon, Dec 06, 2010 at 12:40:15PM -0500, Matt Turner wrote:
On Mon, Dec 6, 2010 at 5:30 PM, Guenter Roeck
guenter.ro...@ericsson.com wrote:
On Mon, Dec 06, 2010 at 01:38:14AM -0500, Matt Turner wrote:
From: Maciej W. Rozycki ma...@linux-mips.org
This is a rewrite of large parts
On Mon, Dec 06, 2010 at 01:38:14AM -0500, Matt Turner wrote:
From: Maciej W. Rozycki ma...@linux-mips.org
This is a rewrite of large parts of the driver mainly so that it uses
SMBus interrupts to offload the CPU from busy-waiting on status inputs.
As a part of the overhaul of the init and
Hi Jean,
On Thu, 2010-11-04 at 08:43 -0400, Jean Delvare wrote:
On Wed, 3 Nov 2010 17:26:29 -0700, Guenter Roeck wrote:
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
This is an usb-i2c adapter I am using to connect to i2c evaluation and test
boards. Not sure if it is worth
Hi Ben,
wow, this is creating way more interest than I thought...
On Thu, 2010-11-04 at 08:47 -0400, Ben Dooks wrote:
On Wed, Nov 03, 2010 at 05:26:29PM -0700, Guenter Roeck wrote:
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
This is an usb-i2c adapter I am using to connect
Hi Jean,
On Thu, 2010-11-04 at 16:18 -0400, Jean Delvare wrote:
Hi Guenter,
On Thu, 4 Nov 2010 09:41:42 -0700, Guenter Roeck wrote:
On Thu, 2010-11-04 at 08:43 -0400, Jean Delvare wrote:
I'm also unsure what is the point of having such a large buffer when
the largest block you ever
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
This is an usb-i2c adapter I am using to connect to i2c evaluation and test
boards. Not sure if it is worth adding it into the kernel. If yes, I'll be
happy to add myself as maintainer.
drivers/i2c/busses/Kconfig | 10
On Sun, Oct 24, 2010 at 11:05:33AM -0400, Éric Piel wrote:
Op 22-10-10 13:57, Samu Onkalo schreef:
Changes are tested only with I2C interface using 8bit sensor since I don't
have other possibilities. Some features are not enabled
by default since I can't test them with all possible
On Sun, Oct 24, 2010 at 11:35:48AM -0400, Guenter Roeck wrote:
On Sun, Oct 24, 2010 at 11:05:33AM -0400, Éric Piel wrote:
Op 22-10-10 13:57, Samu Onkalo schreef:
Changes are tested only with I2C interface using 8bit sensor since I don't
have other possibilities. Some features
On Fri, 2010-10-22 at 07:57 -0400, Samu Onkalo wrote:
Changes are tested only with I2C interface using 8bit sensor since I don't
have other possibilities. Some features are not enabled
by default since I can't test them with all possible configurations.
Platform data contains field which
On Fri, Oct 22, 2010 at 07:44:48PM -0400, Éric Piel wrote:
Op 22-10-10 22:08, Guenter Roeck schreef:
On Fri, 2010-10-22 at 07:57 -0400, Samu Onkalo wrote:
Changes are tested only with I2C interface using 8bit sensor since I don't
have other possibilities. Some features are not enabled
On Thu, Oct 21, 2010 at 10:43:04AM -0400, Jean Delvare wrote:
On Tue, 19 Oct 2010 20:55:08 -0700, Guenter Roeck wrote:
This patch adds support for PCA9541, an I2C Bus Master Selector.
The driver is modeled as single channel I2C Multiplexer to be able to
utilize
the I2C multiplexer
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
MAINTAINERS |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index f46d8e6..f96e8a3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4458,6 +4458,12 @@ S: Maintained
F
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
drivers/i2c/muxes/pca954x.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/muxes/pca954x.c b/drivers/i2c/muxes/pca954x.c
index 6f9accf..54e1ce7 100644
--- a/drivers/i2c/muxes/pca954x.c
+++ b
Hi Jean,
On Tue, Oct 19, 2010 at 01:06:47PM -0400, Jean Delvare wrote:
Hi Guenter,
On Tue, 12 Oct 2010 18:15:16 -0700, Guenter Roeck wrote:
This patch adds support for PCA9541, an I2C Bus Master Selector.
The driver is modeled as single channel I2C Multiplexer to be able to
utilize
On Tue, 2010-10-19 at 17:49 -0400, Jean Delvare wrote:
On Tue, 19 Oct 2010 13:50:53 -0700, Guenter Roeck wrote:
Hi Jean,
On Tue, 2010-10-19 at 13:06 -0400, Jean Delvare wrote:
[ ... ]
+
+/*
+ * I2C init/probing/exit functions
+ */
+static int __devinit pca9541_probe
This patch adds support for PCA9541, an I2C Bus Master Selector.
The driver is modeled as single channel I2C Multiplexer to be able to utilize
the I2C multiplexer framework.
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
Reviewed-by: Tom Grennan tom.gren...@ericsson.com
---
v3 changes
On Tue, Oct 12, 2010 at 09:15:16PM -0400, Guenter Roeck wrote:
This patch adds support for PCA9541, an I2C Bus Master Selector.
The driver is modeled as single channel I2C Multiplexer to be able to utilize
the I2C multiplexer framework.
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
Jean Delvare kh...@... writes:
[...]
I don't quite see the point of such chips, BTW. I2C supports
multi-master already, so two masters talking to the same slave
sequentially is already supported.
To follow up on this, turns out there are (at least) two good reasons for having
such a chip.
On Wed, Sep 29, 2010 at 03:19:28AM -0400, Jean Delvare wrote:
[ ... ]
I don't quite see the point of such chips, BTW. I2C supports
multi-master already, so two masters talking to the same slave
sequentially is already supported.
To follow up on this, turns out there are (at least) two good
This patch adds support for PCA9541, an I2C Bus Master Selector.
The driver is modeled as single channel I2C Multiplexer to be able to utilize
the I2C multiplexer framework.
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
Reviewed-by: Tom Grennan tom.gren...@ericsson.com
---
v2 changes
On Sat, Oct 02, 2010 at 08:27:05AM -0400, Jonathan Cameron wrote:
On 10/02/10 09:25, Jean Delvare wrote:
Hi Guenter,
On Fri, 1 Oct 2010 19:53:11 -0700, Guenter Roeck wrote:
On Fri, Oct 01, 2010 at 07:46:47AM -0400, Samu Onkalo wrote:
This patch set is done to top of 2.6.36-RC5
On Thu, Sep 30, 2010 at 01:59:44AM -0400, Michael Lawnick wrote:
[ ... ]
I only took a rough look, but it seemed to me that the pca is part of
the main device.
Yes
From abstraction side of view your problem seems a matter of
synchronization of two independent computer systems. You will need
On Wed, Sep 29, 2010 at 03:19:28AM -0400, Jean Delvare wrote:
[ ... ]
I was speaking of the PCA9540. I don't think anyone ever wrote a driver
for the PCA9541. And in all honestly I don't think the new i2c-mux
infrastructure is ready for this. It was written with single-master
topologies in
Hi all,
I am in the process of writing a driver for the pca9541 bus master selector.
I using the i2c multiplexer framework, which fits the requirements quite nicely.
If anyone happens to know about an existing driver for this chip, please let me
know.
I would love to get some input for the
Hi Jean,
On Tue, Sep 28, 2010 at 12:42:15PM -0400, Jean Delvare wrote:
On Tue, 28 Sep 2010 09:07:46 -0700, Guenter Roeck wrote:
On Tue, Sep 28, 2010 at 11:16:07AM -0400, Jean Delvare wrote:
Hi Guenter,
On Tue, 28 Sep 2010 07:33:02 -0700, Guenter Roeck wrote:
I am in the process
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
tempX_emergency will be used by max6696. It can also be used for other chips
supporting three upper temperature limits.
Documentation/hwmon/sysfs-interface |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git
On Thu, Aug 26, 2010 at 12:10:23PM -0400, Henrique de Moraes Holschuh wrote:
On Thu, 26 Aug 2010, Guenter Roeck wrote:
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
tempX_emergency will be used by max6696. It can also be used for other chips
supporting three upper
On Thu, Aug 26, 2010 at 12:10:23PM -0400, Henrique de Moraes Holschuh wrote:
On Thu, 26 Aug 2010, Guenter Roeck wrote:
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
tempX_emergency will be used by max6696. It can also be used for other chips
supporting three upper
On Tue, Aug 10, 2010 at 08:29:38AM -0400, Jean Delvare wrote:
Hi Guenter,
Sorry for the late answer, I am just returning from vacation.
Hi Jean,
I figured that much...
On Tue, 20 Jul 2010 21:29:22 -0700, Guenter Roeck wrote:
what is the current status of i2c mux support, specifically
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
v2 changes:
- Added support for MAX6604
- Added support for TSE2002B3 and TS3000B3 (IDT)
- Define Manufacturer IDs separately and only once per manufacturer
- Rearranged chip defines to alphabetic order
---
Documentation/hwmon/jc42
On Sun, Jul 11, 2010 at 11:31:06AM -0400, Joe Perches wrote:
On Sun, 2010-07-11 at 07:53 -0700, Guenter Roeck wrote:
diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c
new file mode 100644
index 000..685057d
--- /dev/null
+++ b/drivers/hwmon/jc42.c
[]
+struct jc42_chips
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
Documentation/hwmon/jc42 | 86 +++
MAINTAINERS |7 +
drivers/hwmon/Kconfig| 11 +
drivers/hwmon/Makefile |1 +
drivers/hwmon/jc42.c | 575 ++
5 files
This patchset adds support for hardware monitoring features of PMBus devices.
The driver has not yet been tested with actual hardware. It is submitted for
early review and to solicit test coverage.
A PMBus device emulator is provided for reference, to show the level of testing
performed. I don't
This driver adds support for hardware monitoring features of various PMBus
devices.
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
drivers/hwmon/Kconfig | 12 +
drivers/hwmon/Makefile |1 +
drivers/hwmon/pmbus.c | 1396
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
Documentation/hwmon/sysfs-interface | 37 +-
1 files changed, 31 insertions(+), 6 deletions(-)
diff --git a/Documentation/hwmon/sysfs-interface
b/Documentation/hwmon/sysfs-interface
index d4e2917
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
Documentation/i2c/i2c-pmbus| 41 ++
drivers/i2c/busses/Kconfig | 13 +
drivers/i2c/busses/Makefile|1 +
drivers/i2c/busses/i2c-pmbus.c | 877
4 files changed, 932 insertions
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
Documentation/hwmon/pmbus | 139 +
1 files changed, 139 insertions(+), 0 deletions(-)
create mode 100644 Documentation/hwmon/pmbus
diff --git a/Documentation/hwmon/pmbus b/Documentation
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
drivers/hwmon/Kconfig | 12 +
drivers/hwmon/Makefile |1 +
drivers/hwmon/pmbus.c | 1227
drivers/hwmon/pmbus.h | 209
4 files changed, 1449 insertions(+), 0 deletions
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
Documentation/hwmon/pmbus | 117 +
1 files changed, 117 insertions(+), 0 deletions(-)
create mode 100644 Documentation/hwmon/pmbus
diff --git a/Documentation/hwmon/pmbus b/Documentation
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
Documentation/hwmon/sysfs-interface | 27 ++-
1 files changed, 22 insertions(+), 5 deletions(-)
diff --git a/Documentation/hwmon/sysfs-interface
b/Documentation/hwmon/sysfs-interface
index d4e2917..b183d94
This patchset adds support for hardware monitoring features of PMBus devices.
The driver has not yet been tested with actual hardware. It is submitted for
early review and, hopefully, to get some test coverage.
A PMBus device emulator is provided for reference, to show the level of testing
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
Documentation/i2c/i2c-pmbus| 41 ++
drivers/i2c/busses/Kconfig | 13 +
drivers/i2c/busses/Makefile|1 +
drivers/i2c/busses/i2c-pmbus.c | 874
4 files changed, 929 insertions
On Mon, Jun 21, 2010 at 01:02:52PM -0400, Jean Delvare wrote:
Hi Guenter,
On Sun, 20 Jun 2010 10:57:53 -0700, Guenter Roeck wrote:
Sibyte i2c bus driver returns non-descriptive error values.
Update to return error values as defined in Documentation/i2c/fault-codes.
Signed-off
Sibyte i2c bus driver returns non-descriptive error values.
Update to return error values as defined in Documentation/i2c/fault-codes.
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
v2: Return -ENXIO for missing ACK and -EIO for other errors
---
drivers/i2c/busses/i2c-sibyte.c
Sibyte i2c bus driver returns non-descriptive error values.
Update to return error values as defined in Documentation/i2c/fault-codes.
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
drivers/i2c/busses/i2c-sibyte.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff
On Sun, May 30, 2010 at 12:15:07AM -0400, Wolfram Sang wrote:
So, the approach I see (unless I miss something) would be writing an
hwmon-I2C-driver named pmbus-devices.c or so which covers the generic
functionality and provides some hooks for manufacturer extensions, if
those are
On Sat, May 29, 2010 at 11:47:41AM -0400, Wolfram Sang wrote:
Yes. PMBus uses i2c as transport, so it can use the existing i2c/smbus
infrastructure.
Data reported is voltage, temperature, current, power, and fan data as
available
from the individual chip. Chips support a chip
Hi,
does anyone know if there is an effort to add infrastructure for PMBus
support (or support for specific PMBus devices) to Linux ?
I'll have to write a driver for a couple of PMBus chips (LTC2978 and
BMR453), and it would help to know if there is a starting point.
Thanks,
Guenter
--
To
201 - 267 of 267 matches
Mail list logo
