Re: [PATCH] MAINTAINERS: i2c: mark also subdirectories as maintained

On Thu, 2015-10-29 at 08:25 +0100, Wolfram Sang wrote: > Otherwise get_maintainer.pl will fall back to git history and CC > more people than needed. > > Signed-off-by: Wolfram Sang > Acked-by: Lee Jones > --- > MAINTAINERS | 1 + > 1 file changed, 1

Re: [PATCH] MAINTAINERS: i2c: mark also subdirectories as maintained

On Thu, 2015-10-29 at 16:52 +0100, Wolfram Sang wrote: > > + The scripts/get_maintainer.pl tool has a quirk about subdirectories. > > + If the file pattern is for a directory, then any subdirectories of > > + the parent directory should also be specified. For instance: > > +

Re: [PATCH 6/6] MAINTAINERS: maintain parport

On Wed, 2015-05-20 at 17:46 +0200, Richard Weinberger wrote: On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee sudipm.mukher...@gmail.com wrote: Lets give the parport subsystem a proper name and start maintaining the files. Excuse me, but usually someone takes over the maintainer role

[RFC PATCH] checkpatch: check for 2 or more spaces around assignment of a declaration

On Wed, 2015-05-20 at 19:59 +0200, Jean Delvare wrote: On Wed, 20 May 2015 22:44:52 +0530, Sudip Mukherjee wrote: On Wed, May 20, 2015 at 05:49:07PM +0200, Wolfram Sang wrote: On Wed, May 20, 2015 at 08:57:00PM +0530, Sudip Mukherjee wrote: static struct parport_driver

Re: [PATCH V1 1/1] iio: Added Capella cm3232 ambient light sensor driver.

On Mon, 2015-01-05 at 12:51 +0200, Daniel Baluta wrote: On Thu, Jan 1, 2015 at 2:10 AM, Kevin Tsai kt...@capellamicro.com wrote: CM3232 is an advanced ambient light sensor with I2C protocol interface. The I2C slave address is internally hardwired as 0x10 (7-bit). Writing to configure

Re: [PATCH V1 1/1] iio: Added Capella cm3232 ambient light sensor driver.

On Mon, 2015-01-05 at 16:20 +0200, Daniel Baluta wrote: On Mon, Jan 5, 2015 at 3:09 PM, Joe Perches j...@perches.com wrote: On Mon, 2015-01-05 at 12:51 +0200, Daniel Baluta wrote: On Thu, Jan 1, 2015 at 2:10 AM, Kevin Tsai kt...@capellamicro.com wrote: CM3232 is an advanced ambient light

Re: [PATCH V1 1/1] iio: Added Capella cm3232 ambient light sensor driver.

On Mon, 2015-01-05 at 19:50 +0200, Daniel Baluta wrote: On Mon, Jan 5, 2015 at 6:42 PM, Joe Perches j...@perches.com wrote: On Mon, 2015-01-05 at 16:20 +0200, Daniel Baluta wrote: On Mon, Jan 5, 2015 at 3:09 PM, Joe Perches j...@perches.com wrote: On Mon, 2015-01-05 at 12:51 +0200, Daniel

Re: [PATCH v9 1/4] mfd: add support for Diolan DLN-2 devices

On Mon, 2014-10-27 at 18:31 +0200, Octavian Purdila wrote: This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO Master Adapter DLN-2. Details about the device can be found here: trivia: diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c [] +static int _dln2_transfer(struct

Re: [PATCH v7 1/4] mfd: add support for Diolan DLN-2 devices

On Thu, 2014-10-09 at 22:22 +0300, Octavian Purdila wrote: This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO Master Adapter DLN-2. Details about the device can be found here: trivia: diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig [] +config MFD_DLN2 + tristate

Re: [PATCH] i2c: i2c-imx: Fix format warning for dev_dbg

On Wed, 2014-08-06 at 10:54 +0800, Xiubo Li wrote: drivers/i2c/busses/i2c-imx.c: In function i2c_imx_probe() drivers/i2c/busses/i2c-imx.c:689:2: warning: format 0x%x expects argument of type unsigned int, but argument 4 has type resource_size_t [-Wformat=] dev_dbg(i2c_imx-adapter.dev, device

Re: [PATCH v3] i2c: new bus driver for efm32

On Tue, 2014-03-25 at 10:11 +0100, Wolfram Sang wrote: On Tue, Mar 25, 2014 at 10:07:00AM +0100, Uwe Kleine-König wrote: Hello, On Mon, Mar 24, 2014 at 06:01:31PM +0100, Wolfram Sang wrote: And checkpatch said: WARNING: braces {} are not necessary for any arm of this statement

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

On Thu, 2014-02-20 at 16:38 -0800, Bjorn Andersson wrote: This bus driver supports the QUP i2c hardware controller in the Qualcomm SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data path engine with input/output FIFOs and an embedded i2c mini-core. The driver

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

On Wed, 2013-11-13 at 20:24 +0100, Marek Vasut wrote: On Tue, Nov 12, 2013 at 07:33:40PM +0100, Marek Vasut wrote: That is because if you look at the only caller of this function, which is pch_i2c_wait_for_check_xfer(), you will see that at the only place where pch_i2c_getack() is

Re: [PATCH 2/2] i2c: i2c-core: fix coding style issues in i2c-core.c

On Mon, 2013-10-14 at 00:43 +0530, RAGHAVENDRA GANIGA wrote: [] diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c [] @@ -1737,9 +1735,10 @@ int i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) if (adap-algo-master_xfer) { #ifdef DEBUG for

Re: [PATCH v3 1/3] i2c: xilinx: Fix i2c checkpatch warnings

On Thu, 2013-10-10 at 12:39 +0200, Michal Simek wrote: Code changes to fix checkpatch warnings listed below. - WARNING: quoted string split across lines [] diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c [] @@ -271,11 +271,8 @@ static void xiic_read_rx(struct

Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

On Thu, 2013-04-18 at 06:35 -0700, Guenter Roeck wrote: On Wed, Apr 17, 2013 at 09:40:53PM -0700, Joe Perches wrote: On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote: On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote: + return kempld_read8(pld, index) | kempld_read8

Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote: On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote: + return kempld_read8(pld, index) | kempld_read8(pld, index+1) 8; index + 1) Please Wondering why does

[PATCH 08/16] i2c: Convert dev_printk(KERN_LEVEL to dev_level(

dev_level calls take less code than dev_printk(KERN_LEVEL and reducing object size is good. Coalesce formats for easier grep. Signed-off-by: Joe Perches j...@perches.com --- drivers/i2c/busses/i2c-piix4.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/i2c

[PATCH 00/16] treewide: Convert dev_printk(KERN_LEVEL to dev_level(

dev_level create smaller objects than dev_printk(KERN_LEVEL. Convert non-debug calls to this form. Joe Perches (16): tile: Convert dev_printk(KERN_LEVEL to dev_level( ata: Convert dev_printk(KERN_LEVEL to dev_level( drivers: base: Convert dev_printk(KERN_LEVEL to dev_level( block: Convert

Re: [PATCH 00/16] treewide: Convert dev_printk(KERN_LEVEL to dev_level(

On Sun, 2012-10-28 at 14:54 +0400, Sergei Shtylyov wrote: Hello. Hi Sergei. On 28-10-2012 12:05, Joe Perches wrote: dev_level create smaller objects than dev_printk(KERN_LEVEL. Convert non-debug calls to this form. Joe Perches (16): tile: Convert dev_printk(KERN_LEVEL

Re: [PATCH] i2c/scx200_*: replace printks with pr_levels

On Fri, 2012-09-14 at 21:21 -0600, Jim Cromie wrote: Replace printks with pr_levels, add pr_fmt()s to replace NAMEs Hi Jim. When you do these, please maximally fill to 80 columns the printk arguments and coalesce formats without regard to 80 columns. diff --git

Re: RFC: Use dynamic-debug with pr_debug when -DDEBUG is set

On Wed, 2011-08-10 at 23:44 -0600, Jim Cromie wrote: On Wed, Aug 10, 2011 at 7:03 PM, Joe Perches j...@perches.com wrote: On Wed, 2011-08-10 at 20:20 -0400, Jason Baron wrote: On Wed, Aug 10, 2011 at 05:01:37PM -0700, Joe Perches wrote: Perhaps another way to enable pr_debug use

Re: dynamic-debug not built into scx200_acb, scx200_i2c

On Wed, 2011-08-10 at 15:06 -0600, Jim Cromie wrote: scx200_acb has several pr_debugs, but theyre not available via dynamic-debug Ive been unable to figure out why. Any ideas ? -DDEBUG forces pr_debug to be output and doesn't allow dynamic_debug for those outputs. from

RFC: Use dynamic-debug with pr_debug when -DDEBUG is set

On Wed, 2011-08-10 at 16:50 -0700, Joe Perches wrote: On Wed, 2011-08-10 at 15:06 -0600, Jim Cromie wrote: scx200_acb has several pr_debugs, but theyre not available via dynamic-debug Ive been unable to figure out why. Any ideas ? -DDEBUG forces pr_debug to be output and doesn't allow

Re: RFC: Use dynamic-debug with pr_debug when -DDEBUG is set

On Wed, 2011-08-10 at 20:20 -0400, Jason Baron wrote: On Wed, Aug 10, 2011 at 05:01:37PM -0700, Joe Perches wrote: Perhaps another way to enable pr_debug use is to reverse the order of dynamic_pr_debug defines. ie: change printk.h: #if defined(CONFIG_DYNAMIC_DEBUG

[PATCH 00/11] Remove unnecessary casts of pci_get_drvdata

Joe Perches (11): drivers/i2c/busses/i2c-nforce2.c: Remove unnecessary casts of pci_get_drvdata drivers/ide/pmac.c: Remove unnecessary casts of pci_get_drvdata drivers/media/dvb/ngene/ngene-core.c: Remove unnecessary casts of pci_get_drvdata drivers/misc/ibmasm/module.c: Remove

[PATCH 01/11] drivers/i2c/busses/i2c-nforce2.c: Remove unnecessary casts of pci_get_drvdata

Signed-off-by: Joe Perches j...@perches.com --- drivers/i2c/busses/i2c-nforce2.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/i2c-nforce2.c b/drivers/i2c/busses/i2c-nforce2.c index a605a50..ff1e127 100644 --- a/drivers/i2c/busses/i2c-nforce2.c +++ b

[PATCH 00/44] remove unnecessary semicolons

ya trivial series... Joe Perches (44): arch/arm: Remove unnecessary semicolons arch/microblaze: Remove unnecessary semicolons arch/um: Remove unnecessary semicolons drivers/cpufreq: Remove unnecessary semicolons drivers/gpio: Remove unnecessary semicolons drivers/i2c: Remove

[PATCH 06/44] drivers/i2c: Remove unnecessary semicolons

Signed-off-by: Joe Perches j...@perches.com --- drivers/i2c/busses/i2c-designware.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware.c b/drivers/i2c/busses/i2c-designware.c index b664ed8..a93922d 100644 --- a/drivers/i2c/busses/i2c

Re: [PATCH v2] iio: light: Adding driver for ISL29018 ALS

On Tue, 2010-10-05 at 14:19 -0700, rkl...@nvidia.com wrote: Adding support for the ISL 29018 ambient light and proximity sensor. Trivial comments below. diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c [] +static int isl29018_set_range(struct

RE: [PATCH v2] iio: light: Adding driver for ISL29018 ALS

On Tue, 2010-10-05 at 14:36 -0700, Rhyland Klein wrote: -Original Message- From: Joe Perches [mailto:j...@perches.com] diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c +static int isl29018_chip_init(struct i2c_client *client

Re: [PATCH v3] iio: light: Adding driver for ISL29018 ALS

On Tue, 2010-10-05 at 15:42 -0700, rkl...@nvidia.com wrote: From: Rhyland Klein rkl...@nvidia.com Hi again. diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c [] +#define ISL29018_REG_ADD_DATA_LSB0x02 +#define ISL29018_REG_ADD_DATA_MSB0x03

Re: [PATCH] Add ALS drivers for the apds9802als

On Tue, 2010-09-28 at 16:56 +0100, Alan Cox wrote: drivers/misc/apds9802als.c | 308 [] +static int apds9802als_probe(struct i2c_client *client, + const struct i2c_device_id *id) +{ + int res; +

[PATCH 05/25] drivers/i2c: Use static const char arrays

Signed-off-by: Joe Perches j...@perches.com --- drivers/i2c/busses/i2c-stu300.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-stu300.c b/drivers/i2c/busses/i2c-stu300.c index 495be45..2f7c09c 100644 --- a/drivers/i2c/busses/i2c-stu300.c +++ b

Re: [PATCH 05/25] drivers/i2c: Use static const char arrays

On Mon, 2010-09-13 at 21:08 +0100, Jonathan Cameron wrote: Commit message is somewhat inaccurate... Yeah, sorry 'bout that. That's what I get for using a script. I did write an intro with more complete description. diff --git a/drivers/i2c/busses/i2c-stu300.c

Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_I2C driver to 2.6.35

On Fri, 2010-09-03 at 16:15 +0900, Masayuki Ohtak wrote: [] +#define pch_dbg(adap, fmt, arg...) \ + dev_dbg(adap-pch_adapter.dev.parent, %s :fmt, __func__, ##arg) + +#define pch_err(adap, fmt, arg...) \ + dev_err(adap-pch_adapter.dev.parent, %s :fmt, __func__, ##arg) + +#define

Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_I2C driver to 2.6.35

logging macro uses. Fix misspelling of Enterred to Entered. Use FAILED consistently. There's an odd use that is still questionable: pch_pci_dbg(pdev, request_irq returns %d pch_probe returns\n, ret); Signed-off-by: Joe Perches j...@perches.com --- drivers/i2c/busses/i2c-pch.c | 103

Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_I2C driver to 2.6.35

On Wed, 2010-09-01 at 11:26 +0900, Masayuki Ohtak wrote: I2C driver of Topcliff PCH +++ b/drivers/i2c/busses/i2c-pch.c [] +static void pch_init(struct i2c_algo_pch_data *adap) [] + if (pch_i2c_speed == FAST_MODE_CLK) { + reg_value |= FAST_MODE_EN; +

Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_I2C driver to 2.6.35

On Wed, 2010-09-01 at 14:08 +0900, Masayuki Ohtake wrote: I have a question. Current our I2C driver has the following 2 patterns dev_err(). (1) dev_err(adap-pch_adapter.dev.parent, ...); (2) dev_err(pdev-dev, ...); #define pch_err(adap, fmt, arg...) \ dev_err(adap-pch_adapter.dev.parent,

Re: [PATCH v2] hwmon: Add support for JEDEC JC 42.4 compliant temperature sensors

On Sun, 2010-07-11 at 07:53 -0700, Guenter Roeck wrote: diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c new file mode 100644 index 000..685057d --- /dev/null +++ b/drivers/hwmon/jc42.c [] +struct jc42_chips { + u16 manid; + u16 devid; + u16 devid_mask; +}; +

[PATCH] scripts/checkpatch.pl: Add strict test of logical test continuations at beginning of line

On Sun, 2010-07-11 at 18:21 +0200, Jean Delvare wrote: On Sun, 11 Jul 2010 09:16:58 -0700, Guenter Roeck wrote: On Sun, Jul 11, 2010 at 11:31:06AM -0400, Joe Perches wrote: Kernel style seems to prefer having logical tests at end of line rather than start of line. Ok. Would be nice

Re: [PATCH] scripts/checkpatch.pl: Add strict test of logical test continuations at beginning of line

On Sun, 2010-07-11 at 21:34 +0200, Jean Delvare wrote: On Sun, 11 Jul 2010 11:57:12 -0700, Joe Perches wrote: I don't remember that discussion. Link? http://lkml.org/lkml/2009/12/5/65 You started the thread, so I would think you'd remember it. Though there are differences in opinion about

[PATCH 06/21] drivers/i2c/i2c-dev.c: Remove unnecessary kmalloc casts

Signed-off-by: Joe Perches j...@perches.com --- drivers/i2c/i2c-dev.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c index e0694e4..b3fcb59 100644 --- a/drivers/i2c/i2c-dev.c +++ b/drivers/i2c/i2c-dev.c @@ -219,9 +219,7

Re: cy8ctmg110 for review

On Wed, 2010-04-14 at 13:54 +0100, Alan Cox wrote: Subject: [FOR COMMENT] cy8ctmg110 for review From: Samuli Konttila samuli.kontt...@aavamobile.com Add support for the cy8ctmg110 capacitive touchscreen used on some embedded devices. (Some clean up by Alan Cox) Some more cleanups.

Re: [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass

Trivial neatening Argument alignment Spacing Make chars static Remove prefixes from dev_level logging Signed-off-by: Joe Perches j...@perches.com --- drivers/misc/hmc6352.c | 44 ++-- 1 files changed, 22 insertions(+), 22 deletions(-) diff --git

Re: [PATCH] i2c-iop3xx.c: fix memory resource

On Fri, 2009-12-11 at 13:32 -0500, H Hartley Sweeten wrote: The i2c-iop3xx driver requires a resource region of 0x18 bytes and currently uses the magic number IOP3XX_I2C_IO_SIZE (defined in i2c-iop3xx.h) to indicate this. All of the users of this driver have a platform memory resource so use