Argument alignment
Makes it take more space
Spacing
Mostly dropped
Make chars static
Not sure I see the point (compiler generates good code anyway)
Remove prefixes from dev_level logging
Good point.
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a
Hi Alan, Kalhan,
Couple of comments below.
On 04/14/10 13:51, Alan Cox wrote:
From: Kalhan Trisal kalhan.tri...@intel.com
This driver will report the heading values in degrees to the sysfs interface.
The values returned are headings . e.g. 245.6
(Some cleanups from Alan Cox)
This is in no way a hwmon chip. Surely misc is a better location for now
(pending the usual discussion about all singing all dancing sensors
frameworks).
Yep it's moving at the moment
+#include linux/module.h
+#include linux/init.h
+#include linux/slab.h
+#include linux/i2c.h
On 04/14/10 15:32, Alan Cox wrote:
This is in no way a hwmon chip. Surely misc is a better location for now
(pending the usual discussion about all singing all dancing sensors
frameworks).
Yep it's moving at the moment
+#include linux/module.h
+#include linux/init.h
+#include
Ripping it out of hwmon and applying the hedge trimmers to everything not
needed and we get this for drivers/misc. I've also swapped the command
codes to characters as the datasheet specifies them in ascii.
8--
hmc6352: Add driver for
Looks good to me,
Acked-by: Jonathan Cameron ji...@cam.ac.uk
On 04/14/10 16:19, Alan Cox wrote:
Ripping it out of hwmon and applying the hedge trimmers to everything not
needed and we get this for drivers/misc. I've also swapped the command
codes to characters as the datasheet specifies them
Trivial neatening
Argument alignment
Spacing
Make chars static
Remove prefixes from dev_level logging
Signed-off-by: Joe Perches j...@perches.com
---
drivers/misc/hmc6352.c | 44 ++--
1 files changed, 22 insertions(+), 22 deletions(-)
diff --git
