Richard Röjfors wrote:
Ben Dooks wrote:
On Sun, Jan 24, 2010 at 06:33:20PM +0100, Richard R?jfors wrote:
+
+#define XIIC_MSB_OFFSET 0
+#define XIIC_REG_OFFSET (0x100+XIIC_MSB_OFFSET)
givevn you're running everything through indirect read/write calls,
how about doing it in there?
Could do,
On Sun, Jan 24, 2010 at 06:33:20PM +0100, Richard R?jfors wrote:
Hi Ben,
Thanks for the feedback! Comments below...
On 1/24/10 4:49 PM, Ben Dooks wrote:
On Tue, Jan 19, 2010 at 05:01:16PM +0100, Richard R?jfors wrote:
This patch adds support for the Xilinx XPS IIC Bus Interface.
The
On Sun, Jan 24, 2010 at 07:15:26PM +0100, Wolfram Sang wrote:
+ * i2c-xiic.c
the directory path to the file would have been nice.
Will update
Ben, are you sure? Those filenames (especially with directories) easily go
stale when reorganizing the tree.
I said nice, not esential.
Ben Dooks wrote:
On Sun, Jan 24, 2010 at 06:33:20PM +0100, Richard R?jfors wrote:
+
+#define XIIC_MSB_OFFSET 0
+#define XIIC_REG_OFFSET (0x100+XIIC_MSB_OFFSET)
givevn you're running everything through indirect read/write calls,
how about doing it in there?
Could do, bad thing is that it
On Tue, Jan 19, 2010 at 05:01:16PM +0100, Richard R?jfors wrote:
This patch adds support for the Xilinx XPS IIC Bus Interface.
The driver uses the dynamic mode, supporting to put several
I2C messages in the FIFO to reduce the number of interrupts.
It has the same feature as ocores, it can
Hi Ben,
Thanks for the feedback! Comments below...
On 1/24/10 4:49 PM, Ben Dooks wrote:
On Tue, Jan 19, 2010 at 05:01:16PM +0100, Richard R?jfors wrote:
This patch adds support for the Xilinx XPS IIC Bus Interface.
The driver uses the dynamic mode, supporting to put several
I2C messages in
+ * i2c-xiic.c
the directory path to the file would have been nice.
Will update
Ben, are you sure? Those filenames (especially with directories) easily go
stale when reorganizing the tree.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux
On Sun, 24 Jan 2010 19:15:26 +0100, Wolfram Sang wrote:
+ * i2c-xiic.c
the directory path to the file would have been nice.
Will update
Ben, are you sure? Those filenames (especially with directories) easily go
stale when reorganizing the tree.
FWIW, I agree with Wolfram on
Wolfram == Wolfram Sang w.s...@pengutronix.de writes:
+ * i2c-xiic.c
the directory path to the file would have been nice.
Will update
Wolfram Ben, are you sure? Those filenames (especially with
Wolfram directories) easily go stale when reorganizing the tree.
Exactly, that's
