Re: [PATCH] i2c: s3c2410: remove superfluous runtime PM calls

2015-12-17 Thread Charles Keepax
On Wed, Dec 16, 2015 at 02:53:07PM +0100, Sylwester Nawrocki wrote: > On 15/12/15 19:14, Wolfram Sang wrote: > > Since commit 6ada5c1e1b077a ("i2c: Mark adapter devices with > > pm_runtime_no_callbacks"), runtime PM on adapters turned into a no-op. > > So, we can remove these calls. > > Won't

Re: [PATCH] i2c: make i2c_parse_fw_timings() always visible

2015-12-17 Thread Mika Westerberg
On Thu, Dec 17, 2015 at 01:32:36PM +0100, Wolfram Sang wrote: > From: Wolfram Sang > > This function used to be DT only, so it lived inside a CONFIG_OF block. > Now it uses device attributes and must be moved outside of it. No > further code changes. > >

Re: [PATCH] i2c: allow building emev2 without slave mode again

2015-12-17 Thread Arnd Bergmann
On Thursday 17 December 2015 13:01:57 Wolfram Sang wrote: > On Mon, Dec 14, 2015 at 11:27:22PM +0100, Arnd Bergmann wrote: > > On Monday 14 December 2015 14:52:06 Wolfram Sang wrote: > > > > > What about not ifdeffing the inline function and keep the build error > > > > > whenever someone uses it

Re: [PATCH] i2c: allow building emev2 without slave mode again

2015-12-17 Thread Wolfram Sang
> > My conclusion for now is: > > > > There needs something to be done surely, but currently I don't have the > > bandwidth to do it or even play around with it. I am not fully happy > > with your patches as well because __maybe_unused has some kind of "last > > resort" feeling to me. > > I

Re: [V1, 1/2] i2c: brcmstb: Adding support for CM and DSL SoCs

2015-12-17 Thread Florian Fainelli
On 16/12/15 12:49, Kamal Dasu wrote: > Broadcoms DSL, CM (cable modem)and STB I2C core implementation have > 8 data in/out registers that can transfer 8 bytes or 32 bytes max. > Cable and DSL "Peripheral" i2c cores use single byte per data > register and the STB can use 4 byte per data register

Re: [V1, 2/2] dt-bindings: i2c: Update i2c-brcmstb compatible string

2015-12-17 Thread Florian Fainelli
On 16/12/15 12:49, Kamal Dasu wrote: > Adding compatibility with the DSL and CM SoCs that use > the "Peripheral" i2c hardware. "brcm,brcmper-i2c" is > also an allowed string. > > Signed-off-by: Kamal Dasu Reviewed-by: Florian Fainelli > --- >

Re: [PATCH] i2c: allow building emev2 without slave mode again

2015-12-17 Thread Wolfram Sang
On Mon, Dec 14, 2015 at 11:27:22PM +0100, Arnd Bergmann wrote: > On Monday 14 December 2015 14:52:06 Wolfram Sang wrote: > > > > What about not ifdeffing the inline function and keep the build error > > > > whenever someone uses it without I2C_SLAVE being selected? > > > > > > The inline function

[PATCH] i2c: emev: select I2C slave support

2015-12-17 Thread Wolfram Sang
From: Wolfram Sang Until we have proper support to make I2C slave support fully optional, select it to prevent build errors on randconfigs. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/Kconfig | 1 + 1 file changed, 1

[PATCH] i2c: make i2c_parse_fw_timings() always visible

2015-12-17 Thread Wolfram Sang
From: Wolfram Sang This function used to be DT only, so it lived inside a CONFIG_OF block. Now it uses device attributes and must be moved outside of it. No further code changes. Reported-by: Jim Davis Signed-off-by: Wolfram Sang

Re: randconfig build error with next-20151216, in drivers/i2c/busses

2015-12-17 Thread Wolfram Sang
On Wed, Dec 16, 2015 at 09:44:00AM -0700, Jim Davis wrote: > Building with the attached random configuration file, > > ERROR: "i2c_parse_fw_timings" [drivers/i2c/busses/i2c-rcar.ko] undefined! Thanks! I just sent a patch to fix it. signature.asc Description: Digital signature

Re: [PATCH v2] i2c: rcar: disable runtime PM correctly in slave mode

2015-12-17 Thread Wolfram Sang
On Wed, Dec 16, 2015 at 08:05:18PM +0100, Wolfram Sang wrote: > From: Wolfram Sang > > When we also are I2C slave, we need to disable runtime PM because the > address detection mechanism needs to be active all the time. However, we > can reenable runtime PM once

Re: [PATCH] i2c: emev: select I2C slave support

2015-12-17 Thread Wolfram Sang
On Thu, Dec 17, 2015 at 01:09:32PM +0100, Wolfram Sang wrote: > From: Wolfram Sang > > Until we have proper support to make I2C slave support fully optional, > select it to prevent build errors on randconfigs. > > Signed-off-by: Wolfram Sang

Re: [PATCH] i2c: make i2c_parse_fw_timings() always visible

2015-12-17 Thread Wolfram Sang
On Thu, Dec 17, 2015 at 01:32:36PM +0100, Wolfram Sang wrote: > From: Wolfram Sang > > This function used to be DT only, so it lived inside a CONFIG_OF block. > Now it uses device attributes and must be moved outside of it. No > further code changes. > >

Re: [PATCH] i2c: allow building emev2 without slave mode again

2015-12-17 Thread Arnd Bergmann
On Thursday 17 December 2015 20:40:17 Wolfram Sang wrote: > > > My conclusion for now is: > > > > > > There needs something to be done surely, but currently I don't have the > > > bandwidth to do it or even play around with it. I am not fully happy > > > with your patches as well because