Re: [PATCH] cleanup sched_yield (sys)call nesting.

2009-11-19 Thread Thomas Gleixner
On Wed, 18 Nov 2009, Sven-Thorsten Dietrich wrote: We are trying to get rid of __sched_yield calls from-inside-the-Kernel, but sys_sched_yield() from user-space will remain. This patch breaks out the in-Kernel interface for the yield() functionality and deprecates it explicitly. The

Re: yield() in i2c non-happy paths hits BUG under -rt patch

2009-11-19 Thread Jean Delvare
On Wed, 18 Nov 2009 21:36:48 +0100 (CET), Thomas Gleixner wrote: On Wed, 18 Nov 2009, Jean Delvare wrote: On Wed, 18 Nov 2009 17:28:53 +0100, Leon Woestenberg wrote: On Wed, Nov 18, 2009 at 2:05 AM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: Our timers are very efficient and some day

Re: yield() in i2c non-happy paths hits BUG under -rt patch

2009-11-19 Thread Alan Cox
Well, I guess only people monitoring system latency would notice, as this is the only thing yield() was supposed to help with in the first place. if (need_resched()) schedule(); will make non-rt tasks act politely at the right moments. RT tasks will likely immediately

Re: yield() in i2c non-happy paths hits BUG under -rt patch

2009-11-19 Thread Peter Zijlstra
On Thu, 2009-11-19 at 12:59 +, Alan Cox wrote: Well, I guess only people monitoring system latency would notice, as this is the only thing yield() was supposed to help with in the first place. if (need_resched()) schedule(); aka. cond_resched(); will

Re: yield() in i2c non-happy paths hits BUG under -rt patch

2009-11-19 Thread Peter Zijlstra
On Thu, 2009-11-19 at 14:11 +0100, Thomas Gleixner wrote: You say NOOP by default, does this imply there is a way to change this? There is a sysctl: sysctl_sched_compat_yield This makes yield() place current behind all other tasks, and sucks too for some workloads. -- To unsubscribe

Re: yield() in i2c non-happy paths hits BUG under -rt patch

2009-11-19 Thread Jean Delvare
Hi Peter, On Thu, 19 Nov 2009 14:06:54 +0100, Peter Zijlstra wrote: On Thu, 2009-11-19 at 12:59 +, Alan Cox wrote: Well, I guess only people monitoring system latency would notice, as this is the only thing yield() was supposed to help with in the first place. if

[PATCH V2] gpio: add driver for MAX7300 I2C GPIO extender

2009-11-19 Thread Wolfram Sang
Add the MAX7300-I2C variant to the MAX7301-SPI version. They share most parts of the driver (i.e. the logic) and the read/write-register functions get encapsulated. It is thus possible to use both variants simultaneously. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Juergen Beisert

Re: yield() in i2c non-happy paths hits BUG under -rt patch

2009-11-19 Thread Peter Zijlstra
On Thu, 2009-11-19 at 15:00 +0100, Jean Delvare wrote: cond_resched(); Are you saying that most calls to yield() should be replaced with calls to cond_resched()? No, depends on the reason yield() is used. Some cases can be replaced by locking constructs, such as a condition variable.

Re: [PATCH V2] gpio: add driver for MAX7300 I2C GPIO extender

2009-11-19 Thread Anton Vorontsov
On Thu, Nov 19, 2009 at 03:02:29PM +0100, Wolfram Sang wrote: Add the MAX7300-I2C variant to the MAX7301-SPI version. They share most parts of the driver (i.e. the logic) and the read/write-register functions get encapsulated. It is thus possible to use both variants simultaneously.

[PATCH] MAINTAINERS: Add missing i2c files

2009-11-19 Thread Jean Delvare
Add missing header files to the i2c subsystem section. Signed-off-by: Jean Delvare kh...@linux-fr.org --- MAINTAINERS |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- linux-2.6.32-rc7.orig/MAINTAINERS 2009-11-19 17:52:32.0 +0100 +++ linux-2.6.32-rc7/MAINTAINERS

[PATCH 1/2 RESEND#2] i2c/pxa: remove unused macro

2009-11-19 Thread Uwe Kleine-König
Commit beea494 ([ARM] Remove EEPROM slave emulation from i2c-pxa driver.) removed all uses of eedbg, so the definition can go, too. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de Cc: Jean Delvare kh...@linux-fr.org Cc: Ben Dooks ben-li...@fluff.org Acked-by: Russell King

[PATCH 2/2 RESEND#2] i2c/pxa: only define 'blue_murder'-function if DEBUG is #defined

2009-11-19 Thread Uwe Kleine-König
From: Wolfram Sang w.s...@pengutronix.de This talkative function is also called on timeouts. As timeouts can happen on regular writes to EEPROMs (no error case), this creates false positives. Giving lots of details is interesting only for developers anyhow, so just use the function if DEBUG is

[PULL] please pull bjdooks' i2c-pnx-fixes branch

2009-11-19 Thread Ben Dooks
The following changes since commit 648f4e3e50c4793d9dbf9a09afa193631f76fa26: Linus Torvalds (1): Linux 2.6.32-rc8 are available in the git repository at: git://git.fluff.org/bjdooks/linux i2c-pnx-fixes Kevin Wells (3): i2c: i2c-pnx: Limit minimum jiffie timeout to 2 i2c: