Re: [PATCH] i2c: designware: Add support for AMD Seattle I2C

2015-12-16 Thread Suravee Suthikulanit
Mika, On 12/16/2015 8:54 AM, Mika Westerberg wrote: On Wed, Dec 16, 2015 at 08:29:38AM -0600, Suravee Suthikulpanit wrote: > > >On 12/16/2015 03:16 AM, Mika Westerberg wrote: > >On Tue, Dec 15, 2015 at 08:14:34PM -0600, Suravee Suthikulpanit wrote: > >>Hi Mika, > >> > >>On 12/15/15 15:55,

Re: [PATCH v2] i2c: designware: Do not require clock when SSCN and FFCN are provided

2015-12-16 Thread Suravee Suthikulanit
On 12/16/2015 8:56 PM, Loc Ho wrote: Hi, The current driver uses input clock source frequency to calculate values for [SS|FS]_[HC|LC] registers. However, when booting ACPI, we do not currently have a good way to provide the frequency information. Instead, we can leverage the SSCN and FFCN ACPI

Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2015-12-14 Thread Suravee Suthikulanit
Hi, I'm not sure if this has been discussed earlier. But after looking at the the acpi_apd driver, all we need is just the platform-specific input clock frequency value used by the drivers/i2c/busses/i2c-designware-core.c: i2c_dw_init() to calculate the values to program into the

Re: [PATCH v2] i2c: designware: Do not require clock when SSCN and FFCN are provided

2015-12-22 Thread Suravee Suthikulanit
Hi Mika, On 12/18/2015 4:13 AM, Mika Westerberg wrote: [] So instead of this, what if we do not assign dev->get_clk_rate_khz at all and then do something like below in the core driver? I like the changes below since it is clear to see within the core file how things are handled when