are not able to send new messages into bus with
successive omap_i2c_xfer calls. Therefore a pending signal is not caught
here and we return only because of timeout or i2c error.
Signed-off-by: Jarkko Nikula [EMAIL PROTECTED]
Signed-off-by: Juha Yrjola [EMAIL PROTECTED]
Signed-off-by: Tony Lindgren
-idle flag before
interrupts are enabled, rather than afterwards.
The patch has survived twenty-two reboots on the 3430SDP here without
wedging I2C1. Not absolutely dispositive, but promising!
Signed-off-by: Paul Walmsley [EMAIL PROTECTED]
Signed-off-by: Tony Lindgren [EMAIL PROTECTED]
---
drivers
From: Paul Walmsley [EMAIL PROTECTED]
Mark functions called only at init time as __init.
Signed-off-by: Paul Walmsley [EMAIL PROTECTED]
Signed-off-by: Tony Lindgren [EMAIL PROTECTED]
---
drivers/i2c/busses/i2c-omap.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git
From: Kalle Jokiniemi [EMAIL PROTECTED]
I2C_WE registers were not configured, which caused huge delays in
I2C operations while cpu idle was enabled and omap entered WFI.
This patch enables all I2C wakeup sources.
Signed-off-by: Kalle Jokiniemi [EMAIL PROTECTED]
Signed-off-by: Tony Lindgren
* Mike Frysinger vap...@gentoo.org [090129 08:48]:
On Thursday 29 January 2009 11:38:46 Tony Lindgren wrote:
* Wolfram Sang w.s...@pengutronix.de [090129 08:31]:
Sourceforge is fat and slow and their mailing lists are filled up with
It is slow at times and even had annoying downtimes
* Jagadeesh Bhaskar Pakaravoor jagadees...@gmail.com [090514 03:34]:
IMO, The regs do not need to move to a separate header unless they will
be used outside of i2c-omap.c.
Would it not be cleaner to move them to a separate header file,
especially considering the fact that we have some 19
) we stay above these
minimum values.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
Ben can you please queue this?
Acked-by: Tony Lindgren t...@atomide.com
---
drivers/i2c/busses/i2c-omap.c | 25 ++---
1 files changed, 18 insertions(+), 7 deletions(-)
diff
* Aaro Koskinen aaro.koski...@nokia.com [090527 07:55]:
Use longer noise filter period for fast and standard mode. Based on an
earlier patch by Eero Nurkkala.
Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com
Ben this should be queued too.
Acked-by: Tony Lindgren t...@atomide.com
* Mark Brown broo...@opensource.wolfsonmicro.com [090803 17:23]:
On Wed, Jul 29, 2009 at 10:06:13AM +0530, balaj...@ti.com wrote:
- if (twl_has_regulator()) {
+ if (twl_has_regulator() is_class_twl4030()) {
is_class_twl4030() feels like it should have better namespacing, though
the OMAP tree. If this really doesn't work, you might try Andrew Morton.
Ack from me too for Ben.
Acked-by: Tony Lindgren t...@atomide.com
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
.
As such, this change restores the original functionality.
Looks like initializing dev-iestate to something before calling
omap_i2c_unidle in omap_i2c_probe is not an option in this case.
We'd want to initialize it to zero, which causes the deadlock..
Acked-by: Tony Lindgren t...@atomide.com
Signed-off
clean-up.
Acked-by: Tony Lindgren t...@atomide.com
---
drivers/i2c/busses/i2c-omap.c | 43 ++--
1 files changed, 24 insertions(+), 19 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 75bf3ad..2d146ac 100644
...@slind.org
CC: linux-i2c@vger.kernel.org
CC: linux-o...@vger.kernel.org
CC: n...@ti.com
Acked-by: Tony Lindgren t...@atomide.com
---
drivers/i2c/busses/i2c-omap.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses
* Cory Maccarrone darkstar6...@gmail.com [100109 10:34]:
On Sat, Jan 9, 2010 at 10:33 AM, Tony Lindgren t...@atomide.com wrote:
Let's plan on adding this into omap-testing branch next week so
we can make sure things are OK for the other platforms.
Then assuming no issues, let's ask Ben
* Cory Maccarrone darkstar6...@gmail.com [100111 17:49]:
On Mon, Jan 11, 2010 at 5:28 PM, Tony Lindgren t...@atomide.com wrote:
Applied to omap-testing with the following fix. Can you please merge
it into your original patch?
Done, I've attached the new patch to here. I've tested
anything.
Then let's ask Ben to queue it.
Regards,
Tony
-Original Message-
From: linux-omap-ow...@vger.kernel.org
[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of
Shilimkar, Santosh
Sent: Friday, February 26, 2010 10:28 AM
To: Tony Lindgren
Cc: ben-li...@fluff.org; linux
* Shilimkar, Santosh santosh.shilim...@ti.com [100227 21:28]:
-Original Message-
From: Tony Lindgren [mailto:t...@atomide.com]
Sent: Sunday, February 28, 2010 2:11 AM
To: Shilimkar, Santosh
Cc: ben-li...@fluff.org; linux-o...@vger.kernel.org;
linux-i2c@vger.kernel.org; Syed
* Kevin Hilman khil...@deeprootsystems.com [100310 10:01]:
Tony Lindgren t...@atomide.com writes:
* Cory Maccarrone darkstar6...@gmail.com [100109 10:34]:
On Sat, Jan 9, 2010 at 10:33 AM, Tony Lindgren t...@atomide.com wrote:
Let's plan on adding this into omap-testing branch next
* Kevin Hilman khil...@deeprootsystems.com [100311 08:36]:
Tony Lindgren t...@atomide.com writes:
Anyways, for the future, considering how critical this driver is
for all omaps.. And considering how badly this driver needs some
updates done..
How about we pile up the i2c-omap patches
* Alexander Shishkin virtu...@slind.org [100316 04:28]:
On Wed, Dec 16, 2009 at 04:02:23 +0200, Alexander Shishkin wrote:
This is to avoid insanely long lines and levels of indentation.
These seem to be forgotten. Is there any problem with these I should address?
Can you please repost and
* Manjunatha GK manj...@ti.com [100413 06:32]:
Under certain rare conditions, I2C_STAT[13].RDR bit may be set
and the corresponding interrupt fire, even there is no data in
the receive FIFO, or the I2C data transfer is still ongoing.
These spurious RDR events must be ignored by the software.
* Ben Dooks ben-li...@fluff.org [100419 17:12]:
On Mon, Apr 19, 2010 at 12:44:22PM +0530, Manjunatha GK wrote:
Under certain rare conditions, I2C_STAT[13].RDR bit may be set
and the corresponding interrupt fire, even there is no data in
the receive FIFO, or the I2C data transfer is still
Hi all,
Here are the i2c-omap patches that we'd like to get in for 2.6.35.
I believe all of these patches have been posted earlier already
to the i2c list. They all have been merged into the linux-omap master
branch for testing.
I've removed some duplicate Cc fields from the commit messages
Reviewed-by: Paul Walmsley p...@pwsan.com
Cc: Cory Maccarrone darkstar6...@gmail.com
Signed-off-by: Tony Lindgren t...@atomide.com
---
drivers/i2c/busses/i2c-omap.c | 146 -
1 files changed, 114 insertions(+), 32 deletions(-)
diff --git a/drivers/i2c/busses
-by: Tony Lindgren t...@atomide.com
---
drivers/i2c/busses/i2c-omap.c | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index ef73483..00fd02e 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c
From: Alexander Shishkin virtu...@slind.org
This is to avoid insanely long lines and levels of indentation.
Signed-off-by: Alexander Shishkin virtu...@slind.org
Cc: Nishant Menon n...@ti.com
Signed-off-by: Tony Lindgren t...@atomide.com
---
drivers/i2c/busses/i2c-omap.c | 43
.
It is applicable for:
1. omap2430
2. omap34xx(including omap3630).
Signed-off-by: Manjunatha GK manj...@ti.com
Cc: Hema Kalliguddi hem...@ti.com
Cc: Nishanth Menon n...@ti.com
Cc: Aaro Koskinen aaro.koski...@nokia.com
Signed-off-by: Tony Lindgren t...@atomide.com
---
drivers/i2c/busses/i2c-omap.c
...@digia.com
Signed-off-by: Kevin Hilman khil...@deeprootsystems.com
Signed-off-by: Tony Lindgren t...@atomide.com
---
arch/arm/plat-omap/i2c.c | 39 +++
drivers/i2c/busses/i2c-omap.c | 24
include/linux/i2c-omap.h |9
know if he should repost.
Acked-by: Tony Lindgren t...@atomide.com
---
drivers/i2c/busses/i2c-omap.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 824ac1c..3271ce1 100644
--- a/drivers/i2c/busses
* Keerthy j-keer...@ti.com [110215 20:53]:
From: Richard woodruff r-woodru...@ti.com
This errata occurs when the ARDY interrupt generation is enabled.
At the begining of every new transaction the ARDY interrupt is cleared.
On continuous i2c transactions where after clearing the ARDY bit
* G, Manjunath Kondaiah manj...@ti.com [110719 09:59]:
On Tue, Jul 19, 2011 at 2:00 AM, Grant Likely grant.lik...@secretlab.ca
wrote:
No, the i2c bus node should still appear in the SoC .dtsi file. If a
board doesn't use a particular i2c bus, then the board.dts file can
add a status =
Hi,
Sorry for the delay, I've been on vacation.
* Ben Dooks ben-...@fluff.org [110802 01:01]:
Hi, should I have been queing these, or is someone else
dealing with the dependencies between the omap arch and
these driver updates?
Yes please. The following fix should go in during the -rc
cycle:
* Shubhrajyoti shubhrajy...@ti.com [111216 00:25]:
Hi Benoit,
On Friday 16 December 2011 02:21 PM, Cousson, Benoit wrote:
Hi Shubhro,
On 12/13/2011 11:55 AM, Shubhrajyoti D wrote:
Under some error conditions the i2c driver may do a reset.
Adding a reset field and support in the
.
For the arch/arm/plat-omap/i2c.c part:
Acked-by: Tony Lindgren t...@atomide.com
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index a882558..45389db 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -43,6 +43,7 @@
#include
* Shubhrajyoti D shubhrajy...@ti.com [120618 07:35]:
The reset in the driver at init is not needed anymore as the
following patch has removed the HWMOD_INIT_NO_RESET flag.
6d3c55f [OMAP: hwmod: fix the i2c-reset timeout during bootup]
This patch does the following
-removes the reset from
* Shubhrajyoti D shubhrajy...@ti.com [120618 07:35]:
From: Jon Hunter jon-hun...@ti.com
The OMAP3530 is based upon the same silicon as the OMAP3430 and so the I2C
revision is the same for 3430 and 3530. However, the OMAP3630 device has the
same I2C revision as OMAP4. Correct the revision
* Shubhrajyoti shubhrajy...@ti.com [120621 00:08]:
On Wednesday 20 June 2012 03:59 PM, Tony Lindgren wrote:
See the comments regarding driver specific resets in hwmod code.
you mean omap_hwmod.c
The way to set this up is to have a shared inline function in
i2c-omap.h that both the driver
* Shubhrajyoti shubhrajy...@ti.com [120621 02:35]:
On Thursday 21 June 2012 12:50 PM, Tony Lindgren wrote:
* Shubhrajyoti shubhrajy...@ti.com [120621 00:08]:
On Wednesday 20 June 2012 03:59 PM, Tony Lindgren wrote:
See the comments regarding driver specific resets in hwmod code.
you mean
this and:
Acked-by: Tony Lindgren t...@atomide.com
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
for this. Other than that it's best to
merge this via the i2c tree:
Acked-by: Tony Lindgren t...@atomide.com
---
Rebased on git://git.pengutronix.de/git/wsa/linux.git, branch
i2c-embedded/for-next
---
arch/arm/plat-omap/i2c.c | 21 -
drivers/i2c/busses/i2c-omap.c | 32
* Kevin Hilman khil...@deeprootsystems.com [121015 10:32]:
Kalle Jokiniemi kalle.jokini...@jollamobile.com writes:
Does not work for me :(
As I said, the issue occurs for me when I enter static suspend (echo mem
/sys/power/autosleep or /sys/power/state). I don't think doing this
just
* Pantelis Antoniou pa...@antoniou-consulting.com [121030 11:04]:
Enable pinctrl for i2c-omap.
Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com
Looks good to me:
Acked-by: Tony Lindgren t...@atomide.com
---
drivers/i2c/busses/i2c-omap.c | 10 ++
1 file changed, 10
* Felipe Balbi ba...@ti.com [121119 04:25]:
On Mon, Nov 19, 2012 at 01:09:42PM +0200, Tomi Valkeinen wrote:
On 2012-11-19 11:27, Felipe Balbi wrote:
fair enough... it looks like this is going nowhere, so best we come back
to this later. No reason to block your patch.
Well, the
* Linus Torvalds torva...@linux-foundation.org [121218 17:07]:
Ugh, guys. Please check this out.
On Tue, Dec 18, 2012 at 3:41 PM, Wolfram Sang w.s...@pengutronix.de wrote:
please pull the i2c-embedded changes for 3.8 which include:
* CBUS driver (an I2C variant)
* continued rework of
* Grygorii Strashko grygorii.stras...@ti.com [130423 06:25]:
Hi
There are two public discussions now related to OMAP boot and drivers
initialization issues:
Multiple issues with omap4 panda es in linux next
http://www.spinics.net/lists/linux-omap/msg90241.html
[BUG] omap: mfd/regulator:
* zhangfei gao zhangfei@gmail.com [130829 04:03]:
On Thu, Aug 29, 2013 at 4:58 PM, Linus Walleij linus.wall...@linaro.org
wrote:
On Wed, Aug 28, 2013 at 11:57 AM, Wolfram Sang w...@the-dreams.de wrote:
On Tue, Aug 20, 2013 at 04:32:28PM +0800, Zhangfei Gao wrote:
Instead of use
* zhangfei gao zhangfei@gmail.com [130829 23:36]:
What about concerns from Wolfram:
Other people might be
depending on subsys_initcall to get I2C active before they want to
activate, say, PMICs. So, I fear regressions, since deferred probing
might not be available in the needed places to
* Wolfram Sang w...@the-dreams.de [131008 14:01]:
On Fri, Aug 30, 2013 at 01:27:13AM -0700, Tony Lindgren wrote:
* zhangfei gao zhangfei@gmail.com [130829 23:36]:
What about concerns from Wolfram:
Other people might be
depending on subsys_initcall to get I2C active before
* Tony Lindgren t...@atomide.com [131008 15:19]:
* Wolfram Sang w...@the-dreams.de [131008 14:01]:
On Fri, Aug 30, 2013 at 01:27:13AM -0700, Tony Lindgren wrote:
* zhangfei gao zhangfei@gmail.com [130829 23:36]:
What about concerns from Wolfram:
Other people might
As we claim to support device tree for mach-omap2, we
should have the necessary flags in the driver to make it
usable.
Cc: Wolfram Sang w...@the-dreams.de
Cc: linux-i2c@vger.kernel.org
Signed-off-by: Tony Lindgren t...@atomide.com
---
If this looks OK, I'd like to merge this as a fix via arm-soc
* Mark Rutland mark.rutl...@arm.com [131114 03:08]:
Please update Documentation/devicetree/bindings/i2c/i2c-omap.txt
Otherwise, this is fine.
Here's this one with updated documentation.
Regards,
Tony
From: Tony Lindgren t...@atomide.com
Date: Wed, 13 Nov 2013 16:36:37 -0800
Subject
* Wolfram Sang w...@the-dreams.de [131113 22:59]:
On Wed, Nov 13, 2013 at 06:35:33PM -0800, Tony Lindgren wrote:
As we claim to support device tree for mach-omap2, we
should have the necessary flags in the driver to make it
usable.
Cc: Wolfram Sang w...@the-dreams.de
Cc: linux-i2c
* Wolfram Sang w...@the-dreams.de [131114 09:49]:
It would have been helpful if the message PATCH [0/x] would have been
sent to the i2c-list also.
Thanks, next time I'll try check the cc list in the cover letter
manually after running git format patch. I guess there's no way
to
* Wolfram Sang w...@the-dreams.de [141124 11:14]:
On Mon, Nov 24, 2014 at 01:10:23PM -0600, Felipe Balbi wrote:
On Mon, Nov 24, 2014 at 11:08:48AM -0800, Kevin Hilman wrote:
On Sat, Nov 22, 2014 at 11:47 AM, Alexander Kochetkov
al.koc...@gmail.com wrote:
In a multimaster environment,
* Alexander Kochetkov al.koc...@gmail.com [141124 11:41]:
24 нояб. 2014 г., в 22:08, Kevin Hilman khil...@kernel.org написал(а):
This patch recently hit linux-next (as commit 903c3859f77f) and boot
breakage[1] in next-20141124 on OMAP3530 Beagle and Overo/Tobi boards
was bisected down
for OMAP3530).
Maybe add Reported-by: credit for Kevin Hilman here?
Other than that, this fixes the problem for me:
Tested-by: Tony Lindgren t...@atomide.com
Signed-off-by: Alexander Kochetkov al.koc...@gmail.com
Fixes: 903c3859f77f9b0aace551da03267ef7a211dbc4
---
drivers/i2c/busses/i2c-omap.c
* Alexander Kochetkov al.koc...@gmail.com [141124 16:11]:
24 нояб. 2014 г., в 23:05, Alexander Kochetkov al.koc...@gmail.com
написал(а):
Something (u-boot, may be) leave the bus in the wrong state.
Really strange.
Actually something wrong with i2c-pullups on i2c.1 bus on fault
* Kevin Hilman khil...@kernel.org [141126 13:27]:
Alexander Kochetkov al.koc...@gmail.com writes:
NOT FOR UPSTREAM
The patch checks if IP reset during probe could bring I2C bus
to a free state on omap2430 - omap3530 boards.
I guess, IP hold one of I2C lines in a low state.
I
* Alexander Kochetkov al.koc...@gmail.com [141128 15:27]:
Hello, Tony!
I just want to know, is multimaster i2c feature is interesting for TI SOC,
so I could send another patches?
Sure and thanks for looking into fixing things.
Or it's better to leave the thing without changes, as current
: omap: resize fifos
before each message
Reported-by: Tony Lindgren t...@atomide.com
I think this is a different issue than what I'm seeing.
Not sure if I've seen what you're describing.. The $subject patch
should be reviewed by Felipe and Aaro, but this does not help
things on 2430.
Regards
* Alexander Kochetkov al.koc...@gmail.com [141203 06:36]:
This pacth series intended for fixing problem reported
by Tony Lindgren t...@atomide.com here[1]
One of first four patched could fix the problem.
Last patch provide event trace so I could resolve problem.
It could be applied using
* Vignesh R vigne...@ti.com [150731 04:00]:
On 07/31/2015 01:44 AM, Dmitry Torokhov wrote:
Instead of having each i2c driver individually parse device tree data in
case it or platform supports separate wakeup interrupt, and handle
enabling and disabling wakeup interrupts in their power
* Dmitry Torokhov dmitry.torok...@gmail.com [150803 13:05]:
On Mon, Aug 03, 2015 at 03:21:21AM -0700, Tony Lindgren wrote:
Hmm why do we need the check for if (device_can_wakeup(client-dev)))?
Because of the code in device_wakeup_attach_irq():
ws = dev-power.wakeup
63 matches
Mail list logo
