Re: [PATCH] I2C driver supporting Moorestown and Medfield platform

2010-10-28 Thread Ben Dooks
On Wed, Oct 27, 2010 at 12:44:03PM +0100, Alan Cox wrote: (Updated to address Ben's comments. With regard to the message segment restriction it's not something we hit on the actual platform so while I will investigate that further I don't think its a blocker to submission. At worst its a

[PATCH] I2C driver supporting Moorestown and Medfield platform

2010-10-27 Thread Alan Cox
(Updated to address Ben's comments. With regard to the message segment restriction it's not something we hit on the actual platform so while I will investigate that further I don't think its a blocker to submission. At worst its a spot over-restrictive) From: Wen Wang wen.w.w...@intel.com

Re: [PATCH] I2C driver supporting Moorestown and Medfield platform

2010-10-26 Thread Jean Delvare
On Fri, 22 Oct 2010 15:05:30 +0100, Alan Cox wrote: I think this now addresses all the points raised in previous review, as well as adding runtime power management support which is needed for MID platforms. Ben, this driver has been floating around for quite some time, I think we really want

Re: [PATCH] I2C driver supporting Moorestown and Medfield platform

2010-10-26 Thread Ben Dooks
On Tue, Oct 26, 2010 at 10:08:00AM +0200, Jean Delvare wrote: On Fri, 22 Oct 2010 15:05:30 +0100, Alan Cox wrote: I think this now addresses all the points raised in previous review, as well as adding runtime power management support which is needed for MID platforms. Ben, this driver

Re: [PATCH] I2C driver supporting Moorestown and Medfield platform

2010-10-26 Thread Ben Dooks
On 22/10/10 15:05, Alan Cox wrote: I think this now addresses all the points raised in previous review, as well I'll go through and have a quick look through this to see if there is anything else to look at. +/* Tables use: 0 Moorestown, 1 Medfield */ +#define NUM_PLATFORMS2 +enum

[PATCH] I2C driver supporting Moorestown and Medfield platform

2010-10-22 Thread Alan Cox
I think this now addresses all the points raised in previous review, as well as adding runtime power management support which is needed for MID platforms. From: Wen Wang wen.w.w...@intel.com Initial release of the driver. Updated and verified on hardware. Cleaned up as follows Alan Cox:

[PATCH] I2C driver supporting Moorestown and Medfield platform

2010-10-14 Thread Alan Cox
From: Wen Wang wen.w.w...@intel.com Initial release of the driver. Updated and verified on hardware. Cleaned up as follows and with fixes backported out of the internal tree for Meego. Alan Cox: Squash down the switches into tables, and use the PCI ident field. We could perhaps take this

[PATCH] I2C driver supporting Moorestown and Medfield platform

2010-10-14 Thread Alan Cox
From: Wen Wang wen.w.w...@intel.com Initial release of the driver. Updated and verified on hardware. Cleaned up as follows and with bits backported from the internal Meego tree Alan Cox: Squash down the switches into tables, and use the PCI ident field. We could perhaps take this further

[PATCH] I2C driver supporting Moorestown and Medfield platform

2010-07-19 Thread Alan Cox
From: Wen Wang wen.w.w...@intel.com Initial release of the driver. Some clean up table removal by Alan Cox Signed-off-by: Wen Wang wen.w.w...@intel.com Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/i2c/busses/Kconfig|9 drivers/i2c/busses/Makefile |1

Re: [PATCH] I2C driver supporting Moorestown and Medfield platform

2010-07-19 Thread Jean Delvare
Hi Alan, On Mon, 19 Jul 2010 11:17:28 +0100, Alan Cox wrote: From: Wen Wang wen.w.w...@intel.com Initial release of the driver. Some clean up table removal by Alan Cox Signed-off-by: Wen Wang wen.w.w...@intel.com Signed-off-by: Alan Cox a...@linux.intel.com ---

[PATCH] I2C driver supporting Moorestown and Medfield platform

2010-07-19 Thread Alan Cox
From: Wen Wang wen.w.w...@intel.com Initial release of the driver. Major clean up by Alan Cox. This fixes the points raised in the initial review except that - some were no longer relevant - speed is left 0/1/2 as specifying exact frequencies uses more command line and makes it more complex