[PATCH] libata: blacklist SAMSUNG HD401LJ / ZZ100-15 for NCQ

2007-07-28 Thread Tejun Heo
SAMSUNG HD401LJ / ZZ100-15 does spurious completion of NCQ commands. Disable NCQ. Reported by Ulrich in bugzilla #8805. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Ulrich [EMAIL PROTECTED] --- And, finally one from samsung. How come vendors got this right previously but screw up on new ones?

Re: errors on shutdown with PMP

2007-07-28 Thread Tejun Heo
Hello, Marc. Marc Bejarano wrote: hi, tejun. i've been using your libata-tj-2.6.22-rc6-20070702 kernel on a centos 4 machine for a while with some 3124's and 3726's. up until today, i hadn't seen any issues. while trying to shut the machine down, this happened: === Jul 27 14:58:44 dell

[PATCH] ide: make CONFIG_IDE_GENERIC default to N

2007-07-28 Thread Tejun Heo
These days, CONFIG_IDE_GENERIC causes more confusion and misconfiguration than it helps. Especially so because libata is linked after the generic driver. Default to N. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- Aye, aye. drivers/ide/Kconfig |3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH] libata: Store bus addresses (versus -mm for testing)

2007-07-28 Thread Tejun Heo
Alan Cox wrote: As we cannot reverse iomap results portably as we tried before the libata layer needs to keep bus addresses around for reporting. This first big patch adds a structure for it and teaches the drivers to keep the information. Thankfully most drivers go via libata-sff and it can

Re: [PATCH] ide: move ide_config_drive_speed() calls to upper layers

2007-07-28 Thread Bartlomiej Zolnierkiewicz
On Friday 27 July 2007, Alan Cox wrote: On Fri, 27 Jul 2007 02:22:27 +0200 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: * Convert {ide_hwif_t,ide_pci_device_t}-host_flag to be u16. * Add IDE_HFLAG_POST_SET_MODE host to indicate the need to program the host for the transfer

Re: [PATCH] use ARRAY_SIZE in ide-cd.c

2007-07-28 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 27 July 2007, Mark Hindley wrote: Hi, ARY_LEN in ide-cd.{c,h} is an unnecessary duplication. Replace with generic ARRAY_SIZE from kernel.h. Seems to be already fixed by: commit 74c8f97a6c2d12fb144ad34076e969e8a01dc4b3 Author: Robert P. J. Day [EMAIL PROTECTED] Date: Mon

Re: [PATCH] libata: Store bus addresses (versus -mm for testing)

2007-07-28 Thread Alan Cox
Eeeek... I don't think this is a good idea. I liked the getting original address from mapped address thing. Is it impossible to get that working on some archs? Or is it just not there yet? Its basically impossible. Either the platform or the libata code would have to keep a copy of the bus

[PATCH] fix IDE legacy mode resource

2007-07-28 Thread Yoichi Yuasa
Hi, I got the following error on MIPS Cobalt. MIPS Cobalt has the 0x1000 offset between resource and bus region. PCI: Unable to reserve I/O region #1:[EMAIL PROTECTED] for device :00:09.1 pata_via :00:09.1: failed to request/iomap BARs for port 0 (errno=-16) PCI: Unable to reserve

Re: [PATCH] ide: make CONFIG_IDE_GENERIC default to N

2007-07-28 Thread Jeff Garzik
Tejun Heo wrote: These days, CONFIG_IDE_GENERIC causes more confusion and misconfiguration than it helps. Especially so because libata is linked after the generic driver. Default to N. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- Aye, aye. drivers/ide/Kconfig |3 +-- 1 file changed, 1

Re: [PATCH] fix IDE legacy mode resource

2007-07-28 Thread Jeff Garzik
Yoichi Yuasa wrote: Hi, I got the following error on MIPS Cobalt. MIPS Cobalt has the 0x1000 offset between resource and bus region. PCI: Unable to reserve I/O region #1:[EMAIL PROTECTED] for device :00:09.1 pata_via :00:09.1: failed to request/iomap BARs for port 0 (errno=-16)

Re: [PATCH] ide: move ide_config_drive_speed() calls to upper layers

2007-07-28 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: On Fri, 27 Jul 2007 02:22:27 +0200 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: * Convert {ide_hwif_t,ide_pci_device_t}-host_flag to be u16. * Add IDE_HFLAG_POST_SET_MODE host to indicate the need to program the host for the transfer mode

[PATCH -mm] Fix libata warnings with CONFIG_PM=n

2007-07-28 Thread Gabriel C
Hi Jeff, I noticed this warnings when CONFIG_PM=n ... drivers/ata/libata-core.c:5993: warning: 'ata_host_disable_link_pm' defined but not used drivers/ata/libata-core.c:6004: warning: 'ata_host_enable_link_pm' defined but not used ... Signed-off-by: Gabriel Craciunescu [EMAIL PROTECTED]

Re: [PATCH] au1xxx: fix au1xxx_set_pio_mode()

2007-07-28 Thread Bartlomiej Zolnierkiewicz
On Thursday 26 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Set transfer mode on the device before programming the host controller for the new timings (matches what auide_tune_chipset() is doing wrt DMA modes). It's not that the most other drives are doing

Re: [PATCH] pdc202xx_new: check ide_config_drive_speed() return value

2007-07-28 Thread Bartlomiej Zolnierkiewicz
On Thursday 26 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] added - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to

Re: [PATCH] ide: make CONFIG_IDE_GENERIC default to N

2007-07-28 Thread Bartlomiej Zolnierkiewicz
On Saturday 28 July 2007, Tejun Heo wrote: These days, CONFIG_IDE_GENERIC causes more confusion and misconfiguration than it helps. Especially so because libata is linked after the generic driver. Default to N. Signed-off-by: Tejun Heo [EMAIL PROTECTED] applied and Jeff's ACK added,

[PATCH] alim15x3: Correct HP detect

2007-07-28 Thread Bartlomiej Zolnierkiewicz
Direct port of Alan's fix for pata_ali. Cc: Alan Cox [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/alim15x3.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ide/pci/alim15x3.c

Re: [PATCH] cs5535: check ide_config_drive_speed() return value

2007-07-28 Thread Bartlomiej Zolnierkiewicz
On Thursday 26 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] added - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to

Re: [2/3] 2.6.23-rc1: known regressions v2

2007-07-28 Thread Bartlomiej Zolnierkiewicz
On Friday 27 July 2007, Michal Piotrowski wrote: IDE Subject : ide problems: 2.6.22-git17 working, 2.6.23-rc1* is not References : http://lkml.org/lkml/2007/7/27/298 Last known good : ? Submitter : dth [EMAIL PROTECTED] Caused-By : ? Handled-By : ? Status