[PATCH] pata_acpi: fix build breakage if !CONFIG_PM

2007-10-17 Thread Tejun Heo
There are configurations where CONFIG_ACPI but !CONFIG_PM. In this case, pata_acpi can be selected but won't build. Fix it. Reported by Avuton Olrich. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Avuton Olrich [EMAIL PROTECTED] --- drivers/ata/pata_acpi.c |2 ++ 1 file changed, 2

Re[2]: Sata Sil3512 bug?; Promise SATA300 TX4

2007-10-17 Thread MisterE
Hello, Wednesday, October 3, 2007, 10:31:17 AM, you wrote: Mikael Pettersson wrote: I'm thinking of replacing both 3512 controllers with a Promise SATA300 TX4. Do you know if there are problems with this device? (please don't top-post) There are no known data-corruption issues with

Re-enabling Serial ATA ports possible?

2007-10-17 Thread Marcin Juszkiewicz
Hi On my system (2.6.23-rc9) I have Serial-ATA DVD/RW drive connected to sata_sil controller. Sometimes when there is a problem with CD or DVD disk controller shutdowns drive: [53560.095573] cdrom: sr0: mrw address space DMA selected [53561.001946] ISO 9660 Extensions: Microsoft Joliet Level 3

Re: Re-enabling Serial ATA ports possible?

2007-10-17 Thread Mikael Pettersson
On Wed, 17 Oct 2007 14:38:04 +0200, Marcin Juszkiewicz wrote: On my system (2.6.23-rc9) I have Serial-ATA DVD/RW drive connected to sata_sil controller. Sometimes when there is a problem with CD or DVD disk controller shutdowns drive: [53560.095573] cdrom: sr0: mrw address space DMA

pata_via refuses to detect one drive

2007-10-17 Thread Michael Tokarev
I tried switching one machine here from old IDE modules to a new pata subsystem today. And it failed, for the first time I ever tried this procedure. Pata_via refuses to recognize one of the drives. Here's the dmesg with via82cxxx (2.6.20): Uniform Multi-Platform E-IDE driver Revision:

Re[2]: Sata Sil3512 bug?; Promise SATA300 TX4

2007-10-17 Thread MisterE
Hello Alexander, Wednesday, October 17, 2007, 2:54:25 PM, you wrote: Log file got lost. Please post relevant parts inline. Sorry, i totally forgot to include them. I can not reproduce the errors. Last times hda did not give errors. So i'm not sure if it is related to each other. (in the thread

pata_via(?): cdrom is recognized as hard drive

2007-10-17 Thread Michael Tokarev
And one more issue with my attempt to switch from via82cxxx to pata_via. I noticied that on all machines I tried to convert, CD-Rom devices are recognized as hard disks. With via82cxxx and ide-cd, it was like hdc: IDE cdrom model=FX4830T s/n=4JV6F7Q4 fw=8.01 udma5 But with pata_via and 2.6.23,

Re: pata_via refuses to detect one drive

2007-10-17 Thread Alan Cox
Oct 17 18:30:59 linux kernel: ata2: port is slow to respond, please be patient (Status 0x80) Oct 17 18:30:59 linux kernel: ata2: SRST failed (errno=-16) So it failed to reset and come back to sanity. Oct 17 18:30:59 linux kernel: ata2.01: ATAPI: FX4830T, R02E, max UDMA/33 Oct 17 18:30:59

Anyone else out there have an ExpressCard to try?

2007-10-17 Thread Mark Lord
I have a Dell Inspiron 9400 with an external ExpressCard slot. I've also got a Bytecc 2-port eSATA ExpressCard-34 that identifies as: Silicon Image, Inc. SiI 3132 Serial ATA Raid II Controller (rev 01) To get it to work with Linux on my Dell notebook, the pcihp_force=1 parameter is necessary

FW: LIBATA issue with SATA drive

2007-10-17 Thread Ip, Clarence
Hello Tejun, I've CC'd the mailing list, but couldn't find Torsten's e-mail. Do you have any suggestions on where I should look for this problem? Did the boot-up log suggest anything to you? - Clarence -Original Message- From: Tejun Heo [mailto:[EMAIL PROTECTED] Sent: Wednesday,

Re: pata_via(?): cdrom is recognized as hard drive

2007-10-17 Thread Alan Cox
On Wed, 17 Oct 2007 19:35:52 +0400 Michael Tokarev [EMAIL PROTECTED] wrote: And one more issue with my attempt to switch from via82cxxx to pata_via. I noticied that on all machines I tried to convert, CD-Rom devices are recognized as hard disks. Thats deeply weird. But with pata_via and

Re: [PATCH 6/12] ide: add struct ide_taskfile

2007-10-17 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Don't set write-only ide_task_t.hobRegister[6] and ide_task_t.hobRegister[7] in idedisk_set_max_address_ext(). * Add struct ide_taskfile and use it in ide_task_t instead of tfRegister[] and hobRegister[]. * Remove no longer needed

Re: [PATCH 5/12] ide: remove task_ioreg_t typedef

2007-10-17 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Remove task_ioreg_t typedef from the kernel code (but leave it in linux/hdreg.h for #ifndef/#endif __KERNEL__ case). While at it also move sata_ioreg_t typedef under #ifndef/#endif __KERNEL__. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]

Re: pata_via refuses to detect one drive

2007-10-17 Thread Michael Tokarev
Alan Cox wrote: Oct 17 18:30:59 linux kernel: ata2: port is slow to respond, please be patient (Status 0x80) Oct 17 18:30:59 linux kernel: ata2: SRST failed (errno=-16) So it failed to reset and come back to sanity. Oct 17 18:30:59 linux kernel: ata2.01: ATAPI: FX4830T, R02E, max UDMA/33

Re: Fwd: CMD 64x regression from 2.6.21 to 2.6.22 and 2.6.23?

2007-10-17 Thread Martin Rogge
On Wednesday 17 October 2007 00:14:26 Bartlomiej Zolnierkiewicz wrote: Martin, could you run git-bisect (http://kerneltrap.org/node/11753 - sorry for not explaining the procudure myself but Linus did it really well) starting with: git bisect good

Re: Sata Sil3512 bug?; Promise SATA300 TX4

2007-10-17 Thread Peter Favrholdt
Hi, MisterE wrote: Tonight i will try the Asus motherboard with 1 drive and much I/O. And i will create a new array which takes 7 hours. But how often/hours do you need to try something to prove it does not fail :P On one box I had problems with the SATA300 TX4 using 2.6.21 through 2.6.22

Re: [git patch] libata build fix

2007-10-17 Thread Martin K. Petersen
BZ == Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] writes: BZ We probably need also this one for pata_cs5536: BZ [PATCH] pata_cs5536: MWDMA fix BZ * Fix out-of-bound array access for MWDMA modes. BZ * Bump driver version. Obviously correct. Acked-by: Martin K. Petersen [EMAIL PROTECTED]

western digital WD1500ADFD: spurious completions during NCQ

2007-10-17 Thread Jeff Garrett
Several threads that suggest this message is related to poor NCQ support, but I did not see any for this drive. It's a Western Digital WD1500ADFD-00NLR1. Is this the same thing, and should this drive be blacklisted? ata1.00: exception Emask 0x2 SAct 0x1f1 SErr 0x0 action 0x2 frozen ata1.00:

Re: pata_via refuses to detect one drive

2007-10-17 Thread Alan Cox
This looks like both drives end up trying to be the slave ? Its certainly very vey confused at this point. Interesting it works with the BIOS doing the reset, wonder what the difference is. Not only it works with BIOS, it also works with via82cxxx just fine. The via82cxxx driver doesn't

Re: Fwd: CMD 64x regression from 2.6.21 to 2.6.22 and 2.6.23?

2007-10-17 Thread Sergei Shtylyov
Hello. Martin Rogge wrote: Martin, could you run git-bisect (http://kerneltrap.org/node/11753 - sorry for not explaining the procudure myself but Linus did it really well) starting with: git bisect good 688a87d145e04f6761c63e7f2e19fd9b3e4ca060 git bisect bad

Fixed my email

2007-10-17 Thread Jeff Garzik
Apologies to those who sent me email in the past 12 hours -- there was a mail loop apparently. Should be fixed now, but anything you sent has likely been lost. Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED]

[PATCH] ata: ahci: Enable enclosure management via LED

2007-10-17 Thread Kristen Carlson Accardi
Enable enclosure management via LED As described in the AHCI spec, some AHCI controllers may support Enclosure management via a variety of protocols. This patch adds support for the LED message type that is specified in AHCI 1.1 and higher. Signed-off-by: Kristen Carlson Accardi [EMAIL

[PATCH 0/3] ide: Fix use of paired device

2007-10-17 Thread Benjamin Herrenschmidt
At least 2 drivers (siimage and cs5535) have a bug where they use the construct: ide_drive_t *pair = hwif-drives[drive-dn ^ 1]; To access the other drive in a master/slave pair. This is bogus because drive-dn is not the unit number, but the global drive number, thus can be 2 3 for

[PATCH 2/3] ide: Fix siimage driver accessing beyond array boundary

2007-10-17 Thread Benjamin Herrenschmidt
The siimage use an incorrect construct to access the other drive of a pair, causing it to access beyond an array boundary on non-0 interfaces. This fixes it by using the new ide_get_paired_drive() hepler instead. Signed-off-by: Benjamin Herrenschmidt [EMAIL PROTECTED] ---

[PATCH 3/3] ide: Fix cs5535 driver accessing beyond array boundary

2007-10-17 Thread Benjamin Herrenschmidt
The cs5535 use an incorrect construct to access the other drive of a pair, causing it to access beyond an array boundary on non-0 interfaces. This fixes it by using the new ide_get_paired_drive() hepler instead. Signed-off-by: Benjamin Herrenschmidt [EMAIL PROTECTED] ---

Re: [PATCH] pata_acpi: fix build breakage if !CONFIG_PM

2007-10-17 Thread Jeff Garzik
Tejun Heo wrote: There are configurations where CONFIG_ACPI but !CONFIG_PM. In this case, pata_acpi can be selected but won't build. Fix it. Reported by Avuton Olrich. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Avuton Olrich [EMAIL PROTECTED] --- drivers/ata/pata_acpi.c |2 ++ 1

Re: [PATCH v3] drivers/ata: add support to Freescale 3.0Gbps SATA Controller

2007-10-17 Thread Jeff Garzik
Li Yang wrote: This patch adds support for Freescale 3.0Gbps SATA Controller supporting Native Command Queueing(NCQ), device hotplug, and ATAPI. This controller can be found on MPC8315 and MPC8378. Signed-off-by: Ashish Kalra [EMAIL PROTECTED] Signed-off-by: Li Yang [EMAIL PROTECTED] ---

Re: [PATCH] libata-sff: Correct use of check_status()

2007-10-17 Thread Jeff Garzik
Alan Cox wrote: ata_check_status() does an SFF compliant check ata_chk_status() does a generic call to ap-ops-check_status (usually ata_check_status) libata-sff uses the wrong one. Hardly suprising given the naming here, which ought to get fixed to ata_sff_check_status() perhaps ?

Re: [PATCH] Update libata driver for bf548 atapi controller against the 2.6.24 tree.

2007-10-17 Thread Jeff Garzik
Sonic Zhang wrote: Changes: 1. Remove irq_ack() and port_disable() methods 2. Acocomodate for the libata-link patches 3. Change Kconfig ATAPI mode option into a module param. 4. Add supported WMDMA mode. Signed-off-by: Sonic Zhang [EMAIL PROTECTED] applied - To unsubscribe from this list:

[git patches] libata fixes

2007-10-17 Thread Jeff Garzik
Well, the new driver is not a fix. Anyway -- still plugging away at debugging libata. It seems some outside changes are causing a bunch of my test boxes to crap themselves. These need to go up in the meantime, however. Maybe its the sg-chaining stuff, we'll see. I'm watching that thread

Re: Inquiry data and emulated SG devices

2007-10-17 Thread Robert Hancock
(cc-ing linux-ide) Mathieu Fluhr wrote: Hello all, First of all, let me introduce myself a little bit. I am the responsable for the development of the Nero Linux burning application. So I have access to all the source code of the application. Now let's go with the story: It seems that there

Re: [PATCH #upstream 1/2] libata: move command post processing to __ata_qc_complete()

2007-10-17 Thread Jeff Garzik
Tejun Heo wrote: Jeff Garzik wrote: Tejun Heo wrote: Some commands need post-processing after successful completion. This was done in ata_scsi_qc_complete() till now but command post processing doesn't belong to SAT layer. Move them to __ata_qc_complete() and, while at it, restructure a bit

Re: Inquiry data and emulated SG devices

2007-10-17 Thread Jeff Garzik
Robert Hancock wrote: This doesn't seem a very reliable way to identify an IDE device, as all that 0 means is that the device does not claim conformance to any standard. I would think it would be legitimate for an IDE device to put a value like 5 in there as well, if it complies with SPC-4..

[PATCH] sata_sis: fix SCR read breakage

2007-10-17 Thread Tejun Heo
SCR read for controllers which uses PCI configuration space for SCR access got broken while adding @val argument to SCR accessors. Fix it. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/sata_sis.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git

Re: Sata Sil3512 bug?

2007-10-17 Thread Tejun Heo
MisterE wrote: Oct 13 13:01:26 fileserver kernel: ata4.00: exception Emask 0x0 SAct 0x0 SErr 0x240 action 0x0 Oct 13 13:01:26 fileserver kernel: ata4.00: (BMDMA2 stat 0x650001) Oct 13 13:01:26 fileserver kernel: ata4.00: cmd ca/00:f8:47:e1:5e/00:00:00:00:00/e4 tag 0 cdb 0x0 data 126976

Re: FW: LIBATA issue with SATA drive

2007-10-17 Thread Tejun Heo
Hello, all. Torsten, Clarence is reporting similar problem on 2.6.22. The original message follows. I'm using the 2.6.22 sources with a Sii3132 SATA controller and a Seagate HDD. What I've noticed is that it often fails to boot with this configuration. Warm boots appear to always fail while

Re: [PATCH #upstream 1/2] libata: move command post processing to __ata_qc_complete()

2007-10-17 Thread Bruce Allen
BTW, while doing the TEST UNIT READY emulation patch for ATA (recently withdrawn from libata-dev.git#upstream), I found a problem with the interface that was difficult to get around: TEST UNIT READY simulation code really wants to look at the result TF of CHECK POWER MODE, even if ATA_ERR is

seagate disks on sil3114 - slow?

2007-10-17 Thread Soeren Sonnenburg
Dear all, I just now realize that all disk i.o. on my machine is quite slow compared with the pata disks I had before. Furthermore I recognized that I only have seagates (ST3400832AS,ST3400620AS,ST3750640AS,ST3750640AS) connected to a sil3114 controller. Being on kernel 2.6.23.1 and stumbling