Re: Bart's efforts?

Mikael Pettersson writes: On Sat, 3 Nov 2007 14:10:22 +, Alan Cox wrote: My question is if the drivers/ide infrastructure is slowly moving in the direction of being leverageable by libata when/if it moves out of scsi. Or does the drivers/ide code simply have the wrong kind of

Re: [PATCH 7/18] ide: add ide_tf_read() helper

Bartlomiej Zolnierkiewicz wrote: * Factor out code reading taskfile registers from ide_end_drive_cmd() to the new ide_tf_read() helper. * Add IDE_TFLAG_IN_* taskfile flags to indicate the need to load particular IDE taskfile register in ide_tf_read(). * Update ide_end_drive_cmd() to

[PATCH] cmd64x: don't clear the other channels interrupt

Make sure to not clear the other IDE channel's interrupt when clearing an IDE interrupt via the MRDMODE register. Thanks to Bart for finding a coding mistake. --- The patch is against the Linus tree. drivers/ide/pci/cmd64x.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)

Re: [PATCH] Don't fail ata device revalidation for bad _GTF methods

I can confirm that this patch solves the problem with s2ram on my laptop. R Matthew Garrett wrote: Experience suggests that the _GTF method may be bad. We currently fail device revalidation in that case, which seems excessive. Signed-off-by: Matthew Garrett [EMAIL PROTECTED] --- diff --git

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

On Thu, 8 Nov 2007 22:46:22 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: On Thu, Nov 08, 2007 at 10:29:37PM -0500, Mark Lord wrote: And I might even privately patch my own kernels to map the ACHI BAR in the cases where the BIOS didn't... The inability to do this in the general case is the

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

On Thu, Nov 08, 2007 at 09:31:30PM -0500, Jeff Garzik wrote: On Fri, Nov 09, 2007 at 09:02:35AM +0700, Riki Oktarianto wrote: Some BIOSen map AHCI ABAR but lock the SATA controller to IDE mode. This patch add quirk to set AHCI mode on ICH board with such case. Tested on Macbook2,1

Re: FIS structure and Command List structure for AHCI SATA controller

Hi Jeff, Actually I am using Marvell's 88SE6121 on kernel 2.4. I just wonder do I have to enable the FIS? The SATA Command Table of the device have following definitions: 00h Command FIS 40h ATAPI Command (CDB) 60h RSVD 80h Physical Region Descriptor Table Does it mean I can only use FIS or

Re: [PATCH 3/15] ide: remove ata_status_t and atapi_status_t

Bartlomiej Zolnierkiewicz wrote: Remove ata_status_t (unused) and atapi_status_t. While at it: * replace 'HWIF(drive)' by 'drive-hwif' (or just 'hwif' where possible) Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To

Re: [PATCH 8/15] ide-cd: fix register loading order in cdrom_start_packet_command()

Bartlomiej Zolnierkiewicz wrote: Load IDE_CONTROL_REG before other registers in cdrom_start_packet_command(). It shouldn't affect anything (just a usual paranoia to separate changes which change the way in which hardware is accessed from code cleanups). While at it move misplaced FIXME

Re: [PATCH 15/15] ide: remove 'tf_in_flags' field from ide_task_t

Bartlomiej Zolnierkiewicz wrote: * Add IDE_TFLAG_IN_DATA taskfile flag to indicate the need of reading IDE_DATA_REG in ide_end_drive_cmd(). Set the new flag in ide_taskfile_ioctl() if -in_flags.b.data is set. * Add IDE_TFLAG_FLAGGED_SET_IN_FLAGS taskfile flag to indicate the need of

Re: [PATCH 3/9] ide: merge flagged_taskfile() into do_rw_taskfile()

Bartlomiej Zolnierkiewicz wrote: Based on the earlier work by Tejun Heo. task-data_phase == TASKFILE_MULTI_{IN,OUT} vs drive-mult_count == 0 check is needed also for ide_taskfile_ioctl() requests that don't have IDE_TFLAG_FLAGGED taskfile flag set. Cc: Tejun Heo [EMAIL PROTECTED]

Re: [PATCH 7/9] ide-disk: extend timeout for PIO-in commands

Bartlomiej Zolnierkiewicz wrote: s/WAIT_CMD/WAIT_WORSTCASE/ to make the timeout the same as in do_rw_taskfile() Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

Alan Cox wrote: On Thu, 8 Nov 2007 22:46:22 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: On Thu, Nov 08, 2007 at 10:29:37PM -0500, Mark Lord wrote: And I might even privately patch my own kernels to map the ACHI BAR in the cases where the BIOS didn't... The inability to do

Re: pata_serverworks hangs

On Fri, 2 Nov 2007, Jeff Garzik wrote: Krzysztof Oledzki wrote: Hello, I just tried to switch from old IDE to libata but unfortunately kernel (2.6.22.10) hangs during boot: does 2.6.23.1 or 2.6.24-rc1 work? No. :( I checked 2.6.23.1 and 2.6.24-rc2 (with recent Alan's pata_serverworks

Re: [PATCH 4/9] ide: convert do_rw_taskfile() to use -data_phase

Bartlomiej Zolnierkiewicz wrote: * Use task-data_phase in do_rw_taskfile() to decide what to do. * task-prehandler is only used by TASKFILE[_MULTI]_OUT so just use pre_task_out_intr() directly and remove no longer needed 'prehandler' field from ide_task_t. * Remove no longer needed

Re: [PATCH 10/15] ide: add ide_pktcmd_tf_load() helper

Bartlomiej Zolnierkiewicz wrote: Add ide_pktcmd_tf_load() helper and convert ATAPI device drivers to use it. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

On Fri, Nov 09, 2007 at 04:49:16PM +0200, Török Edwin wrote: There is one problem with force enabling ahci. You'll loose the CDROM on Dell laptops. Prior to force-enabling ahci there is one device that sees the 2 sata channels, and the 2 ide channels. When you force-enable ahci, this device

Correction Re: Bug is fixed in 2.6.23.1: sata_promise: port is slow to respond, reset failed

Hi, I previously wrote this issue was fixed by upgrading to 2.6.23.1 There were some mails on this list regarding a workaround for an Asic bug and of course I'm looking forward to trying it :-) Anyway here goes for completeness: * 2.6.23.1 completed dd-stress tests as described earlier

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

Alan Cox wrote: On Thu, 8 Nov 2007 22:46:22 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: On Thu, Nov 08, 2007 at 10:29:37PM -0500, Mark Lord wrote: And I might even privately patch my own kernels to map the ACHI BAR in the cases where the BIOS didn't... The inability to do this in the general

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

Matthias Schniedermeyer wrote: And on the topic of broken BIOSes. I have a little empathy for the MB manufactures as non-RAID AHCI royaly screws Windos, so not supporting it reduces their support costs enough to overlook screwing the non-windos faction. non-RAID AHCI works just fine on

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

On Fri, Nov 09, 2007 at 10:05:05PM -0500, Jeff Garzik wrote: By forcing AHCI, your PATA devices will be inaccessible, in a common configuration. It also means shuffling users from one driver to another, which induces breakage. I was speaking wishfully. Real life intrudes, alas. Not even

Re: [PATCH] sata_nv,ahci: add the ahci legacy mode support to sata_nv

Jeff Garzik wrote: The proposed sata_nv patch does the opposite -- guarantees we must support the continually problematic legacy IDE interface ad infinitum. Such patches are OK for the test lab, but in this specific case users /suffer/ when not running AHCI mode. Just to reinforce...