Re: Subject: [PATCH 1/3] Let scsi_cmnd-cmnd use request-cmd buffer

2008-02-12 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 09:05:17PM +0200, Boaz Harrosh wrote: - Lots of drivers still use MAX_COMMAND_SIZE. So I have left that #define but equate it to BLK_MAX_CDB. The way I see it and is reflected in the patch below is. MAX_COMMAND_SIZE - means: The longest fixed-length (*) SCSI CDB

Re: [PATCH 2/3] block layer varlen-cdb

2008-02-12 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 09:09:41PM +0200, Boaz Harrosh wrote: - add varlen_cdb and varlen_cdb_len to hold a large user cdb if needed. They start as empty. Allocation of buffer must be done by user and held until request execution is done. - Since there can be either a fix_length command up

Re: Current git -- kaboom [bisect] seems IDE related.

2008-02-10 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 02:38:46PM +0100, Bartlomiej Zolnierkiewicz wrote: The OOPS is most likely (again) my fault - I was rushing out to push out the fix and memset() line didn't get converted. The new patch works fine for me. I prepared the new patch, documented it and started looking into

Re: Current git -- kaboom [bisect] seems IDE related.

2008-02-09 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 12:06:10AM +0100, Bartlomiej Zolnierkiewicz wrote: Please try booting with hdx=noflush kernel parameter or please try the attached patch which should fix the issue (if my theory is correct). hda=noflush hdb=noflush hdd=noflush fixes the qemu setup for me. Thanks, I

current mainline ide doesn't like qemu/kvm (or vice versa)

2008-02-08 Thread Christoph Hellwig
When trying to put some stress on qemu by running the xfs testsuite I get the following: debian:~/xfs-cmds/xfstests# sh check [ 438.166822] SGI XFS with ACLs, security attributes, realtime, large block numbers, no debug enabled [ 438.185557] SGI XFS Quota Management subsystem [ 438.193150]

Re: [PATCH 2/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-16 Thread Christoph Hellwig
On Sun, Dec 16, 2007 at 06:50:19PM +0900, Paul Mundt wrote: +static irqreturn_t gdrom_command_interrupt(int irq, void *dev_id) +{ + if (dev_id != gd) + return IRQ_NONE; You aren't setting this up as a shared IRQ, so this shouldn't be necessary. It's not nessecary for

Re: request_queue_t depends on CONFIG_BLOCK

2007-03-22 Thread Christoph Hellwig
On Thu, Mar 22, 2007 at 10:52:34PM +0100, Olaf Hering wrote: How can this compile error be fixed properly? request_queue_t is inside CONFIG_BLOCK, ide_drive_s (and likely others) use it unconditionally. CC arch/powerpc/kernel/setup_64.o In file included from

Re: [PATCH scsi-misc-2.6] SCSI: kill sht-suspend/resume

2007-03-21 Thread Christoph Hellwig
driver callbacks). This patch removes sht-suspend/resume() callbacks. This change is suggested by Christoph Hellwig. Very nice, as the rest of the series. Thanks a lot Tejun. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED

Re: [PATCH 3/4] libata: reimplement suspend/resume support using sdev-manage_start_stop

2007-03-20 Thread Christoph Hellwig
On Wed, Mar 21, 2007 at 12:25:33AM +0900, Tejun Heo wrote: Reimplement suspend/resume support using sdev-manage_start_stop. * Device suspend/resume is now SCSI layer's responsibility and the code is simplified a lot. Finally. I've been telling people to do it this way forever. Can you

Re: impact of 4k sector size on the IO FS stack

2007-03-12 Thread Christoph Hellwig
On Mon, Mar 12, 2007 at 10:45:16AM -0400, Jeff Garzik wrote: Christoph Hellwig wrote: the occasional 2k sector SCSI MO device aswell. It would be nice to get samples of large sector size ATA devices into the hands of developers to do real world testing of the whole stack. hands

Re: [PATCH 2.6.13] libata: Marvell SATA support (PIO mode)

2005-09-01 Thread Christoph Hellwig
+#include linux/kernel.h +#include linux/module.h +#include linux/pci.h +#include linux/init.h +#include linux/blkdev.h +#include linux/delay.h +#include linux/interrupt.h +#include linux/sched.h +#include linux/dma-mapping.h +#include scsi.h pleaese don't include scsi.h in new drivers.

Re: [PATCH 2.6.13] libata: Marvell SATA support (PIO mode)

2005-09-01 Thread Christoph Hellwig
On Thu, Sep 01, 2005 at 04:03:27PM -0400, Jeff Garzik wrote: Christoph Hellwig wrote: On Thu, Sep 01, 2005 at 03:48:51PM -0400, Jeff Garzik wrote: Christoph Hellwig wrote: +#include linux/kernel.h +#include linux/module.h +#include linux/pci.h +#include linux/init.h +#include linux

Re: libata: clustering on or off?

2005-08-28 Thread Christoph Hellwig
On Sun, Aug 28, 2005 at 04:20:19PM +0200, Jens Axboe wrote: Agree, we should just remove the ability to control clustering, as it really overlaps with the segment settings anyways. What are we going to do with iscsi then? It really doesn't like segments over a pages size. Best thing would

Re: Another libata TODO item

2005-08-24 Thread Christoph Hellwig
On Wed, Aug 24, 2005 at 02:17:11AM -0400, Jeff Garzik wrote: Difficulty: beginner / intermediate Modern network drivers have a per-NIC list of debugging messages that can be enabled/disabled at runtime, implemented as a bitmask named 'msg_enable' in each driver. VERY useful for tracing

[PATCH] kill asm/hdreg.h

2005-03-29 Thread Christoph Hellwig
I just found a patch in the SuSE tree that changes ide_ioreg_t for ia64, and checking for the implications I noticed ide_ioreg_t and hdreg.h have been completely unused for a while, and the headers have a #warning. So let's kill them for good: --- 1.3/include/asm-alpha/hdreg.h 2004-04-14