James Bottomley wrote:
On Mon, 2008-02-25 at 10:34 -0600, Brian King wrote:
The new libata-eh is used for more than just EH. It is used for device
probing, device revalidation, and power management. It is also woken for
all command failures and is where the request sense for ATAPI devices is
Michael S. Tsirkin wrote:
git bisect points at this commit:
commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2.
power_state: get rid of write-only variable in SATA
Hello Pavel --
It looks like this not a write-only variable after all...
Jeff
-
To unsubscribe from this list: send the
/libata.h |1 -
2 files changed, 4 insertions(+), 2 deletions(-)
Adrian Bunk (1):
make atapi_dmadir static
Jeff Garzik (1):
Revert power_state: get rid of write-only variable in SATA
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index fbc2435..4fbcce7 100644
Mark Lord wrote:
Pavel Machek wrote:
This is a patch (very ugly, assumes you have just one disk) to bring
powersaving to AHCI. You need Alan's SCSI autosuspend (attached) patch
as a base.
It saves .5W compared to config with disk spinning, and even .15W
compared to hdparm -y... on my thinkpad
chaoyang wang wrote:
Dear Jeff,
I was looking at the kernel 2.6.21 code of the achi driver and found
that the sg_table_size was set to 168, while the libata set the maximum
sg to be 128 somewhere else. When a requester issues a request with 128
sgs to the ahci attached device, the system
Saumendra Dash wrote:
Hi Jeff,
I'm working on ULI1575 SATA driver which I want to run in Emulated-PATA
mode.
I have the following understanding to run a SATA device in
Emulated-PATA mode:
1. In Emulated-PATA mode the legacy IDE driver should access the SATA
device directly in combined
Jon Li wrote:
Hello,
I am curious as to whether there are plans to add support for integrated
sata devices. I personally want to add support for a 60x1C0 based
device (pci:id = 0x5182). I think adding support should be relatively
simple, except for a few issues outlined below.
In the
Elias Oltmanns wrote:
The general idea: A daemon running in user space monitors input data
from an accelerometer. When the daemon detects a critical condition,
i.e., a sudden acceleration (for instance, laptop slides off the desk),
it signals the kernel so the hard disk may be put into a (more)
Mark Lord wrote:
Jeff Garzik wrote:
Jon Li wrote:
Hello,
I am curious as to whether there are plans to add support for integrated
sata devices. I personally want to add support for a 60x1C0 based
device (pci:id = 0x5182). I think adding support should be relatively
simple, except for a few
As an aside, ISTR tomo-san was working on eliminating the need for the
/2 by tackling the details on the IOMMU side...
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Mark Lord wrote:
Jeff Garzik wrote:
Tejun Heo wrote:
Yeah, exactly. I think what needs to be done is to separate out SFF
assumptions from core layer, factor out SFF-proper helpers and use them
to implement LLDs for quasi-SFF controllers.
Thinking long term, I continue to hope that SFF
To repeat myself from threads past...
In particular with the Marvell 6440 (SATA/SAS, drivers/scsi/mvsas.c)
when SATA PMP support is completed, we will want to look at passing
things other than normal ATA commands via -qc_issue.
Although selection isn't necessarily, talking to a PMP is
Pavel Machek wrote:
power_state is scheduled for removal, and libata uses it in write-only
mode. Remove it.
Signed-off-by: Pavel Machek [EMAIL PROTECTED]
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index b4985bc..a31572d 100644
--- a/drivers/ata/libata-core.c
+++
Tejun Heo wrote:
Back in 2.6.17-rc2, a libata module parameter was added for atapi_dmadir.
That's nice, but most SATA devices which need it will tell us about it
in their IDENTIFY PACKET response, as bit-15 of word-62 of the
returned data (as per ATA7, ATA8 specifications).
So for those which
Mark Lord wrote:
Mark Lord wrote:
Tejun Heo wrote:
Hello, Mark.
Mark Lord wrote:
Tejun, I've added PMP to sata_mv, and am now trying to get it
to work with a Marvell PM attached.
And the behaviour I see is very bizarre.
After hard+soft resets, the PM signature is found,
and libata
Shane Huang wrote:
Jeff and Tejun:
I'm using my private mailbox to submit it before I set up
the connection to our exchange mail server under linux.
Please check whether this patch can be accepted.
Thanks
Shane
CUT HERE
SB700 SATA controller can support 64 bit DMA, the previous
Anton Vorontsov wrote:
This patch fixes build and few warnings when ATA_VERBOSE_DEBUG
is defined:
CC drivers/ata/sata_fsl.o
drivers/ata/sata_fsl.c: In function ‘sata_fsl_fill_sg’:
drivers/ata/sata_fsl.c:338: warning: format ‘%x’ expects type ‘unsigned int’,
but argument 3 has type ‘void
Randy Dunlap wrote:
From: Randy Dunlap [EMAIL PROTECTED]
Fix libata-core kernel-doc warning:
Warning(linux-2.6.25-rc2-git6//drivers/ata/libata-core.c:168): No description
found for parameter 'ap'
Signed-off-by: Randy Dunlap [EMAIL PROTECTED]
---
drivers/ata/libata-core.c |2 +-
1 file
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/ahci.c| 23 +--
drivers/ata/libata-core.c | 16 ++--
drivers/ata/libata-pmp.c
Tejun Heo wrote:
Yeah, exactly. I think what needs to be done is to separate out SFF
assumptions from core layer, factor out SFF-proper helpers and use them
to implement LLDs for quasi-SFF controllers.
Thinking long term, I continue to hope that SFF support can eventually
be separate into a
Mark Lord wrote:
Albert Lee wrote:
Tejun Heo wrote:
Back in 2.6.17-rc2, a libata module parameter was added for
atapi_dmadir.
That's nice, but most SATA devices which need it will tell us about it
in their IDENTIFY PACKET response, as bit-15 of word-62 of the
returned data (as per ATA7, ATA8
Anders Eriksson wrote:
Hi,
Trying out 2.6.25-rc2 smartd always causes my box to hang. I can switch
vt:s and the keyboard seems to work.
Using sysrq-e I noticed a callpath open - ext3 - journals - sync_buffer -
io_scheduel - generic_unplig_device.
I'd guess the open stems from smartd.
Anders Eriksson wrote:
Is smartd prepared to handle /dev/sdX style devices?
Yes. You need to pass -d ata to smartd and smartctl, if your scripts
are not already doing so.
If this is the prefered driver these days, maybe it shouldn't be marked
experimental in the menu anymore?
It's not
Tejun Heo wrote:
Yeah, this is an interesting problem. There are basically multiple sets
of TF registers and the SFF way of assuming single set doesn't really
work well and I don't really think adding -pmp_read/write is the
correct long term solution to the problem. We need to confine direct
Pavel Machek wrote:
power_state is scheduled for removal, and libata uses it in write-only
mode. Remove it.
Signed-off-by: Pavel Machek [EMAIL PROTECTED]
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index b4985bc..a31572d 100644
--- a/drivers/ata/libata-core.c
+++
Huang, Shane wrote:
OMG, but I modified my settings and verified that the patch can really
work here before I sent it to you...
It's word-wrapping, and also quoting a bunch of characters, which make
it difficult for tools to pick up:
@ -85,6 +85,7 @@
board_ahci_ign_iferr=3D 2,
Harvey Harrison wrote:
Use ld_qdi and ld_winbond to avoid shadowing static int
variables qdi and winbond. The ld_ prefix refers to
legacy_data.
drivers/ata/pata_legacy.c:777:21: warning: symbol 'qdi' shadows an earlier one
drivers/ata/pata_legacy.c:128:12: originally declared here
Martin Michlmayr wrote:
The sata_mv driver can be loaded as a platform device, as is done by
various Orion (ARM) based devices. The driver needs to define a module
alias for the platform driver so udev will load it automatically.
Tested with Debian on a QNAP TS-209.
Signed-off-by: Martin
Saeed Bishara wrote:
this fixes crash bug as the iomap table is not valid for integrated controllers.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
drivers/ata/sata_mv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
Harvey Harrison wrote:
Avoids lots of these, also is more readable.
include/linux/libata.h:1210:13: warning: potentially expensive pointer
subtraction
Change the subtraction to addition on the other side of the comparison.
Thanks to Christer Weinigel for the suggestion.
Signed-off-by: Harvey
Mark Lord wrote:
Back in 2.6.17-rc2, a libata module parameter was added for atapi_dmadir.
That's nice, but most SATA devices which need it will tell us about it
in their IDENTIFY PACKET response, as bit-15 of word-62 of the
returned data (as per ATA7, ATA8 specifications).
So for those which
Saeed Bishara wrote:
this will fix crash bug when doing rmmod to the driver, this is because the
port_stop function get called later and it could access the device's registers.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
drivers/ata/sata_mv.c |6 ++
1 files changed, 2
Note: Tejun's change is a feature addition, but one that is IMO
important for debugging and serious-bug workarounds. It's
self-contained and should not affect anyone not using the new parm.
Please pull from 'upstream-linus' branch of
Randy Dunlap wrote:
From: Randy Dunlap [EMAIL PROTECTED]
Fix libata kernel-doc parameter:
Warning(linux-2.6.25-rc2-git3//drivers/ata/libata-scsi.c:845): No description
found for parameter 'rq'
Signed-off-by: Randy Dunlap [EMAIL PROTECTED]
---
drivers/ata/libata-scsi.c |2 +-
1 file
Harvey Harrison wrote:
diff --git a/include/linux/libata.h b/include/linux/libata.h
index 2845983..f0e1178 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -1211,7 +1211,7 @@ static inline struct ata_link *ata_port_next_link(struct
ata_link *link)
return
Martin K. Petersen wrote:
Fix speed negotiation for secondary device.
Signed-off-by: Martin K. Petersen [EMAIL PROTECTED]
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Tejun Heo wrote:
ata_host_detach() detaches an attached port and shouldn't be called on
a port which hasn't been attached yet. pata_legacy incorrectly calls
ata_host_detach() on unattached port after initialization failure
causing oops. Fix it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Cc:
Akira Iguchi wrote:
This patch adds default thaw ops and fixes the freeze/thaw inconsistency.
Signed-off-by: Kou Ishizaki [EMAIL PROTECTED]
Signed-off-by: Akira Iguchi [EMAIL PROTECTED]
---
diff -pu linux-2.6.25-rc1/drivers/ata/pata_scc.c
linux-2.6.25-rc1_mod/drivers/ata/pata_scc.c
---
Harvey Harrison wrote:
drop return statement.
drivers/ata/pata_amd.c:149:2: warning: returning void-valued expression
Commit ce54d1616302117fa98513ae916bbe1c02ea pata_amd: update mode selection
for NV PATAs
added the initializer for nv_mode_filter but missed deleting the previously
set
Harvey Harrison wrote:
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
drivers/ata/libata-scsi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
applied 1-2 of 3
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL
Harvey Harrison wrote:
drivers/ata/ata_piix.c:1655:8: warning: symbol 'rc' shadows an earlier one
drivers/ata/ata_piix.c:1616:6: originally declared here
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
drivers/ata/ata_piix.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Got another couple sata_mv fixes pending too... coming soon.
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/ata_piix.c |2 +-
drivers/ata/libata-core.c |
Stephen Rothwell wrote:
Also, more trees please ... :-)
Please add the 'NEXT' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
to your list. This is a throwaway meta-branch that is rebased often.
The 'master' branch of libata-dev.git always contains the base
Jeff Garzik wrote:
Please add the 'NEXT' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
to your list. This is a throwaway meta-branch that is rebased often.
Additional FYI:
Don't be worried if git diff master..NEXT is empty from time to time.
This condition
James Bottomley wrote:
So does this indicate the meaning of upstream and upstream-fixes is
still the same? I always took upstream-fixes to be bug fixes for this
-rc and upstream as queued for the next merge window, in which case NEXT
would be the union of those two sets?
In practice,
Jeff Garzik wrote:
Greg Kroah-Hartman (cc'd) needs to pick up your patch, since it is in
the PCI side of the house...
In addition to just waiting, it is normal to ping someone and/or
resend the patch, if nothing happens in 1-2 weeks.
Jeff
-
To unsubscribe from this list: send
Cai, Crane wrote:
Hi Jeff,
Sorry to diturb you. However, it is a long time for me to submit this patch. Can you tell me when this patch can be upsteamed to the kernel tree?
Thanks,
Crane
-Original Message-
From: Jeff Garzik [mailto:[EMAIL PROTECTED]
Sent: Saturday, February 02, 2008
Tejun Heo wrote:
When no reset method is available, libata currently oopses. Although
the condition can't happen unless there's a bug in a low level driver,
oopsing isn't the best way to report the error condition. Complain,
dump stack and fail reset instead.
Signed-off-by: Tejun Heo [EMAIL
Please pull from 'upstream-fixes' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-fixes
to receive the following updates:
drivers/ata/libata-core.c | 48 +-
drivers/ata/pata_amd.c |2 +-
Byron Bradley wrote:
When the sata_mv driver is used as a platform driver,
mv_create_dma_pools() is never called so it fails when trying
to alloc in mv_pool_start().
Signed-off-by: Byron Bradley [EMAIL PROTECTED]
Acked-by: Mark Lord [EMAIL PROTECTED]
---
Mark, based on the comment from Andrew
Tejun Heo wrote:
Some controllers (VIA CX700) raise device error on SETXFER even after
mode configuration succeeded. Update ata_dev_set_mode() such that
device error is ignored if transfer mode is configured correctly. To
implement this, device is revalidated even after device error on
Tejun Heo wrote:
PCI device should be powered up or powered up before its PCI regsiters
are accessed. Although PCI configuration register access is allowed
in D3hot, PCI device is free to reset its status when transiting from
D3hot to D0 causing configuration data to change.
Many libata SFF
Yinghai Lu wrote:
[PATCH] sata_mv: fix loop with last port
commit f351b2d638c3cb0b95adde3549b7bfaf3f991dfa
sata_mv: Support SoC controllers
cause panic:
[...]
last_port already include port0 base.
this patch change use last_port directly, and move pp assignment later.
Signed-off-by:
Tejun Heo wrote:
The first port of cx700 is SATA. Fix cable detection.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/pata_via.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the
Alan Cox wrote:
This has confused a few people so fix it
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.24-mm1/drivers/ata/pata_amd.c
linux-2.6.24-mm1/drivers/ata/pata_amd.c
---
Alan Cox wrote:
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.24-mm1/drivers/ata/pata_legacy.c
linux-2.6.24-mm1/drivers/ata/pata_legacy.c
--- linux.vanilla-2.6.24-mm1/drivers/ata/pata_legacy.c 2008-02-06
Jeff Garzik wrote:
Tejun Heo wrote:
This patchset updates block layer padding and draining support and
make libata use it. It's based on James Bottomley's initial work and,
of the five, the last two patches are from James with some
modifications.
Please read the following thread for more info
Jens Axboe wrote:
On Fri, Feb 08 2008, Jeff Garzik wrote:
Jeff Garzik wrote:
Tejun Heo wrote:
This patchset updates block layer padding and draining support and
make libata use it. It's based on James Bottomley's initial work and,
of the five, the last two patches are from James with some
ACK patch series... would it be ok to send via the ARM maintainer?
I would prefer to add this at the same time as its user...
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Tejun Heo wrote:
AHCI uses CAP.NP to indicate the number of ports and PI to tell which
ports are enabled. The only requirement is that the number of ports
indicated by CAP.NP should equal or be higher than the number of
enabled ports in PI.
CAP.NP and PI carry duplicate information and there
Tejun Heo wrote:
From: James Bottomley [EMAIL PROTECTED]
qc-n_iter was used for libata's own sg walking before sg chaining
replaced it. During conversion, the field and its usage in sata_fsl
were left behind. Kill the filed and update sata_fsl.
tj: This was part of James's
Adrian Bunk wrote:
This patch fixes the following section mismatches:
-- snip --
...
WARNING: drivers/ata/built-in.o(.text+0x15072): Section mismatch in reference
from the function piix_init_one() to the function
.devinit.text:piix_init_sata_map()
WARNING:
HITACHI drives
James Bottomley (1):
libata: kill now unused n_iter and fix sata_fsl
Jeff Garzik (1):
Rename: linux/pata_platform.h to linux/ata_platform.h
Robert Hancock (1):
sata_nv: fix ATAPI issues with memory over 4GB (v7)
Saeed Bishara (1):
sata_mv: Support SoC
David Milburn wrote:
The HITACHI HDS7250SASUN500G and HITACHI HDS7225SBSUN250 drives
do not need to be blacklisted, the NCQ problem has been resolved
with the sata_nv: fix for completion handling patch.
Signed-off-by David Milburn [EMAIL PROTECTED]
---
libata-core.c |2 --
1 files
Robert Hancock wrote:
This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode
on systems with memory located above 4GB. We need to delay setting the 64-bit
DMA mask until the PRD table and padding buffer are allocated so that they don't
get allocated above 4GB and break
[EMAIL PROTECTED] wrote:
From: Andrew Morton [EMAIL PROTECTED]
mips:
drivers/ata/sata_mv.c: In function `mv_port_free_dma_mem':
drivers/ata/sata_mv.c:1080: error: implicit declaration of function
`dma_pool_free'
Cc: Jeff Garzik [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED
Tejun Heo wrote:
This patchset updates block layer padding and draining support and
make libata use it. It's based on James Bottomley's initial work and,
of the five, the last two patches are from James with some
modifications.
Please read the following thread for more info.
Tejun Heo wrote:
For misc ATAPI commands which transfer variable length data to the
host, overflow can occur due to application or hardware bug. Such
overflows can be ignored safely as long as overflow data is properly
drained. libata HSM implementation has this implemented in
Tejun Heo wrote:
Misc ATAPI commands may try to transfer more bytes than requested.
For PIO which is performed by libata HSM, this is worked around by
draining extra bytes from __atapi_pio_bytes().
This patch implements drain buffer to perform draining for DMA and
PIO-over-DMA cases. One page
James Bottomley wrote:
The aic94xx sequencer has a very finely honed sense of DMA transfers.
It's fully automated, and handles both ATA DMA and ATA PIO in the
sequencer engine (so all the driver sees is DMA).
ditto AHCI, and most other DMA engines
It reports both underrun and overrun
Tuomas Jormola wrote:
On Sun, Feb 03, 2008 at 08:14:30AM +0900, Tejun Heo wrote:
Tuomas Jormola wrote:
00:08.0 IDE interface [0101]: nVidia Corporation MCP61 SATA Controller
[10de:03f6] (rev a2)
00:08.1 IDE interface [0101]: nVidia Corporation MCP61 SATA Controller
[10de:03f6] (rev a2)
Chris Rankin wrote:
ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata1.00: cmd c8/00:08:00:00:00/00:00:00:00:00/e0 tag 0 dma 4096 in
res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
ata1.00: status: { DRDY }
ata1: soft resetting link
ata1.00: configured for UDMA/66
[EMAIL PROTECTED] wrote:
--- /dev/null
+++ b/include/linux/sata_mv.h
@@ -0,0 +1,21 @@
+/*
+ * Marvell integrated SATA platfrom device data definition file.
+ *
+ * Saeed Bishara [EMAIL PROTECTED]
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This
Alan Cox wrote:
Use qc_defer to serialize the two channels
Signed-off-by: Alan Cox [EMAIL PROTECTED]
applied... nice!
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
. That allows libata to offer
the same
just get me a disk somehow fallback that old IDE did.
Obsoletes pata_qdi.
Signed-off-by: Alan Cox [EMAIL PROTECTED]
Cc: Tejun Heo [EMAIL PROTECTED]
Cc: Jeff Garzik [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
Signed
[EMAIL PROTECTED] wrote:
From: Saeed Bishara [EMAIL PROTECTED]
The integrated SATA controller is connected directly to the SoC's
internal bus, not via PCI interface. this patch removes the dependency
on the PCI interface.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
drivers/ata/Kconfig
Robert Hancock wrote:
This patch is based on an original patch from Kuan Luo of NVIDIA,
posted under subject fixed a bug of adma in rhel4u5 with HDS7250SASUN500G.
His description follows. I've reworked it a bit to avoid some unnecessary
repeated checks but it should be functionally identical.
Tejun Heo wrote:
There's no reason not to allow multiple calls to pcim_enable_device().
Calls after the first one can simply be noop. All PCI resources will
be released when the initial pcim_enable_device() resource is
released.
This allows more flexibility to managed PCI users.
Tejun Heo wrote:
This patch implements libata.force module parameter which can
selectively override ATA port, link and device configurations
including cable type, SATA PHY SPD limit, transfer mode and NCQ.
For example, you can say use 1.5Gbps for all fan-out ports attached
to the second port
The PCI change was ack'd by Greg...
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/Kconfig |2 +-
drivers/ata/ahci.c |2 +
James Bottomley wrote:
From: James Bottomley [EMAIL PROTECTED]
Date: Thu, 10 Jan 2008 11:42:50 -0600
Subject: libata: implement drain buffers
This just updates the libata slave configure routine to take advantage
of the block layer drain buffers.
I suspect I should also be checking for AHCI as
James Bottomley wrote:
Could we please get this in ... I thought I mentioned several times that
it fixes a fatal oops in both aic94xx and ipr.
Tejun has a persistent objection... see other email.
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body
I'm currently polling various drive manufacturers for comments, so I'm
going to delay ack/nak on this patchset until their comments come back.
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info
Tejun Heo wrote:
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 07dcaf6..08301ca 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -351,6 +351,8 @@ static const struct ata_port_operations ahci_vt8251_ops = {
.port_suspend = ahci_port_suspend,
ACK patches 6-9
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Tejun Heo wrote:
-irq_clear() is used to clear IRQ bit of a SFF controller and isn't
useful for drivers which don't use libata SFF HSM implementation.
However, it's a required callback and many drivers implement their own
noop version as placeholder. This patch implements ata_noop_irq_clear
and
Tejun Heo wrote:
diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c
index 7e68edf..5ef6594 100644
--- a/drivers/ata/pata_ali.c
+++ b/drivers/ata/pata_ali.c
@@ -597,6 +597,11 @@ static int ali_init_one(struct pci_dev *pdev, const struct
pci_device_id *id)
const struct
Tejun Heo wrote:
When no reset method is available, libata currently oopses. Although
the condition can't happen unless there's a bug in a low level driver,
oopsing isn't the best way to report the error condition. Complain,
dump stack and fail reset instead.
Signed-off-by: Tejun Heo [EMAIL
[EMAIL PROTECTED] wrote:
From: Saeed Bishara [EMAIL PROTECTED]
Marvell's Orion SoC includes SATA controllers based on Marvell's
PCI-to-SATA 88SX controllers. This patch extends the libATA sata_mv
driver to support those controllers.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
Anantha Subramanyam wrote:
This patch adds ATAPI DMA support for HT1000 (aka BCM5785) HT1100
(aka BCM11000) SATA Controller.
Signed-off-by: Anantha Subramanyam [EMAIL PROTECTED]
Thanks much for your patience. Feedback:
Engineering process issues:
1) patch is word-wrapped, and cannot be
Cai, Crane wrote:
From: Crane Cai [EMAIL PROTECTED]
PCI: modify SATA IDE mode quirk
When initialize and resume, SB600/700/800 need to set SATA mode
correctly.
Signed-off-by: Crane Cai [EMAIL PROTECTED]
--- a/drivers/pci/quirks.c 2007-09-24
Linux Kernel Mailing List wrote:
Commit: 0948391641918b95d8d96c15089eb5ac156850b3
PCI: Remove users of pci_enable_device_bars()
This patch converts users of pci_enable_device_bars() to the new
pci_enable_device_{io,mem} interface.
The new API fits nicely, except
applied 10-13
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Mark Lord wrote:
Jeff Garzik wrote:
Mark Lord wrote:
Create host-owned DMA memory pools, for use in allocating/freeing
per-port
command/response queues and SG tables. This gives us a way to
guarantee we
meet the hardware address alignment requirements, and also reduces
memory that
might
Mark Lord wrote:
Meanwhile, no further action required here.
ACK :)
And thanks for rounding out the NCQ work. sata_mv has needed love and
attention for a while (well, really, its entire life).
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body
Mark Lord wrote:
Jeff Garzik wrote:
Mark Lord wrote:
Meanwhile, no further action required here.
ACK :)
And thanks for rounding out the NCQ work. sata_mv has needed love and
attention for a while (well, really, its entire life).
..
Well, it's going to be getting plenty of TLC over
saeed bishara wrote:
On 1/16/08, Mark Lord [EMAIL PROTECTED] wrote:
saeed bishara wrote:
I attached the new patch
..
Try again, please.
This time, post the patch *inline* in the body of the email,
so that it can more easily be seen, read, and commented on.
Beware of many email clients that
Mark Lord wrote:
Create host-owned DMA memory pools, for use in allocating/freeing per-port
command/response queues and SG tables. This gives us a way to guarantee we
meet the hardware address alignment requirements, and also reduces
memory that
might otherwise be wasted on alignment gaps.
saeed bishara wrote:
Hi Jeff,
what is the status of this patch?
I'd like to have this patch, and a second part that adds support for
the SoC devices, to be merged into 2.6.25. please note that my patch
collides with Mark's patches, I don't mind to rebase mine above Mark's
patches, but, in that
Jason Gaston wrote:
This patch adds the Intel ICH10 SATA RAID Controllers DeviceID's.
Signed-off-by: Jason Gaston [EMAIL PROTECTED]
--- linux-2.6.24/drivers/ata/ahci.c.orig2008-01-24 14:58:37.0
-0800
+++ linux-2.6.24/drivers/ata/ahci.c 2008-01-28 14:58:22.0 -0800
1 - 100 of 1579 matches
Mail list logo
