Re: [PATCH 0/7] blk_end_request: full I/O completion handler

2008-02-08 Thread Jens Axboe
sometime in April. Thanks, Chandrakala -Original Message- From: Jens Axboe [mailto:[EMAIL PROTECTED] Sent: Tuesday, February 05, 2008 4:09 PM To: S, Chandrakala (STSD) Cc: Kiyoshi Ueda; [EMAIL PROTECTED]; [EMAIL PROTECTED]; linux-ide@vger.kernel.org; Miller, Mike (OS Dev

Re: [PATCHSET #upstream] block/libata: update and use block layer padding and draining

2008-02-08 Thread Jens Axboe
through the block repo, since they are not trivial. Wont be until the week after next, though. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/7] blk_end_request: full I/O completion handler

2008-02-05 Thread Jens Axboe
On Tue, Feb 05 2008, S, Chandrakala (STSD) wrote: Hello, We would like to know in which kernel version these patches are available. They were merged after 2.6.24 was released, so they will show up in the 2.6.25 kernel. -- Jens Axboe - To unsubscribe from this list: send the line

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 -g8561b089

2008-01-31 Thread Jens Axboe
)) BUG(); HWGROUP(drive)-rq = NULL; spin_unlock_irqrestore(ide_lock, flags); -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 -g8561b089

2008-01-31 Thread Jens Axboe
On Thu, Jan 31 2008, Florian Lohoff wrote: On Thu, Jan 31, 2008 at 02:05:58PM +0100, Jens Axboe wrote: The below fix should be enough. It's perfectly legal to have leftover byte counts when the drive signals completion, happens all the time for eg user issued commands where you don't know

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 -g8561b089

2008-01-31 Thread Jens Axboe
On 31/01/2008, at 18.04, Kiyoshi Ueda [EMAIL PROTECTED] wrote: Hi Jens, On Thu, 31 Jan 2008 14:05:58 +0100, Jens Axboe wrote: On Thu, Jan 31 2008, Nai Xia wrote: My dmesg relevant info is quite similar: [6.875041] Freeing unused kernel memory: 320k freed [8.143120] ide-cd: rq

Re: [PATCH 41/63] ide-cd: move lba_to_msf() and msf_to_lba() to linux/cdrom.h

2007-12-20 Thread Jens Axboe
On Thu, Dec 20 2007, Bartlomiej Zolnierkiewicz wrote: * Move lba_to_msf() and msf_to_lba() to linux/cdrom.h (use 'u8' type instead of 'byte' while at it). * Remove msf_to_lba() copy from drivers/cdrom/cdrom.c. Cc: Jens Axboe [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Jens Axboe
data having changed. Why not just bisect it? -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Jens Axboe
On Thu, Dec 13 2007, Mark Lord wrote: Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Matthew Wilcox wrote: On Thu, Dec 13, 2007 at 01:48:18PM -0500, Mark Lord wrote: Problem confirmed. 2.6.23.8 regularly generates segments up to 64KB for libata, but 2.6.24 uses

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Jens Axboe
On Thu, Dec 13 2007, Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Matthew Wilcox wrote: On Thu, Dec 13, 2007 at 01:48:18PM -0500, Mark Lord wrote: Problem confirmed. 2.6.23.8 regularly

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Jens Axboe
On Thu, Dec 13 2007, Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Matthew Wilcox wrote: On Thu, Dec 13, 2007 at 01:48:18PM -0500, Mark Lord

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Jens Axboe
On Thu, Dec 13 2007, Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Matthew Wilcox wrote: On Thu, Dec 13, 2007 at 01:48:18PM -0500

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Jens Axboe
On Thu, Dec 13 2007, Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Jens Axboe wrote: On Thu, Dec 13 2007, Mark Lord wrote: Mark Lord wrote: Jens Axboe wrote: On Thu

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread Jens Axboe
On Thu, Dec 13 2007, Andrew Morton wrote: On Thu, 13 Dec 2007 21:09:59 +0100 Jens Axboe [EMAIL PROTECTED] wrote: OK, it's a vm issue, cc linux-mm and probable culprit. I have tens of thousand backward pages after a boot - IOW, bvec-bv_page is the page before bvprv-bv_page

Re: SAS v SATA interface performance

2007-12-10 Thread Jens Axboe
. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Bug: get EXT3-fs error Allocating block in system zone

2007-12-10 Thread Jens Axboe
On Mon, Dec 10 2007, Marco Gatti wrote: Jens Axboe schrieb: Hello Jens, Thanks for help. I just applied the patch. Unfortunately it doesn't work. Can you try and additionally boot with iommu=off as a boot parameter? Yes. This is the end of getting any sata devices. See screenshots

Re: Bug: get EXT3-fs error Allocating block in system zone

2007-12-09 Thread Jens Axboe
)) { dev_printk(KERN_INFO, pdev-dev, -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Bug: get EXT3-fs error Allocating block in system zone

2007-12-09 Thread Jens Axboe
On Sun, Dec 09 2007, Marco Gatti wrote: Jens Axboe schrieb: Was just thinking that, this should do the trick. If this works, then we can look at whether this is a hardware or iommu or block bouncing (unlikely, would affect more people) bug. diff --git a/drivers/ata/ahci.c b/drivers/ata

Re: Bug: get EXT3-fs error Allocating block in system zone

2007-12-09 Thread Jens Axboe
On Sun, Dec 09 2007, Marco Gatti wrote: Jens Axboe schrieb: On Sun, Dec 09 2007, Marco Gatti wrote: Jens Axboe schrieb: Was just thinking that, this should do the trick. If this works, then we can look at whether this is a hardware or iommu or block bouncing (unlikely, would affect more

Re: [PATCH 01/28] blk_end_request: add new request completion interface (take 3)

2007-12-05 Thread Jens Axboe
. Twice the merging is not an issue for me. As for the patch inclusion, do you push the driver changes to Linus all at once? Or should I ask each maintainer to take the patch? Lets just try to get as many maintainer acks as possible, since the patches need to go in together. -- Jens Axboe

Re: [PATCH 00/28] blk_end_request: full I/O completion handler (take 3)

2007-12-04 Thread Jens Axboe
, could you merge it to your tree? Or does it have to be merged to -mm tree first? Looks good to me now, I'll queue it up. Thanks! -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [BUG] New Kernel Bugs

2007-11-13 Thread Jens Axboe
the bugzilla. Did so now. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-05 Thread Jens Axboe
On Fri, Nov 02 2007, Kristen Carlson Accardi wrote: On Thu, 1 Nov 2007 09:41:46 +0100 Jens Axboe [EMAIL PROTECTED] wrote: On Wed, Oct 31 2007, Jens Axboe wrote: Hi, My x60 stopped suspending about two days ago. It just freezes after printing Suspending console(s

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jens Axboe
On Wed, Oct 31 2007, Jens Axboe wrote: Hi, My x60 stopped suspending about two days ago. It just freezes after printing Suspending console(s) where it would normally turn everything off and the 'moon' light would go on. Posting this message in case somebody else knows what is up

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jens Axboe
On Thu, Nov 01 2007, Jens Axboe wrote: On Wed, Oct 31 2007, Jens Axboe wrote: Hi, My x60 stopped suspending about two days ago. It just freezes after printing Suspending console(s) where it would normally turn everything off and the 'moon' light would go on. Posting

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jens Axboe
On Thu, Nov 01 2007, Jens Axboe wrote: On Thu, Nov 01 2007, Jens Axboe wrote: On Wed, Oct 31 2007, Jens Axboe wrote: Hi, My x60 stopped suspending about two days ago. It just freezes after printing Suspending console(s) where it would normally turn everything off

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Jens Axboe
On Thu, Nov 01 2007, Jeff Garzik wrote: Jens Axboe wrote: Reverting just the default AHCI flags makes it work again. IOW, with the below patch I can suspend properly with current -git. diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index ed9b407..77f7631 100644 --- a/drivers/ata/ahci.c

Re: Fix ATAPI transfer lengths causes CD writing regression

2007-10-31 Thread Jens Axboe
the excess away, which I think is the sane way to do this. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Fix ATAPI transfer lengths causes CD writing regression

2007-10-31 Thread Jens Axboe
On Wed, Oct 31 2007, Jeff Garzik wrote: Jens Axboe wrote: On Wed, Oct 31 2007, Alan Cox wrote: On Tue, 30 Oct 2007 19:21:29 + Daniel Drake [EMAIL PROTECTED] wrote: Alan Cox wrote: I would guess Brasero is issuing a command with the length of data wrongly set. In the old code that might

Re: Fix ATAPI transfer lengths causes CD writing regression

2007-10-31 Thread Jens Axboe
On Wed, Oct 31 2007, Jeff Garzik wrote: Jens Axboe wrote: Right, that's of course problematic... There has to be a way to recover that situation though, or you can't export any user command issue facility. You cannot hope to handle all possible effects arising from an app providing

Re: ata_exec_internal crash at boot in -git22

2007-10-22 Thread Jens Axboe
is 2.6.23-rc9. Andi, can you test with this patch applied? http://brick.kernel.dk/sg-git.patch -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: ata_exec_internal crash at boot in -git22

2007-10-22 Thread Jens Axboe
On Mon, Oct 22 2007, Andi Kleen wrote: On Monday 22 October 2007 20:26:45 Jens Axboe wrote: On Mon, Oct 22 2007, Andi Kleen wrote: One of the systems tested in autoboot crashes at boot with with -git22. This is a AMD 2 socket Opteron NUMA system. The tester was a little flakey

Re: remove blk_queue_max_phys_segments in libata

2007-10-16 Thread Jens Axboe
: fd820f405574a30aacf9a859886e173d641f080b Author: FUJITA Tomonori [EMAIL PROTECTED] AuthorDate: Tue Sep 18 12:16:45 2007 +0200 Committer: Jens Axboe [EMAIL PROTECTED] CommitDate: Tue Oct 16 11:24:44 2007 +0200 remove blk_queue_max_phys_segments in libata LIBATA_MAX_PRD is the maximum number

Re: 2.6.23-rc7-mm1 AHCI ATA errors -- won't boot

2007-09-25 Thread Jens Axboe
to something my ATA devel tree has introduced into -mm. Nope, you're off the hook. The libata tree works great, so it must be something else in -mm conflicting. Can you try 2.6.23-rc8 plus this patch: http://brick.kernel.dk/git-block.patch.bz2 and see if that works? -- Jens Axboe

Re: 2.6.23-rc7-mm1 AHCI ATA errors -- won't boot

2007-09-25 Thread Jens Axboe
On Tue, Sep 25 2007, Berck E. Nash wrote: Jens Axboe wrote: On Tue, Sep 25 2007, Berck E. Nash wrote: Jeff Garzik wrote: The first step would be to clone the upstream branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git and see if the problem

Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

2007-09-21 Thread Jens Axboe
On Fri, Sep 21 2007, Alan Cox wrote: On Fri, 21 Sep 2007 12:31:20 +0200 Jens Axboe [EMAIL PROTECTED] wrote: On Fri, Sep 21 2007, Peer Chen wrote: According to the description of section 5.2.2.1 and 10.1.2 of AHCI specification rev1_1/rev1_2, GHC.HR shall only be set to ¡®1

Re: [PATCH] ide-cd is unmaintained

2007-09-20 Thread Jens Axboe
make the most sense, I think. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: 2.6.23-rc4-mm1

2007-09-11 Thread Jens Axboe
that we can selectively enable drivers when we KNOW they work, instead of trying to do this (massive) operation whole sale. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [-mm patch] remove ide_get_error_location()

2007-09-11 Thread Jens Axboe
, I'll add it there. PS none of the blkdev_issue_flush() users uses *error_sector argument so it can be probably removed as well I had hoped that the existance was enough incentive, but it didn't happen. I'll make a note to kill that again. -- Jens Axboe - To unsubscribe from this list: send

Re: [PATCH 6/7] blk_end_request: remove/unexport end_that_request_*

2007-09-04 Thread Jens Axboe
in when nothing current needs it, I'd much rather add it back in should the need arise. That's the proper way to handle things like this. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] libata: kill sector_buf temporary buffer

2007-08-16 Thread Jens Axboe
? If we're issuing this log page read, we cannot do any IO to the device. So this allocation must not generate any IO. And if we fail in allocating memory and just return, the device wont talk to us in the future. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide

Re: libata git tree, mbox queue status and contents

2007-08-13 Thread Jens Axboe
/sec goes beyond a low threshold then disable ALPM again. In my testing on this notebook (x60), throughput was reduced to about 30% when using ALPM. So while it does save a good amount of power, it also makes the disk a slow dog if you are actually using it. -- Jens Axboe - To unsubscribe from

Re: Some NCQ numbers...

2007-07-09 Thread Jens Axboe
to prefer managing the IO queue largely in software instead of punting to (often) buggy firmware. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-22 Thread Jens Axboe
On Fri, Jun 22 2007, Kristen Carlson Accardi wrote: On Thu, 21 Jun 2007 15:08:32 +0200 Jens Axboe [EMAIL PROTECTED] wrote: On Wed, Jun 20 2007, Kristen Carlson Accardi wrote: Enable Aggressive Link Power management for AHCI controllers. This patch will set the correct bits to turn

Re: 126X DVD drive? (odd ide-cd output)

2007-06-21 Thread Jens Axboe
not highly surprising :-) -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-21 Thread Jens Axboe
. */ + ahci_disable_alpm(ap); + ap-pm_policy = SHOST_MAX_PERFORMANCE; + return 0; + case SHOST_MIN_POWER: ap-pm_policy = SHOST_MIN_POWER; /* configure HBA to enter SLUMBER */ -- Jens Axboe - To unsubscribe from this list

Re: [patch 0/3] AHCI Link Power Management

2007-06-14 Thread Jens Axboe
, and that quickly turns into a lot of timer management. Not exactly free, in terms of CPU usage. I've yet to do some power measurements with this ahci patch, I just noticed that with min_power performance drops from ~55mb/sec to ~15mb/sec sequential on my drive. That's pretty drastic :-) -- Jens

Re: use_clustering (sht) bit set to 0 in AHCI ?

2007-05-21 Thread Jens Axboe
at the documentation, it states that ahci supports up to 64k sg entries and each can have a size of up to 4mb (bits 0 through 21). So as far as I can tell, clustering should work with a segment size up to those 4mb. ahci has always had clustering disabled, perhaps Jeff can expand on why? -- Jens

Re: [PATCH 4/4] bidi support: bidirectional request

2007-05-01 Thread Jens Axboe
read-write paths. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] bidi support: bidirectional request

2007-04-30 Thread Jens Axboe
for the next data phase. I bet this would be a LOT less invasive as well, and we can get by with a few helpers to support it. And it should definitely be a request type. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 4/4] bidi support: bidirectional request

2007-04-30 Thread Jens Axboe
On Mon, Apr 30 2007, Benny Halevy wrote: Jens Axboe wrote: On Sun, Apr 29 2007, James Bottomley wrote: On Sun, 2007-04-29 at 18:48 +0300, Boaz Harrosh wrote: FUJITA Tomonori wrote: From: Boaz Harrosh [EMAIL PROTECTED] Subject: [PATCH 4/4] bidi support: bidirectional request Date: Sun

Re: [PATCH 4/4] bidi support: bidirectional request

2007-04-30 Thread Jens Axboe
On Mon, Apr 30 2007, Douglas Gilbert wrote: Jens Axboe wrote: On Mon, Apr 30 2007, Benny Halevy wrote: Jens Axboe wrote: On Sun, Apr 29 2007, James Bottomley wrote: On Sun, 2007-04-29 at 18:48 +0300, Boaz Harrosh wrote: FUJITA Tomonori wrote: From: Boaz Harrosh [EMAIL PROTECTED

Re: BUG: Null pointer dereference in fs/open.c

2007-04-26 Thread Jens Axboe
and what the expected result is, I can try and help. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: BUG: Null pointer dereference in fs/open.c

2007-04-26 Thread Jens Axboe
complaining about an invalid bit being set in the command descriptor block. That's usually a bug in the issuer. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

[PATCH] Maxtor 6B250S0/BANC1B70 hangs with NCQ

2007-03-30 Thread Jens Axboe
Hi, I've seen this several times on this drive, completely reproducible. Once it has hung, power needs to be cut from the drive to recover it, a simple reboot is not enough. So I'd suggest disabling NCQ on this driver. Error log attached. Signed-off-by: Jens Axboe [EMAIL PROTECTED] diff --git

Re: 2.6.20.3 AMD64 oops in CFQ code

2007-03-22 Thread Jens Axboe
? -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libata: add NCQ blacklist entries from Silicon Image Windows driver

2007-02-22 Thread Jens Axboe
patches had a blacklist entry for that drive as well, but apparently the blacklist got lost somewhere along the way? -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] libata: add NCQ blacklist entries from Silicon Image Windows driver

2007-02-22 Thread Jens Axboe
On Thu, Feb 22 2007, Mark Lord wrote: Jens Axboe wrote: Robert Hancock wrote: .. +/* The following blacklist entries are taken from the Windows + driver .inf files for the Silicon Image 3124 and 3132. */ +{ Maxtor 7B250S0,BANC1B70,ATA_HORKAGE_NONCQ

Re: libata FUA revisited

2007-02-21 Thread Jens Axboe
On Wed, Feb 21 2007, Tejun Heo wrote: [cc'ing Ric, Hannes and Dongjun, Hello. Feel free to drag other people in.] Robert Hancock wrote: Jens Axboe wrote: But we can't really change that, since you need the cache flushed before issuing the FUA write. I've been advocating for an ordered

Re: libata FUA revisited

2007-02-21 Thread Jens Axboe
On Mon, Feb 19 2007, Robert Hancock wrote: Jens Axboe wrote: But we can't really change that, since you need the cache flushed before issuing the FUA write. I've been advocating for an ordered bit for years, so that we could just do: 3. w/FUA+ORDERED normal operation - barrier issued

Re: libata FUA revisited

2007-02-21 Thread Jens Axboe
On Wed, Feb 21 2007, Tejun Heo wrote: Jens Axboe wrote: On Wed, Feb 21 2007, Tejun Heo wrote: [cc'ing Ric, Hannes and Dongjun, Hello. Feel free to drag other people in.] Robert Hancock wrote: Jens Axboe wrote: But we can't really change that, since you need the cache flushed

Re: libata FUA revisited

2007-02-15 Thread Jens Axboe
for NCQ/FUA anyway, we do need to drain the drive queue before issuing the WRITE/FUA. And at that point we may as well not use the NCQ command, just go for the regular non-NCQ FUA write. I think that should be safe. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux

Re: ahci problems with sata disk.

2007-01-17 Thread Jens Axboe
to the drive queue. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: ahci problems with sata disk.

2007-01-17 Thread Jens Axboe
is meh. There are other algorithms for scheduling that perform better. Well Linux doesn't default to using a normal elevator, so it's a moot point. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: 2.6.20-rc4-mm1

2007-01-15 Thread Jens Axboe
On Mon, Jan 15 2007, Ingo Molnar wrote: * Jens Axboe [EMAIL PROTECTED] wrote: In a previous write invoked by: fsck.ext3(1896): WRITE block 8552 on sdb1 end_buffer_async_write() is invoked. sdb1 is not a part of a raid device. When I briefly tested this before I left

Re: 2.6.20-rc4-mm1

2007-01-14 Thread Jens Axboe
On Sun, Jan 14 2007, Thomas Gleixner wrote: On Mon, 2007-01-15 at 09:05 +1100, Jens Axboe wrote: raid seems to have severe problems with the plugging change. I'll try and find Neil and have a chat with him, hopefully we can work it out. Some hints: mount(1899): WRITE block 16424 on md3

Re: [PATCH] SCSI, libata: add support for ATA_16 commands to libata ATAPI devices

2007-01-04 Thread Jens Axboe
haven't had the guts to merge it yet. http://git.kernel.dk/?p=linux-2.6-block.git;a=commitdiff;h=bf5f922d167a5c5cf57132bbcaa1e0ddfd5c45f7 -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] SCSI, libata: add support for ATA_16 commands to libata ATAPI devices

2007-01-04 Thread Jens Axboe
On Thu, Jan 04 2007, Mark Lord wrote: Jens Axboe wrote: On Wed, Jan 03 2007, James Bottomley wrote: Er, well, as you know, I've never been a fan of this static list. I thought Jens was going to put us all out of our misery by making the list settable per device by root and thus shovel

Re: AHCI and add_disk_randomness()

2006-11-16 Thread Jens Axboe
don't know where to add it, because its parameter is struct gendisk *disk and didn't find it used anywhere in ahci or libata. Since ahci attaches its devices through the scsi layer, add_disk_randomness() will get called from scsi_end_request() like for any other scsi controller. -- Jens Axboe

Re: [patch 0/4] ide: Break ide_lock to per-hwgroup lock

2005-09-07 Thread Jens Axboe
On Tue, Sep 06 2005, Ravikiran G Thirumalai wrote: The following patchset breaks down the global ide_lock to per-hwgroup lock. We have taken the following approach. Curious, what is the point of this? -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide

Re: [patch 0/4] ide: Break ide_lock to per-hwgroup lock

2005-09-07 Thread Jens Axboe
On Wed, Sep 07 2005, Ravikiran G Thirumalai wrote: On Wed, Sep 07, 2005 at 11:19:24AM +0200, Jens Axboe wrote: On Tue, Sep 06 2005, Ravikiran G Thirumalai wrote: The following patchset breaks down the global ide_lock to per-hwgroup lock. We have taken the following approach

Re: libata: clustering on or off?

2005-08-28 Thread Jens Axboe
do it). Agree, we should just remove the ability to control clustering, as it really overlaps with the segment settings anyways. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: libata: clustering on or off?

2005-08-28 Thread Jens Axboe
On Sun, Aug 28 2005, Christoph Hellwig wrote: On Sun, Aug 28, 2005 at 04:20:19PM +0200, Jens Axboe wrote: Agree, we should just remove the ability to control clustering, as it really overlaps with the segment settings anyways. What are we going to do with iscsi then? It really doesn't

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-27 Thread Jens Axboe
= scsicmd[2]; tf-lbah = scsicmd[1] 0x1f; /* mask out reserved bits */ -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-27 Thread Jens Axboe
On Sat, Aug 27 2005, Jeff Garzik wrote: Here is the patch I just checked in. Looks perfect. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Hdaps-devel] Re: HDAPS, Need to park the head for real

2005-08-26 Thread Jens Axboe
is correct. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: PATCH: ide: ide-disk freeze support for hdaps

2005-08-26 Thread Jens Axboe
:-) -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-23 Thread Jens Axboe
On Tue, Aug 23 2005, Douglas Gilbert wrote: Jens Axboe wrote: On Mon, Aug 22 2005, Douglas Gilbert wrote: if (scsicmd[0] == READ_6 || scsicmd[0] == WRITE_6) { - qc-nsect = tf-nsect = scsicmd[4]; + if (scsicmd[4] == 0

Re: ahci, SActive flag, and the HD activity LED

2005-08-03 Thread Jens Axboe
On Wed, Aug 03 2005, Martin Wilck wrote: Jens Axboe wrote: If I am reading the specs correctly, that'd mean the ahci driver is wrong in setting the SActive bit. I completely agree, that was my reading of the spec as well and hence my original posts about this in the NCQ thread. Have

Re: Crash in ide_do_request() on card removal

2005-08-02 Thread Jens Axboe
On Tue, Aug 02 2005, Steven Scholz wrote: Jens Axboe wrote: That's not quite true, q is not invalid after this call. It will only be invalid when it is freed (which doesn't happen from here but rather from the blk_cleanup_queue() call when the reference count drops to 0). This is still

Re: Crash in ide_do_request() on card removal

2005-08-02 Thread Jens Axboe
On Tue, Aug 02 2005, Steven Scholz wrote: Jens Axboe wrote: On Tue, Aug 02 2005, Steven Scholz wrote: Jens Axboe wrote: That's not quite true, q is not invalid after this call. It will only be invalid when it is freed (which doesn't happen from here but rather from

Re: Crash in ide_do_request() on card removal

2005-08-02 Thread Jens Axboe
On Tue, Aug 02 2005, Steven Scholz wrote: Jens Axboe wrote: On Tue, Aug 02 2005, Steven Scholz wrote: Jens Axboe wrote: On Tue, Aug 02 2005, Steven Scholz wrote: Jens Axboe wrote: That's not quite true, q is not invalid after this call. It will only be invalid when

Re: Crash in ide_do_request() on card removal

2005-08-02 Thread Jens Axboe
On Tue, Aug 02 2005, Steven Scholz wrote: Jens Axboe wrote: On Tue, Aug 02 2005, Steven Scholz wrote: Jens Axboe wrote: On Tue, Aug 02 2005, Steven Scholz wrote: Jens Axboe wrote: On Tue, Aug 02 2005, Steven Scholz wrote: Jens Axboe wrote: That's not quite

Re: Crash in ide_do_request() on card removal

2005-08-02 Thread Jens Axboe
On Tue, Aug 02 2005, Steven Scholz wrote: Jens Axboe wrote: No, those waiters will be woken up when ide does an end_request for requests coming in for a device which no longer exists. But that would mean generating requests for devices, drives and hwifs that no longer exists. But exactly

Re: Crash in ide_do_request() on card removal

2005-08-02 Thread Jens Axboe
On Tue, Aug 02 2005, Steven Scholz wrote: Jens Axboe wrote: It's not the right way, it only solves a little part of the problem. Killing a request with an error usually looks like this: blkdev_dequeue_request(rq); end_that_request_first(rq, 0, rq-hard_nr_sectors

Re: Crash in ide_do_request() on card removal

2005-08-02 Thread Jens Axboe
); + end_that_request_first(rq, 0, rq-hard_nr_sectors); + end_that_request_last(rq); + } + } } /* Looks good to me now, that's one item off Barts list :-) -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux

Re: ahci, SActive flag, and the HD activity LED

2005-08-02 Thread Jens Axboe
about this in the NCQ thread. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Driver for sata adapter promise sata300 tx4

2005-08-01 Thread Jens Axboe
* driver should now be fairly trivial (with docs). -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Driver for sata adapter promise sata300 tx4

2005-08-01 Thread Jens Axboe
On Mon, Aug 01 2005, Jens Axboe wrote: On Mon, Aug 01 2005, Daniel Drake wrote: Otto Meier wrote: My question is also are these features (NCQ/TCQ) and the heigher datarate be supported by this modification? or is only the basic feature set of sata 150 TX4 supported? NCQ support

Re: Driver for sata adapter promise sata300 tx4

2005-08-01 Thread Jens Axboe
On Mon, Aug 01 2005, Jeff Garzik wrote: Jens Axboe wrote: On Mon, Aug 01 2005, Daniel Drake wrote: Otto Meier wrote: My question is also are these features (NCQ/TCQ) and the heigher datarate be supported by this modification? or is only the basic feature set of sata 150 TX4 supported

Re: [git patches] IDE update

2005-07-08 Thread Jens Axboe
On Fri, Jul 08 2005, Ingo Molnar wrote: * Jens Axboe [EMAIL PROTECTED] wrote: But! I used hdparm -t solely, 2.6 was always ~5% faster than 2.4. But using -Tt slowed down the hd speed by about 30%. So it looks like some scheduler interaction, perhaps the memory timing loops gets

Re: Readahead with softraid1

2005-07-08 Thread Jens Axboe
more than one process doing io to get a performance increase. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Readahead with softraid1

2005-07-08 Thread Jens Axboe
on the other drive(s)? Not sure if it's a design decision or just this works ok, I'll fix it later. Clearly there is a lot of room for improvement in the balancing logic, to get more cases correct/faster. It's quite doable to split a bio and send bits of it to various drives. -- Jens Axboe

Re: [PATCH Linux 2.6.12 00/09] NCQ: generic NCQ completion/error-handling

2005-07-08 Thread Jens Axboe
On Fri, Jul 08 2005, Tejun Heo wrote: On Fri, Jul 08, 2005 at 10:03:48AM +0200, Jens Axboe wrote: Hi, Ok, one more error, this time from irq context: AHCI: ata1: error irq, status=4001 stat=51 err=04 sstat=0113 serr= ata1: aborting commands due to error

Re: sata_sil 3112 activity LED patch

2005-07-07 Thread Jens Axboe
led as an activity light. Just in case you prefer that to overloading the bmdma start/stop handlers. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: sata_sil 3112 activity LED patch

2005-07-07 Thread Jens Axboe
this? Hmm yes, it will require more work for you. It should be cleaned up a little to pass in a START/STOP variable and handle everything in the block layer instead. You probably just want to continue using the bmdma hooks now, that is actually a fine implementation imo. -- Jens Axboe

Re: [PATCH Linux 2.6.12 00/09] NCQ: generic NCQ completion/error-handling

2005-07-06 Thread Jens Axboe
On Wed, Jul 06 2005, Jens Axboe wrote: On Mon, Jul 04 2005, Jens Axboe wrote: On Fri, Jul 01 2005, Jens Axboe wrote: I converted most of debug messages I've used during development into warning messages when posting the patchset and forgot about it, so I've never posted the debug

Re: [git patches] IDE update

2005-07-05 Thread Jens Axboe
On Tue, Jul 05 2005, Ondrej Zary wrote: Jens Axboe wrote: On Tue, Jul 05 2005, Ondrej Zary wrote: André Tomt wrote: Al Boldi wrote: Bartlomiej Zolnierkiewicz wrote: { On 7/4/05, Al Boldi [EMAIL PROTECTED] wrote: Hdparm -tT gives 38mb/s in 2.4.31 Cat /dev/hda /dev/null gives 2

Re: [git patches] IDE update

2005-07-05 Thread Jens Axboe
machine is quite slow, perhaps that is showing the slower performance. Can you try and make HZ 100 in 2.6 and test again? 2.6.13-recent has it as a config option, otherwise edit include/asm/param.h appropriately. -- Jens Axboe [EMAIL PROTECTED] - To unsubscribe from this list: send the line

Re: [git patches] IDE update

2005-07-05 Thread Jens Axboe
On Tue, Jul 05 2005, Ondrej Zary wrote: Jens Axboe wrote: On Tue, 2005-07-05 at 15:02 +0200, Ondrej Zary wrote: Ok, looks alright for both. Your machine is quite slow, perhaps that is showing the slower performance. Can you try and make HZ 100 in 2.6 and test again? 2.6.13-recent has

  1   2   >