RE: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-10-14 Thread Kuan Luo
Jeff wrote: Kuan Luo wrote: One idea, only simply adding if (!swncq_enabled) nv_port_info[SWNCQ].flags = ~ATA_FLAG_NCQ; ppi[0] = nv_port_info[type]; rc = ata_pci_prepare_sff_host(pdev, ppi, host); I don't know if this is appropriate As long as

Re: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-10-12 Thread Jeff Garzik
Kuan Luo wrote: One idea, only simply adding if (!swncq_enabled) nv_port_info[SWNCQ].flags = ~ATA_FLAG_NCQ; ppi[0] = nv_port_info[type]; rc = ata_pci_prepare_sff_host(pdev, ppi, host); I don't know if this is appropriate As long as the structure is not

RE: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-10-04 Thread Peer Chen
Jeff, Is it possible this patch appear in mainline kernel 2.6.24? BRs Peer Chen -Original Message- From: Kuan Luo Sent: Thursday, September 27, 2007 4:55 PM To: 'Jeff Garzik' Cc: Zoltan Boszormenyi; [EMAIL PROTECTED]; Peer Chen; Robert Hancock; linux-ide@vger.kernel.org Subject: RE:

RE: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-27 Thread Kuan Luo
hi, i saw the below changes from http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.git;a=commi tdiff;h=5a5a9e1890b8260686218a68862d880daee1a817 [libata] sata_nv: Clean up ATA_FLAG_NCQ usage; bit test micro-opt @@ -622,7 +622,9 @@ static const struct ata_port_info nv_port_info[] = {

Re: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-27 Thread Jeff Garzik
Kuan Luo wrote: hi, i saw the below changes from http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.git;a=commi tdiff;h=5a5a9e1890b8260686218a68862d880daee1a817 [libata] sata_nv: Clean up ATA_FLAG_NCQ usage; bit test micro-opt @@ -622,7 +622,9 @@ static const struct ata_port_info

RE: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-27 Thread Kuan Luo
Jeff Garzik wrote: Kuan Luo wrote: hi, i saw the below changes from http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.g it;a=commi tdiff;h=5a5a9e1890b8260686218a68862d880daee1a817 [libata] sata_nv: Clean up ATA_FLAG_NCQ usage; bit test micro-opt @@ -622,7 +622,9

Re: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-27 Thread Jeff Garzik
Kuan Luo wrote: Jeff Garzik wrote: Kuan Luo wrote: hi, i saw the below changes from http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.g it;a=commi tdiff;h=5a5a9e1890b8260686218a68862d880daee1a817 [libata] sata_nv: Clean up ATA_FLAG_NCQ usage; bit test micro-opt @@ -622,7

RE: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-27 Thread Kuan Luo
Jeff Garzik wrote: Kuan Luo wrote: Jeff Garzik wrote: Kuan Luo wrote: hi, i saw the below changes from http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.g it;a=commi tdiff;h=5a5a9e1890b8260686218a68862d880daee1a817 [libata] sata_nv: Clean up ATA_FLAG_NCQ usage;

RE: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-27 Thread Kuan Luo
Jeff Garzik wrote: Kuan Luo wrote: Jeff Garzik wrote: Kuan Luo wrote: hi, i saw the below changes from http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.g it;a=commi tdiff;h=5a5a9e1890b8260686218a68862d880daee1a817 [libata] sata_nv: Clean up ATA_FLAG_NCQ usage;

Re: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-25 Thread Jeff Garzik
Zoltan Boszormenyi wrote: Hi, Jeff Garzik írta: [EMAIL PROTECTED] wrote: From: Kuan Luo [EMAIL PROTECTED] Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. NCQ function is disable by default, you can enable it with 'swncq=1'. NCQ will be turned off if the

Re: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-25 Thread Zoltan Boszormenyi
Jeff Garzik írta: Zoltan Boszormenyi wrote: Hi, Jeff Garzik írta: [EMAIL PROTECTED] wrote: From: Kuan Luo [EMAIL PROTECTED] Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. NCQ function is disable by default, you can enable it with 'swncq=1'. NCQ will be

Re: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-25 Thread Jeff Garzik
Zoltan Boszormenyi wrote: Jeff Garzik írta: Zoltan Boszormenyi wrote: Hi, Jeff Garzik írta: [EMAIL PROTECTED] wrote: From: Kuan Luo [EMAIL PROTECTED] Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. NCQ function is disable by default, you can enable it

Re: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-25 Thread Zoltan Boszormenyi
Jeff Garzik írta: Zoltan Boszormenyi wrote: Jeff Garzik írta: Zoltan Boszormenyi wrote: Hi, Jeff Garzik írta: [EMAIL PROTECTED] wrote: From: Kuan Luo [EMAIL PROTECTED] Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. NCQ function is disable by default, you

Re: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-21 Thread Zoltan Boszormenyi
Hi, Zoltan Boszormenyi írta: I will test the code without this locking. Can you give me a better idea besides beating both my disks with separate requests? Say, bonnie++ and simultaneous hdparm -tT on both? I tested the driver without locking with the above test, it survived nicely. Patch is

Re: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-20 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Kuan Luo [EMAIL PROTECTED] Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. NCQ function is disable by default, you can enable it with 'swncq=1'. NCQ will be turned off if the drive is Maxtor on MCP51 or MCP55 rev 0xa2 platform.

Re: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-20 Thread Zoltan Boszormenyi
Hi, Jeff Garzik írta: [EMAIL PROTECTED] wrote: From: Kuan Luo [EMAIL PROTECTED] Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. NCQ function is disable by default, you can enable it with 'swncq=1'. NCQ will be turned off if the drive is Maxtor on MCP51 or