Re: [PATCH] libata: fix probe_ent alloc/free bugs

2007-02-20 Thread Tejun Heo
Tejun Heo wrote: ata_probe_ent_alloc() had a temporary hack such that devm_kzalloc() was used for allocation if devres had been previously initialized on the device; otherwise, plain kzalloc() was used. This was to make the code useable from both the old and devres-aware libata drivers during

Re: [PATCH] libata: fix probe_ent alloc/free bugs

2007-02-20 Thread Jeff Garzik
Tejun Heo wrote: ata_probe_ent_alloc() had a temporary hack such that devm_kzalloc() was used for allocation if devres had been previously initialized on the device; otherwise, plain kzalloc() was used. This was to make the code useable from both the old and devres-aware libata drivers during

Re: [PATCH] libata: fix probe_ent alloc/free bugs

2007-02-17 Thread Sergei Shtylyov
Hello. Tejun Heo wrote: ata_probe_ent_alloc() had a temporary hack such that devm_kzalloc() was used for allocation if devres had been previously initialized on the device; otherwise, plain kzalloc() was used. This was to make the code useable from both the old and devres-aware libata drivers

Re: [PATCH] libata: fix probe_ent alloc/free bugs

2007-02-17 Thread James Bottomley
On Sun, 2007-02-18 at 02:24 +0900, Tejun Heo wrote: ata_probe_ent_alloc() had a temporary hack such that devm_kzalloc() was used for allocation if devres had been previously initialized on the device; otherwise, plain kzalloc() was used. This was to make the code useable from both the old and

Re: [PATCH] libata: fix probe_ent alloc/free bugs

2007-02-17 Thread Sergei Shtylyov
Hello. James Bottomley wrote: +probe_ent = devm_kzalloc(dev, sizeof(*probe_ent), GFP_KERNEL); if (!probe_ent) { printk(KERN_ERR DRV_NAME (%s): out of memory\n, kobject_name((dev-kobj))); [...] The patch certainly looks mangled tab-wise. :-) It isn't,