Re: [PATCH 8/15] ide: disable DMA in -ide_dma_check for no IORDY case

2007-01-25 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: The other advantage of doing cleanups is that code becomes cleaner/simpler which matters a lot for this codebase, i.e. ide-dma-off-void.patch exposed (yet to be fixed) bug in set_using_dma() (-ide_dma_off_quietly always returns 0 which is passed by

Re: [PATCH 8/15] ide: disable DMA in -ide_dma_check for no IORDY case

2007-01-20 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: I've looked thru the code, and found more issues with the PIO fallback there. Will try to cook up patches for at least some drivers... Great, if possible please base them on top of the IDE tree... Erm, I had doubts about it (having in mind that

Re: [PATCH 8/15] ide: disable DMA in -ide_dma_check for no IORDY case

2007-01-20 Thread Bartlomiej Zolnierkiewicz
Hi, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: I've looked thru the code, and found more issues with the PIO fallback there. Will try to cook up patches for at least some drivers... Great, if possible please base them on top of the IDE tree... Erm, I had doubts about

Re: [PATCH 8/15] ide: disable DMA in -ide_dma_check for no IORDY case

2007-01-20 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: The other advantage of doing cleanups is that code becomes cleaner/simpler which matters a lot for this codebase, i.e. ide-dma-off-void.patch exposed (yet to be fixed) bug in set_using_dma() (-ide_dma_off_quietly always returns 0 which is passed by

Re: [PATCH 8/15] ide: disable DMA in -ide_dma_check for no IORDY case

2007-01-19 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: disable DMA in -ide_dma_check for no IORDY case I've looked thru the code, and found more issues with the PIO fallback there. Will try to cook up patches for at least some drivers... Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

Re: [PATCH 8/15] ide: disable DMA in -ide_dma_check for no IORDY case

2007-01-19 Thread Bartlomiej Zolnierkiewicz
Sergei Shtylyov wrote: Hello. Hi, Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: disable DMA in -ide_dma_check for no IORDY case I've looked thru the code, and found more issues with the PIO fallback there. Will try to cook up patches for at least some drivers... Great, if possible

Re: [PATCH 8/15] ide: disable DMA in -ide_dma_check for no IORDY case

2007-01-19 Thread Bartlomiej Zolnierkiewicz
Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: disable DMA in -ide_dma_check for no IORDY case I've looked thru the code, and found more issues with the PIO fallback there. Will try to cook up patches for at least some drivers... Great, if possible