On Sunday 24 February 2008, Jeff Garzik wrote:
[...]
Alan Cox (1):
pata_atiixp: Use 255 sector limit
AHCI needs sorting too but this deals with the old interface
Signed-off-by: Alan Cox [EMAIL PROTECTED]
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
[...]
diff --git
From the patch description it can't be told whether the patch itself is
correct and only the patch description is bogus...
zero length PRD misparsing. If I remember rightly old IDE never generates
64K PRD slots because other hardware can't handle it either (CS5520/30
etc)
-
To unsubscribe from
On Sunday 24 February 2008, Alan Cox wrote:
From the patch description it can't be told whether the patch itself is
correct and only the patch description is bogus...
zero length PRD misparsing. If I remember rightly old IDE never generates
64K PRD slots because other hardware can't handle
Jeff Garzik wrote:
libata disabling command queueing (aka NCQ) based on some hueristics for
detection device brokenness that ultimately turned out to be broken.
Remove the broken hueristic and turn NCQ back on for all the wrongfully
maligned hard drives.
Yay!
-
To unsubscribe from this
Tejun Heo wrote:
These are upstream patches I collected while Jeff is away. Thanks.
* workaround for ATAPI tape drives
* detection/suspend workarounds for several laptops
* ICH8/9 port_enable fix
ata_piix controller ID reorganization is included to ease the fixes.
Please pull from
Mikael Pettersson wrote:
That's my fault for misremembering the rule about the
number of dashes before the other comments part :-(
I'll remember better in the future.
Well, I should have caught it and hand-edited it on my side too...
Jeff
-
To unsubscribe from this list: send the
On Tue, 30 Oct 2007 11:54:01 -0700 (PDT), Linus Torvalds wrote:
On Tue, 30 Oct 2007, Jeff Garzik wrote:
Mikael Pettersson (2):
sata_promise: ASIC PRD table bug workaround, take 2
sata_promise: cleanups
You and Mikael need to sort out the way you send/accept patches.
On Tue, 30 Oct 2007, Jeff Garzik wrote:
Mikael Pettersson (2):
sata_promise: ASIC PRD table bug workaround, take 2
sata_promise: cleanups
You and Mikael need to sort out the way you send/accept patches.
Both of these commits had stuff like this:
Signed-off-by: Mikael
Linus Torvalds wrote:
On Tue, 30 Oct 2007, Jeff Garzik wrote:
Mikael Pettersson (2):
sata_promise: ASIC PRD table bug workaround, take 2
sata_promise: cleanups
You and Mikael need to sort out the way you send/accept patches.
Both of these commits had stuff like this:
On Tue, 30 Oct 2007, Jeff Garzik wrote:
Can we change git-am to accept two dashes as well as three? :)
It seems pretty common, not just with Mikael but several others who send
patches to me.
Well, git-am actually used to be a lot less strict about the dashes, and
we've made it *more*
On Oct 30 2007 12:31, Linus Torvalds wrote:
On Tue, 30 Oct 2007, Jeff Garzik wrote:
Can we change git-am to accept two dashes as well as three? :)
It seems pretty common, not just with Mikael but several others who send
patches to me.
Well, git-am actually used to be a lot less strict
Jan Engelhardt [EMAIL PROTECTED] writes:
On Oct 30 2007 12:31, Linus Torvalds wrote:
On Tue, 30 Oct 2007, Jeff Garzik wrote:
Can we change git-am to accept two dashes as well as three? :)
Well, git-am actually used to be a lot less strict about the dashes, and
we've made it *more* strict
On Tue, 3 Jul 2007, Alan Cox wrote:
Chuck Ebbert (1):
pata_ali: fix UDMA settings
Could you please fix your git tree to have the proper credits for patches
you pull from bugzilla.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242472
I don't think it is Jeff who needs
attribution. Probably because of some insane system he uses (he has a
comment in that bugzilla about patch from comment #14 is in CVS now..
CVS? What kind if insane setup do you have there at Red Hat?
CVS is used for tracking patch sets for RPMS rather than source trees.
Its quite good at
On Wed, 27 Jun 2007 03:35:26 -0400, Jeff Garzik wrote:
Tejun Heo (9):
libata: kill the infamous abnormal status message
libata: kill non-sense warning message
libata: be less verbose about hpa
libata: remove unused variable from ata_eh_reset()
libata: fix
On Wed, 27 Jun 2007 03:35:26 -0400 Jeff Garzik [EMAIL PROTECTED] wrote:
+ /* Don't allow DMA if it isn't multiple of 16 bytes. Quite a
+ * few ATAPI devices choke on such DMA requests.
+ */
+ if (unlikely(qc-nbytes 15))
+ return 1;
It might be worth emitting
Andrew Morton wrote:
On Wed, 27 Jun 2007 03:35:26 -0400 Jeff Garzik [EMAIL PROTECTED] wrote:
+ /* Don't allow DMA if it isn't multiple of 16 bytes. Quite a
+* few ATAPI devices choke on such DMA requests.
+*/
+ if (unlikely(qc-nbytes 15))
+ return 1;
On Wed, 27 Jun 2007, Jeff Garzik wrote:
Such would be a diagnostic that would trigger on valid SCSI commands, when the
user is doing nothing wrong and the system can indeed complete the command
just fine. Additionally, this is moving us in the direction of what the IDE
driver has
On Fri, 25 May 2007 18:03:07 -0400, Jeff Garzik wrote:
Jeff Garzik (4):
[libata] sata_promise: fix flags typo
...
--- a/drivers/ata/sata_promise.c
+++ b/drivers/ata/sata_promise.c
@@ -297,7 +297,7 @@ static const struct ata_port_info pdc_port_info[] = {
/* board_2057x_pata */
Jeff Garzik wrote:
This disables libata ACPI, among other things.
If a -rc6 is possible, that would be quite nice...
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
On Wed, 28 Mar 2007, Jeff Garzik wrote:
Jeff Garzik wrote:
This disables libata ACPI, among other things.
If a -rc6 is possible, that would be quite nice...
Heh. I don't think -rc6 is possible - it's inevitable. We have too
much fallout from the timer changes still outstanding. It looks
On Wed, 28 Mar 2007 13:53:10 -0700 (PDT)
Linus Torvalds [EMAIL PROTECTED] wrote:
On Wed, 28 Mar 2007, Jeff Garzik wrote:
Jeff Garzik wrote:
This disables libata ACPI, among other things.
If a -rc6 is possible, that would be quite nice...
Heh. I don't think -rc6 is possible -
Paul Rolland wrote:
Oh... that's just weird. It seems you'll have to continue
boot with the
timeouts for the time being. Sorry about that.
Would you agree to a patch to add a kernel boot parameter to skip some
ata ports ?
I found some archives refering to some ataX=noprobe, but it seems
to
On Mon, Mar 19, 2007 at 08:48:00AM +0100, Paul Rolland wrote:
Would you agree to a patch to add a kernel boot parameter to skip some
ata ports ?
It should in theory not be neccessary
I found some archives refering to some ataX=noprobe, but it seems
to have no effect, and I'd like to
Hello,
Can you put the harddisk under high load and see what happens? How
often do those errors occur? Care to post full dmesg?
I started again a stock 2.6.21-rc4, and ran that :
while (/bin/true); do tar jxf linux-2.6.19.1.tar.bz2; rm -rf linux-2.6.19.1;
echo -n .; done
After several
Paul Rolland wrote:
Hello,
Can you put the harddisk under high load and see what happens? How
often do those errors occur? Care to post full dmesg?
I started again a stock 2.6.21-rc4, and ran that :
while (/bin/true); do tar jxf linux-2.6.19.1.tar.bz2; rm -rf linux-2.6.19.1;
echo -n .;
Hello,
Yeap, more than three HSM violations in ten minutes. That's the
criteria for turning off NCQ. Good to see it working. It look like a
lot because libata reports all active commands (can't help as on HSM
failure, there's no way to determine which caused it) and the SCSI
prints
Hi,
This is NCQ protocol violation on the drive's side shown on some early
drives. No need to worry too much about it. The drive will just get
blacklisted for NCQ and should work fine.
Thx.
Also, remember one of the problem I have, with ata2 going to timeout
because this port of the ICH7
Doh ! Got that :
ACPI: PCI Interrupt :00:1f.2[B] - GSI 23 (level, low) - IRQ 23
ahci :00:1f.2: AHCI 0001.0100 32 slots 4 ports 3 Gbps 0xf impl SATA mode
ahci :00:1f.2: flags: 64bit ncq led clo pio slum part
ata1: SATA max UDMA/133 cmd 0xc208e900 ctl 0x
PS : I'd like to try 2.6.21-rc3, but it seems that this is
breaking my
config : disk naming is no more the same, and I end up with a panic
Warning: unable to open an initial console
though i've been compiling with the same .config I was
using for 2.6.21-rc2
Gaah. Can you get a log
'; 'Jeff Garzik'; 'Alan Cox'; 'Andrew
Morton'; linux-ide@vger.kernel.org; 'LKML'; 'Eric D. Mudama'
Subject: Re: [git patches] libata fixes
Paul Rolland wrote:
I keep forgetting about this. I'll ask SIMG how to deal with
this. For
the time being, connecting a device to the PMP port
On Sat, Mar 17, 2007 at 07:47:01PM +0100, Paul Rolland wrote:
Hello,
Here is a patch to avoid these pesky messages for the Maxtor disk :
Please match the firmware version as well for the Maxtor drives
--- linux-2.6.21-rc4/drivers/ata/libata-core.c 2007-03-17 19:29:45.0
+0100
Hello,
Please match the firmware version as well for the Maxtor drives
Ok.
--- linux-2.6.21-rc4/drivers/ata/libata-core.c 2007-03-17
19:29:45.0
+0100
+++ linux-2.6.21-rc4-Maxtor/drivers/ata/libata-core.c 2007-03-17
19:37:28.0 +0100
@@ -3359,6 +3359,8 @@
Paul Rolland wrote:
Hello,
I'm preparing to attach a disk.
In the meantime, I've rebuild a 2.6.21-rc4, and got that while booting :
...
ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300)
ata1.00: ATA-7: Maxtor 6L250S0, BANC1G10, max UDMA/133
ata1.00: 490234752 sectors, multi 0: LBA48
Signed-off-by: Paul Rolland [EMAIL PROTECTED]
NAK - but add the firmware to the match and you can have an Ack 8)
Second try, compiled _and_ boot tested, of course.
dmesg says :
ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300)
ata1.00: ATA-7: Maxtor 6L250S0, BANC1G10,
Paul Rolland wrote:
If you leave it alone, does libata turn off NCQ and boot continues?
boot continues, but I can't tell anything about libata turning of NCQ...
I've had a bunch of them at some while while compiling some kernel, so it
was quite some time after booting.
Is there a message
Hello,
The kernel says that NCQ is turned off due to excessive
errors. If your
HSM violation is intermittent, it might not trigger tho.
I've just grep'ed thru all my messages, and I can't find anything
stating that NCQ is being turned off...
Paul
-
To unsubscribe from this list: send
Paul Rolland wrote:
Hello,
The kernel says that NCQ is turned off due to excessive
errors. If your
HSM violation is intermittent, it might not trigger tho.
I've just grep'ed thru all my messages, and I can't find anything
stating that NCQ is being turned off...
Can you put the
Hello,
Ok, so that's just a message irritation, not actually bothersome
otherwise?
It is somewhat painful, because delays involved are quite long, and
it is not possible to explain the machine to ignore the port, and
skip to the next one...
The second problem is a Jmicron363 controler
Hello,
It involves a long timeout, so it's bothersome. This is caused by
Silicon Image 4726/3726 storage processor (SATA Port Multiplier with
extra features) attached to one of the ICH ports.
Yes, I think this is the part Asus is using for it's EZ-Raid feature
on this motherboard, and they
Paul Rolland wrote:
I keep forgetting about this. I'll ask SIMG how to deal with
this. For
the time being, connecting a device to the PMP port should remove the
timeouts.
That sounds a quite expensive solution ;)
You should be able to just move the drive attached at ata1 to ata2.
Please
Hello,
That sounds a quite expensive solution ;)
You should be able to just move the drive attached at ata1 to ata2.
Please report whether that works.
I'll try to find an unused disk... As I said, these ports are part of
Asus EZRaid solution, and i'd prefer this piece of code not to try to
Hello,
It seems like IRQ is not getting through. The first IRQ
driven command is failing for you.
H
Extract is :
ata7: PATA max UDMA/100 cmd 0x00019c00 ctl 0x00019882 bmdma
0x00019400 irq 16
ata8: PATA max UDMA/100 cmd 0x00019800 ctl
PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Paul Rolland
Sent: Sunday, March 11, 2007 7:35 PM
To: 'Linus Torvalds'
Cc: 'Tejun Heo'; 'Jeff Garzik'; 'Andrew Morton';
linux-ide@vger.kernel.org; 'LKML'; 'Eric D. Mudama'
Subject: RE: [git patches] libata fixes
Hello,
do I understand
On Sun, 11 Mar 2007, Paul Rolland wrote:
Nope... I tried several patches from Tejun, and also some that Jeff posted
to linux-ide, but no luck. The only way to have this DVD-RW working is to
use irqpoll on the command line...
So it has *never* worked? That's what I'm trying to see - you had
Hello,
Nope... I tried several patches from Tejun, and also some
that Jeff posted
to linux-ide, but no luck. The only way to have this DVD-RW
working is to
use irqpoll on the command line...
So it has *never* worked? That's what I'm trying to see - you had a
before and after dmesg
On Sun, 11 Mar 2007, Paul Rolland wrote:
My machine is having two problems : the one you are describing above,
which is due to a SIL controler being connected to one port of the ICH7
(at least, it seems to), and probing it goes timeout, but nothing is
connected on it.
Ok, so that's just a
Hello, Linus.
Linus Torvalds wrote:
On Sun, 11 Mar 2007, Paul Rolland wrote:
My machine is having two problems : the one you are describing above,
which is due to a SIL controler being connected to one port of the ICH7
(at least, it seems to), and probing it goes timeout, but nothing is
Of course I forgot to CC. :-) Quoting whole message for Justin.
Tejun Heo wrote:
Hello, Linus.
Linus Torvalds wrote:
On Sun, 11 Mar 2007, Paul Rolland wrote:
My machine is having two problems : the one you are describing above,
which is due to a SIL controler being connected to one port
Paul Rolland wrote:
Hell Tejun,
I've boot-tested this yesterday, with no real luck...
1 - Tested on top of 2.6.21-rc2 (hope it's fine for you),
2 - Collected a full dmesg before and after
Extract is :
ata7: PATA max UDMA/100 cmd 0x00019c00 ctl 0x00019882 bmdma
0x00
Hello,
1. Has it ever worked with the previous kernels?
I can't tell, this machine is new, and it never booted something that
was not a 2.6.20 or 2.6.21.
2. If you connect a harddisk to pata_jmicron, does it work?
3. Does applying the attached patch fix your problem?
Will do these two
Hello,
Your drive has some issues with NCQ and is scheduled to be blacklisted
such that it isn't enabled. libata used to ignore the
condition but now
considers it NCQ protocol violation and fails all pending commands.
OK, do you need an hdparm report to fully identify the disk ?
libata
Paul Rolland wrote:
Hello,
Your drive has some issues with NCQ and is scheduled to be blacklisted
such that it isn't enabled. libata used to ignore the
condition but now
considers it NCQ protocol violation and fails all pending commands.
OK, do you need an hdparm report to fully
]
[mailto:[EMAIL PROTECTED] On Behalf Of Tejun Heo
Sent: Monday, March 05, 2007 4:45 PM
To: [EMAIL PROTECTED]
Cc: 'Jeff Garzik'; 'Andrew Morton'; 'Linus Torvalds';
linux-ide@vger.kernel.org; 'LKML'; 'Eric D. Mudama'
Subject: Re: [git patches] libata fixes
Paul Rolland wrote:
Hello
[cc'ing Eric D. Mudama. Hi!]
Paul Rolland wrote:
ata1.00: exception Emask 0x2 SAct 0xffe0 SErr 0x0 action 0x2 frozen
ata1.00: (spurious completions during NCQ issue=0x0 SAct=0xffe0
FIS=004040a1:0010)
ata1.00: cmd 60/02:28:52:ec:c4/00:00:0e:00:00/40 tag 5 cdb 0x0 data 1024 in
res
Hello,
Paul Rolland wrote:
Hello,
Applied this on top of 2.6.21-rc1 and your previous patch (see my previous
mail).
Still booting, no more the weird error I've reported minutes ago.
pata_jmicron still unable to detect my DVD-RW :
scsi8 : pata_jmicron
ata9.00: ATAPI, max UDMA/66
Hello,
Applied this on top of 2.6.21-rc1, and I now have the following in my
logs :
ahci :00:1f.2: version 2.0
ACPI: PCI Interrupt :00:1f.2[B] - GSI 23 (level, low) - IRQ 23
PCI: Setting latency timer of device :00:1f.2 to 64
ahci :00:1f.2: AHCI 0001.0100 32 slots 4 ports 3 Gbps
On Fri, 2007-02-02 at 11:58 -0500, Jeff Garzik wrote:
Brian and Tejun's patches fix really ugly bugs, Alan's are of less
importance
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following
Linus Torvalds wrote:
On Fri, 2 Feb 2007, Jeff Garzik wrote:
pata_atiixp: propogate cable detection hack from drivers/ide to the new
driver
It's prop*a*gate.
Damn.
Linus some speling mistaeks drive me wild Torvalds
Those UK types don't know how to spell tons of
On Fri, 2 Feb 2007 09:13:56 -0800 (PST)
Linus Torvalds [EMAIL PROTECTED] wrote:
On Fri, 2 Feb 2007, Jeff Garzik wrote:
pata_atiixp: propogate cable detection hack from drivers/ide to the
new driver
It's prop*a*gate.
Damn.
Linus some speling mistaeks
Jeff Garzik wrote:
All fixes for ugly bugs and/or regressions.
Brian King (2):
libata: Fixup n_elem initialization
libata: Initialize qc-pad_len
Thanks for pulling this in. There is one patch outstanding preventing
ipr SATA from working:
* Jeff Garzik ([EMAIL PROTECTED]) wrote:
FWIW the Tejun cleanups are a fix, split into three reviewable pieces.
Also, my local iomap branch has advanced sufficiently enough that I
think it's high time to kill those libata warnings that spew on every
build. (I hear the crowds roar)
Perhaps
62 matches
Mail list logo
