Heck, if .dev_select() took a *device* instead of a *port*
as it's parameter, then I could probably manage it fine in there.
dev_select gets called during probing before the relevant structures are
neccessarily set up.
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the
Tejun Heo wrote:
Hello, Mark.
Mark Lord wrote:
Tejun, I've added PMP to sata_mv, and am now trying to get it
to work with a Marvell PM attached.
And the behaviour I see is very bizarre.
After hard+soft resets, the PM signature is found,
and libata interrogates the PM registers.
It
Tejun Heo wrote:
The following things are needed for a LLD to support PMP.
..
I think that's about it. Feel free to ask if something isn't clear.
..
I think we need better semantics around sata_scr_{read,write}(),
or more specifically
These need to be moved into ata_port_operations
so
Mark Lord wrote:
Tejun Heo wrote:
The following things are needed for a LLD to support PMP.
..
I think that's about it. Feel free to ask if something isn't clear.
..
I think we need better semantics around sata_scr_{read,write}(),
or more specifically
These need to be moved into
Mark Lord wrote:
Heh... I never thought a PMP aware controller would use TF SRST, so what
you want to do is set pmp value in the register and calling
ata_std_softreset(), right? I think the correct thing to do is to
separate out SRST sequence proper from ata_std_softreset() into, say,
Mark Lord wrote:
Mark Lord wrote:
Tejun Heo wrote:
The following things are needed for a LLD to support PMP.
..
I think that's about it. Feel free to ask if something isn't clear.
..
I think we need better semantics around sata_scr_{read,write}(),
or more specifically
These need to be
Tejun Heo wrote:
Mark Lord wrote:
Heh... I never thought a PMP aware controller would use TF SRST, so what
you want to do is set pmp value in the register and calling
ata_std_softreset(), right? I think the correct thing to do is to
separate out SRST sequence proper from ata_std_softreset()
Mark Lord wrote:
Tejun Heo wrote:
Mark Lord wrote:
Heh... I never thought a PMP aware controller would use TF SRST, so
what
you want to do is set pmp value in the register and calling
ata_std_softreset(), right? I think the correct thing to do is to
separate out SRST sequence proper from
Mark Lord wrote:
Mark Lord wrote:
..
We already have .pmp_scr_{read,write} operations.
If NULL, then default to the built-ins that are there now.
..
Mmm.. lost some lines there, try again:
We already have .scr_{read,write} operations, and
what I think we need are .pmp_scr_{read,write} in
Tejun Heo wrote:
The following things are needed for a LLD to support PMP.
..
I think that's about it. Feel free to ask if something isn't clear.
..
Tejun, I've added PMP to sata_mv, and am now trying to get it
to work with a Marvell PM attached.
And the behaviour I see is very bizarre.
10 matches
Mail list logo
