[PATCH] libata: always use polling IDENTIFY

2006-12-03 Thread Tejun Heo
libata switched to IRQ-driven IDENTIFY when IRQ-driven PIO was introduced. This has caused a lot of problems including device misdetection and phantom device. ATA_FLAG_DETECT_POLLING was added recently to selectively use polling IDENTIFY on problemetic drivers but many controllers and devices

Re: [PATCH] libata: always use polling IDENTIFY

2006-12-03 Thread Jeff Garzik
Tejun Heo wrote: libata switched to IRQ-driven IDENTIFY when IRQ-driven PIO was introduced. This has caused a lot of problems including device misdetection and phantom device. ATA_FLAG_DETECT_POLLING was added recently to selectively use polling IDENTIFY on problemetic drivers but many

[PATCH RESEND] libata: always use polling IDENTIFY

2006-12-03 Thread Tejun Heo
libata switched to IRQ-driven IDENTIFY when IRQ-driven PIO was introduced. This has caused a lot of problems including device misdetection and phantom device. ATA_FLAG_DETECT_POLLING was added recently to selectively use polling IDENTIFY on problemetic drivers but many controllers and devices

Re: [PATCH] libata: always use polling IDENTIFY

2006-12-03 Thread Alan
On Sun, 3 Dec 2006 19:30:32 +0900 Tejun Heo [EMAIL PROTECTED] wrote: libata switched to IRQ-driven IDENTIFY when IRQ-driven PIO was introduced. This has caused a lot of problems including device misdetection and phantom device. ATA_FLAG_DETECT_POLLING was added recently to selectively use

Re: [PATCH RESEND] libata: always use polling IDENTIFY

2006-12-03 Thread Jeff Garzik
Tejun Heo wrote: libata switched to IRQ-driven IDENTIFY when IRQ-driven PIO was introduced. This has caused a lot of problems including device misdetection and phantom device. ATA_FLAG_DETECT_POLLING was added recently to selectively use polling IDENTIFY on problemetic drivers but many

Re: AHCI support on Intel chipsets (confusion?)

2006-12-03 Thread Tejun Heo
Wayne Sherman wrote: So, does the kernel source code incorrectly indicate some of these chipsets are AHCI compatible? Not really. If the controller has PCI ID of 0x27c1, it's an ahci controller. Care to post full dmesg and the result of 'lspci -nn'? -- tejun - To unsubscribe from this list:

Re: [PATCH 2.6.19 2/3] sata_promise: new EH conversion

2006-12-03 Thread Tejun Heo
Hello, Mikael. Thanks for doing this. Mikael Pettersson wrote: [--snip--] +static void pdc_freeze(struct ata_port *ap) +{ + void __iomem *mmio = (void __iomem *) ap-ioaddr.cmd_addr; + u32 tmp; + + tmp = readl(mmio + PDC_CTLSTAT); + tmp |= PDC_IRQ_DISABLE; + tmp =

Re: [PATCH 2.6.19 2/3] sata_promise: new EH conversion

2006-12-03 Thread Jeff Garzik
Tejun Heo wrote: Hello, Mikael. Thanks for doing this. Mikael Pettersson wrote: [--snip--] +static void pdc_freeze(struct ata_port *ap) +{ + void __iomem *mmio = (void __iomem *) ap-ioaddr.cmd_addr; + u32 tmp; + + tmp = readl(mmio + PDC_CTLSTAT); + tmp |=

Re: [PATCH 2.6.19 1/3] sata_promise: PHYMODE4 fixup

2006-12-03 Thread Jeff Garzik
Mikael Pettersson wrote: This patch adds code to fix up the PHYMODE4 align timing register value on second-generation Promise SATA chips. Failure to correct this value on non-x86 machines makes drive detection prone to failure due to timeouts. (I've observed about 50% detection failure rates on

Re: [PATCH 2.6.19 3/3] sata_promise: cleanups

2006-12-03 Thread Jeff Garzik
Mikael Pettersson wrote: This patch performs two simple cleanups of sata_promise. * Remove board_20771 and map device id 0x3577 to board_2057x. After the recent corrections for SATAII chips, board_20771 and board_2057x were equivalent in the driver. * Remove hp-hotplug_offset and use

Re: [PATCH 2.6.19 3/3] sata_promise: cleanups

2006-12-03 Thread Tejun Heo
Mikael Pettersson wrote: This patch performs two simple cleanups of sata_promise. * Remove board_20771 and map device id 0x3577 to board_2057x. After the recent corrections for SATAII chips, board_20771 and board_2057x were equivalent in the driver. Ack. * Remove hp-hotplug_offset and

Re: pata_sl82c105 can not reserve IO region

2006-12-03 Thread Alan
I modified pci_request_regions to request only the first 5 regions. Now the detection works, but access to the drive does not work: Some drives do that with the new EH code. Its ATAPI specific and I don't know why. With the older libata it all works. It may also be a driver bug but since it

Re: pata_sl82c105 can not reserve IO region

2006-12-03 Thread Alan
On Sun, 3 Dec 2006 23:24:49 +0100 (MET) Olaf Hering [EMAIL PROTECTED] wrote: This change seems to fix it, only a single reset occurs. I think that one is normal when a CD is in the drive during bootup, maybe it leaves the drive in a confused state. @@ -167,9 +175,13 @@ static void

Re: sata_sis and SIS180 in combined mode

2006-12-03 Thread Uwe Koziolek
Hello Sven, the sata_sis does not really supports PATA-ports. The driver must be modified. A good solution would be to move the SiS180/964 support to pata_sis because the PATA code is much longer then the SATA code. Only some lines must be added to the pata_sis, to support the SATA ports. But

Re: pata_sl82c105 can not reserve IO region

2006-12-03 Thread Alan
On Sat, 02 Dec 2006 09:19:43 +1100 We don't have a choice but to trust the firmware on those machines. We can't assign things ourselves on most of them for various reasons (in many cases, the hypervisor won't let us). So you suggest that I clear resource-flags in that case ? That will do

Re: pata_sl82c105 can not reserve IO region

2006-12-03 Thread Olaf Hering
On Sun, Dec 03, Alan wrote: On Sun, 3 Dec 2006 23:24:49 +0100 (MET) Olaf Hering [EMAIL PROTECTED] wrote: This change seems to fix it, only a single reset occurs. I think that one is normal when a CD is in the drive during bootup, maybe it leaves the drive in a confused state. @@

[PATCH 2.6.19-rc6-mm2] sata_sis: support SiS966/966L

2006-12-03 Thread Uwe Koziolek
The SiS966/966L has different PCI-IDs for native mode and AHCI mode. The SiS966 supports four SATA ports only in native mode. Added additional PCI-ID 0x0183 for SiS965/965L. this patch is based on the code from David Wang from SiS Corporation published on SiS Website. Signed-off-by: Uwe

Re: sata_sis and SIS180 in combined mode

2006-12-03 Thread Uwe Koziolek
Because you are only using the PATA port, you can make a private solution, move the PCI-ID 180 from sata_sis.c to sis5513.c or pata_sis.c dependend on the ide driver you want to use. The SiS180 has no hardware RAID functionality, It is only a BIOS based software raid. The SiS180 is a