sata_via WKP

2007-01-20 Thread Luca M. Gazzolo
Dear Sir, I'm writing as I've found Your address in the code of the sata_via module included in the gnu linux kernel: the module does not work as expected since kernel 2.6.18, here's a link that explains the problem better than I could http://bugzilla.kernel.org/show_bug.cgi?id=7415 ; as far

Re: [PATCH] sd: implement stop_on_shutdown

2007-01-20 Thread Jeff Garzik
Tejun Heo wrote: Darrick J. Wong wrote: Tejun Heo wrote: sd doesn't stop (unload head) on shutdown. This behavior is necessary for multi initiator cases. Unloading head by powering off stresses the drive and sometimes produces distinct clunking noise which apparently disturbs users

Re: [PATCH] sd: implement stop_on_shutdown

2007-01-20 Thread Tejun Heo
Jeff Garzik wrote: Tejun Heo wrote: For ATA, it's currently being done inside libata proper (a bit ugly). It would be nice to have those implemented at sd layer but I wonder how useful it's going to be for actual SCSI devices. Do people actually suspend using SCSI? If it's useful at the

Re: [PATCH] sd: implement stop_on_shutdown

2007-01-20 Thread James Bottomley
On Sat, 2007-01-20 at 12:22 +0900, Tejun Heo wrote: Darrick J. Wong wrote: Tejun Heo wrote: sd doesn't stop (unload head) on shutdown. This behavior is necessary for multi initiator cases. Unloading head by powering off stresses the drive and sometimes produces distinct clunking noise

Re: [PATCH] sd: implement stop_on_shutdown

2007-01-20 Thread James Bottomley
On Sat, 2007-01-20 at 04:50 -0500, Jeff Garzik wrote: Tejun Heo wrote: Darrick J. Wong wrote: Tejun Heo wrote: sd doesn't stop (unload head) on shutdown. This behavior is necessary for multi initiator cases. Unloading head by powering off stresses the drive and sometimes produces

[PATCH] ahci: don't enter slumber on power down

2007-01-20 Thread Tejun Heo
Some ATA/ATAPI devices act weirdly after the link is put into slumber mode. Some hang completely requiring physical power removal while others fail to wake up till the link is hardreset a couple of times. The addition of slumber on power down was never driven by real need. It just followed what

Re: ICH6-M libata disk timeouts in 2.6.19 (except with small queue depth)

2007-01-20 Thread Tejun Heo
Mike Accetta wrote: The distinguishing factor appears to be the queue depth (4 works, 5 and various values up to and including 31 fail) not the kernel version. I am going to try running with the queue depth clamped at 4 to see if this consistently masks the problem. I may also try some more

Re: [PATCH 8/15] ide: disable DMA in -ide_dma_check for no IORDY case

2007-01-20 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: I've looked thru the code, and found more issues with the PIO fallback there. Will try to cook up patches for at least some drivers... Great, if possible please base them on top of the IDE tree... Erm, I had doubts about it (having in mind that

Re: [PATCH 8/15] ide: disable DMA in -ide_dma_check for no IORDY case

2007-01-20 Thread Bartlomiej Zolnierkiewicz
Hi, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: I've looked thru the code, and found more issues with the PIO fallback there. Will try to cook up patches for at least some drivers... Great, if possible please base them on top of the IDE tree... Erm, I had doubts about

Re: [PATCH 8/15] ide: disable DMA in -ide_dma_check for no IORDY case

2007-01-20 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: The other advantage of doing cleanups is that code becomes cleaner/simpler which matters a lot for this codebase, i.e. ide-dma-off-void.patch exposed (yet to be fixed) bug in set_using_dma() (-ide_dma_off_quietly always returns 0 which is passed by

Re: [PATCH 10/15] ide: add ide_set_dma() helper

2007-01-20 Thread Sergei Shtylyov
Hello again. :-) Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: add ide_set_dma() helper * add ide_set_dma() helper and make ide_hwif_t.ide_dma_check return -1 when DMA needs to be disabled (== need to call -ide_dma_off_quietly) 0 when DMA needs to be enabled (== need to call

Re: [PATCH 12/15] ide: make ide_hwif_t.ide_dma_host_on void

2007-01-20 Thread Sergei Shtylyov
Hello again. :-) Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: make ide_hwif_t.ide_dma_host_on void * since ide_hwif_t.ide_dma_host_on is called either when drive-using_dma == 1 or when return value is discarded make it void, also drop ide_ prefix * make __ide_dma_host_on() void and drop