Re: [PATCH] libata: fix compile warning caused by ignoring __must_check results

2007-01-22 Thread Alan
On Sat, 20 Jan 2007 14:23:29 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Fix compile warnings in pata_cs5530, sata_inic162x and sata_nv which are caused by throwing away return values marked with __must_check. Signed-off-by: Tejun Heo [EMAIL PROTECTED] NAK NAK NAK NAK NAK NAK As was

Re: [PATCH] sata_uli: ignore SIMPLEX

2007-01-22 Thread Alan
The PCI IDE spec specifies the simplex bit, but a /vast majority/ of controllers, PATA as well as SATA, hardwire the bit, or program it to a value set by BIOS. As such, most drivers really should /just know/ that their hardware need never worry about this odd simplex concept. The ULi is

Re: ICH6-M libata disk timeouts in 2.6.19 (except with small queue depth)

2007-01-22 Thread Mike Accetta
Tejun Heo writes: Mike Accetta wrote: The distinguishing factor appears to be the queue depth (4 works, 5 and various values up to and including 31 fail) not the kernel version. I am going to try running with the queue depth clamped at 4 to see if this consistently masks the problem. I

Re: [PATCH] ide: Fix ATAPI DMA lost irq problem with CDB intr devices

2007-01-22 Thread Bartlomiej Zolnierkiewicz
Hi, On 1/22/07, Albert Lee [EMAIL PROTECTED] wrote: Albert Lee wrote: Hi Bart, Albert Lee wrote: Problem: IDE ATAPI DMA lost irq with CDB intr devices on Intel ICHx machines. This patch clears the INTR and ERROR bits of DMA status before starting BMDMA to fix the problem. [PATCH] ide-cd:

Re: [DISSCUSS] Iinux raid striped aligned write over xfs

2007-01-22 Thread Jan Engelhardt
On Jan 22 2007 13:49, Raz Ben-Jehuda(caro) wrote: Jan hello I am referring to xfs awareness over linux software raid . ...you lost me. I have no clue what you are talking about or why the patch makes the code more correct than it was before. Please post a reference to the original thread

Re: [PATCH] libata: fix compile warning caused by ignoring __must_check results

2007-01-22 Thread Tejun Heo
Alan wrote: On Sat, 20 Jan 2007 14:23:29 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Fix compile warnings in pata_cs5530, sata_inic162x and sata_nv which are caused by throwing away return values marked with __must_check. Signed-off-by: Tejun Heo [EMAIL PROTECTED] NAK NAK NAK NAK NAK NAK As

Re: [PATCH 13/15] ide: fix UDMA/MWDMA/SWDMA masks

2007-01-22 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: fix UDMA/MWDMA/SWDMA masks * use 0x00 instead of 0x80 to disable -{ultra,mwdma,swdma}_mask * add udma_mask field to ide_pci_device_t and use it to initialize -ultra_mask in aec62xx, pdc202xx_new and pdc202xx_old drivers * fix UDMA masks

Re: [PATCH 13/15] ide: fix UDMA/MWDMA/SWDMA masks

2007-01-22 Thread Alan
On Mon, 22 Jan 2007 21:17:33 +0300 Ugh, I'm not seeing any *actual* support for MW/SW DMA in this driver... Thats long been broken. Should be correct in the libata driver Alan - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED]

[git patches] libata fixes

2007-01-22 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: Documentation/DocBook/libata.tmpl |2 +- drivers/ata/libata-eh.c |4 drivers/ata/sata_mv.c |5

Re: [PATCH 2/3] libata: Initialize nbytes for internal sg commands

2007-01-22 Thread Brian King
Brian King wrote: Tejun Heo wrote: Brian King wrote: Some LLDDs, like ipr, use nbytes and pad_len to determine the total data transfer length of a command. Make sure nbytes gets initialized for internally generated commands. I think it's better to apply the following patch instead of this

Re: [PATCH 14/15] ide: rework the code for selecting the best DMA transfer mode

2007-01-22 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: rework the code for selecting the best DMA transfer mode Here's another portion of comments... Depends on the ide: fix UDMA/MWDMA/SWDMA masks patch. * add ide_hwif_t.filter_udma_mask hook for filtering UDMA mask Erm, maybe a

Re: [PATCH 13/15] ide: fix UDMA/MWDMA/SWDMA masks

2007-01-22 Thread Sergei Shtylyov
Hello. Alan wrote: Ugh, I'm not seeing any *actual* support for MW/SW DMA in this driver... Thats long been broken. Should be correct in the libata driver Here's a surprise for you. pata_cmd64x copied the SW/MW DMA setup code from the IDE driver. No way it could be working. You

Re: [PATCH 13/15] ide: fix UDMA/MWDMA/SWDMA masks

2007-01-22 Thread Alan
Ugh, I'm not seeing any *actual* support for MW/SW DMA in this driver... Thats long been broken. Should be correct in the libata driver Here's a surprise for you. pata_cmd64x copied the SW/MW DMA setup code from the IDE driver. No way it could be working. You may check

[PATCH] ahci: make ULi M5288 ignore interface fatal error bit

2007-01-22 Thread Tejun Heo
As with JMicron controllers, ULi M5288 sets interface fatal error bit on device error including ATAPI CC. This makes libata hardreset the port on ATAPI CC thus making it impossible to use. Ignore interface fatal error bit on ULi M5288. This fixes bugzilla bug #7837. Signed-off-by: Tejun Heo