[PATCH] libata: add a dummy set_mode() in pata_pcmcia

2007-01-28 Thread Arnd Bergmann
CompactFlash cards in a passive PCMCIA adapter don't seem to like the ATA_CMD_SET_FEATURES command, which causes libata device probing to fail. Since PCMCIA only allows PIO mode 0 anyway, there is no point in ever setting a higher speed. Adding the dummy function seems to do the right thing.

[patch] use __u8 rather than u8 in userspace SIZE defines in hdreg.h

2007-01-28 Thread Mike Frysinger
the hdreg.h exports some SIZE defines to userspace but it utilizes sizeof(u8) in its definition ... that's no good so the trivial attached patch changes that to sizeof(__u8) -mike pgpMboRpdpWGM.pgp Description: PGP signature Use __u8 rather than u8 in SIZE defines exported to userspace.

[PATCH] pata_sil680: PIO1 taskfile transfers oveclocking fix

2007-01-28 Thread Sergei Shtylyov
Fix PIO mode 1 overclocked taskfile transfers -- probably a typo carried over from drivers/ide/pci/siimage.c where I've found it by documentation check... drivers/ata/pata_sil680.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6/drivers/ata/pata_sil680.c

[RFC] libata IORDY handling

2007-01-28 Thread Sergei Shtylyov
Hello. Sergei Shtylyov wrote: Fix PIO mode 1 overclocked taskfile transfers -- probably a typo carried over from drivers/ide/pci/siimage.c where I've found it by documentation check... drivers/ata/pata_sil680.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) Index:

[PATCH] pata_sil680: PIO1 taskfile transfers overclocking fix (repost)

2007-01-28 Thread Sergei Shtylyov
Fix PIO mode 1 overclocked taskfile transfers -- probably a typo carried over from drivers/ide/pci/siimage.c where I've found it by documentation check... drivers/ata/pata_sil680.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] Index:

Re: [RFC] libata IORDY handling

2007-01-28 Thread Alan
I looked into fixing this but had a feeling that the thing wasn't right from the very start, including ata_pio_need_iordy(). In my understanding of the ANSI T13 stadrads, when one issues Set Features subcommand Set Transfer Mode with sector count register of 0x8 thru 0xC this means

Re: [RFC] libata IORDY handling

2007-01-28 Thread Sergei Shtylyov
Hello. Alan wrote: I looked into fixing this but had a feeling that the thing wasn't right from the very start, including ata_pio_need_iordy(). In my understanding of the ANSI T13 stadrads, when one issues Set Features subcommand Set Transfer Mode with sector count register of 0x8 thru

cirrus ep93xx pata driver (was: Re: PATA drivers queued for 2.6.19)

2007-01-28 Thread Lennert Buytenhek
(please CC, not on the list) On Fri, Sep 22, 2006 at 05:51:22AM -0400, Jeff Garzik wrote: Allessandro Zummo sent the patch below to me a while ago, for support for the PATA controller (PIO only, although the hardware can also do UDMA) in the cirrus logic ep93xx ARM cpu. The driver has

[PATCH] siimage: PIO1/2 taskfile transfer overclocking fix

2007-01-28 Thread Sergei Shtylyov
Fix two typos found by SiI680A documentation check. They caused the taskfile transfer overclocking: - in PIO mode 1 as 0x2283 must be used for both data and taskfile transfers; - in PIO mode 2 as data and taskfile timings are swapped when writing to the MMIO regs. Fix coding style and

Re: [PATCH] siimage: PIO1/2 taskfile transfer overclocking fix

2007-01-28 Thread Sergei Shtylyov
Hello, I wrote: Fix two typos found by SiI680A documentation check. They caused the taskfile transfer overclocking: - in PIO mode 1 as 0x2283 must be used for both data and taskfile transfers; - in PIO mode 2 as data and taskfile timings are swapped when writing to the MMIO regs. Fix

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-28 Thread Andrew Morton
On Sun, 28 Jan 2007 14:33:44 +0100 Uwe Bugla [EMAIL PROTECTED] wrote: Subject: problems with CD burning References : http://www.spinics.net/lists/linux-ide/msg06545.html Submitter : Uwe Bugla [EMAIL PROTECTED] Status : unknown ... Hi everybody, the problem I already

Re: Boot problems with pata_via driver

2007-01-28 Thread Adrian Bunk
On Sun, Jan 28, 2007 at 12:47:18PM +0100, Patrick Ale wrote: Hi, Hi Patrick, With kernel 2.6.19 I was able to boot using the pata_via driver I tried to compile 2.6.20-rc6 and now I get a unknown device: sda3 error when I try to boot. I compiled 2.6.20-rc6 by copying over the .config from

[PATCH -mm] sata_nv: use ADMA for NODATA commands

2007-01-28 Thread Robert Hancock
Patch is against 2.6.20-rc6-mm1, though will also apply to 2.6.20-rc6 if sata_nv-cleanup-adma-error-handling-v2.patch and sata_nv-cleanup-adma-error-handling-v2-cleanup.patch from -mm are applied first. Testing from those who experienced the previous cache flush timeout problem, in particular,

[PATCH] libata: fix translation for START STOP UNIT

2007-01-28 Thread Robert Hancock
Applies to 2.6.20-rc6. --- libata's SCSI translation for the SCSI START STOP UNIT command with the START bit clear (i.e. stopping the drive) appears to be incorrect. It sends an ATA STANDBY command with the time period set to 0, which the code comment says means now, but the ATA standard

[PATCH RFC] sd: spin down disks on removal or power-down

2007-01-28 Thread Robert Hancock
Here's a patch for sd.c I've cooked up which issues a START STOP UNIT command to stop the drive when the SCSI disk is removed or the machine is powered down. The rationale behind this is that apparently on many drives, simply cutting power to the spinning disk forces it to do an emergency head

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-28 Thread Mike Galbraith
On Sun, 2007-01-28 at 14:33 +0100, Uwe Bugla wrote: Original-Nachricht Datum: Sat, 27 Jan 2007 18:42:30 +0100 Von: Adrian Bunk [EMAIL PROTECTED] An: Linus Torvalds [EMAIL PROTECTED], Andrew Morton [EMAIL PROTECTED] Betreff: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-28 Thread Linus Torvalds
[ Added Jeff, Jens and Mike Christie to Cc. I would _guess_ this is associated with the larger block pc request stuff: Mike, Jens? James B added for good luck. It apparently started happening somewhere between 2.6.19 and 2.6.20-rc2, and doing a gitk v2.6.19..v2.6.20-rc2

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-28 Thread Mike Galbraith
On Sun, 2007-01-28 at 23:04 -0800, Linus Torvalds wrote: Can somebody try to bisect this? I'm bisecting the old fashioned way right now. I'll get it to at least a specific rc, and maybe further. -Mike - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of

Re: sata_promise TX2/TX4 cards rejecting smart auto-offline auto-save ata cmds?

2007-01-28 Thread Jim Paris
Tejun Heo wrote: Andrew Paprocki wrote: On 10/30/06, Tejun Heo [EMAIL PROTECTED] wrote: Please read the following thread. http://thread.gmane.org/gmane.linux.ide/13222/focus=13235 Worked like a charm! Just patched up smartmontools now and I don't get the failed cmds anymore. Hope Bruce

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-28 Thread Andrew Morton
On Mon, 29 Jan 2007 07:26:03 +0100 Mike Galbraith [EMAIL PROTECTED] wrote: FWIW, I just tried it with 2.6.20-rc6, and can confirm. Once nero is run, the kernel never gives up retrying whatever command failed, so I get... [ 4362.972995] hdd: status error: status=0x58 { DriveReady

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-28 Thread Mike Galbraith
On Sun, 2007-01-28 at 22:48 -0800, Andrew Morton wrote: On Mon, 29 Jan 2007 07:26:03 +0100 Mike Galbraith [EMAIL PROTECTED] wrote: FWIW, I just tried it with 2.6.20-rc6, and can confirm. Once nero is run, the kernel never gives up retrying whatever command failed, so I get... [

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-28 Thread Linus Torvalds
On Mon, 29 Jan 2007, Mike Galbraith wrote: Unfortunately, I'm git impaired. I am rummaging as we speak though. Ok, I'm personally heading to bed, but it rally should be as simple as - get the git tree in the first place - do git bisect good v2.6.19 git bisect bad