Re: Sata_via problems in a Vintage2-AE1

2007-02-13 Thread Jean Delvare
Hi Leopold, Le Lundi 12 Février 2007 17:23, Leopold Palomo-Avellaneda a écrit : A Dilluns 12 Febrer 2007 10:11, Jean Delvare va escriure: Did you report the problem to Asus? They should fix it. Maybe this new BIOS actually fixes some other problems you have. no. It's on the todo list.

Re: [PATCH] libata: [take 2] add support for READ/WRITE LONG commands

2007-02-13 Thread Mark Lord
[ take 2 -- s/cmd/scmd/; also fixed nbytes in libata-eh ] The READ/WRITE LONG commands are theoretically obsolete, but most (all?) drives to date still implement them. Of these, WRITE_LONG and WRITE_LONG_ONCE are of particular interest for fault injection testing -- eg. creating media errors at

[PATCH] (pata-2.6 fix queue) sl82c105: DMA support code cleanup

2007-02-13 Thread Sergei Shtylyov
Fold the now equivalent code in the ide_dma_check() method into a mere call to ide_use_dma(). Make config_for_dma() return non-zero if DMA mode has been set and call it from the ide_dma_check() method instead of ide_dma_on(). Also, defer writing the DMA timings to the chip registers until DMA is

[PATCH] (pata-2.6 fix queue) sl82c105: rework PIO support

2007-02-13 Thread Sergei Shtylyov
Get rid of the 'pio_speed' member of 'ide_drive_t' that was only used by this driver by storing the PIO mode timings in the 'drive_data' instead -- this allows us to greatly simplify the process of reloading of the chip's timing register and do in right in the ide_dma_off_quietly() and to turn

Re: pcim_enable_device BUGs for libata devices in 2.6.20-git6

2007-02-13 Thread Tejun Heo
Hello, Pavel. Pavel Machek wrote: 1. Don't restore power state and re-enable PCI device on resume from freeze just as we don't do the opposite when freezing. 2. Unconditionally disable and power down PCI device on suspend whether it's freeze or not. #2 would be simpler but I'm a bit

Re: Sata_via problems in a Vintage2-AE1

2007-02-13 Thread Leopold Palomo-Avellaneda
A Dimarts 13 Febrer 2007 12:20, Jean Delvare va escriure: Hi Leopold, Le Lundi 12 Février 2007 17:23, Leopold Palomo-Avellaneda a écrit : A Dilluns 12 Febrer 2007 10:11, Jean Delvare va escriure: Did you report the problem to Asus? They should fix it. Maybe this new BIOS actually fixes

Re: Sata_via problems in a Vintage2-AE1

2007-02-13 Thread Jean Delvare
Le Mardi 13 Février 2007 17:11, Leopold Palomo-Avellaneda a écrit : A Dimarts 13 Febrer 2007 12:20, Jean Delvare va escriure: (...) *If* the VT8251 needs the VIA IRQ quirk, then the attached patch may help. Leopold, can you give it a try? Well, making your patch to the vanilla

[PATCH] SATA: use NULL for ptrs

2007-02-13 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix sparse warnings in SATA: drivers/ata/sata_sil.c:342:9: warning: Using plain integer as NULL pointer drivers/ata/sata_mv.c:2056:55: warning: Using plain integer as NULL pointer Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/ata/sata_mv.c |

[PATCH 1/8] alim15x3: PIO fallback fix

2007-02-13 Thread Bartlomiej Zolnierkiewicz
[PATCH] alim15x3: PIO fallback fix If DMA tuning fails always set the best PIO mode. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/alim15x3.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) Index: b/drivers/ide/pci/alim15x3.c

[PATCH 2/8] alim15x3: use ide_tune_dma()

2007-02-13 Thread Bartlomiej Zolnierkiewicz
[PATCH] alim15x3: use ide_tune_dma() Use ide_tune_dma() in ali15x3_config_drive_for_dma() and remove all the open coded DMA tuning code and also config_chipset_for_dma(). Set -atapi_dma flag correctly in init_hwif_common_ali15x3() so ide_tune_dma() can take care of checking if ATAPI DMA is

[PATCH 3/8] pdc202xx_new: use ide_tune_dma()

2007-02-13 Thread Bartlomiej Zolnierkiewicz
[PATCH] pdc202xx_new: use ide_tune_dma() * remove code enabling IORDY and prefetch from config_chipset_for_dma(), as the comment states it has no real effect because these settings are overriden when the PIO mode is set (and for this driver -autotune == 1 so PIO mode is always programmed)

[PATCH 4/8] ide: remove some obsoleted kernel params

2007-02-13 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide: remove some obsoleted kernel params Remove * hdx=serialize * idex=noautotune * idex=autotune kernel params, they have been obsoleted for ages. idex=serialize, hdx=noautotune and hdx=autotune are still available so there is no funcionality loss caused by this patch. Signed-off-by:

[PATCH 7/8] ide: make legacy IDE VLB modules check for the probe kernel params

2007-02-13 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide: make legacy IDE VLB modules check for the probe kernel params Legacy IDE VLB host drivers didn't check for probe options when compiled as modules, which was obviously wrong as we don't want module to poke at random I/O ports by simply loading it. Fix it by adding probe module param

[PATCH 8/8] ide: fix ide.c

2007-02-13 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide: fix ide.c #ifdef madness For some built-in host driver we need to take care of the order in which they are probed. Do this during link time and remove all ugly #ifdefs from ide.c. [ We can probe m68k specific drivers before PCI drivers (no PCI on m68k except broken for ages

Re: [PATCHSET] libata: PATA driver for Celleb

2007-02-13 Thread Akira Iguchi
Hi, Jeff-san. Jeff Garzik wrote: This patchset consists of [1] add another IRQ calls (core and headers) [2] add another IRQ calls (libata drivers) [3] PATA driver for Celleb And patch[3] depends on patch[1,2]. This patchset is based on the Tejun's devres git tree, which is available at

Re: [PATCHSET] libata: PATA driver for Celleb

2007-02-13 Thread Benjamin Herrenschmidt
2.6.20 has been released and (I think) it is the time of merge-window for 2.6.21. I want this patch to be merged at this time. Please tell me if there are anything I should do. FYI, Jeff, we have merged the rest of the celleb platform support in the 2.6.21 merge window, so it would be

Re: libata FUA revisited

2007-02-13 Thread Robert Hancock
Tejun Heo wrote: On the NCQ side, I think it's pretty safe to assume that all controllers will handle it. Obviously I've verified it with sata_nv (at least that it doesn't blow up obviously), and the other two NCQ drivers we have, ahci and sata_sil24 just feed raw FIS data into the controller

Re: libata FUA revisited

2007-02-13 Thread Tejun Heo
[cc'ing Jeff, Alan, Mark and Jens. Hi!] Hello, Robert. Robert Hancock wrote: Well, we should be able to determine that experimentally (at least on specific controllers) with a little test program that just writes little bits of data and fsyncs repeatedly (assuming that does in fact trigger

[PATCH] ide/pci/delkin_cb.c: pci_module_init to pci_register_driver

2007-02-13 Thread Richard Knutsson
Convert pci_module_init() to pci_register_driver(). Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Compile-tested with allyes, allmod allno on i386 diff --git a/drivers/ide/pci/delkin_cb.c b/drivers/ide/pci/delkin_cb.c index e2672fc..d4b753e 100644 --- a/drivers/ide/pci/delkin_cb.c +++