Re: Fwd: [LIBATA] drives not detected

On 2/16/07, Albert Lee [EMAIL PROTECTED] wrote: Hi, To make the fun even more fun. when I compile the old IDE drivers, rmmod the libata ones and modprobe the IDE drivers for my Promise card, the drives DO get detected. See here my dmesg. Linux version 2.6.20 ([EMAIL PROTECTED]) (gcc version

Re: pata_amd dropping to PIO on resume

Jeff Garzik wrote: Robert Hancock wrote: Yes, the fact that it's going into simplex mode is the problem, it wasn't in simplex to start with. It looks like pata_amd does an ata_pci_clear_simplex only for certain chip models, maybe this model needs it as well? Deleting the

2.6.20-git10 (and -git13): BUG at drivers/pci/pci.c:817 during resume from disk

Update: I get the same BUG with 2.6.20-git13 100% of the time during the resume. The system seems to be fully functional nonetheless. On Thursday, 15 February 2007 12:23, Rafael J. Wysocki wrote: Update: On Thursday, 15 February 2007 00:16, Rafael J. Wysocki wrote: Hi, I've got this

[PATCH] libata: fix probe_ent free in ata_sas_port_alloc()

probe_ent is allocated using devm_kzalloc() and thus should be freed using devm_kfree(). ata_sas_port_alloc() freed its probe_ent using kfree() thus causing double free later. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- James, does this fix the bug you mentioned on IRC? diff --git

Re: [PATCH] libata: fix probe_ent free in ata_sas_port_alloc()

On Sat, 2007-02-17 at 23:27 +0900, Tejun Heo wrote: probe_ent is allocated using devm_kzalloc() and thus should be freed using devm_kfree(). ata_sas_port_alloc() freed its probe_ent using kfree() thus causing double free later. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- James, does

Re: Implement the technote about promise/maxtor drives

On 2/15/07, Albert Lee [EMAIL PROTECTED] wrote: Some Maxtor drives have Maxtor and others have MAXTOR in the identify device data. If the slave is a MAXTOR one, the following code segment doesn't work. The 6L drive is a design brought over from Maxtor's purchase of Quantum, the 6Y is a Maxtor

Re: [PATCH] libata: fix probe_ent alloc/free bugs

Hello. Tejun Heo wrote: ata_probe_ent_alloc() had a temporary hack such that devm_kzalloc() was used for allocation if devres had been previously initialized on the device; otherwise, plain kzalloc() was used. This was to make the code useable from both the old and devres-aware libata drivers

Re: [PATCH] libata: fix probe_ent alloc/free bugs

On Sun, 2007-02-18 at 02:24 +0900, Tejun Heo wrote: ata_probe_ent_alloc() had a temporary hack such that devm_kzalloc() was used for allocation if devres had been previously initialized on the device; otherwise, plain kzalloc() was used. This was to make the code useable from both the old and

Re: [PATCH] libata: fix probe_ent alloc/free bugs

Hello. James Bottomley wrote: +probe_ent = devm_kzalloc(dev, sizeof(*probe_ent), GFP_KERNEL); if (!probe_ent) { printk(KERN_ERR DRV_NAME (%s): out of memory\n, kobject_name((dev-kobj))); [...] The patch certainly looks mangled tab-wise. :-) It isn't,

Re: [PATCH] use winbond libata instead of ide driver for pseries CD drives

Olaf Hering wrote: Change the default for the built-in IDE on p610/p615/p630 from ide to libata. libata has better error handling and the drive can recover when hald does its CD media polling. Signed-off-by: Olaf Hering [EMAIL PROTECTED] --- arch/powerpc/configs/ppc64_defconfig |4 ++--

[git patches] libata ACPI support

This has been living in libata-dev#ALL (and thus -mm) for quite a while now. For both PATA and SATA, this helps at suspend/resume time. For SATA, ACPI support mostly consists of taskfiles (ATA commands) that the BIOS wants us to send to the system drive. Most notably, if you have set a hard