[PATCH] libata: blacklist SAMSUNG HD401LJ / ZZ100-15 for NCQ
SAMSUNG HD401LJ / ZZ100-15 does spurious completion of NCQ commands.
Disable NCQ. Reported by Ulrich in bugzilla #8805.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Cc: Ulrich [EMAIL PROTECTED]
---
And, finally one from samsung. How come vendors got this right
previously but screw up on new ones?
drivers/ata/libata-core.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 6001aae..60e78be 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -3788,6 +3788,7 @@ static const struct ata_blacklist_entry
ata_device_blacklist [] = {
{ WDC WD740ADFD-00NLR1, NULL, ATA_HORKAGE_NONCQ, },
{ FUJITSU MHV2080BH, 00840028, ATA_HORKAGE_NONCQ, },
{ ST9160821AS,3.CLF,ATA_HORKAGE_NONCQ, },
+ { SAMSUNG HD401LJ,ZZ100-15, ATA_HORKAGE_NONCQ, },
/* Devices with NCQ limits */
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: errors on shutdown with PMP
Hello, Marc. Marc Bejarano wrote: hi, tejun. i've been using your libata-tj-2.6.22-rc6-20070702 kernel on a centos 4 machine for a while with some 3124's and 3726's. up until today, i hadn't seen any issues. while trying to shut the machine down, this happened: === Jul 27 14:58:44 dell shutdown: shutting down for system halt Jul 27 14:59:15 dell kernel: ata8.00: exception Emask 0x0 SAct 0x1 SErr 0x0 action 0x2 frozen Jul 27 14:59:15 dell kernel: ata8.00: cmd 61/10:00:a7:0a:00/00:00:00:00:00/40 tag 0 cdb 0x0 data 8192 out Jul 27 14:59:15 dell kernel: res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout) Device times out write. Jul 27 14:59:15 dell kernel: ata8.15: hard resetting link Jul 27 14:59:17 dell kernel: ata8.15: SATA link up 3.0 Gbps (SStatus 123 SControl 0) Jul 27 14:59:17 dell kernel: ata8.00: hard resetting link Jul 27 14:59:27 dell kernel: ata8.00: softreset failed (timeout) Jul 27 14:59:27 dell kernel: ata8.00: hard resetting link Jul 27 14:59:28 dell kernel: ata8.00: COMRESET failed (errno=-5) Jul 27 14:59:28 dell kernel: ata8.00: reset failed, giving up Jul 27 14:59:28 dell kernel: ata8.15: hard resetting link Jul 27 14:59:38 dell kernel: ata8.15: softreset failed (timeout) Jul 27 14:59:38 dell kernel: ata8.15: hard resetting link Jul 27 14:59:40 dell kernel: ata8.15: SATA link up 3.0 Gbps (SStatus 123 SControl 0) Jul 27 14:59:40 dell kernel: ata8.00: hard resetting link Jul 27 14:59:50 dell kernel: ata8.00: softreset failed (timeout) Jul 27 14:59:50 dell kernel: ata8.00: hard resetting link Jul 27 14:59:51 dell kernel: ata8.00: COMRESET failed (errno=-5) Jul 27 14:59:51 dell kernel: ata8.00: reset failed, giving up Jul 27 14:59:51 dell kernel: ata8.15: hard resetting link Jul 27 15:00:01 dell kernel: ata8.15: softreset failed (timeout) Jul 27 15:00:01 dell kernel: ata8.15: hard resetting link Jul 27 15:00:03 dell kernel: ata8.15: SATA link up 3.0 Gbps (SStatus 123 SControl 0) Jul 27 15:00:03 dell kernel: ata8.00: hard resetting link Jul 27 15:00:13 dell kernel: ata8.00: softreset failed (timeout) Jul 27 15:00:13 dell kernel: ata8.00: hard resetting link Jul 27 15:00:14 dell kernel: ata8.00: COMRESET failed (errno=-5) Jul 27 15:00:14 dell kernel: ata8.00: reset failed, giving up Jul 27 15:00:14 dell kernel: ata8.00: failed to recover link after 3 tries, disabling Jul 27 15:00:14 dell kernel: ata8.00: disabled And then never comes back. Please post the result of 'smartctl -a /dev/sdX' where sdX is the device which went offline. -- tejun - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ide: make CONFIG_IDE_GENERIC default to N
These days, CONFIG_IDE_GENERIC causes more confusion and misconfiguration than it helps. Especially so because libata is linked after the generic driver. Default to N. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- Aye, aye. drivers/ide/Kconfig |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig index b1a9b81..0a801c6 100644 --- a/drivers/ide/Kconfig +++ b/drivers/ide/Kconfig @@ -304,9 +304,8 @@ comment IDE chipset support/bugfixes config IDE_GENERIC tristate generic/default IDE chipset support - default y help - If unsure, say Y. + If unsure, say N. config BLK_DEV_CMD640 bool CMD640 chipset bugfix/support - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] libata: Store bus addresses (versus -mm for testing)
Alan Cox wrote: As we cannot reverse iomap results portably as we tried before the libata layer needs to keep bus addresses around for reporting. This first big patch adds a structure for it and teaches the drivers to keep the information. Thankfully most drivers go via libata-sff and it can do the work for them. For the others we replace ata_std_ports with ata_std_io_ports / std_mmio_ports and pass both the mapped and some bus address info. We don't keep all the mappings in both forms. We only need cmd, ctrl and status (for wait_status() reporting). We also keep a base for devices where the taskfile (cmd/ctl) mapping makes no sense. This patch stores all the data but doesn't yet change the display side. I've got a couple of variants I'm playing with on the display side and want to get that right. In the mean time this should store all the data and have no side effects for anyone, so is a good first chunk for testing alone. Signed-off-by: Alan Cox [EMAIL PROTECTED] Eeeek... I don't think this is a good idea. I liked the getting original address from mapped address thing. Is it impossible to get that working on some archs? Or is it just not there yet? Thanks. -- tejun - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ide: move ide_config_drive_speed() calls to upper layers
On Friday 27 July 2007, Alan Cox wrote:
On Fri, 27 Jul 2007 02:22:27 +0200
Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote:
* Convert {ide_hwif_t,ide_pci_device_t}-host_flag to be u16.
* Add IDE_HFLAG_POST_SET_MODE host to indicate the need to program the
host for the transfer mode after programming the device. Set it in
au1xxx-ide/cs5530/cs5535/pdc202xx_new/sc1200/via82cxxx host drivers.
The CS5530 at least shouldn't care what order changes are done. I don't
think the SC1200 does either but I don't have the docs to hand.
Thanks, I will make a follow up patch to remove this flag from
cs5530 host driver (unless of course somebody beats me to it).
For libata we went the post_set_mode way and then junked it. Instead
there is a -set_mode method which defaults to the usual order and
actions. IT821x and similar override it to do very little, post_set_mode
people call the default method and then do their stuff, and some of the
crazier cases do stuff both before and after the default.
Much more flexible and it can do anything unlike flags for the cases you
have.
I view this patch as an intermediate step in -set_mode direction.
Thanks,
Bart
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] use ARRAY_SIZE in ide-cd.c
Hi,
On Friday 27 July 2007, Mark Hindley wrote:
Hi,
ARY_LEN in ide-cd.{c,h} is an unnecessary duplication. Replace with generic
ARRAY_SIZE from
kernel.h.
Seems to be already fixed by:
commit 74c8f97a6c2d12fb144ad34076e969e8a01dc4b3
Author: Robert P. J. Day [EMAIL PROTECTED]
Date: Mon Jul 9 23:17:57 2007 +0200
ide-cd: replace C code with call to ARRAY_SIZE() macro
Delete the unnecessary macro ARY_LEN and use ARRAY_SIZE directly.
Signed-off-by: Robert P. J. Day [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Please always make sure that you are working on the current git tree
or such unfortunate situation is likely to happen... ;)
Thanks,
Bart
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] libata: Store bus addresses (versus -mm for testing)
Eeeek... I don't think this is a good idea. I liked the getting original address from mapped address thing. Is it impossible to get that working on some archs? Or is it just not there yet? Its basically impossible. Either the platform or the libata code would have to keep a copy of the bus and virtual mappings for the various devices. If the arch layers do it then we have to fix each architecture and track all the iomaps where the info is not in fact needed. Alan - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] fix IDE legacy mode resource
Hi,
I got the following error on MIPS Cobalt.
MIPS Cobalt has the 0x1000 offset between resource and bus region.
PCI: Unable to reserve I/O region #1:[EMAIL PROTECTED] for device :00:09.1
pata_via :00:09.1: failed to request/iomap BARs for port 0 (errno=-16)
PCI: Unable to reserve I/O region #3:[EMAIL PROTECTED] for device :00:09.1
pata_via :00:09.1: failed to request/iomap BARs for port 1 (errno=-16)
pata_via :00:09.1: no available native port
At this point, these resources should be the bus regions.
Signed-off-by: Yoichi Yuasa [EMAIL PROTECTED]
diff -pruN -X generic/Documentation/dontdiff generic-orig/drivers/pci/probe.c
generic/drivers/pci/probe.c
--- generic-orig/drivers/pci/probe.c2007-07-26 17:07:44.151670750 +0900
+++ generic/drivers/pci/probe.c 2007-07-26 17:25:42.227046250 +0900
@@ -744,22 +744,40 @@ static int pci_setup_device(struct pci_d
*/
if (class == PCI_CLASS_STORAGE_IDE) {
u8 progif;
+ struct pci_bus_region region;
+ struct resource resource;
pci_read_config_byte(dev, PCI_CLASS_PROG, progif);
if ((progif 1) == 0) {
- dev-resource[0].start = 0x1F0;
- dev-resource[0].end = 0x1F7;
- dev-resource[0].flags = LEGACY_IO_RESOURCE;
- dev-resource[1].start = 0x3F6;
- dev-resource[1].end = 0x3F6;
- dev-resource[1].flags = LEGACY_IO_RESOURCE;
+ resource.start = 0x1F0;
+ resource.end = 0x1F7;
+ resource.flags = LEGACY_IO_RESOURCE;
+ pcibios_resource_to_bus(dev, region,
resource);
+ dev-resource[0].start = region.start;
+ dev-resource[0].end = region.end;
+ dev-resource[0].flags = resource.flags;
+ resource.start = 0x3F6;
+ resource.end = 0x3F6;
+ resource.flags = LEGACY_IO_RESOURCE;
+ pcibios_resource_to_bus(dev, region,
resource);
+ dev-resource[1].start = region.start;
+ dev-resource[1].end = region.end;
+ dev-resource[1].flags = resource.flags;
}
if ((progif 4) == 0) {
- dev-resource[2].start = 0x170;
- dev-resource[2].end = 0x177;
- dev-resource[2].flags = LEGACY_IO_RESOURCE;
- dev-resource[3].start = 0x376;
- dev-resource[3].end = 0x376;
- dev-resource[3].flags = LEGACY_IO_RESOURCE;
+ resource.start = 0x170;
+ resource.end = 0x177;
+ resource.flags = LEGACY_IO_RESOURCE;
+ pcibios_resource_to_bus(dev, region,
resource);
+ dev-resource[2].start = region.start;
+ dev-resource[2].end = region.end;
+ dev-resource[2].flags = resource.flags;
+ resource.start = 0x376;
+ resource.end = 0x376;
+ resource.flags = LEGACY_IO_RESOURCE;
+ pcibios_resource_to_bus(dev, region,
resource);
+ dev-resource[3].start = region.start;
+ dev-resource[3].end = region.end;
+ dev-resource[3].flags = resource.flags;
}
}
break;
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ide: make CONFIG_IDE_GENERIC default to N
Tejun Heo wrote: These days, CONFIG_IDE_GENERIC causes more confusion and misconfiguration than it helps. Especially so because libata is linked after the generic driver. Default to N. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- Aye, aye. drivers/ide/Kconfig |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig index b1a9b81..0a801c6 100644 --- a/drivers/ide/Kconfig +++ b/drivers/ide/Kconfig @@ -304,9 +304,8 @@ comment IDE chipset support/bugfixes config IDE_GENERIC tristate generic/default IDE chipset support - default y help - If unsure, say Y. + If unsure, say N. ACK - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] fix IDE legacy mode resource
Yoichi Yuasa wrote: Hi, I got the following error on MIPS Cobalt. MIPS Cobalt has the 0x1000 offset between resource and bus region. PCI: Unable to reserve I/O region #1:[EMAIL PROTECTED] for device :00:09.1 pata_via :00:09.1: failed to request/iomap BARs for port 0 (errno=-16) PCI: Unable to reserve I/O region #3:[EMAIL PROTECTED] for device :00:09.1 pata_via :00:09.1: failed to request/iomap BARs for port 1 (errno=-16) pata_via :00:09.1: no available native port At this point, these resources should be the bus regions. Signed-off-by: Yoichi Yuasa [EMAIL PROTECTED] I'm not sure I understand what's going on here... could you or someone provide additional explanation as to why this is a fix? Thanks, Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ide: move ide_config_drive_speed() calls to upper layers
Hello.
Bartlomiej Zolnierkiewicz wrote:
On Fri, 27 Jul 2007 02:22:27 +0200
Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote:
* Convert {ide_hwif_t,ide_pci_device_t}-host_flag to be u16.
* Add IDE_HFLAG_POST_SET_MODE host to indicate the need to program the
host for the transfer mode after programming the device. Set it in
au1xxx-ide/cs5530/cs5535/pdc202xx_new/sc1200/via82cxxx host drivers.
The CS5530 at least shouldn't care what order changes are done. I don't
And neither CS5535. And Au1200 static bus controller shouldn't care about
the order too, so au1xxx-ide hardly needs that.
Here's the datasheet, BTW:
http://www.razamicroelectronics.com/documents/32798e_Au1200_db.pdf
think the SC1200 does either but I don't have the docs to hand.
It seems pretty much alike CS553x except it's accessed via PCI config.
space, not MSRs... Here's the datasheet:
http://www.amd.com/files/connectivitysolutions/geode/32579B_sc1200_ds.pdf
I have a feeling that only pdc202xx_new and jmicron drivers actually need
this flag (and the latter one actually doesn't care as its methods are empty
anyway). Well, AMD/VIA chips enable UltraDMA mode by snooping Set Features
command (as the drivers tell them to do so), so the order seems important
unless that is changed.
Thanks,
Bart
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH -mm] Fix libata warnings with CONFIG_PM=n
Hi Jeff,
I noticed this warnings when CONFIG_PM=n
...
drivers/ata/libata-core.c:5993: warning: 'ata_host_disable_link_pm' defined but
not used
drivers/ata/libata-core.c:6004: warning: 'ata_host_enable_link_pm' defined but
not used
...
Signed-off-by: Gabriel Craciunescu [EMAIL PROTECTED]
---
--- linux-2.6.23-rc1/drivers/ata/libata-core.c.orig 2007-07-28
21:17:31.0 +0200
+++ linux-2.6.23-rc1/drivers/ata/libata-core.c 2007-07-28 21:17:48.0
+0200
@@ -5989,6 +5989,7 @@ int ata_flush_cache(struct ata_device *d
return 0;
}
+#ifdef CONFIG_PM
static void ata_host_disable_link_pm(struct ata_host *host)
{
int i;
@@ -6011,7 +6012,7 @@ static void ata_host_enable_link_pm(stru
}
}
-#ifdef CONFIG_PM
+
static int ata_host_request_pm(struct ata_host *host, pm_message_t mesg,
unsigned int action, unsigned int ehi_flags,
int wait)
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] au1xxx: fix au1xxx_set_pio_mode()
On Thursday 26 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Set transfer mode on the device before programming the host controller for the new timings (matches what auide_tune_chipset() is doing wrt DMA modes). It's not that the most other drives are doing something different... :-) Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] added - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] pdc202xx_new: check ide_config_drive_speed() return value
On Thursday 26 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] added - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ide: make CONFIG_IDE_GENERIC default to N
On Saturday 28 July 2007, Tejun Heo wrote: These days, CONFIG_IDE_GENERIC causes more confusion and misconfiguration than it helps. Especially so because libata is linked after the generic driver. Default to N. Signed-off-by: Tejun Heo [EMAIL PROTECTED] applied and Jeff's ACK added, thanks - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] alim15x3: Correct HP detect
Direct port of Alan's fix for pata_ali.
Cc: Alan Cox [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/alim15x3.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/drivers/ide/pci/alim15x3.c
===
--- a/drivers/ide/pci/alim15x3.c
+++ b/drivers/ide/pci/alim15x3.c
@@ -593,7 +593,7 @@ static struct dmi_system_id cable_dmi_ta
.ident = HP Pavilion N5430,
.matches = {
DMI_MATCH(DMI_BOARD_VENDOR, Hewlett-Packard),
- DMI_MATCH(DMI_BOARD_NAME, OmniBook N32N-736),
+ DMI_MATCH(DMI_BOARD_VERSION, OmniBook N32N-736),
},
},
{ }
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] cs5535: check ide_config_drive_speed() return value
On Thursday 26 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] added - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [2/3] 2.6.23-rc1: known regressions v2
On Friday 27 July 2007, Michal Piotrowski wrote: IDE Subject : ide problems: 2.6.22-git17 working, 2.6.23-rc1* is not References : http://lkml.org/lkml/2007/7/27/298 Last known good : ? Submitter : dth [EMAIL PROTECTED] Caused-By : ? Handled-By : ? Status : unknown No IDE changes after 2.6.22-git17. Despite this I will try to follow this bugreport. Thanks, Bart - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
