Re: 2.6.23-rc7 - _random_ IRQ23 : nobody cared

2007-09-27 Thread Paul Rolland
Hi Tejun, On Thu, 27 Sep 2007 09:55:22 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Paul Rolland wrote: Hi David, On Mon, 24 Sep 2007 23:56:59 +0930 David Newall [EMAIL PROTECTED] wrote: Paul Rolland (???) wrote: Hell, IRQ 23 is shared between libata and my modem !!!

RE: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-27 Thread Kuan Luo
hi, i saw the below changes from http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.git;a=commi tdiff;h=5a5a9e1890b8260686218a68862d880daee1a817 [libata] sata_nv: Clean up ATA_FLAG_NCQ usage; bit test micro-opt @@ -622,7 +622,9 @@ static const struct ata_port_info nv_port_info[] = {

Re: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-27 Thread Jeff Garzik
Kuan Luo wrote: hi, i saw the below changes from http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.git;a=commi tdiff;h=5a5a9e1890b8260686218a68862d880daee1a817 [libata] sata_nv: Clean up ATA_FLAG_NCQ usage; bit test micro-opt @@ -622,7 +622,9 @@ static const struct ata_port_info

RE: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-27 Thread Kuan Luo
Jeff Garzik wrote: Kuan Luo wrote: hi, i saw the below changes from http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.g it;a=commi tdiff;h=5a5a9e1890b8260686218a68862d880daee1a817 [libata] sata_nv: Clean up ATA_FLAG_NCQ usage; bit test micro-opt @@ -622,7 +622,9

Re: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-27 Thread Jeff Garzik
Kuan Luo wrote: Jeff Garzik wrote: Kuan Luo wrote: hi, i saw the below changes from http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.g it;a=commi tdiff;h=5a5a9e1890b8260686218a68862d880daee1a817 [libata] sata_nv: Clean up ATA_FLAG_NCQ usage; bit test micro-opt @@ -622,7

T61 SATA error in log

2007-09-27 Thread Benjamin Herrenschmidt
Saw that popping up in my log today on a brand new T61 thinkpad: [ 427.712000] ata1.00: exception Emask 0x2 SAct 0x18 SErr 0x0 action 0x2 frozen [ 427.712000] ata1.00: (spurious completions during NCQ issue=0x0 SAct=0x18 FIS=004040a1:0024) [ 427.712000] ata1.00: cmd

RE: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-27 Thread Kuan Luo
Jeff Garzik wrote: Kuan Luo wrote: Jeff Garzik wrote: Kuan Luo wrote: hi, i saw the below changes from http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.g it;a=commi tdiff;h=5a5a9e1890b8260686218a68862d880daee1a817 [libata] sata_nv: Clean up ATA_FLAG_NCQ usage;

RE: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-27 Thread Kuan Luo
Jeff Garzik wrote: Kuan Luo wrote: Jeff Garzik wrote: Kuan Luo wrote: hi, i saw the below changes from http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.g it;a=commi tdiff;h=5a5a9e1890b8260686218a68862d880daee1a817 [libata] sata_nv: Clean up ATA_FLAG_NCQ usage;

Re: Improper disk shutdown with 2.6.22.6?

2007-09-27 Thread Robert
On Thu, Sep 27, 2007 at 09:39:54AM +0900, Tejun Heo wrote: [cc'ing Henrique and Jeff] Robert wrote: Hello, When shutting down this system running Linux 2.6.22.6, I get a warning about the possibility that the disks are not properly shut down. When the power is turned off, it sounds

Re: 2.6.23-rc7 - _random_ IRQ23 : nobody cared

2007-09-27 Thread Benjamin Herrenschmidt
Let me guess... this is a T61 or X61 ? There's a problem with these that we don't fully understand yet, we're getting those stale interrupts all over the range. I wonder if it could be a bug with the ICH8 chipset... If yours is one of these, it's being dealt with (or attempted to deal with) at

[patch] SB700 contains more than one IDE channel

2007-09-27 Thread Shane Huang
From: [EMAIL PROTECTED] SB700 supports one physical IDE channel, but SB700 SATA controller supports combined mode. When the SATA combined mode is enabled, two SATA ports(port4 and port5) share one IDE channel from IDE controller, and PATA will share the other IDE channel. Our previous patch

Re: 2.6.23-rc7 - _random_ IRQ23 : nobody cared

2007-09-27 Thread Paul Rolland
Hello, On Thu, 27 Sep 2007 19:04:11 +1000 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: Let me guess... this is a T61 or X61 ? Bad luck ;) This is an Asus P5W-DH Deluxe motherboard, with a Core2 6400 CPU, a bunch of disk (2 IDE, 3 SATA, 1 CDRW and 1 DVDRW-DL), and a damned Olitec PCI V92

Re: [patch] SB700 contains more than one IDE channel

2007-09-27 Thread Sergei Shtylyov
Hello. Shane Huang wrote: SB700 supports one physical IDE channel, but SB700 SATA controller supports combined mode. When the SATA combined mode is enabled, two SATA ports(port4 and port5) share one IDE channel from IDE controller, and PATA will share the other IDE channel. Our previous

Sata Sil3512 bug?

2007-09-27 Thread MisterE
Hello, First off, i'm quite new to linux. I don't know the official way's to report bugs. I'm not even sure that the bug is sata driver related. I hope you can do some suggestions. I recently bought 2 Sweex Sata controllers (without raid). This device contains the Sil3512 chip. I connected it to

correct kernel parameter in documentation.

2007-09-27 Thread Dave Jones
'noacpi' isn't a standalone parameter, give it its prefix. Signed-off-by: Dave Jones [EMAIL PROTECTED] diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 4d175c7..a87bc58 100644 --- a/Documentation/kernel-parameters.txt +++

Re: correct kernel parameter in documentation.

2007-09-27 Thread Robert P. J. Day
On Thu, 27 Sep 2007, Dave Jones wrote: 'noacpi' isn't a standalone parameter, give it its prefix. Signed-off-by: Dave Jones [EMAIL PROTECTED] diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 4d175c7..a87bc58 100644 ---

Re: correct kernel parameter in documentation.

2007-09-27 Thread Alan Cox
if you're going to add that libata-related parm to the kernel parms file, wouldn't it make sense for consistency to add the other available boot-time parms from libata-core.c as well? it seems counter-productive to document only a subset of them from the same source file. He's not adding it

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 3

2007-09-27 Thread Kristen Carlson Accardi
On Tue, 25 Sep 2007 00:14:36 +0100 Matthew Garrett [EMAIL PROTECTED] wrote: Modern laptops with hotswap bays still tend to utilise a PATA interface on a SATA bridge, generally with the host controller in some legacy emulation mode rather than AHCI. This means that the existing hotplug code

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 3

2007-09-27 Thread Matthew Garrett
On Thu, Sep 27, 2007 at 10:26:59AM -0700, Kristen Carlson Accardi wrote: 1. How does it handle things when you have a bay that is located behind a dock and the dock ejects? In the acpi bay driver, I use the mechanism that the dock driver exports to get undock notifications so that the bay

Re: Maxtor 6L200M0 sata irq timeouts

2007-09-27 Thread Tejun Heo
Michal Suchanek wrote: Hello (please CC me when replying) On 11/09/2007, Tejun Heo [EMAIL PROTECTED] wrote: Michal Suchanek wrote: What does 'smartctl -a /dev/sda' say? Attaching output. Hmmm... How often does the condition occur? smartlog records only two occasions. Every few

Re: 2.6.22.6 sata_sil device errors timeouts

2007-09-27 Thread Tejun Heo
Bruce Allen wrote: Andrew: thanks for isolating this problem. Tejun: any thoughts? The STRANGE_BUFFER_LENGTH problem is fixed in the code that Andrew is running. The problem is provoked with '-o on' which goes via a TASKFILE ioctl. I suppose you mean HDIO_DRIVE_TASK, right? libata

Re: Stardom SATA HSM violation

2007-09-27 Thread Alan Cox
I think there have been enough cases where this draining was necessary. IIRC, ata_piix was involved in those cases, right? If so, can you please submit a patch which applies this only to affected controllers? I don't feel too confident about applying this to all SFF controllers. Old IDE

RE: sata_sil24 with port multiplier

2007-09-27 Thread Jon Chelton
After applying the patches you sent, I had not received any additional errors until today. Below is an output from dmesg. Thanks for your help, Jon ata1.15: exception Emask 0x100 SAct 0x0 SErr 0x0 action 0x6 frozen ata1.15: irq_stat 0x00020002, PMP DMA CS errata ata1.00: exception Emask 0x100

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 3

2007-09-27 Thread Henrique de Moraes Holschuh
On Thu, 27 Sep 2007, Matthew Garrett wrote: The spec seems to imply that even if the drive hotswap bay and the battery bay are physically the same, they're logically distinct. 10.2.1 That holds true for thinkpads up to the T43, at least. I don't know about the newer ones. You get bay

Re: 2.6.23-rc7 - _random_ IRQ23 : nobody cared

2007-09-27 Thread Benjamin Herrenschmidt
On Thu, 2007-09-27 at 10:05 +, Paul Rolland wrote: Hello, On Thu, 27 Sep 2007 19:04:11 +1000 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: Let me guess... this is a T61 or X61 ? Bad luck ;) This is an Asus P5W-DH Deluxe motherboard, with a Core2 6400 CPU, a bunch of disk (2

Re: T61 SATA error in log

2007-09-27 Thread Tejun Heo
Benjamin Herrenschmidt wrote: Saw that popping up in my log today on a brand new T61 thinkpad: [ 427.712000] ata1.00: exception Emask 0x2 SAct 0x18 SErr 0x0 action 0x2 frozen [ 427.712000] ata1.00: (spurious completions during NCQ issue=0x0 SAct=0x18 FIS=004040a1:0024) [

Re: Stardom SATA HSM violation

2007-09-27 Thread Tejun Heo
Alan Cox wrote: I think there have been enough cases where this draining was necessary. IIRC, ata_piix was involved in those cases, right? If so, can you please submit a patch which applies this only to affected controllers? I don't feel too confident about applying this to all SFF

Re: T61 SATA error in log

2007-09-27 Thread Benjamin Herrenschmidt
On Thu, 2007-09-27 at 13:35 -0700, Tejun Heo wrote: Benjamin Herrenschmidt wrote: Saw that popping up in my log today on a brand new T61 thinkpad: [ 427.712000] ata1.00: exception Emask 0x2 SAct 0x18 SErr 0x0 action 0x2 frozen [ 427.712000] ata1.00: (spurious completions during NCQ

Re: Stardom SATA HSM violation

2007-09-27 Thread Jeff Garzik
Tejun Heo wrote: Alan Cox wrote: I think there have been enough cases where this draining was necessary. IIRC, ata_piix was involved in those cases, right? If so, can you please submit a patch which applies this only to affected controllers? I don't feel too confident about applying this to

Re: T61 SATA error in log

2007-09-27 Thread Tejun Heo
Benjamin Herrenschmidt wrote: Allright. What is happening exactly ? A fluke on the link ? The drive is sending spurious completions of NCQ commands (ie. it's sending completions for commands which are not pending). We believe this happens due to firmware bugs and it matched the reality pretty

[PATCH] libata drain fifo on stuck DRQ HSM violation

2007-09-27 Thread Mark Lord
Tejun Heo wrote: Jeff Garzik wrote: Tejun Heo wrote: Alan Cox wrote: I think there have been enough cases where this draining was necessary. IIRC, ata_piix was involved in those cases, right? If so, can you please submit a patch which applies this only to affected controllers? I don't feel

RE: [patch] SB700 contains more than one IDE channel

2007-09-27 Thread Shane Huang
Hi Sergei: Thanks for your reply. The inlined patch has suffered from word wrapping, OK, I think the cause is my mail client MS outlook's setting. I try to change my outlook settings and attach the patch again at the end of this mail. Please check it again. and the attached one luckily

Re: 2.6.22.6 sata_sil device errors timeouts

2007-09-27 Thread Bruce Allen
Hi Tejun, Thanks! Yes I meant HDIO_DRIVE_TASK. Please let me know what your tests reveal. Cheers, Bruce On Thu, 27 Sep 2007, Tejun Heo wrote: Bruce Allen wrote: Andrew: thanks for isolating this problem. Tejun: any thoughts? The STRANGE_BUFFER_LENGTH problem is fixed in the

Re: Stardom SATA HSM violation

2007-09-27 Thread Mark Lord
Tejun Heo wrote: Alan Cox wrote: I think there have been enough cases where this draining was necessary. IIRC, ata_piix was involved in those cases, right? If so, can you please submit a patch which applies this only to affected controllers? I don't feel too confident about applying this to