Re: [PATCH] ide: introduce CONFIG_BLK_DEV_IDEDMA_SFF option

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Saturday 09 February 2008, Sergei Shtylyov wrote: Introduce new option CONFIG_BLK_DEV_IDEDMA_SFF for non-PCI SFF-8038i compatible bus mastering IDE controllers (which there are a few known), thus fixing a hack made for Palmchip BK3710 controller... Signed-off-by: Sergei Shtylyov

Re: [PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Sunday 10 February 2008, Bartlomiej Zolnierkiewicz wrote: On Sunday 10 February 2008, Atsushi Nemoto wrote: On Sun, 06 Jan 2008 18:03:10 +0100, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: + /* reset DMA masks only for SFF-style DMA controllers */ + if ((d-host_flags

[PATCH] ide: fix comment in init_irq()

2008-02-10 Thread Bartlomiej Zolnierkiewicz
APUS support is gone... Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ide/ide-probe.c === --- a/drivers/ide/ide

Re: Current git -- kaboom [bisect] seems IDE related.

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Sunday 10 February 2008, Sebastian Siewior wrote: * Bartlomiej Zolnierkiewicz | 2008-02-10 19:32:06 [+0100]: Sebastian/Christoph, please test the final patch (after your ACK I'll push it to Linus together with the rest of pending IDE fixes). This seems to work. Thanks. - To unsubscribe

[PATCH] ide: remove stale comment from ide-lib.c

2008-02-10 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-lib.c |9 - 1 file changed, 9 deletions(-) Index: b/drivers/ide/ide-lib.c === --- a/drivers/ide/ide-lib.c +++ b/drivers/ide/ide-lib.c

[git patches] IDE fixes

2008-02-10 Thread Bartlomiej Zolnierkiewicz
--- drivers/ide/pci/pdc202xx_old.c | 22 include/linux/ide.h| 11 +++--- 16 files changed, 107 insertions(+), 159 deletions(-) Adrian Bunk (1): ide: fix ide/legacy/gayle.c compilation Bartlomiej Zolnierkiewicz (12): palm_bk3710: ide_register_hw

Re: [PATCH] Prevent IDE boot ops on NUMA system in mainline

2008-02-11 Thread Bartlomiej Zolnierkiewicz
On Monday 11 February 2008, Andi Kleen wrote: Without this patch a Opteron test system here oopses at boot with currentg git. Calling to_pci_dev() on a NULL pointer gives a negative value so the following NULL pointer check never triggers and then an illegal address is referenced.

Re: 2.6.25 Regression: DriveStatusError

2008-02-11 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday 11 February 2008, Daniel Exner wrote: Hi! Please CC me as I'm not subscribed to any list, thx in advance. I tried all -git Kernels since begining of cycle and starting when they finaly compiled fine, they weren't able to mount my root. As my laptop with the serial

Re: Current git -- kaboom [bisect] seems IDE related.

2008-02-11 Thread Bartlomiej Zolnierkiewicz
On Monday 11 February 2008, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: From: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Subject: [PATCH] ide-disk: fix flush requests (take 2) commit 813a0eb233ee67d7166241a8b389b6a76f2247f9 Author: Bartlomiej Zolnierkiewicz [EMAIL

Re: [PATCH] ide: Add missing base addresses for falconide and macide

2008-02-11 Thread Bartlomiej Zolnierkiewicz
On Monday 11 February 2008, Geert Uytterhoeven wrote: commit 29dd59755a849cc6475faa6a75f3b804e23a6fc2 (ide: remove ide_setup_ports) forgot to take into account the base addresses for the CONTROL registers for falconide and macide, as pointed out by Michael Schmitz. Falconide was tested on

Re: [PATCH 2/2] ide-tape: remove atomic test/set macros for packet commands

2008-02-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 09 February 2008, Borislav Petkov wrote: From 92dd5c1cfb27c0945894a3a055098290047d1ff0 Mon Sep 17 00:00:00 2001 From: Borislav Petkov [EMAIL PROTECTED] Date: Sat, 9 Feb 2008 20:33:48 +0100 Subject: [PATCH 2/2] ide-tape: remove atomic test/set macros for packet commands

Re: [PATCH 0/4] ide: generic packet command representation

2008-02-11 Thread Bartlomiej Zolnierkiewicz
On Monday 11 February 2008, Borislav Petkov wrote: Hi Bart, here's the ide_atapi_pc unification series. It all went pretty smoothly along the search replace line. Using driver-specific members in ide_atapi_pc like idefloppy_callback and idetape_callback is kinda dumb but this approach

Re: [PATCH 1/2] ide-tape: move all struct and other defs at the top

2008-02-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 09 February 2008, Borislav Petkov wrote: Hi Bart, thanks for the update earlier. I'll look into blk_{get,put}_request later and try it on idefloppy. In the meantime, here are the patches as requested: Thanks. --- From 0d91862fc802d6f5aa79947b2685de6c209236f2 Mon Sep 17

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Bartlomiej Zolnierkiewicz
On Tuesday 12 February 2008, Benjamin Herrenschmidt wrote: On Fri, 2008-02-08 at 19:40 +1100, Benjamin Herrenschmidt wrote: On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote: - couple of fixes and preparatory patches - rework of PowerMac media-bay support ([un

Re: [RFC PATCH] ide-floppy: use rq-cmd for preparing and sending packet cmds to the drive

2008-02-12 Thread Bartlomiej Zolnierkiewicz
Hi Borislav, On Tuesday 12 February 2008, Borislav Petkov wrote: Hi Bart, here's a first go at converting ide-floppy to using rq-cmd for packet commands. The code below is pretty rough and from what i can tell needs to be hammered a lot more, for it raises a lot of issues: I think that

Re: [PATCH] ide-scsi: do non-atomic pc-flags testing

2008-02-12 Thread Bartlomiej Zolnierkiewicz
On Tuesday 12 February 2008, Borislav Petkov wrote: commit 272976f0f5754707f9e41da315717a6eb8d9d536 Author: Borislav Petkov [EMAIL PROTECTED] Date: Tue Feb 12 16:22:44 2008 +0100 ide-scsi: do non-atomic pc-flags testing Signed-off-by: Borislav Petkov [EMAIL PROTECTED] diff

Re: [PATCH] ide-floppy: rename end_request handler properly

2008-02-12 Thread Bartlomiej Zolnierkiewicz
On Tuesday 12 February 2008, Borislav Petkov wrote: commit 48f9b88d491aa478ffcf21e2f523e3665db0770b Author: Borislav Petkov [EMAIL PROTECTED] Date: Tue Feb 12 09:42:19 2008 +0100 ide-floppy: rename end_request handler properly mv idefloppy_do_end_request -

Re: [PATCH 09/18] ide: rework PowerMac media-bay support

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 13 February 2008, Michael Ellerman wrote: On Fri, 2008-02-08 at 01:45 +0100, Bartlomiej Zolnierkiewicz wrote: Rework PowerMac media-bay support in such way that instead of un/registering the IDE interface we un/register IDE devices: * Add ide_port_scan() helper

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-13 Thread Bartlomiej Zolnierkiewicz
On Wednesday 13 February 2008, Greg KH wrote: On Wed, Feb 13, 2008 at 02:17:37AM +, Alan Cox wrote: Why does the calgary driver need this? Can we just use pci_get_device() instead? Why do you need to walk the device list backwards? Do you get false positives going forward? It

Re: [RFC PATCH] ide-floppy: use rq-cmd for preparing and sending packet cmds to the drive

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 13 February 2008, Borislav Petkov wrote: On Tue, Feb 12, 2008 at 10:39:22PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi Bart, I think that this _really_ should be done _after_ unifying ATAPI handling [*]. Otherwise you will be making some of the same changes

Re: [PATCH 1/2] ide: use generic ATAPI packet command flags in ide-{floppy,tape,scsi}

2008-02-13 Thread Bartlomiej Zolnierkiewicz
On Feb 13, 2008 5:18 PM, Borislav Petkov [EMAIL PROTECTED] wrote: This is done in one single patch in order not to cause git breakage. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] Looks good but could you please reorder patches and move PC_* - PC_FLAG * rename in ide-scsi to the patch

Re: [PATCH 1/2] ide: use generic ATAPI packet command flags in ide-{floppy,tape}

2008-02-13 Thread Bartlomiej Zolnierkiewicz
On Wednesday 13 February 2008, Borislav Petkov wrote: Signed-off-by: Borislav Petkov [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] ide-scsi: do non-atomic pc-flags testing

2008-02-13 Thread Bartlomiej Zolnierkiewicz
On Wednesday 13 February 2008, Borislav Petkov wrote: ...also, convert ide-scsi to using the generic pc-flags defines. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED]

Re: [PATCH] ide-floppy: merge callbacks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
On Wednesday 13 February 2008, Borislav Petkov wrote: commit d1f1f84f413ab00cb2fec48170d022fcd900e214 Author: Borislav Petkov [EMAIL PROTECTED] Date: Wed Feb 13 20:26:56 2008 +0100 ide-floppy: merge callbacks The appropriate functionality of the callback is established

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-13 Thread Bartlomiej Zolnierkiewicz
On Wednesday 13 February 2008, Greg KH wrote: On Wed, Feb 13, 2008 at 09:28:24AM -0800, Greg KH wrote: On Wed, Feb 13, 2008 at 01:34:12PM +0100, Bartlomiej Zolnierkiewicz wrote: On Wednesday 13 February 2008, Greg KH wrote: On Wed, Feb 13, 2008 at 02:17:37AM +, Alan Cox wrote

Re: 2.6.26-git0: IDE oops during boot

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 12 February 2008, Kamalesh Babulal wrote: Bartlomiej Zolnierkiewicz wrote: Hi, On Monday 11 February 2008, Kamalesh Babulal wrote: Nish Aravamudan wrote: On 2/7/08, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: On Thursday 07 February 2008, Kamalesh Babulal

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-13 Thread Bartlomiej Zolnierkiewicz
On Thursday 14 February 2008, Greg KH wrote: On Wed, Feb 13, 2008 at 11:20:36PM +0100, Bartlomiej Zolnierkiewicz wrote: On Wednesday 13 February 2008, Greg KH wrote: On Wed, Feb 13, 2008 at 09:28:24AM -0800, Greg KH wrote: On Wed, Feb 13, 2008 at 01:34:12PM +0100, Bartlomiej

[PATCH 00/11] ide/ppc: remove PPC specific IDE hacks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Previous patchset adding warm-plug support allows the removal of PPC specific IDE hacks (500 LOC gone)... [ Ben, please take a look when you have some time, thanks! ] diffstat: arch/powerpc/kernel/setup_32.c |8 -- arch/powerpc/platforms/powermac/pci.c | 22 ---

[PATCH 01/11] ide-pmac: remove dead code

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Remove unused pmac_ide_{check_base,get_irq}() and pmac_find_ide_boot(), then remove no longer needed ide_majors[] and pmac_ide_count. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ppc/pmac.c | 47

[PATCH 02/11] ppc/hdpu: remove dead IDE code

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Also remove now not needed linux/ide.h include. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/ppc/platforms/hdpu.c | 36 1 file changed, 36 deletions(-) Index: b/arch/ppc/platforms/hdpu.c

[PATCH 03/11] ppc/ppc4xx: remove ppc_ide_md hooks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/ppc/syslib/ppc4xx_setup.c | 23 --- 1 file changed, 23 deletions(-) Index: b/arch/ppc/syslib/ppc4xx_setup.c

[PATCH 04/11] ppc/pmac: remove ppc_ide_md hooks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/powerpc/platforms/powermac/pmac.h |5 --- arch/powerpc/platforms/powermac/setup.c |8 - drivers/ide/ppc/pmac.c | 50 +++- 3 files

[PATCH 10/11] ppc: don't include linux/ide.h

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/ppc/platforms/4xx/bamboo.c |1 - arch/ppc/platforms/4xx/ebony.c |1 - arch/ppc/platforms/4xx/luan.c |1 - arch/ppc/platforms/4xx/ocotea.c |1 - arch

[PATCH 09/11] ppc: remove ppc_ide_md

2008-02-13 Thread Bartlomiej Zolnierkiewicz
/kernel/ppc_ksyms.c - arch/ppc/kernel/setup.c - arch/ppc/platforms/pplus.c - arch/ppc/platforms/prep_setup.c There should be no functional changes caused by this patch. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/powerpc

[PATCH 07/11] ppc/sandpoint: remove ppc_ide_md hooks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
is superior over ide_generic. ] Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/ppc/configs/sandpoint_defconfig |2 arch/ppc/platforms/sandpoint.c | 94 --- arch/ppc/platforms/sandpoint.h

[PATCH 06/11] ppc/lopec: remove ppc_ide_md hooks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
. Thanks. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/ppc/platforms/lopec.c | 85 - drivers/ide/pci/sl82c105.c |4 ++ 2 files changed, 4 insertions(+), 85 deletions(-) Index: b/arch

[PATCH 05/11] ppc/mpc8xx: remove ppc_ide_md hooks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
in ide.c. There should be no other functional changes. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/ppc/syslib/m8xx_setup.c |6 --- drivers/ide/ppc/mpc8xx.c | 86 +++ 2 files

[PATCH 08/11] ppc/pplus: remove ppc_ide_md.ide_init_hwif hook

2008-02-13 Thread Bartlomiej Zolnierkiewicz
* Call ide_init_default_irq() for pplus in init_ide_data(). * Remove no longer needed pplus_ide_init_hwif_ports(). There should be no functional changes caused by this patch. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/ppc

[PATCH 11/11] ppc/pmac: remove no longer needed IDE quirk

2008-02-13 Thread Bartlomiej Zolnierkiewicz
IDE PMAC host driver and all IDE PCI host drivers use pci_enable_device() nowadays so the following quirk in pmac_pcibios_after_init() can be removed. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/powerpc/platforms/powermac/pci.c

mount: could not find filesystem - aacraid? (was: Re: 2.6.26-git0: IDE oops during boot)

2008-02-14 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 14 February 2008, Kamalesh Babulal wrote: Bartlomiej Zolnierkiewicz wrote: Hi, On Tuesday 12 February 2008, Kamalesh Babulal wrote: Bartlomiej Zolnierkiewicz wrote: Hi, On Monday 11 February 2008, Kamalesh Babulal wrote: Nish Aravamudan wrote: On 2/7/08

Re: mount: could not find filesystem - aacraid? (was: Re: 2.6.26-git0: IDE oops during boot)

2008-02-14 Thread Bartlomiej Zolnierkiewicz
On Thursday 14 February 2008, Bartlomiej Zolnierkiewicz wrote: Hi, On Thursday 14 February 2008, Kamalesh Babulal wrote: Bartlomiej Zolnierkiewicz wrote: Hi, On Tuesday 12 February 2008, Kamalesh Babulal wrote: Bartlomiej Zolnierkiewicz wrote: Hi, On Monday 11

Re: IDE cdrom problem with PLEXTOR DVDR PX-608AL

2008-02-14 Thread Bartlomiej Zolnierkiewicz
On Thursday 14 February 2008, Borislav Petkov wrote: On Thu, Feb 14, 2008 at 12:37:50AM +0100, Hans-Peter Jansen wrote: [Added Bart to CC] Am Dienstag, 12. Februar 2008 schrieb Borislav Petkov: On Tue, Feb 12, 2008 at 10:26:17AM +0100, Hans-Peter Jansen wrote: Hi, I suffer

Re: [discuss] pci_get_device_reverse(), why does Calgary need this?

2008-02-14 Thread Bartlomiej Zolnierkiewicz
On Thursday 14 February 2008, Andreas Jaeger wrote: Greg KH [EMAIL PROTECTED] writes: How does the patch below look? I didn't want to remove the whole config option, as there is more to the logic than just the reverse order stuff there. I think you miss Documentation - it's mentioned

Re: [PATCH] ide-floppy: merge callbacks

2008-02-14 Thread Bartlomiej Zolnierkiewicz
On Thursday 14 February 2008, Borislav Petkov wrote: On Wed, Feb 13, 2008 at 11:04:23PM +0100, Bartlomiej Zolnierkiewicz wrote: On Wednesday 13 February 2008, Borislav Petkov wrote: commit d1f1f84f413ab00cb2fec48170d022fcd900e214 Author: Borislav Petkov [EMAIL PROTECTED] Date: Wed

[PATCH 2/2] ide: remove CONFIG_IDE_ARCH_OBSOLETE_INIT

2008-02-14 Thread Bartlomiej Zolnierkiewicz
* Use CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS instead of CONFIG_IDE_ARCH_OBSOLETE_INIT in init_ide_data(). * Remove no longer needed CONFIG_IDE_ARCH_OBSOLETE_INIT. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide

[PATCH 1/2] ide: add CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS

2008-02-14 Thread Bartlomiej Zolnierkiewicz
Add CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS to drivers/ide/Kconfig and use it instead of defining IDE_ARCH_OBSOLETE_DEFAULTS in arch/ide.h. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig |3 +++ drivers/ide/ide.c |5

Re: [PATCH 1/2] ide: add CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS

2008-02-14 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 14 February 2008, Sam Ravnborg wrote: Hi Bart. On Thu, Feb 14, 2008 at 09:55:50PM +0100, Bartlomiej Zolnierkiewicz wrote: Add CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS to drivers/ide/Kconfig and use it instead of defining IDE_ARCH_OBSOLETE_DEFAULTS in arch/ide.h. Signed-off

Re: [PATCH] MAINTAINERS: update ide-cd maintainer's email address

2008-02-16 Thread Bartlomiej Zolnierkiewicz
On Saturday 16 February 2008, Borislav Petkov wrote: commit c65b97fdbb9f3075a37f711aa6b388a48a27d3f4 Author: Borislav Petkov [EMAIL PROTECTED] Date: Sat Feb 16 09:10:46 2008 +0100 MAINTAINERS: update ide-cd maintainer's email address Signed-off-by: Borislav Petkov [EMAIL

[PATCH 09/12] ide: move default IDE ports setup to ide_generic host driver

2008-02-16 Thread Bartlomiej Zolnierkiewicz
CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig |4 +--- drivers/ide/ide-generic.c | 16 +--- drivers/ide/ide.c | 18 -- 3 files changed, 14 insertions(+), 24 deletions(-) Index: b/drivers

[PATCH 10/12] ide: remove ide_init_default_irq() macro

2008-02-16 Thread Bartlomiej Zolnierkiewicz
* Use ide_default_irq() instead of ide_init_default_irq() in ide_generic host driver (so the correct IRQ is always set regardless of CONFIG_PCI / CONFIG_BLK_DEV_IDEPCI). * Remove no longer needed ide_init_default_irq() macro. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 11/12] ide: cleanup ide_match_hwif()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
* Remove no longer needed matching against I/O base and 'io_base' argument. * Move printk() to the caller and remove 'name' argument. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/setup-pci.c | 47 +++ 1 file changed, 15

[PATCH 12/12] ide: cleanup ide_find_port()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Remove no longer needed matching against I/O base and 'base' argument. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/bast-ide.c|2 +- drivers/ide/arm/icside.c |2 +- drivers/ide/arm/ide_arm.c |2 +- drivers/ide/arm/palm_bk3710

[PATCH 06/12] ide: limit legacy VLB host drivers to alpha, x86 and mips

2008-02-16 Thread Bartlomiej Zolnierkiewicz
as BROKEN) [ the common sense tells me that VLB was only used on x86 but there are urban legends that one of these host drivers was needed on some other arch - thus the extra care ] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig |2 +- 1 file changed, 1

[PATCH 03/12] ide: add ide-4drives host driver

2008-02-16 Thread Bartlomiej Zolnierkiewicz
probe itself for IDE devices instead of indirectly depending on ide_generic host driver. * Add probe module parameter to ide-4drives and update documentation. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Documentation/ide.txt|5 ++-- drivers/ide/Kconfig

[PATCH 04/12] cmd640: cleanup setup_device_ptrs()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
This loop is no longer needed. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cmd640.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) Index: b/drivers/ide/pci/cmd640.c

[PATCH 07/12] ide: init hwif-{io_ports,irq} explicitly in legacy VLB host drivers

2008-02-16 Thread Bartlomiej Zolnierkiewicz
to be explicitly enabled with probe parameter. ] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/ali14xx.c | 12 drivers/ide/legacy/dtc2278.c | 12 drivers/ide/legacy/ht6560b.c | 12 drivers/ide/legacy/ide-4drives.c

Re: [BUID_FAILURE] next-20080215 Build failure caused by ide: rework PowerMac media-bay support

2008-02-16 Thread Bartlomiej Zolnierkiewicz
On Friday 15 February 2008, Kamalesh Babulal wrote: The linux-next-20080215 kernel build fails on the powerpc with following error CC arch/powerpc/platforms/powermac/setup.o In file included from arch/powerpc/platforms/powermac/setup.c:66: include/asm/mediabay.h:29: error: syntax

[PATCH 01/12] ide: remove ide_default_io_ctl() macro

2008-02-16 Thread Bartlomiej Zolnierkiewicz
It is always == '((base) + 0x206)' if CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS=y and it is not needed otherwise (arm, blackfin, parisc, ppc64, sh, sparc[64]). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c |2 +- include/asm-alpha/ide.h

[PATCH 05/12] cmd640: init hwif-{io_ports,irq} explicitly

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Do explicit port setup instead of depending on init_ide_data(). This way hwif-io_ports[] and hwif-irq are always correctly set regardless of CONFIG_PCI / CONFIG_BLK_DEV_IDEPCI. [ Remember to not break idex=noprobe parameter. ] While at it fix printk(). Signed-off-by: Bartlomiej Zolnierkiewicz

[PATCH 02/12] ide: remove ppc ifdef from init_ide_data()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
On PPC32 ide_init_default_irq() is non-zero only for PPLUS and PPC_PREP (the latter marked as BROKEN currently) so this ifdef can be removed. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c |2 -- 1 file changed, 2 deletions(-) Index: b/drivers/ide/ide.c

Re: IDE cdrom problem

2008-02-16 Thread Bartlomiej Zolnierkiewicz
On Saturday 16 February 2008, Borislav Petkov wrote: On Sat, Feb 16, 2008 at 04:24:46PM +0100, Bartlomiej Zolnierkiewicz wrote: [ added Borislav (ide-cd maintainer) to cc: ] Hi, Unless there are some very important reasons to keep the discussion private please always cc: linux

Re: Optiarc DVD RW AD-5200A audio playing

2008-02-16 Thread Bartlomiej Zolnierkiewicz
On Saturday 16 February 2008, Borislav Petkov wrote: On Sat, Feb 16, 2008 at 04:24:01PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi, On Saturday 16 February 2008, Borislav Petkov wrote: On Fri, Feb 15, 2008 at 02:53:27PM -0500, Stefan Bader wrote: Hello Borislav, I worked

Re: Optiarc DVD RW AD-5200A audio playing

2008-02-16 Thread Bartlomiej Zolnierkiewicz
On Saturday 16 February 2008, Borislav Petkov wrote: On Sat, Feb 16, 2008 at 06:48:24PM +0100, Bartlomiej Zolnierkiewicz wrote: On Saturday 16 February 2008, Borislav Petkov wrote: On Sat, Feb 16, 2008 at 04:24:01PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi, On Saturday 16

Re: [PATCH 5/13] cy82c693: add -set_dma_mode method

2008-02-16 Thread Bartlomiej Zolnierkiewicz
[ Sorry for the late reply. ] On Friday 04 January 2008, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Fix SWDMA/MWDMA masks in cy82c693_chipset. * Add IDE_HFLAG_CY82C693 host flag and use it in ide_tune_dma() to check whether the DMA should be enabled even

[PATCH 2/2] ide-pmac: use ide_find_port()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ppc/pmac.c | 44 +++- 1 file changed, 19 insertions(+), 25 deletions(-) Index: b/drivers/ide/ppc/pmac.c

[PATCH 1/2] ide-pmac: dynamically allocate struct pmac_ide_hwif instances

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Dynamically allocate struct pmac_ide_hwif instances in pmac_ide_macio_attach() and pmac_ide_pci_attach(), then remove no longer needed pmac_ide[]. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ppc/pmac.c | 49

Re: Optiarc DVD RW AD-5200A audio playing

2008-02-16 Thread Bartlomiej Zolnierkiewicz
On Saturday 16 February 2008, Borislav Petkov wrote: On Sat, Feb 16, 2008 at 07:23:58PM +0100, Bartlomiej Zolnierkiewicz wrote: On Saturday 16 February 2008, Borislav Petkov wrote: On Sat, Feb 16, 2008 at 06:48:24PM +0100, Bartlomiej Zolnierkiewicz wrote: On Saturday 16 February 2008

[PATCH 6/9] umc8672: don't use ide_hwifs[] in umc_set_pio_mode()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/umc8672.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/ide/legacy/umc8672.c === --- a/drivers/ide/legacy/umc8672.c

[PATCH 5/9] scc_pata: store 'hwif' pointer in struct scc_ports

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Replace 'unsigned char hwif_id' by 'ide_hwif_t *hwif' in struct scc_ports. This allows us to remove ide_hwifs[] usage from scc_remove(). There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/scc_pata.c |6

[PATCH 4/9] cmd640: use ide_find_port()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cmd640.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) Index: b/drivers/ide/pci/cmd640.c === --- a/drivers/ide

[PATCH 8/9] qd65xx: return error value in qd_probe()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Return error value in qd_probe() and use it in qd65xx_init() instead of checking ide_hwifs[].chipset. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/qd65xx.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) Index: b/drivers

[PATCH 7/9] ht6560b: use driver name for resource allocation

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/ht6560b.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/drivers/ide/legacy/ht6560b.c === --- a/drivers/ide/legacy/ht6560b.c

[PATCH 1/9] sgiioc4: use ide_find_port()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/sgiioc4.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) Index: b/drivers/ide/pci/sgiioc4.c

[PATCH 9/9] ide: IDE_HFLAG_BOOTABLE - IDE_HFLAG_NON_BOOTABLE

2008-02-16 Thread Bartlomiej Zolnierkiewicz
bootable should be the default behavior so replace IDE_HFLAG_BOOTABLE host flag with IDE_HFLAG_NON_BOOTABLE. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/aec62xx.c |3 ++- drivers/ide/pci

[PATCH 2/9] au1xxx-ide: use ide_find_port()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/mips/au1xxx-ide.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Index: b/drivers/ide/mips/au1xxx-ide.c === --- a/drivers/ide/mips/au1xxx

[PATCH 3/9] cmd640: remove cmd_drives[]

2008-02-16 Thread Bartlomiej Zolnierkiewicz
* Pass 'ide_drive_t *drive' to check_prefetch(), set_prefetch_mode(), program_drive_counts() and cmd640_set_mode(). * Remove no longer needed cmd_drives[]. * Inline setup_device_ptrs() helper in cmd640x_init(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci

[PATCH] falconide: locking bugfix

2008-02-17 Thread Bartlomiej Zolnierkiewicz
] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-generic.c |6 -- drivers/ide/legacy/falconide.c |2 ++ 2 files changed, 2 insertions(+), 6 deletions(-) Index: b/drivers/ide/ide-generic.c

Re: PROBLEM: Corruption problems in pata_via for Via NanoBook owners (Cloudbook, EasyNote XS etc.)

2008-02-17 Thread Bartlomiej Zolnierkiewicz
] Subject: [PATCH] via82cxxx: add new PCI id for cx700 [bart: manually ported it over via82cxxx changes] From: Andrew Smith [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/via82cxxx.c |1 + include/linux/pci_ids.h |1 + 2 files changed, 2

Re: [PATCH 03/12] ide: add ide-4drives host driver

2008-02-17 Thread Bartlomiej Zolnierkiewicz
On Saturday 16 February 2008, Randy Dunlap wrote: [...] +You also need to use probe kernel paramater for ide-4drives driver parameter thanks, fixed in take 2 - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message

Re: [PATCH 1/4] : More use DIV_ROUND_UP

2008-02-17 Thread Bartlomiej Zolnierkiewicz
On Saturday 16 February 2008, Julia Lawall wrote: From: Julia Lawall [EMAIL PROTECTED] The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) / (d)) but is perhaps more readable. An extract of the semantic patch that makes this change is as follows:

[PATCH 1/5] ide: remove PIO downgrade quirk

2008-02-17 Thread Bartlomiej Zolnierkiewicz
No need for it nowadays so remove quirk code from ide_get_best_pio_mode() and IDE_HFLAG_PIO_DOWNGRADE host flag. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-lib.c | 10 -- drivers/ide/pci/amd74xx.c |1 - drivers/ide/pci/via82cxxx.c |1

[PATCH 2/5] ide: merge ide_match_hwif() and ide_find_port()

2008-02-17 Thread Bartlomiej Zolnierkiewicz
(). There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c | 46 ++ drivers/ide/ide.c | 15 --- drivers/ide/setup-pci.c | 48

[PATCH 5/5] ide: unexport ide_hwifs[]

2008-02-17 Thread Bartlomiej Zolnierkiewicz
All modular users have been fixed to not reference ide_hwifs[] directly. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c |5 - 1 file changed, 5 deletions(-) Index: b/drivers/ide/ide.c

[PATCH 3/5] ide: use ide_find_port() in legacy VLB host drivers

2008-02-17 Thread Bartlomiej Zolnierkiewicz
in qd65xx host driver to not use hwif-name. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |4 +- drivers/ide/legacy/ali14xx.c | 19 --- drivers/ide/legacy/dtc2278.c | 22 +++-- drivers/ide/legacy/ht6560b.c | 31

[PATCH 4/5] ide-generic: use ide_find_port()

2008-02-17 Thread Bartlomiej Zolnierkiewicz
There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-generic.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) Index: b/drivers/ide/ide-generic.c

[PATCH 4/4] ide-disk: fix issues found by checkpatch.pl

2008-02-17 Thread Bartlomiej Zolnierkiewicz
There are no changes to the resulting drivers/ide/ide-disk.o binary file (md5sum-s after and before the patch match). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c | 120 - 1 file changed, 70 insertions

[PATCH 2/4] ide-disk: add missing printk() KERN_* levels

2008-02-17 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index: b/drivers/ide/ide-disk.c === --- a/drivers/ide/ide-disk.c +++ b/drivers/ide

[PATCH 3/4] ide-disk: add proc_idedisk_read_smart() helper

2008-02-17 Thread Bartlomiej Zolnierkiewicz
caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c | 39 +-- 1 file changed, 17 insertions(+), 22 deletions(-) Index: b/drivers/ide/ide-disk.c

[PATCH 1/4] ide: fix sparse warning about shadowing 'flags' symbol

2008-02-17 Thread Bartlomiej Zolnierkiewicz
drivers/ide/ide.c:801:18: warning: symbol 'flags' shadows an earlier one drivers/ide/ide.c:732:16: originally declared here Also fix some whitespace damage while at it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c | 13 + 1 file changed, 5

Re: [PATCH 1/5] ide: remove PIO downgrade quirk

2008-02-18 Thread Bartlomiej Zolnierkiewicz
Hi Sergei, On Feb 18, 2008 5:06 PM, Sergei Shtylyov [EMAIL PROTECTED] wrote: Bartlomiej Zolnierkiewicz wrote: No need for it nowadays Since which moment, could you elaborate We fixed: - PIO auto-tuning in core code - PIO programming in host drivers - IORDY handling in core code

Re: [PATCH] next-20080218 build failure at pmac_ide_macio_attach ()

2008-02-18 Thread Bartlomiej Zolnierkiewicz
to preserve bisectability. From: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Subject: [PATCH] ide-pmac: dynamically allocate struct pmac_ide_hwif instances (take 2) * Dynamically allocate struct pmac_ide_hwif instances in pmac_ide_macio_attach() and pmac_ide_pci_attach(), then remove no longer

Re: Optiarc DVD RW AD-5200A audio playing

2008-02-18 Thread Bartlomiej Zolnierkiewicz
On Monday 18 February 2008, Stefan Bader wrote: Borislav Petkov wrote: On Sat, Feb 16, 2008 at 04:24:01PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi, On Saturday 16 February 2008, Borislav Petkov wrote: On Fri, Feb 15, 2008 at 02:53:27PM -0500, Stefan Bader wrote: Hello Borislav

Re: [PATCH ht6560b] Force prefetch for some devices

2008-02-18 Thread Bartlomiej Zolnierkiewicz
On Monday 18 February 2008, Jan Evert van Grootheest wrote: Prefetch needs to be set for some ide devices to work when connected to a ht6560b interface. This was not always done properly, causing a system with a HD and CD on the primary interface to not work properly. Or, in effect, hang hard.

Re: [PATCH] ht6560b can only do up to PIO mode 4

2008-02-18 Thread Bartlomiej Zolnierkiewicz
[EMAIL PROTECTED] Subject: [PATCH] ht6560b can only do up to PIO mode 4 According to the datasheet, ht6560b only supports up to PIO mode 4. [bart: manually ported it over 2.6.25-rc2] Signed-off-by: Jan Evert van Grootheest [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[git patches] IDE fixes

2008-02-18 Thread Bartlomiej Zolnierkiewicz
+ include/linux/Kbuild |2 +- include/linux/hdsmart.h|4 ++-- include/linux/pci_ids.h|1 + 12 files changed, 34 insertions(+), 21 deletions(-) Andrew Smith (1): via82cxxx: add new PCI id for cx700 Bartlomiej Zolnierkiewicz (2): falconide: locking

Re: Optiarc DVD RW AD-5200A audio playing

2008-02-19 Thread Bartlomiej Zolnierkiewicz
On Tuesday 19 February 2008, Borislav Petkov wrote: [...] Author: Borislav Petkov [EMAIL PROTECTED] Date: Sat Feb 16 09:56:36 2008 +0100 ide-cd: Enable audio play quirk for Optiarc DVD RW AD-5200A drive Reported-by: Stefan Bader [EMAIL PROTECTED] Signed-off-by:

Re: [PATCH] ide-cd: remove the internal 64k buffer

2008-02-19 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 19 February 2008, Borislav Petkov wrote: Hi Bart, here's one more item from my TODO list. The removal is straight forward, after testing it with all my cdrom drives they all seem even to rotate quieter due to the automatic speed adjustment of the drive to the continuous

Re: [PATCH 4/5] ide-generic: use ide_find_port()

2008-02-19 Thread Bartlomiej Zolnierkiewicz
On Tuesday 19 February 2008, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/drivers/ide/ide-generic.c

Re: [PATCH 03/12] ide: add ide-4drives host driver

2008-02-19 Thread Bartlomiej Zolnierkiewicz
On Tuesday 19 February 2008, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: CONFIG_BLK_DEV_4DRIVES deserves its own host driver: * Add drivers/ide/legacy/ide-4drives.c and move 4drives support there. * Add ide-4drives.o in the link order after all other legacy host

[PATCH] ide_platform: fix resources handling

2008-02-19 Thread Bartlomiej Zolnierkiewicz
Tell IDE layer to not manage resources by always setting hwif-mmio flag (resources are handled by a platform device). Cc: Anton Vorontsov [EMAIL PROTECTED] Cc: Vitaly Bordug [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/ide_platform.c |5

<    8   9   10   11   12   13   14   >