Re: ST340823A disk size issue

2007-08-01 Thread Bartlomiej Zolnierkiewicz
On Thursday 02 August 2007, Bartlomiej Zolnierkiewicz wrote: Otherwise this patch looks fine and is a bit simpler than my patch. If you fix the printk, add patch description (can use the one from my patch) and add Signed-off-by: I would happily apply it and dump mine version. On the second

Re: ST340823A disk size issue

2007-08-02 Thread Bartlomiej Zolnierkiewicz
On Thursday 02 August 2007, Alan Cox wrote: Additionally fs/partitions/check.c:rescan_partitions() should warn if the partition exceeds device size and we are not seeing any such warning. Why would it if there isn't anything wrong ? Look at the __generic_make_requests() snippet (which was

[PATCH] sc1200: always tune PIO

2007-08-02 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/sc1200.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) Index: b/drivers/ide/pci/sc1200.c === --- a/drivers/ide/pci/sc1200.c +++ b/drivers

[PATCH] ide-cris: always tune PIO

2007-08-02 Thread Bartlomiej Zolnierkiewicz
Cc: Mikael Starvik [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/cris/ide-cris.c |2 ++ 1 file changed, 2 insertions(+) Index: b/drivers/ide/cris/ide-cris.c === --- a/drivers/ide

Re: [PATCH] ide: add cable detection for early UDMA66 devices (take 2)

2007-08-02 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday 30 July 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: * Move ide_in_drive_list() from ide-dma.c to ide-iops.c. * Add ivb_list[] table for listening early UDMA66 devices which don't conform to ATA4 standard wrt cable detection (bit14 is zero

Re: ST340823A disk size issue

2007-08-02 Thread Bartlomiej Zolnierkiewicz
. Thanks to Mikko for investigating the issue and testing this patch. v2: * Add missing export and improve patch description a bit. Cc: Mikko Rapeli [EMAIL PROTECTED] Cc: Alan Cox [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- This patch depends

[PATCH] slc90e66: always tune PIO

2007-08-02 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/slc90e66.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Index: b/drivers/ide/pci/slc90e66.c === --- a/drivers/ide/pci/slc90e66.c

Re: [PATCH] ide: move ide_config_drive_speed() calls to upper layers

2007-08-03 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 28 July 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: On Fri, 27 Jul 2007 02:22:27 +0200 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: * Convert {ide_hwif_t,ide_pci_device_t}-host_flag to be u16. * Add IDE_HFLAG_POST_SET_MODE host

Re: 2.6.23-rc1: pata_via cable detection differs from via82cxxx

2007-08-03 Thread Bartlomiej Zolnierkiewicz
On Saturday 04 August 2007, Alan Cox wrote: On Fri, 3 Aug 2007 20:28:39 +0200 (MEST) Mikael Pettersson [EMAIL PROTECTED] wrote: The machine is an Athlon64 laptop with a K8T800 chipset. With the IDE VIA driver the disk is detected as udma/100: Currently old IDE via driver has a hack in

Re: [PATCH] hook ACPI _PSx method to IDE power on/off

2007-08-04 Thread Bartlomiej Zolnierkiewicz
On Thursday 02 August 2007, Shaohua Li wrote: ACPI spec defines the sequence of IDE power on/off: Powering down: Call _GTM. Power down drive (calls _PS3 method and turns off power planes). Powering up: Power up drive (calls _PS0 method if present and turns on power planes).

[PATCH] ide-pmac: use ide_tune_dma() (take 2)

2007-08-04 Thread Bartlomiej Zolnierkiewicz
controller/device if the device was ide_floppy). Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Ben, any update on the testing status of ide-pmac series? I also merged your patch to my tree but it is lacking description: http://kernel.org

[PATCH 1/11] atiixp: DMA setup fixes

2007-08-04 Thread Bartlomiej Zolnierkiewicz
by atiixp_set_dma_mode() and if SWDMA mode is chosen atiixp_dma_host_on() erroneously enables UDMA, just disable support for SWDMA modes for now. * Enable support for MWDMA0 mode. * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/atiixp.c | 53

[PATCH 3/11] au1xxx-ide: use ide_tune_dma()

2007-08-04 Thread Bartlomiej Zolnierkiewicz
bit not being checked - device not being checked against generic DMA blacklist - transfer mode not being set on device/host * Add PIO autotune fallback to auide_dma_check(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c |3 +++ drivers/ide

[PATCH 2/11] it8213/piix/slc90e66: remove {it8213,piix,slc90e66}_dma_2_pio()

2007-08-04 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/it8213.c | 44 +++- drivers/ide/pci/piix.c | 44 +++- drivers/ide/pci/slc90e66.c | 33 +++-- 3

[PATCH 4/11] hpt34x: fix CONFIG_HPT34X_AUTODMA=n handling

2007-08-04 Thread Bartlomiej Zolnierkiewicz
-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/hpt34x.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) Index: b/drivers/ide/pci/hpt34x.c === --- a/drivers/ide/pci/hpt34x.c +++ b/drivers/ide/pci

[PATCH 5/11] ide: remove drive-init_speed zeroing

2007-08-04 Thread Bartlomiej Zolnierkiewicz
Several host drivers used to reset drive-init_speed in their -ide_dma_check implementations which resulted in incorrect init speed being reported to the user, fix it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/alim15x3.c |2 -- drivers/ide/pci

[PATCH 6/11] ide: remove ide_use_fast_pio()

2007-08-04 Thread Bartlomiej Zolnierkiewicz
-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-lib.c | 15 --- drivers/ide/pci/aec62xx.c |3 +-- drivers/ide/pci/atiixp.c |3 +-- drivers/ide/pci/cmd64x.c |3 +-- drivers/ide/pci/cs5535.c |3 +-- drivers/ide/pci

[PATCH 7/11] cs5530/sc1200: add PIO autotune fallback to -ide_dma_check

2007-08-04 Thread Bartlomiej Zolnierkiewicz
-ide_dma_check to return -1 if DMA cannot be set. * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cs5530.c |6 -- drivers/ide/pci/sc1200.c |6 -- 2 files changed, 8 insertions(+), 4 deletions(-) Index: b/drivers/ide/pci

[PATCH 10/11] ide-pmac: add PIO autotune fallback to -ide_dma_check

2007-08-04 Thread Bartlomiej Zolnierkiewicz
-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ppc/pmac.c |2 ++ 1 file changed, 2 insertions(+) Index: b/drivers/ide/ppc/pmac.c === --- a/drivers/ide/ppc/pmac.c +++ b/drivers/ide/ppc/pmac.c @@ -1587,6 +1587,8

[PATCH 8/11] sl82c105: add PIO autotune fallback to -ide_dma_check

2007-08-04 Thread Bartlomiej Zolnierkiewicz
Since sl82c105 re-programs DMA/PIO timings for DMA enable/disable, and sets -autotune this change shouldn't have any other effect than bringing sl82c105 driver in-line with other host drivers wrt -ide_dma_check implementation. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 11/11] ide: remove -ide_dma_check

2007-08-04 Thread Bartlomiej Zolnierkiewicz
config_drive_for_dma(). * Make ide_tune_dma() static. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/icside.c |9 -- drivers/ide/cris/ide-cris.c| 12 drivers/ide/ide-dma.c

[PATCH 9/10] ide-cris: add PIO autotune fallback to -ide_dma_check

2007-08-04 Thread Bartlomiej Zolnierkiewicz
Since ide-cris allows separate PIO and DMA timings, and ide-cris always sets -autotune this change shouldn't have any other effect than bringing ide-cris driver in-line with other host drivers wrt -ide_dma_check implementation. Cc: Mikael Starvik [EMAIL PROTECTED] Signed-off-by: Bartlomiej

Re: 2.6.23-rc2: check_irq_resend on resume (ali15x3)

2007-08-06 Thread Bartlomiej Zolnierkiewicz
commit 0fc4969b866671dfe39b1a9119d0fdc7ea0f63e5 I doubt that this particular report helps in debugging ne2k-pci problem... ;) On Saturday 04 August 2007, Andrey Borzenkov wrote: Just noticed this; I do not remember having seen it before, but I also do not check dmesg every time after

Re: 2.6.23-rc2 regression: check_irq_resend() warning from cmd64x

2007-08-06 Thread Bartlomiej Zolnierkiewicz
commit 0fc4969b866671dfe39b1a9119d0fdc7ea0f63e5 Linus, please revert it. On Sunday 05 August 2007, Mikael Pettersson wrote: This is on a sparc64 ultra5 with a rev 3 CMD646. Starting with kernel 2.6.23-rc2, each boot triggers a WARNING from kernel/irq/resend.c: Uniform Multi-Platform E-IDE

Re: [PATCH 11/11] ide: remove -ide_dma_check

2007-08-07 Thread Bartlomiej Zolnierkiewicz
On Monday 06 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Index: b/drivers/ide/arm/icside.c === --- a/drivers/ide/arm/icside.c +++ b/drivers/ide/arm/icside.c @@ -309,14 +309,6 @@ static int

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-08 Thread Bartlomiej Zolnierkiewicz
On Sunday 05 August 2007, Sergei Shtylyov wrote: HPT374 BIOS seems to only save f_CNT register value for the function #0 before re-tuning DPLL causing the driver to report obviously distorted f_CNT for the function #1 -- fix this by always reading the saved f_CNT register value from in the

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-08 Thread Bartlomiej Zolnierkiewicz
On Sunday 05 August 2007, Sergei Shtylyov wrote: The Marvell bridge chips used on HighPoint SATA cards do not seem to support the UltraDMA modes 1, 2, and 3 (as well as any MWDMA modes), so the driver needs to account for this in the udma_filter() method. In order to achieve that, do the

Re: [PATCH 3/11] au1xxx-ide: use ide_tune_dma()

2007-08-08 Thread Bartlomiej Zolnierkiewicz
On Monday 06 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Good, that's what I lacked for hpt366.c! Were you planning to push it to Linus soon? Not really but if needed I will extract MWDMA filter part and push it sooner. * Add -mdma_filter to ide_hwif_t

[PATCH 1/4] ide: fix hidden dependencies on CONFIG_IDE_GENERIC

2007-08-09 Thread Bartlomiej Zolnierkiewicz
. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/cris/arch-v10/drivers/Kconfig |1 + arch/cris/arch-v32/drivers/Kconfig |1 + drivers/ide/Kconfig|9 + 3 files changed, 11 insertions(+) Index: b/arch/cris/arch-v10/drivers/Kconfig

[PATCH 2/4] it8213/piix/slc90e66: de-couple PIO and UDMA modes

2007-08-09 Thread Bartlomiej Zolnierkiewicz
Don't force PIO4 when programming UDMA mode (suggested by Sergei). Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/it8213.c |9 - drivers/ide/pci/piix.c | 11 +-- drivers/ide/pci/slc90e66.c | 10

[PATCH 3/4] sis5513: clear prefetch and postwrite for ATAPI devices

2007-08-09 Thread Bartlomiej Zolnierkiewicz
Clear prefetch and postwrite for ATAPI devices instead of depending on BIOS. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/sis5513.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) Index: b/drivers/ide/pci/sis5513.c

[PATCH 4/4] sis5513: remove /proc/ide/sis

2007-08-09 Thread Bartlomiej Zolnierkiewicz
two bugs: - wrong cable bit was checked (0x0001 instead of 0x8000) on ATA_133 chipsets - incorrect UDMA cycle time was reported on ATA_100a/ATA_133 chipsets Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/sis5513.c | 249

Re: [PATCH 1/2] pata_hpt37x: actually clock HPT374 by 50 MHz DPLL

2007-08-09 Thread Bartlomiej Zolnierkiewicz
While at it: On Sunday 05 August 2007, Sergei Shtylyov wrote: Index: linux-2.6/drivers/ata/pata_hpt37x.c === --- linux-2.6.orig/drivers/ata/pata_hpt37x.c +++ linux-2.6/drivers/ata/pata_hpt37x.c @@ -8,12 +8,10 @@ this driver

[PATCH] pata_artop: fix UDMA5 for AEC6280[R] and UDMA6 for AEC6880[R]

2007-08-09 Thread Bartlomiej Zolnierkiewicz
present in IDE aec62xx driver. Cc: Alan Cox [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ata/pata_artop.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) Index: b/drivers/ata/pata_artop.c

Re: [PATCH] pata_artop: fix UDMA5 for AEC6280[R] and UDMA6 for AEC6880[R]

2007-08-09 Thread Bartlomiej Zolnierkiewicz
On Friday 10 August 2007, Alan Cox wrote: On Thu, 9 Aug 2007 23:19:34 +0200 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: Maximum supported UDMA mode for AEC6280[R] is UDMA5 (not UDMA4) and for AEC6880[R] it is UDMA6 (not UDMA5): * Fix the problem by adding missing struct

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-10 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 10 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: The Marvell bridge chips used on HighPoint SATA cards do not seem to support the UltraDMA modes 1, 2, and 3 (as well as any MWDMA modes), so the driver needs to account for this in the udma_filter

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-10 Thread Bartlomiej Zolnierkiewicz
On Friday 10 August 2007, Sergei Shtylyov wrote: Alan Cox wrote: + if (chip_type == HPT374 (PCI_FUNC(dev-devfn) 1)) { + struct pci_dev *dev1 = pci_get_slot(dev-bus, + dev-devfn - 1); Can be NULL Not

Re: [PATCH 3/11] au1xxx-ide: use ide_tune_dma()

2007-08-10 Thread Bartlomiej Zolnierkiewicz
On Friday 10 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Good, that's what I lacked for hpt366.c! Were you planning to push it to Linus soon? Not really but if needed I will extract MWDMA filter part and push it sooner. Erm, may I just merge

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: Index: linux-2.6/drivers/ide/pci/hpt366.c === --- linux-2.6.orig/drivers/ide/pci/hpt366.c +++ linux-2.6/drivers/ide/pci/hpt366.c

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: + if (chip_type == HPT374 (PCI_FUNC(dev-devfn) 1)) { + struct pci_dev *dev1 = pci_get_slot(dev-bus, +dev

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: + if (chip_type == HPT374 (PCI_FUNC(dev-devfn) 1)) { + struct pci_dev *dev1 = pci_get_slot(dev-bus, + dev-devfn

Re: [PATCH 3/11] au1xxx-ide: use ide_tune_dma()

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, you wrote: Bartlomiej Zolnierkiewicz wrote: Good, that's what I lacked for hpt366.c! Were you planning to push it to Linus soon? Not really but if needed I will extract MWDMA filter part and push it sooner. Erm, may I just merge it to my patch

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Index: linux-2.6/drivers/ide/pci/hpt366.c === --- linux-2.6.orig/drivers/ide/pci/hpt366.c +++ linux-2.6/drivers/ide/pci/hpt366.c

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: + if (chip_type == HPT374 (PCI_FUNC(dev-devfn) 1)) { + struct pci_dev *dev1 = pci_get_slot(dev-bus, +dev-devfn - 1

Re: [PATCH] pata_cmd64x: Set up MWDMA modes properly

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Hello. Alan Cox wrote: Set the MWDMA timing by updating the correct registers. Split the PIO path as this is mostly shared code. Wants testing. Cool! So much simpler than my fix to the old IDE driver... Signed-off-by: Alan Cox

[PATCH 1/7] ide: use PCI_VDEVICE() macro

2007-08-18 Thread Bartlomiej Zolnierkiewicz
While at it: - make struct pci_device_id tables const - use PCI_DEVICE_ID_ITE_8213 define in it8213.c - fix comment in generic.c Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/aec62xx.c | 12 - drivers/ide/pci/alim15x3.c |6 ++-- drivers

[PATCH 2/7] ide: remove CONFIG_BLK_DEV_IDEDMA_FORCED

2007-08-18 Thread Bartlomiej Zolnierkiewicz
This code doesn't use pci_assign_resource() and ide_get_or_set_dma_base() uses pci_resource_start() to get DMA base address so it has no chance of working. Moreover this belongs to PCI quirks (in case somebody would like to fix it). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 7/7] ide: add DECLARE_GENERIC_PCI_DEV() macro to generic IDE PCI host driver

2007-08-18 Thread Bartlomiej Zolnierkiewicz
* Add DECLARE_GENERIC_PCI_DEV() macro to generic IDE PCI host driver and use it to cleanup generic_chipsets[]. * Remove dead/obsolete code while at it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/generic.c | 113

[PATCH 5/7] ide: add hdx=nodma kernel parameter

2007-08-18 Thread Bartlomiej Zolnierkiewicz
* Add hdx=nodma option allowing user to disallow DMA for a given device. * Obsolete ide=nodma option. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Documentation/ide.txt |4 ++-- drivers/ide/ide-dma.c |2 +- drivers/ide/ide.c |7 +-- include/linux/ide.h

[PATCH 3/7] ide: remove idex=dma kernel parameter

2007-08-18 Thread Bartlomiej Zolnierkiewicz
It has been obsoleted since 1 Nov 2004, is valid only when used together with ide=nodma kernel parameter (which makes no sense) and only for aec62xx, cmd64x, cs5220, generic, hpt366, sl82c105, tc86c001 and triflex host drivers. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 6/7] ide: remove CONFIG_IDEDMA_ONLYDISK

2007-08-18 Thread Bartlomiej Zolnierkiewicz
ATAPI devices with broken DMA support should be handled by DMA blacklist and for debugging purposes we have new shiny hdx=nodma kernel paremeter. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig | 10 -- drivers/ide/ide-probe.c |5 + 2

Re: [PATCH 1/8] alim15x3: PIO fallback fix

2007-08-18 Thread Bartlomiej Zolnierkiewicz
On Saturday 18 August 2007, you wrote: Bartlomiej Zolnierkiewicz wrote: [PATCH] alim15x3: PIO fallback fix If DMA tuning fails always set the best PIO mode. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Oh, it's

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-18 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Hello, I wrote: 101 files changed, 1880 insertions(+), 2828 deletions(-) please look at -mm or IDE quilt tree instead. :) Looking... When are you planning to push out to Linus the

[git patches] IDE fixes

2007-08-20 Thread Bartlomiej Zolnierkiewicz
|4 +- 15 files changed, 113 insertions(+), 74 deletions(-) Bartlomiej Zolnierkiewicz (12): ide: fix hidden dependencies on CONFIG_IDE_GENERIC ide-cris: fix -set_pio_mode method to set transfer mode on the device ide: config_drive_for_dma() fixes ide-pmac

Re: [PATCH] ide: fix PCI refcounting

2007-08-21 Thread Bartlomiej Zolnierkiewicz
On Saturday 18 August 2007, Sergei Shtylyov wrote: The IDE core never marked the PCI IDE devices as being in use after succesfull driver probe call (the devices were marked in use only while being probed), and so was susceptible to issues caused by unsolicited PCI hotplug device removal. So,

Re: [PATCH 1/4] ide: add ide_dev_is_sata() helper

2007-08-21 Thread Bartlomiej Zolnierkiewicz
On Sunday 19 August 2007, Sergei Shtylyov wrote: Make the SATA drive detection code from eighty_ninty_three() into inline ide_dev_is_sata() helper fixing it along the way to be more strict while checking word 80 for the reserved values... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]

Re: [PATCH 2/4] hpt366: UltraDMA filter for SATA cards (take 2)

2007-08-21 Thread Bartlomiej Zolnierkiewicz
On Sunday 19 August 2007, Sergei Shtylyov wrote: The Marvell bridge chips used on HighPoint SATA cards do not seem to support the UltraDMA modes 1, 2, and 3 as well as any MWDMA modes, so the driver needs to account for this in the udma_filter() method. In order to achieve that, do the

Re: [PATCH 2.6.23-rc3] pata_pdc2027x: PLL detection fixes

2007-08-24 Thread Bartlomiej Zolnierkiewicz
On Friday 24 August 2007, Sergei Shtylyov wrote: Hello. Albert Lee wrote: b) puts more work [the enter test mode stuff] in between the start and and sampling points, reducing the precision of the PLL detection; I actually observed quite noticeable differences in detected PLL

Re: [PATCH] mpc8xx: Only build mpc8xx on arch/ppc

2007-08-27 Thread Bartlomiej Zolnierkiewicz
On Thursday 23 August 2007, Kumar Gala wrote: Currently the mpc8xx ide driver will only work on arch/ppc so only allow it to be built there. Also, killed a minor include that isn't actually used by the driver. Signed-off-by: Kumar Gala [EMAIL PROTECTED] applied - To unsubscribe from this

Re: [PATCH 2/4] hpt366: UltraDMA filter for SATA cards (take 3)

2007-08-27 Thread Bartlomiej Zolnierkiewicz
Hello, On Saturday 25 August 2007, Sergei Shtylyov wrote: The Marvell bridge chips used on HighPoint SATA cards do not seem to support the UltraDMA modes 1, 2, and 3 as well as any MWDMA modes, so the driver needs to account for this in the udma_filter() method. In order to achieve that, do

Re: [PATCH 1/4] ide: add ide_dev_is_sata() helper (take 2)

2007-08-27 Thread Bartlomiej Zolnierkiewicz
On Saturday 25 August 2007, Sergei Shtylyov wrote: Make the SATA drive detection code from eighty_ninty_three() into inline ide_dev_is_sata() helper fixing it along the way to be more strict while checking word 80 for the reserved values... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-27 Thread Bartlomiej Zolnierkiewicz
On Saturday 25 August 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: The Marvell bridge chips used on HighPoint SATA cards do not seem to support the UltraDMA modes 1, 2, and 3 (as well as any MWDMA modes), so the driver needs to account for this in the udma_filter

Re: [PATCH 1/2] pdc202xx_new: fix PCI refcounting

2007-08-27 Thread Bartlomiej Zolnierkiewicz
On Sunday 26 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: The driver erroneously lets go the mate IDE chip in init_setup_pdc20270() when ide_setup_pci_devices() call succeeds -- fix this, and drop a couple of useless assignments in this function while

[PATCH 2/8] amd74xx: remove /proc/ide/amd74xx

2007-08-27 Thread Bartlomiej Zolnierkiewicz
This belongs to user-space (and only if really needed). textdata bss dec hex filename 67232000 288751222f drivers/ide/pci/amd74xx.o.before 38332000 16584916d9 drivers/ide/pci/amd74xx.o.after Signed-off-by: Bartlomiej Zolnierkiewicz

[PATCH 4/8] ide: add IDE_HFLAG_BOOTABLE host flag

2007-08-27 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_BOOTABLE host flag and IDE_HFLAG_OFF_BOARD define. Convert all host drivers using ide_pci_device_t to use IDE_HFLAG_{BOOTABLE,OFF_BOARD} instead of d-bootable and then remove no longer needed d-bootable. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide

[PATCH 7/8] ide: add IDE_HFLAG_NO_LBA48 and IDE_HFLAG_NO_LBA48_DMA host flags

2007-08-27 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_NO_LBA48[_DMA] host flags, use it instead of hwif-no_lba48[_dma] and then remove no longer needed hwif-no_lba48[_dma]. As a side-effect this change fixes hwif-no_lba48_dma not being restored by ide_hwif_restore(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 6/8] ide: remove -init_setup_dma from ide_pci_device_t

2007-08-27 Thread Bartlomiej Zolnierkiewicz
which PCI BAR to use, remove no longer needed cs5520.c::cs5520_init_setup_dma() and ide_pci_device_t.init_setup_dma. This fixes PCI bus-mastering and DMA simplex mode not being checked for CS5510/CS5520 hosts. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci

[PATCH 5/8] ide: add IDE_HFLAG_NO_{DMA,AUTODMA} host flags

2007-08-27 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_NO_{DMA,AUTODMA} host flags. Convert all host drivers using ide_pci_device_t to use these flags instead of d-autodma and then remove no longer needed d-autodma. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/aec62xx.c |8 ++-- drivers

[PATCH 3/8] ide: add IDE_HFLAG_NO_ATAPI_DMA host flag

2007-08-27 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_NO_ATAPI_DMA host flag and set it in host drivers which don't support ATAPI DMA. Then remove no longer needed hwif-atapi_dma. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/icside.c |1 - drivers/ide/cris/ide-cris.c|1 + drivers

[PATCH 8/8] ata: add ATA_MWDMA* and ATA_SWDMA* defines

2007-08-27 Thread Bartlomiej Zolnierkiewicz
Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- include/linux/ata.h | 13 + 1 file changed, 13 insertions(+) Index: b/include/linux/ata.h === --- a/include/linux/ata.h

[PATCH 10/8] ide: add -mwdma_mask and -swdma_mask to ide_pci_device_t

2007-08-27 Thread Bartlomiej Zolnierkiewicz
masks. While at it: * Use ATA_{UDMA,MWDMA,SWDMA}* defines. * hpt34x.c: add separate ide_pci_device_t instances for HPT343 and HPT345. * serverworks.c: fix DMA masks being set before checking DMA base. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Yes, you guessed right! patch #10

[PATCH 1/10] ide: use pci_dev-revision

2007-08-29 Thread Bartlomiej Zolnierkiewicz
Some places were using PCI_CLASS_REVISION instead of PCI_REVISION_ID so they were not converted by commit 44c10138fd4bbc4b6d6bff0873c24902f2a9da65. Cc: Auke Kok [EMAIL PROTECTED] Cc: Greg Kroah-Hartman [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Quick grep

[PATCH 2/10] ide: use I/O ops directly part #2

2007-08-29 Thread Bartlomiej Zolnierkiewicz
Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/hpt366.c | 43 --- drivers/ide/pci/piix.c |4 ++-- drivers/ide/pci/tc86c001.c | 12 ++-- 3 files changed, 28

[PATCH 3/10] aec62xx: remove -init_setup

2007-08-29 Thread Bartlomiej Zolnierkiewicz
Merge init_setup_{aec62xx,aec6x80}() into aec62xx_init_one(). While at it: * Use id-driver_data instead of dev-device. * Use ATA_UDMA6 define. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/aec62xx.c | 39 ++- 1 file

[PATCH 4/10] cmd64x: remove -init_setup

2007-08-29 Thread Bartlomiej Zolnierkiewicz
Merge init_setup_{cmd64x,cmd646}() into cmd64x_init_one(). Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cmd64x.c | 39 --- 1 file changed, 12 insertions(+), 27 deletions(-) Index: b

[PATCH 6/10] pdc202xx_new: remove -init_setup

2007-08-29 Thread Bartlomiej Zolnierkiewicz
* Split off pdc20270_get_dev2() helper from init_setup_pdc20270(). * Merge init_setup_{pdcnew,pdc20270,pdc20276}() into pdc202new_init_one(). While at it: * Change KERN_ level of interrupt fixup message from KERN_WARNING to KERN_INFO. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 5/10] hpt366: remove -init_setup

2007-08-29 Thread Bartlomiej Zolnierkiewicz
and fix .enablebits/.host_flags for HPT36x hpt366_chipsets[] entry. * Bump driver version. Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/hpt366.c | 306 +++ 1 file changed, 127 insertions

[PATCH 7/10] pdc202xx_old: remove -init_setup

2007-08-29 Thread Bartlomiej Zolnierkiewicz
* Split off pdc202ata4_fixup_irq() helper from init_setup_pdc202ata4(). * Merge init_setup_{pdc202ata4,pdc20265,pdc202xx}() into pdc202xx_init_one(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/pdc202xx_old.c | 57

[PATCH 9/10] serverworks: remove -init_setup

2007-08-29 Thread Bartlomiej Zolnierkiewicz
Merge init_setup_{svwks,csb6}() into svwks_init_one(). While at it: * Remove redundant dev-device checks. * Operate on a local copy of serverworks_chipsets[] entry. * Use pci_resource_start(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/serverworks.c

[PATCH 10/10] ide: remove .init_setup from ide_pci_device_t

2007-08-29 Thread Bartlomiej Zolnierkiewicz
Now that all users were fixed we can safely remove it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- include/linux/ide.h |1 - 1 file changed, 1 deletion(-) Index: b/include/linux/ide.h === --- a/include/linux

Re: [PATCH 1/10] ide: use pci_dev-revision

2007-08-29 Thread Bartlomiej Zolnierkiewicz
On Wednesday 29 August 2007, Kok, Auke wrote: Bartlomiej Zolnierkiewicz wrote: Some places were using PCI_CLASS_REVISION instead of PCI_REVISION_ID so they were not converted by commit 44c10138fd4bbc4b6d6bff0873c24902f2a9da65. that's actually another effort that I'm working on atm. You

Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards

2007-09-03 Thread Bartlomiej Zolnierkiewicz
On Sunday 02 September 2007, Sergei Shtylyov wrote: Hello, I wrote: The patch was 4/4 of course. :- Probably I was too esctatic about the code. ;-) The Marvell bridge chips used on HighPoint SATA cards do not seem to support the MWDMA modes (at least that caould be seen in

Re: [PATCH 3/4] ide: make ide_rate_filter() also respect PIO and SW/MW DMA mode masks (take 2)

2007-09-03 Thread Bartlomiej Zolnierkiewicz
Hi, On Sunday 02 September 2007, Sergei Shtylyov wrote: Make ide_rate_filter() also respect PIO/SWDMA/MWDMA mode masks. While at it, Hm, this seems to be already dealt with by:

[PATCH] via82cxxx: add Arima W730-K8 and other rebadgings to short cables list

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Port of Alan's patch for pata_via.c. Cc: Alan Cox [EMAIL PROTECTED] Cc: Mikael Pettersson [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/via82cxxx.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) Index: b/drivers/ide

Re: [PATCH 2/10] ide: use I/O ops directly part #2

2007-09-05 Thread Bartlomiej Zolnierkiewicz
On Saturday 01 September 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Strange I thought I've already replaced everything in hpt366.c ... although we could switch

[PATCH 1/13] aec62xx: no need to disable UDMA in -init_hwif method for ATP850UF

2007-09-05 Thread Bartlomiej Zolnierkiewicz
* No need to disable UDMA in -init_hwif method for ATP850UF (and since we now always tune PIO it will be disabled by -set_pio_mode calls anyway). * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/aec62xx.c | 14 +- 1 file

[PATCH 2/13] pdc202xx_new: add DECLARE_PDCNEW_DEV() macro

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/pdc202xx_new.c | 76 ++--- 1 file changed, 19 insertions(+), 57 deletions(-) Index: b/drivers/ide/pci/pdc202xx_new.c

[PATCH 3/13] pdc202xx_old: add DECLARE_PDC2026X_DEV() macro

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/pdc202xx_old.c | 60 - 1 file changed, 19 insertions(+), 41 deletions(-) Index: b/drivers/ide/pci/pdc202xx_old.c

[PATCH 4/13] piix: add DECLARE_ICH_DEV() macro

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Add DECLARE_ICH_DEV() macro. While at it: * Add init_hwif_ich() (-init_hwif method) for ICH controllers. * Rename init_chipset_piix() to init_chipset_ich() and use it only for ICH controllers. * Remove no longer needed piix_is_ichx() helper. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 5/13] ide: add IDE_HFLAG_ERROR_STOPS_FIFO host flag

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_ERROR_STOPS_FIFO host flag and use it instead of hwif-err_stops_fifo. As a side-effect this change fixes hwif-err_stops_fifo not being restored by ide_hwif_restore(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c |3 ++- drivers

[PATCH 6/13] ide: add IDE_HFLAG_SERIALIZE host flag

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_SERIALIZE host flag to tell ide_pci_setup_ports() to set hwif/mate-serialized and convert aec62xx, cs5530 and sc1200 host drivers to use it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/aec62xx.c | 10 +- drivers/ide/pci/cs5530.c |7

[PATCH 7/13] ide: add IDE_HFLAG_LEGACY_IRQS host flag

2007-09-05 Thread Bartlomiej Zolnierkiewicz
-init_hwif for MPIIX. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/atiixp.c |8 +++- drivers/ide/pci/piix.c| 24 ++-- drivers/ide/pci/serverworks.c | 15 +++ drivers/ide/pci/sis5513.c |6 ++ drivers/ide

[PATCH 9/13] cs5520: always tune PIO

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Since cs5520 uses VDMA best PIO mode was tuned anyway by ide_dma_check() but only if DMA was successfully initialized. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cs5520.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Index: b/drivers/ide

[PATCH 11/13] opti621: always tune PIO

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/opti621.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: b/drivers/ide/pci/opti621.c === --- a/drivers/ide/pci/opti621.c +++ b

[PATCH 12/13] triflex: always tune PIO

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/triflex.c |3 +++ 1 file changed, 3 insertions(+) Index: b/drivers/ide/pci/triflex.c === --- a/drivers/ide/pci/triflex.c +++ b/drivers/ide/pci

[PATCH 13/13] ide: set drive-autotune in ide_pci_setup_ports()

2007-09-05 Thread Bartlomiej Zolnierkiewicz
: * MPIIX controller (no -init_hwif method so also no -set_pio_mode method) However if there is no -set_pio_mode method there are no changes in behavior w.r.t. PIO tuning so always set drive-autotune in ide_pci_setup_ports(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide

[PATCH 8/13] alim15x3: always tune PIO

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/alim15x3.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Index: b/drivers/ide/pci/alim15x3.c === --- a/drivers/ide/pci/alim15x3.c

[git patches] IDE fixes for 2.6.23-rc6

2007-09-11 Thread Bartlomiej Zolnierkiewicz
files changed, 141 insertions(+), 97 deletions(-) Bartlomiej Zolnierkiewicz (1): via82cxxx: add Arima W730-K8 and other rebadgings to short cables list Daniel Exner (1): pata_ali/alim15x3: override 80-wire cable detection for Toshiba S1800-814 Kumar Gala (1): mpc8xx: Only build

Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards

2007-09-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 08 September 2007, Sergei Shtylyov wrote: Hello, I wrote: Sergei Shtylyov wrote: The patch was 4/4 of course. :- Probably I was too esctatic about the code. ;-) Or rarher me. :-) The Marvell bridge chips used on HighPoint SATA cards do not seem to support

Re: [PATCH 3/4] ide: make ide_rate_filter() also respect PIO and SW/MW DMA mode masks (take 2)

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 08 September 2007, Sergei Shtylyov wrote: Once I quothed: Make ide_rate_filter() also respect PIO/SWDMA/MWDMA mode masks. While at it, make the udma_filter() method calls take precedence over using the mode masks. This one not looking to pretty -- I've geve

<    1   2   3   4   5   6   7   8   9   10   >