.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux-ide-export/drivers/ide/ide-dma.c
===
--- linux-ide-export.orig/drivers/ide/ide-dma.c 2005-02-02 10:28:05.642130143
+0900
+++ linux-ide-export/drivers/ide/ide-dma.c 2005-02
condition between ide_get_error_location()
and other requests.
2. ide_queue_flush_cmd() converted to use REQ_DRIVE_TASKFILE.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux-ide-export/drivers/ide/ide-disk.c
Bartlomiej Zolnierkiewicz wrote:
On Wed, 2 Feb 2005 12:10:37 +0900, Tejun Heo [EMAIL PROTECTED] wrote:
26_ide_taskfile_cmd_ioctl.patch
ide_cmd_ioctl() converted to use ide_taskfile_ioctl(). This
is the last user of REQ_DRIVE_CMD.
ide_cmd_ioctl() needs to map to taskfile transport
Hello, Bartlomiej.
These patches are the split versions of 05_ide_merge_pci_driver_hc.
I removed crappy/unused macros from aec62xx, pdc202xx_old and
serverworks drivers in respective *_cleanup patches and merged
.h into .c files in *_merge patches.
[ Start of patch descriptions ]
10_ide_pci_pdc202xx_old_cleanup.patch
Removes SPLIT_BYTE macro from ide/pci/pdc202xx_old driver.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux-idepci-export/drivers/ide/pci/pdc202xx_old.c
===
--- linux-idepci
07_ide_pci_it8172_merge.patch
Merges ide/pci/it8172.h into it8172.c.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux-idepci-export/drivers/ide/pci/it8172.c
===
--- linux-idepci-export.orig/drivers/ide/pci/it8172
03_ide_pci_cmd64x_merge.patch
Merges ide/pci/cmd64x.h into cmd64x.c.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux-idepci-export/drivers/ide/pci/cmd64x.c
===
--- linux-idepci-export.orig/drivers/ide/pci
on taskfile-command for all dma commands)
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux-ide-series3-export/drivers/ide/ide-io.c
===
--- linux-ide-series3-export.orig/drivers/ide/ide-io.c 2005-02-06
19:49
are
- flagged taskfile now honors HOB feature register.
- No do_rw_taskfile() HIHI check on select register. Except
for the DEV bit, all bits are honored.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux-ide-series3-export/drivers/ide/ide-taskfile.c
02_ide_do_rw_disk_use_write_taskfile.patch
__ide_do_rw_disk() rewritten using ide_write_taskfile().
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux-ide-series3-export/drivers/ide/ide-disk.c
===
--- linux-ide
Hello, B. Zolnierkiewicz.
These patches are various fixes/improvements to the ide driver. They
are against the 2.6 bk tree as of today (20050202).
01_ide_remove_adma100.patch
Removes drivers/ide/pci/adma100.[hc]. The driver isn't
compilable (missing functions) and no Kconfig
01_ide_remove_adma100.patch
Removes drivers/ide/pci/adma100.[hc]. The driver isn't
compilable (missing functions) and no Kconfig actually enables
CONFIG_BLK_DEV_ADMA100.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux-ide
03_ide_cleanup_opti621.patch
In drivers/ide/pci/opti612.[hc], init_setup_opt621() is
declared, defined and referenced but never actullay used.
Thie patch removes the function.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux
26_ide_taskfile_cmd_ioctl.patch
ide_cmd_ioctl() converted to use ide_taskfile_ioctl(). This
is the last user of REQ_DRIVE_CMD.
Index: linux-ide-export/drivers/ide/ide-iops.c
===
---
Sorry, this is the same 08 patch with the correct subject line.
08_ide_do_identify_model_string_termination.patch
Terminates id-model string before invoking strstr() in
do_identify().
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux-ide-export/drivers/ide/ide-probe.c
27_ide_remove_cmd.patch
Removed unused REQ_DRIVE_CMD handling.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux-ide-export/drivers/ide/ide-io.c
===
--- linux-ide-export.orig/drivers/ide/ide-io.c 2005-02-02 10:28
are
converted to use time_{after|before} macros.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux-ide-export/drivers/ide/ide-io.c
===
--- linux-ide-export.orig/drivers/ide/ide-io.c 2005-02-02 10:28:03.340503581
+0900
layer.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux-ide-export/drivers/ide/ide-taskfile.c
===
--- linux-ide-export.orig/drivers/ide/ide-taskfile.c2005-02-02
10:28:05.642130143 +0900
+++ linux-ide-export/drivers/ide/ide
change any behavior. (The code will get used in
later patches.)
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux-ide-export/drivers/ide/ide-taskfile.c
===
--- linux-ide-export.orig/drivers/ide/ide-taskfile.c2005-02-02
Sorry, the original #14 added back SVWKS_DEBUG_DRIVE_INFO which #13
removed. This is the regenerated patch.
14_ide_pci_serverworks_merge.patch
Merges ide/pci/serverworks.h into serverworks.c.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux-idepci-export/drivers/ide/pci
Oops, I accidentally put , , in the To: line of all the mails which
contain patches, and they don't show up on the lkml. I'll post the
patches again.
Bartlomiej, if you got the first set of patches, please ignore them.
The contents are identical, so if you've already reviewed them, you
Tejun Heo wrote:
Oops, I accidentally put , , in the To: line of all the mails which
contain patches, and they don't show up on the lkml. I'll post the
patches again.
Bartlomiej, if you got the first set of patches, please ignore them.
The contents are identical, so if you've already
06_ide_remove_task.patch
Unused REQ_DRIVE_TASK handling removed.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux-ide-series2-export/drivers/ide/ide-io.c
===
--- linux-ide-series2-export.orig/drivers/ide/ide-io.c
Hello, Bartlomiej. Happy new lunar year.
Bartlomiej Zolnierkiewicz wrote:
I would prefer to not teach do_rw_taskfile() about -tf_{in,out}_flags
(and convert all users to use helpers) - it is much simpler this way,
-flags field in ide_task_t is needed anyway (32-bit I/O flag).
New lunar year day
().
* fixes taskfile ioctl oops bug which was caused by referencing
NULL rq-rq_disk of taskfile requests.
* enables TASKFILE ioctls to get valid register outputs on
successful completion.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
drivers/ide/ide-dma.c
04_ide_ATA_TFLAG_LBA48.patch
This small patch fixes unneeded writes/reads to LBA48 taskfile
registers on LBA48 capable disks for following cases:
* Power Management requests
(WIN_FLUSH_CACHE[_EXT], WIN_STANDBYNOW1, WIN_IDLEIMMEDIATE commands)
* special
08_ide_remove_task.patch
Unused REQ_DRIVE_TASK handling removed.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
drivers/block/ll_rw_blk.c |1
drivers/ide/ide-io.c | 48 +++---
drivers/ide/ide-lib.c |2 -
include/linux/blkdev.h
10_ide_taskfile_cmd_ioctl.patch
ide_cmd_ioctl() rewritten to use taskfile transport. This is
the last user of REQ_DRIVE_CMD.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
drivers/ide/ide-taskfile.c | 118 -
include/linux/ide.h
() converted to use REQ_DRIVE_TASKFILE.
By this change, when WIN_FLUSH_CACHE_EXT is used, full HOB
registers are written and read. This isn't optimal but
shouldn't be noticeable either.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
drivers/ide/ide-disk.c | 19
07_ide_taskfile_task_ioctl.patch
ide_task_ioctl() rewritten to use taskfile transport. This is
the last user of REQ_DRIVE_TASK.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
ide-taskfile.c | 50 +++---
1 files changed, 31 insertions
09_ide_taskfile_cmd.patch
All in-kernel REQ_DRIVE_CMD users except for ide_cmd_ioctl()
converted to use REQ_DRIVE_TASKFILE.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
ide-disk.c |1 -
ide.c | 15 ---
2 files changed, 12 insertions(+), 4 deletions
03_ide_diag_taskfile_use_init_drive_cmd.patch
In ide_diag_taskfile(), taskfile rq was initialized using
memset(). Use init_drive_cmd() instead.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
ide-taskfile.c |3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
Index: linux
11_ide_remove_cmd.patch
Unused REQ_DRIVE_CMD handling removed.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
drivers/block/ll_rw_blk.c |1
drivers/ide/ide-io.c | 181 ++
drivers/ide/ide-lib.c |8 --
include/linux/blkdev.h
Bartlomiej Zolnierkiewicz wrote:
On Sunday 27 February 2005 05:51, Tejun Heo wrote:
Hello, Bartlomiej,
On Thu, Feb 24, 2005 at 03:45:39PM +0100, Bartlomiej Zolnierkiewicz wrote:
Original patch from Tejun Heo [EMAIL PROTECTED],
ported over recent IDE changes by me.
* teach ide_tf_get_address
Hi,
Bartlomiej Zolnierkiewicz wrote:
On Sunday 27 February 2005 08:36, Tejun Heo wrote:
Hello, Bartlomiej.
This patch should be modified to use flagged taskfile if the
task_end_request_fix patch isn't applied. As non-flagged taskfile
won't return valid result registers, TASK ioctl users won't
Hello, Bartlomiej.
This patch updates Documentation/ioctl/hdio.txt. I'm gonna use this
documentation as reference for future changes, so I tried to include
all the specifics.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux-taskfile-ng/Documentation/ioctl/hdio.txt
Hello, Bartlomiej.
This patch fixes ide_dma_intr() oops which occurs for TASKFILE ioctl
using DMA dataphses. This is against the latest ide-dev-2.6 tree +
all your recent 9 patches.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux-taskfile-ng/drivers/ide/ide-dma.c
Hello, again.
I've updated descriptions regarding SELECT register.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: linux-taskfile-ng/Documentation/ioctl/hdio.txt
===
--- linux-taskfile-ng.orig/Documentation/ioctl/hdio.txt 2005
Hello, Jens.
Jens Axboe wrote:
On Thu, Mar 03 2005, Tejun Heo wrote:
Hello, Bartlomiej.
This patch fixes ide_dma_intr() oops which occurs for TASKFILE ioctl
using DMA dataphses. This is against the latest ide-dev-2.6 tree +
all your recent 9 patches.
Signed-off-by: Tejun Heo [EMAIL PROTECTED
.
* ide_init_setmult_cmd(): ditto
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
drivers/ide/ide-disk.c | 31 ++---
drivers/ide/ide-dma.c | 16 --
drivers/ide/ide-io.c | 21 +--
drivers/ide/ide-taskfile.c | 263 +
include/linux/ata.h
04_ide_remove_unused_fields.patch
Remove unused fields ide_drive_t-rq and ide_task_t-special
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
drivers/ide/ide-tape.c |1 -
include/linux/ide.h|2 --
2 files changed, 3 deletions(-)
Index: linux-taskfile-ng/drivers/ide/ide-tape.c
commands). The following behavior changes occur.
* ide_taskfile_ioctl(): req_task-command_type is ignored.
This doesn't make any difference except for error/crash
cases in the original code.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
drivers/ide/ide-disk.c
Kanniball wrote:
Well let's see if we can get the tecnical info...
This is a very annoying problem... so please devs give us the info we need,
and we'll try to do your best
Hello, Kanniball.
I've digged lkml previously and what I've found out are
* It's basically because of faulty SATA
Hello, guys.
As I also have two seagate drives and siimage controller, I spent
some time tinkering with those, and the benchmark result looks okay.
I'll tidy up the patch and post it tomorrow or the day after tomorrow.
The patch makes sata_sil driver report normal max_sectors and loops
over
%CP
16 1541 99 + +++ + +++ 1895 98 + +++ 8682 99
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Index: libata-export/drivers/scsi/sata_sil.c
===
--- libata-export.orig/drivers/scsi/sata_sil.c 2005-03
Jens Axboe wrote:
On Wed, Jul 06 2005, Jens Axboe wrote:
On Mon, Jul 04 2005, Jens Axboe wrote:
On Fri, Jul 01 2005, Jens Axboe wrote:
I converted most of debug messages I've used during development into
warning messages when posting the patchset and forgot about it, so
I've never posted
Hello, Jeff, Jens and Albert.
This is the second take of generic NCQ completion/error-handling
patchset. Changes are...
* Generic special command helper (ata_qc_exec_special) added. Now
all internal commands run with timeout (request sense, read log,
set xfer...)
* New non-NCQ error
.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
libata-core.c | 10 ++
libata-scsi.c | 36 +---
libata.h |2 +-
3 files changed, 24 insertions(+), 24 deletions(-)
Index: work/drivers/scsi/libata-core.c
11_libata_debug.patch
As usual, debug messages and error triggers.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
drivers/scsi/ahci.c| 43 +++
drivers/scsi/libata-core.c |9 ++
drivers/scsi/sata_sil.c| 61
09_libata_remove-unused-eh-functions.patch
This patch removes ata_scsi_requeue(),
ata_scsi_block_requests() and ata_scsi_unblock_requests().
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
drivers/scsi/libata-core.c |3 ---
drivers/scsi/libata-scsi.c | 32
07_libata_convert-ahci-to-new-eh.patch
This patch converts ahci driver to use new NCQ helpers.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
ahci.c | 363 ++---
1 files changed, 58 insertions(+), 305 deletions(-)
Index: work
10_libata_ahci-atapi.patch
This patch adds ATAPI support to ahci driver. This currently
doesn't work. I'll write a reply to this thread to tell more
about this. However, it at least shows that NCQ ATAPI error
handling works.
Signed-off-by: Tejun Heo [EMAIL
06_libata_implement-ncq-helpers.patch
This patch implements generic NCQ completion/error-handling
helpers.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
drivers/scsi/libata-core.c | 237 +
include/linux/libata.h |3
2 files
03_libata_convert-drivers-to-new-eh.patch
This patch converts sata_sil and ata_piix to use new EH.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
ata_piix.c |4 ++--
sata_sil.c |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
Index: work/drivers/scsi/ata_piix.c
On Thu, Jul 07, 2005 at 10:10:04PM +0900, Tejun Heo wrote:
10_libata_ahci-atapi.patch
This patch adds ATAPI support to ahci driver. This currently
doesn't work. I'll write a reply to this thread to tell more
about this. However, it at least shows that NCQ ATAPI error
On Fri, Jul 08, 2005 at 10:03:48AM +0200, Jens Axboe wrote:
Hi,
Ok, one more error, this time from irq context:
AHCI: ata1: error irq, status=4001 stat=51 err=04 sstat=0113
serr=
ata1: aborting commands due to error. active_tag -1, sactive 0001
ahci: sactive 1
ata1:
Tejun Heo wrote:
On Thu, Jul 07, 2005 at 10:10:04PM +0900, Tejun Heo wrote:
10_libata_ahci-atapi.patch
This patch adds ATAPI support to ahci driver. This currently
doesn't work. I'll write a reply to this thread to tell more
about this. However, it at least shows
Matthew Garrett wrote:
On Tue, Jul 12, 2005 at 11:49:35PM +0900, Tejun Heo wrote:
This has come up several times now. One thing I'm curious about is
why we are disabling HPA on boot without consent from the user. AFAIK,
HPA is mostly used to implement hidden recovery/suspend storage areas
to issue ATAPI commands.
* Port multiplier. This one is difficult. We don't know how to do
it on sil24 and don't have proper infrastructure in libata.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
--- a/drivers/scsi/Kconfig
+++ b/drivers
As usual, error trigger and debug message patch.
diff --git a/drivers/scsi/sata_sil24.c b/drivers/scsi/sata_sil24.c
--- a/drivers/scsi/sata_sil24.c
+++ b/drivers/scsi/sata_sil24.c
@@ -421,6 +421,46 @@ static int sil24_qc_issue(struct ata_que
struct sil24_port_priv *pp = ap-private_data;
wrong. I've also tested basic error handling and it
seems to work.
Thanks.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -499,6 +499,14 @@ config SCSI_SATA_SIL
If unsure, say N
06_sil24_add-flusing-after-masking-irq.patch
Add IO flushing after masking irq during initialization.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
sata_sil24.c |1 +
1 files changed, 1 insertion(+)
Index: work/drivers/scsi/sata_sil24.c
-by: Tejun Heo [EMAIL PROTECTED]
sata_sil24.c | 10 +++---
1 files changed, 7 insertions(+), 3 deletions(-)
Index: work/drivers/scsi/sata_sil24.c
===
--- work.orig/drivers/scsi/sata_sil24.c 2005-07-30 19:13:40.0 +0900
07_sil24_add-FIXME-ata_device_add-return_value.patch
Add FIXME comment above ata_device_add.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
sata_sil24.c |1 +
1 files changed, 1 insertion(+)
Index: work/drivers/scsi/sata_sil24.c
03_sil24_add-test-for-PCI-fault.patch
On entry to interrupt handler, PORT_SLOT_STAT register is read
first. Check if PCI fault or device removal has occurred by
testing the value for 0x.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
sata_sil24.c |6 ++
1
Hello, Jeff Carlos.
These patches are misc fixes suggested by Jeff for rewritten sil24
driver. The follwing issues are not fixed in this patchset. I need
more info to work on these.
* Device signature access on reset.
* How to discern completion interrupts from error ones.
* 64bit
02_sil24_separate-out-error-path.patch
Move error handling from sil24_host_intr into separate
function - sil24_error_intr.
Jeff, I don't think this patch actually improves readability
and/or performance. Is this what you wanted?
Signed-off-by: Tejun Heo [EMAIL
Hello, Edward.
One more question.
I think this will work (adapted from sil_interrupt():
static void sil_irq_clear(struct ata_port *ap)
{
struct sil_port_priv *pp = ap-private_data;
struct Port_Registers *port_base = pp-pregs;
unsigned long port_int;
Hi, again, Edward.
Bad news...
On Tue, Aug 02, 2005 at 03:56:05PM -0700, Edward Falk wrote:
Again, you would need to fetch them from the returned FIS structure.
Here's a code fragment derived from SiI's issue_soft_reset() function:
struct Port_Registers *port_base = yadayada;
Edward Falk wrote:
Tejun Heo wrote:
Hi, again, Edward.
Bad news...
On Tue, Aug 02, 2005 at 03:56:05PM -0700, Edward Falk wrote:
Again, you would need to fetch them from the returned FIS structure.
Here's a code fragment derived from SiI's issue_soft_reset() function:
Yeah, well
On Fri, Aug 05, 2005 at 12:52:07PM +0900, Tejun Heo wrote:
Mark Lord wrote:
The problem with this patch is that is causes leaks, and doesn't
actually ready the devices because scsi_eh_ready_devs() is never called:
scsi_eh_abort_cmds() is guaranteed to fail out every time its called.
MMmm
On Fri, Jul 29, 2005 at 01:06:54AM -0400, Jeff Garzik wrote:
So, one thing that's terribly ugly about SATA ATAPI is that we need to
pad DMA transfers to the next 32-bit boundary, if the length is not
evenly divisible by 4.
Messing with the scatterlist to accomplish this is terribly ugly
Hello, Andreas.
Andreas Klöckner wrote:
Hey Jeff, all,
I was wondering why ATA_ENABLE_PATA and ATA_ENABLE_ATAPI are #undef'ed in
include/linux/libata.h by default, since reverting them to #define's was the
only way to make the ata-piix driver detect my CDROM on my new shiny ThinkPad
Hi, Mark.
Mark Lord wrote:
Tejun,
I'm back from holiday now, and will try your one-liner
in place of the more complex patch I had been using.
(that's what you intended, right?)
Yeap, and if possible, please also try the second large patch. I
wanna make sure it's free of that problem.
Hello, Jeff.
The patch I posted in this thread is just collapsed version of the
following patchset.
http://marc.theaimsgroup.com/?l=linux-idem=112074204019013w=2
Above post has it splitted over 11 patches and has proper explanations.
Jeff Garzik wrote:
Tejun Heo wrote
Jeff Garzik wrote:
Tejun Heo wrote:
05_sil24_mdelay-instead-of-udelay.patch
loop 100 times with mdelay(1) instead of 1000 times with
udelay(100) in sil24_reset_controller.
Jeff, is this what you wanted? If not, just ignore this
patch. The following patches will apply
Jeff Garzik wrote:
Tejun Heo wrote:
Hello, Jeff Carlos.
These patches are misc fixes suggested by Jeff for rewritten sil24
driver. The follwing issues are not fixed in this patchset. I need
more info to work on these.
* Device signature access on reset.
* How to discern completion
Mark Lord wrote:
Tejun Heo wrote:
* _All_ errors are handled in EH thread.
* Once any error has occurred, all normal processing stops until
error condition is cleared by EH.
Do you mean all normal processing for that channel stops,
or *ALL* processing on all libata channels stops
Tejun Heo wrote:
Mark Lord wrote:
Tejun Heo wrote:
* _All_ errors are handled in EH thread.
* Once any error has occurred, all normal processing stops until
error condition is cleared by EH.
Do you mean all normal processing for that channel stops,
or *ALL* processing on all libata
Chris Boot wrote:
Hi all,
I just recently took the plunge and bought 4 250 GB Seagate drives and
a 2 port Silicon Image 3112A controller card for the 2 drives my
motherboard doesn't handle. No matter how hard I try, I can't get the
hard drives to work: they are detected correctly and work
Chris Boot wrote:
Hi Tejun,
On 12 Aug 2005, at 12:33, Chris Boot wrote:
Hi Tejun,
On 12 Aug 2005, at 12:28, Tejun Heo wrote:
Hello, Chris.
Chris Boot wrote:
On 12 Aug 2005, at 4:24, Tejun Heo wrote:
Chris Boot wrote:
Hi all,
I just recently took the plunge and bought 4 250 GB
Hello, Chris.
Chris Boot wrote:
On 12 Aug 2005, at 15:08, Tejun Heo wrote:
[adding cc to Jeff Garzik. (Hi!)]
Hi again, Chris.
Unfortunately, I'm as lost as you are. Can you please do the
followings?
* Verify if read is free from the problem. ie. does dd if=/dev/ sd?
of=/dev
Chris Boot wrote:
Some interesting developments!
I installed a fresh copy of Windows, and all the VIA and nVidia and so
on drivers. At some point during all this (a period of relatively heavy
disk IO), the computer seemed to crash and I rebooted it. It then
worked fine for a while, but
subsystem that it's not our interrupt.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
sata_sil24.c | 15 +--
1 files changed, 5 insertions(+), 10 deletions(-)
Index: work/drivers/scsi/sata_sil24.c
===
--- work.orig/drivers/scsi
07_sil24_fix-PORT_CTRL_STAT-constants.patch
PORT_CTRL_STAT constants were copied incorrectly from the
preview driver.
Signed-off-by: Edward Falk
sata_sil24.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
Index: work/drivers/scsi/sata_sil24.c
Steven Scholz wrote:
Hi there,
According to an (old) man page of sync(2)
According to the standard specification (e.g., SVID),
sync() schedules the writes, but may return before the
actual writing is done. However, since version 1.3.20
Linux does
Steven Scholz wrote:
Tejun Heo wrote:
Steven Scholz wrote:
Hi there,
According to an (old) man page of sync(2)
According to the standard specification (e.g., SVID),
sync() schedules the writes, but may return before the
actual writing is done. However
Steven Scholz wrote:
Tejun,
How about recent kernels? Does sync() block until buffers are flushed?
How can I find out if the disk caches are actually flushed?
I want to make sure that all data is flushed to my disk drive
before powering down the system.
All disk caches are flushed before
Hi, Jeff.
Jeff Garzik wrote:
Tejun,
In an email I cannot find anymore, you asked why I was interested in
converting libata to use the fine-grained EH hooks in the SCSI layer,
rather than continued with the current -eh_strategy_handler() method.
Several reasons:
1) The fine-grained
Hello, Jeff and Albert.
This patchset fixes the following race.
(port A has ATA device and B ATAPI).
port B : ata_issue_prot() (ATAPI_NODATA)
port B : packet_task scheduled
port A : ata_issue_prot() (DMA)
intr: ata_interrupt()
port A : ata_host_intr - this is all good dandy
port B :
Hello, Jeff Albert.
This is another patchset fixing races in libata.
The first patch implements ata_poll_qc_complete which graps host
lock, turns irq back on, completes qc and release host lock. All
command completion in polling tasks are replaced with this function.
The effect is...
* If
. This patch makes it use
ata_poll_qc_complete, so irq is now turned back on on error
exits.
Note: With this change, ALL invocations of ata_qc_complete()
are now done under host_set lock.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
libata-core.c | 32
host_set
lock before invoking -eng_timeout().
Note: host_failed decrementing and eh_cmd_q banging are moved
above -eng_timeout() invocation such that they're done while
holding the lock.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
libata-scsi.c | 12 +---
1
Hello, guys.
Jeff Garzik wrote:
(added Alan, Bart and Jens to CC)
Tejun Heo wrote:
Hello, Jeff libata developers.
I've been spending some time on libata EH and am trying to make a
list of things which can be improved. If you have something, please
add to the list.
1. Errors
Hello, Larry.
Larry Battraw wrote:
I installed a SiL3114-based PCI card (Syba) and Western Digital
WD2500SD in my system recently and haven't been able to get the system
to write/read any data from the drive beyond the initial drive probe. I
get a lot of messages about ATA: abnormal status
Jeff Garzik wrote:
Tejun Heo wrote:
Hello, Jeff.
Jeff Garzik wrote:
Tejun Heo wrote:
Hello, Jeff and Albert.
This patchset fixes the following race.
(port A has ATA device and B ATAPI).
port B: ata_issue_prot() (ATAPI_NODATA)
port B: packet_task scheduled
port
Hi, Jeff.
Jeff Garzik wrote:
Tejun Heo wrote:
sata_sil Mod15Write workaround was broken by the following commit by
Albert Lee.
Commit: 21b1ed74ee3667dcabcba92e486988ea9119a085
[PATCH] libata: Prevent the interrupt handler from completing a
command twice
This commit clears
Hello, Jeff.
Jeff Garzik wrote:
Tejun Heo wrote:
Hello, Jeff and Albert.
This patchset fixes the following race.
(port A has ATA device and B ATAPI).
port B: ata_issue_prot() (ATAPI_NODATA)
port B: packet_task scheduled
port A: ata_issue_prot() (DMA)
intr: ata_interrupt
Howdy, Jeff.
Jeff Garzik wrote:
Tejun Heo wrote:
Jeff Garzik wrote:
Tejun Heo wrote:
Hello, Jeff.
Jeff Garzik wrote:
Tejun Heo wrote:
Hello, Jeff and Albert.
This patchset fixes the following race.
(port A has ATA device and B ATAPI).
port B: ata_issue_prot
Hello, Jeff.
Jeff Garzik wrote:
Tejun Heo wrote:
Jeff Garzik wrote:
Tejun Heo wrote:
Also, Jeff, I know you're very busy, but what do you think about
taking m15w workaround into ata tree? It's been around for a while
now and I haven't received any complaints (except for this one) yet
1 - 100 of 2104 matches
Mail list logo
