Re: [PATCH] libata: Cable strategy

2008-02-08 Thread Chuck Ebbert
On 02/08/2008 10:21 AM, Alan Cox wrote: + ata_link_for_each_dev(dev, link) { + if (!ata_is_40wire(dev)) + return 1; + } return 0; ??? - To unsubscribe from this list: send the line

Re: LIBATA SCSI command validation changed in 2.6.24

2008-01-11 Thread Chuck Ebbert
On 01/11/2008 04:35 PM, Jeff Garzik wrote: Chuck Ebbert wrote: commit 607126c2a21cd6e9bb807fdd415c1a992f7b9009 changed command validation to allow short commands in 16-byte CDBs, but it also made checking more strict. Before the change, a 10-byte SG_IO command could have its length set to 9

LIBATA SCSI command validation changed in 2.6.24

2008-01-11 Thread Chuck Ebbert
commit 607126c2a21cd6e9bb807fdd415c1a992f7b9009 changed command validation to allow short commands in 16-byte CDBs, but it also made checking more strict. Before the change, a 10-byte SG_IO command could have its length set to 9 and still work. Now it fails. Not sure if this is a bug, but it has

Re: LIBATA SCSI command validation changed in 2.6.24

2008-01-11 Thread Chuck Ebbert
On 01/11/2008 06:21 PM, Jeff Garzik wrote: Chuck Ebbert wrote: On 01/11/2008 04:35 PM, Jeff Garzik wrote: Chuck Ebbert wrote: commit 607126c2a21cd6e9bb807fdd415c1a992f7b9009 changed command validation to allow short commands in 16-byte CDBs, but it also made checking more strict. Before

Re: [Bugme-new] [Bug 9533] New: 2.6.24-rc4: some ahci/acpi interaction causes delays during boot

2007-12-10 Thread Chuck Ebbert
On 12/10/2007 03:52 PM, Andrew Morton wrote: On Mon, 10 Dec 2007 05:55:20 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9533 Another box-killing regression to track, please. Either ATA or ACPI. - To unsubscribe from this list: send the line unsubscribe

Re: Hard drives only detected when booting from CD on nVidia MCP67 SATA

2007-12-06 Thread Chuck Ebbert
On 12/05/2007 06:53 PM, Chuck Ebbert wrote: With kernel 2.6.23 on an Acer 7220 notebook using nVidia MCP67 SATA, hard drives are only detected after first booting from a CD. Boot from hard drive No drives detected Boot live CD Detected Boot CD to GRUB menu

Hard drives only detected when booting from CD on nVidia MCP67 SATA

2007-12-05 Thread Chuck Ebbert
With kernel 2.6.23 on an Acer 7220 notebook using nVidia MCP67 SATA, hard drives are only detected after first booting from a CD. Boot from hard drive No drives detected Boot live CD Detected Boot CD to GRUB menu, Detected then warm-boot from hard drive Non-detect case:

[stable patch] backport of be tolerant of 12-byte ATAPI commands in 16-byte CDBs

2007-11-28 Thread Chuck Ebbert
Submitted for comment, not compile tested. Backport of commit 607126c2a21cd6e9bb807fdd415c1a992f7b9009 libata-scsi: be tolerant of 12-byte ATAPI commands in 16-byte CDBs --- drivers/ata/libata-scsi.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) ---

Re: [BUG] New Kernel Bugs

2007-11-13 Thread Chuck Ebbert
On 11/13/2007 04:12 PM, Alan Cox wrote: Bug fixing is not about finding someone to blame, it's about getting the bug fixed. Partly - its also about understanding why the bug occurred and making it not happen again. Very few people think about that part. - To unsubscribe from this list:

Re: [PATCH #upstream 1/2] libata: relocate forcing PIO0 on reset

2007-10-30 Thread Chuck Ebbert
On 10/29/2007 03:41 AM, Tejun Heo wrote: retry: + ata_link_for_each_dev(dev, ap-link) { How do I backport these loops to 2.6.23? I see something like this in the old code: for (i=0; i ATA_MAX_DEVICES; i++) { dev = ap-device[i]; if

sata_nv in 2.6.23-rc8 only detects one of two controllers

2007-10-01 Thread Chuck Ebbert
2.6.18: libata version 2.00 loaded. sata_nv :00:07.0: version 2.0 ACPI: PCI Interrupt Link [LTID] enabled at IRQ 20 GSI 18 sharing vector 0xE9 and IRQ 18 ACPI: PCI Interrupt :00:07.0[A] - Link [LTID] - GSI 20 (level, low) - IRQ 233 PCI: Setting latency timer of device :00:07.0 to 64

Re: [PATCH] pata_sis: add missing UDMA5 timing value in sis_66_set_dmamode()

2007-09-25 Thread Chuck Ebbert
On 09/21/2007 03:29 AM, Tejun Heo wrote: sis_66_set_dmamode() also handles early UDMA100 (SIS630 ET) but is missing udma timing value for UDMA100. According to sis5513, this should be 0x8000. This caused UDMA100 device to fail on pata_sis till it downgrades to UDMA66 while it works fine on

IDE broken on Pegasos PPC platform

2007-09-24 Thread Chuck Ebbert
Without this patch, taken from a Suse 2.6.22 kernel, the Pegasos PPC machines can't use their IDE interface. Is this the right fix? Bug: https://bugzilla.redhat.com/show_bug.cgi?id=247602 Patch (also below): https://bugzilla.redhat.com/attachment.cgi?id=167747 === The built-in IDE

Re: [PATCH] libata: Add a drivers/ide style DMA disable

2007-09-19 Thread Chuck Ebbert
On 08/22/2007 06:37 PM, Alan Cox wrote: This is useful when debugging, handling problem systems, or for distributions just to get the system installed so it can be sorted out later. This is a bit smarter than the old IDE one and lets you do libata.pata_dma=0 Disable all PATA

Re: [PATCH] libata: Add a drivers/ide style DMA disable

2007-09-14 Thread Chuck Ebbert
On 09/07/2007 06:47 PM, Jeff Garzik wrote: This is useful when debugging, handling problem systems, or for distributions just to get the system installed so it can be sorted out later. This is a bit smarter than the old IDE one and lets you do libata.pata_dma=0Disable all PATA DMA

Re: libata not working for sis5533

2007-09-12 Thread Chuck Ebbert
On 08/31/2007 06:20 PM, Patrizio Bassi wrote: Patrizio Bassi ha scritto: Michal Piotrowski ha scritto: Hi, [Adding IDE wizards to CC] On 26/08/07, Patrizio Bassi [EMAIL PROTECTED] wrote: My sis630 chipset shipped with Asus A1000 doesn't work properly with suspend with ide drivers

Re: ATAPI tape drives broken with libata

2007-08-30 Thread Chuck Ebbert
On 08/29/2007 07:50 PM, Alan Cox wrote: Device Ready, Seek Complete, Data Request, Error DRQ and Error together is a bit odd to say the least It then commits suicide and falls off the bus. That may be due to the fact we use SRST on ATAPI device errors still rather than trying an ATAPI

ATAPI tape drives broken with libata

2007-08-29 Thread Chuck Ebbert
https://bugzilla.redhat.com/show_bug.cgi?id=243568 Using kernel 2.6.22: Aug 29 17:08:11 itox kernel: ata2.00: ATAPI: Seagate STT8000A, 5.51, max MWDMA2 Aug 29 17:08:11 itox kernel: ata2.00: configured for MWDMA2 Aug 29 17:08:11 itox kernel: scsi 1:0:0:0: Sequential-Access Seagate STT8000A

Re: [PATCH] libata: implement BROKEN_HPA horkage and apply it to HDS724040KLSA80

2007-08-07 Thread Chuck Ebbert
On 08/07/2007 11:36 AM, Tejun Heo wrote: Alan Cox wrote: On Tue, 7 Aug 2007 14:42:50 +0900 Tejun Heo [EMAIL PROTECTED] wrote: HDS724040KLSA80 reports that it supports HPA LBA48 but craps itself on READ_NATIVE_MAX_EXT. Implement BROKEN_HPA horkage and apply it to the drive. If the horkage

Re: [PATCH -mm] libata: add human-readable error value decoding v3

2007-08-03 Thread Chuck Ebbert
On 08/03/2007 02:00 PM, Robert Hancock wrote: This adds human-readable decoding of the ATA status and error registers (similar to what drivers/ide does) as well as the SATA Serror register to libata error handling output. This prevents the need to pore through standards documents to figure

Re: No equivalent for ide-scsi available with the new PATA drivers?

2007-07-23 Thread Chuck Ebbert
On 07/23/2007 12:52 PM, Alan Cox wrote: People with IDE tape drives are complaining there's no ide-scsi driver available anymore with the new PATA layer. Is anyone working on one? It would make no sense. The libata layer is already using the SCSI midlayer so compliant devices should already

[patch] libata: fix last_ctl caching in ata_tf_read()

2007-07-17 Thread Chuck Ebbert
libata: fix last_ctl caching in ata_tf_read() last_ctl was not cached properly. (Pointed out by Tejun Heo.) Signed-off-by: Chuck Ebbert [EMAIL PROTECTED] --- (Apply after Petr's patch to fix SMART bugs.) drivers/ata/libata-sff.c |4 1 file changed, 4 insertions(+) --- 2.6.22-d390

[patch] libata: fix last_ctl caching in ata_tf_read()

2007-07-16 Thread Chuck Ebbert
libata: fix last_ctl caching in ata_tf_read() last_ctl was not cached properly. (Pointed out by Tejun Heo.) Signed-off-by: Chuck Ebbert [EMAIL PROTECTED] --- (Apply after Petr's patch to fix the sense data.) drivers/ata/libata-sff.c |5 + 1 file changed, 5 insertions(+) --- linux

AHCI driver prints D2H reg with I during NCQ message, what is it?

2007-07-13 Thread Chuck Ebbert
I see this on boot with kernels 2.6.22.1 and 2.6.20.15: ata1: D2H reg with I during NCQ, this message won't be printed again But I can't find anything that tells me what it means, or whether it's a real problem. x86_64 kernel with controller: 00:1f.2 SATA controller: Intel

Re: [PATCH] libata: add another Maxtor drive with broken NCQ to the list

2007-07-12 Thread Chuck Ebbert
On 07/12/2007 02:39 PM, Jeff Garzik wrote: Alan Cox posted some example code recently, which demonstrated how to add support for wildcards to the ATA blacklist. Would you be willing to grab or recreate that, and then simply blacklist BANC* Not right now. - To unsubscribe from this list:

Re: Another Maxtor drive with broken NCQ

2007-07-06 Thread Chuck Ebbert
On 07/06/2007 03:09 PM, Jeff Garzik wrote: {Maxtor 6B200M0, BANC1BM0, ATA_HORKAGE_NONCQ } Or should *all* Maxtor 6B200M0 be blacklisted, since there's already one of them in the list? Wanna send that as a patch, with attribution and sign-offs? :) For all revisions, or just

Re: libata ignore_hpa=1 doesn't wok on SATA ?

2007-07-05 Thread Chuck Ebbert
On 07/04/2007 08:00 PM, yong Jung wrote: Hi, . I would like to see the whole disk area and erase the hpa area in my desktop. At first I tried setmax.c program but it didn't work on SATA at least. So I upgraeded it to FC7 and added libata ignore_hpa=1 option on boot command and

[PATCH] libata: ata_piix: add ID for Intel Santa Rosa (ICH8M) controller

2007-07-03 Thread Chuck Ebbert
From: Christian Lamparter [EMAIL PROTECTED] ATA: add a PCI ID for Intel Santa Rosa (ICH8M) PATA controller. Signed-off-by: Christian Lamparter [EMAIL PROTECTED] --- drivers/ata/ata_piix.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c

Re: [1/2] 2.6.22-rc6: known regressions v2

2007-06-29 Thread Chuck Ebbert
On 06/29/2007 12:59 PM, Alan Cox wrote: SATA/PATA Subject: libata IT821X driver still fails! Hard-freezes system References : http://lkml.org/lkml/2007/6/14/82 Submitter : Rodney Gordon II [EMAIL PROTECTED] Status : unknown Not a regression as it seems this user's box has always

ATA: add a PCI ID for Intel Santa Rosa PATA controller

2007-06-28 Thread Chuck Ebbert
From: Christian Lamparter [EMAIL PROTECTED] ATA: add a PCI ID for Intel Santa Rosa PATA controller. Signed-off-by: Christian Lamparter [EMAIL PROTECTED] --- [against 2.6.22-rc6; patch also attached, use the attachment] drivers/ata/ata_piix.c |2 ++ 1 file changed, 2 insertions(+) diff

pata_ali patch not merged?

2007-06-25 Thread Chuck Ebbert
This patch was found to fix some of the problems with the pata_ali driver. Is it going to be merged in 2.6.22? [https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=156482] --- linux-2.6.22-rc4/drivers/ata/pata_ali.c 2007-06-04 23:05:17.0 -0700 +++ devel/drivers/ata/pata_ali.c

Re: [BUG] 2.6.21.1: ide-pci is not finding ide controller.

2007-05-23 Thread Chuck Ebbert
On 05/23/2007 04:24 PM, Alan Cox wrote: On Wed, 23 May 2007 15:11:18 -0500 [EMAIL PROTECTED] (Linas Vepstas) wrote: I've got a rather old x86 box that I'm booting 2.6.21.1 on; this kernel is not finding an ide controller on it. HPT366 fixes were posted here earlier. It doesn't in fact

Re: [PATCH] libata: add human-readable error value decoding

2007-05-11 Thread Chuck Ebbert
Robert Hancock wrote: + ehc-i.serror SERR_TRANS_ST_ERROR ? TransStatTransErr : , + ehc-i.serror SERR_UNRECOG_FIS ? UnrecogFIS : , + ehc-i.serror SERR_DEV_XCHG ? DevExchanged : ); I'm not really convinced whether this is necessary. The human readable form

Re: [PATCH] pci-quirks: disable MSI on RS400-200 and RS480, take #2

2007-05-09 Thread Chuck Ebbert
Tejun Heo wrote: MSI doesn't work on RS400-200 and RS480 requiring pci=nomsi kernel boot parameter for ahci to work. This patch renames quirk_svw_msi() to quirk_disable_all_msi() and use it to disable MSI on those chips. http://thread.gmane.org/gmane.linux.ide/17820

Re: [PATCH] pci-quirks: disable MSI on RS400-200 and RS480, take #2

2007-05-09 Thread Chuck Ebbert
Tejun Heo wrote: FWIW several distros have turned off MSI by default and added a pci=msi option to enable it. Yeah, it seem to cause a lot of problems on certain chips but I think the correct path is to add PCI quirks for those. Most MSI problems I've seen are on these ATI chips. Do you

Re: [git patches] libata updates

2007-05-01 Thread Chuck Ebbert
Stephen Clark wrote: I'm running fc6 but with kernel 2.6.21 from kernel.org - compiled with the .config file from fc6. My system is a asus laptop with an ich7 chipset which has both sata and pata controllers. My laptop only brings out the pata controller interface and both my hd and od

Re: [git patches] libata updates

2007-04-30 Thread Chuck Ebbert
Jeff Garzik wrote: Jeff Garzik (8): libata/IDE: remove combined mode quirk You can't just remove the combined_mode= kernel parameter or every Linux user who uses that will get an unbootable kernel with no good way of diagnosing the problem. It should still be accepted and just print a

Re: [git patches] libata updates

2007-04-30 Thread Chuck Ebbert
Jeff Garzik wrote: Chuck Ebbert wrote: Jeff Garzik wrote: Jeff Garzik (8): libata/IDE: remove combined mode quirk You can't just remove the combined_mode= kernel parameter or every Linux user who uses that will get an unbootable kernel with no good way of diagnosing the problem

Re: Loud pop coming from hard drive on reboot

2007-04-23 Thread Chuck Ebbert
Peter Zijlstra wrote: but I have an increasing seek error rate as well. I got the ST disk because thinkwiki suggested it. Apparently Seagate has their own definition of seek error rate. Large numbers are normal, or at least very common. Now I wonder if they have their own way of doing

Re: Loud pop coming from hard drive on reboot

2007-04-19 Thread Chuck Ebbert
Stephen Clark wrote: Mark Lord wrote: Mark Lord wrote: With the patch applied, I don't see *any* new activity in those S.M.A.R.T. attributes over multiple hibernates (Linux suspend-to-disk). Scratch that -- operator failure. ;) The patch makes no difference over hibernates in

Re: Loud pop coming from hard drive on reboot

2007-04-18 Thread Chuck Ebbert
Mark Lord wrote: Mark Lord wrote: With the patch applied, I don't see *any* new activity in those S.M.A.R.T. attributes over multiple hibernates (Linux suspend-to-disk). Scratch that -- operator failure. ;) The patch makes no difference over hibernates in the SMART logs. It's still

Re: Loud pop coming from hard drive on reboot

2007-04-18 Thread Chuck Ebbert
Bartlomiej Zolnierkiewicz wrote: On Wednesday 18 April 2007, Chuck Ebbert wrote: Mark Lord wrote: Mark Lord wrote: With the patch applied, I don't see *any* new activity in those S.M.A.R.T. attributes over multiple hibernates (Linux suspend-to-disk). Scratch that -- operator failure

Re: Loud pop coming from hard drive on reboot

2007-04-16 Thread Chuck Ebbert
Jan Engelhardt wrote: On Apr 15 2007 12:53, Henrique de Moraes Holschuh wrote: On Sat, 14 Apr 2007, Pavel Machek wrote: How common are notebooks that cut power to disks during reboot? Assuming it also does this when running Windows, I'd report it as a grave bug to the vendor and demand it to

Re: Loud pop coming from hard drive on reboot

2007-04-13 Thread Chuck Ebbert
Bartlomiej Zolnierkiewicz wrote: Now we're getting somewhere. There is some other OS on here because it's required for doing BIOS updates. I booted it and shut down. The power cycle count increased but the power off retract count did not. The counts are: power cycle ... 111 power off

Re: Loud pop coming from hard drive on reboot

2007-04-13 Thread Chuck Ebbert
Bartlomiej Zolnierkiewicz wrote: There is no noise and the retract count does not increase when I boot and then shutdown/power off the other OS. What about shutdown/reboot? Very loud noise and the count goes up. - To unsubscribe from this list: send the line unsubscribe linux-ide in the

Re: Loud pop coming from hard drive on reboot

2007-04-11 Thread Chuck Ebbert
Jan Engelhardt wrote: On Apr 11 2007 17:35, Chuck Ebbert wrote: Jan Engelhardt wrote: On Apr 11 2007 17:07, Chuck Ebbert wrote: When I reboot my notebook, it powers off and powers back on. On poweroff a loud snapping noise seems to be coming from the hard drive. Today I noticed

Re: [PATCH] HPA support: Revised patch

2007-04-09 Thread Chuck Ebbert
Alan Cox wrote: On Fri, 6 Apr 2007 17:37:07 +0100 Matthew Garrett [EMAIL PROTECTED] wrote: On Thu, Apr 05, 2007 at 02:13:52PM +0100, Alan Cox wrote: This one should fix the problems with slave devices and the Macintosh hang Better, but still not happy with ata_piix - I get the following:

Re: HPA patches

2007-03-23 Thread Chuck Ebbert
Alan Cox wrote: What is 0x40? can it be #defined (or enum-ed) instead of a magic value? please? (more of same below) It's 0x40. Its a command dependant bit - no useful name. dependent. OK, thanks. IDE is a bit like that. I'm amazed some of the command flags arent in latin. Hmm,

Re: Loading both the pata_atiixp and the ahci driver causes problems

2007-03-18 Thread Chuck Ebbert
Tejun Heo wrote: Jon Masters wrote: Chuck Ebbert wrote: If you try to load both the pata_atiixp and the ahci driver (for the same ATI SB600 adapter), very strange things happen. The AHCI driver churns for three minutes or so, spewing messages like this, then nothing works: 6ata3: SATA

Loading both the pata_atiixp and the ahci driver causes problems

2007-03-15 Thread Chuck Ebbert
If you try to load both the pata_atiixp and the ahci driver (for the same ATI SB600 adapter), very strange things happen. The AHCI driver churns for three minutes or so, spewing messages like this, then nothing works: 6ata3: SATA link up 3.0 Gbps (SStatus 123 SControl 300) 4ata3.00: qc timeout

Re: Current PATA working tree

2007-02-28 Thread Chuck Ebbert
Alan wrote: While Andrew and -mm are taking a bit of a break... I've uploaded a patch file of the libata PATA working tree versus 2.6.20-mm2 to http://zeniv.linux.org.uk/~alan/IDE Generated without --show-c-function. Sigh. - To unsubscribe from this list: send the line unsubscribe

Re: [patch ide-dev 6/9] check capacity in ide_task_init_flush()

2005-03-04 Thread Chuck Ebbert
On Thu, 24 Feb 2005 at 15:44:34, Bartlomiej Zolnierkiewicz wrote: --- a/drivers/ide/ide-io.c2005-02-23 20:58:16 +01:00 +++ b/drivers/ide/ide-io.c2005-02-23 20:58:16 +01:00 @@ -61,7 +61,8 @@ memset(task, 0, sizeof(*task)); - if (ide_id_has_flush_cache_ext(drive-id)) { +

Re: [PATCH 2.6.11-rc2 02/04] ide: __ide_do_rw_disk() rewritten ide_write_taskfil

2005-02-11 Thread Chuck Ebbert
On Sun, 6 Feb 2005 at 20:26:55 +0900, Tejun Heo wrote: + if (drive-using_dma + !(hwif-no_lba48_dma block + rq-nr_sectors 1ULL 28)) { + /* DMA */ + if (hwif-dma_setup(drive)) + goto fallback_to_pio; + if